Re: [Piglit] [PATCH 1/3] arb_get_texture_sub_image: fix expected error when querying a level which hasn't been explicitly defined

Pushed! On Wed, 2018-04-11 at 09:45 -0700, Anthony Pesch wrote: > From: Anthony Pesch > > Change expected error from INVALID_OPERATION to INVALID_VALUE when querying a > level which hasn't been explicitly defined. The level is valid, however, the > level hasn't been

Re: [Piglit] [PATCH 1/3] arb_get_texture_sub_image: fix expected error when querying a level which hasn't been explicitly defined

ists.freedesktop.org Subject: Re: [Piglit] [PATCH 1/3] arb_get_texture_sub_image: fix expected error when querying a level which hasn't been explicitly defined On Wed, 2018-04-04 at 15:04 +, Anthony Pesch wrote: > Hey Juan, > > The change from INVALID_OPERATION to INVALID_VALUE is

Re: [Piglit] [PATCH 1/3] arb_get_texture_sub_image: fix expected error when querying a level which hasn't been explicitly defined

m> > Sent: Wednesday, April 4, 2018 7:12 AM > To: Anthony Pesch; piglit@lists.freedesktop.org > Subject: Re: [Piglit] [PATCH 1/3] arb_get_texture_sub_image: fix expected > error when querying a level which hasn't been explicitly defined > > On Wed, 2018-03-28 at 11:

Re: [Piglit] [PATCH 1/3] arb_get_texture_sub_image: fix expected error when querying a level which hasn't been explicitly defined

_texture_sub_image: fix expected error when querying a level which hasn't been explicitly defined On Wed, 2018-03-28 at 11:15 -0400, Anthony Pesch wrote: > From: Anthony Pesch <ape...@nvidia.com> > > Change expected error from INVALID_OPERATION to INVALID_VALUE when querying

Re: [Piglit] [PATCH 1/3] arb_get_texture_sub_image: fix expected error when querying a level which hasn't been explicitly defined

On Wed, 2018-03-28 at 11:15 -0400, Anthony Pesch wrote: > From: Anthony Pesch > > Change expected error from INVALID_OPERATION to INVALID_VALUE when querying > a level which hasn't been explicitly defined. This is a valid operation, the > error set should be due to the

Re: [Piglit] [PATCH 1/3] arb_get_texture_sub_image: fix expected error when querying a level which hasn't been explicitly defined

I think the bad enum is some copy and paste from an above test case. I feel it should be changed as well, right now the test is relying on the level / size being validated before the format. - Anthony P.S. Sorry for the spam on these changes, I had a problem with my filters and thought the

Re: [Piglit] [PATCH 1/3] arb_get_texture_sub_image: fix expected error when querying a level which hasn't been explicitly defined

I'm confused why the test is passing a bad enum when its purpose seems to be to test a non-existent level. In any case, your change looks correct to me. Reviewed-by: Arthur Huillet On 28.03.2018 17:15, Anthony Pesch wrote: From: Anthony Pesch Change

[Piglit] [PATCH 1/3] arb_get_texture_sub_image: fix expected error when querying a level which hasn't been explicitly defined

From: Anthony Pesch Change expected error from INVALID_OPERATION to INVALID_VALUE when querying a level which hasn't been explicitly defined. This is a valid operation, the error set should be due to the requested width and height being greater than the default width and

[Piglit] [PATCH 1/3] arb_get_texture_sub_image: fix expected error when querying a level which hasn't been explicitly defined

From: Anthony Pesch Change expected error from INVALID_OPERATION to INVALID_VALUE when querying a level which hasn't been explicitly defined. This is a valid operation, the error set should be due to the requested width and height being greater than the default width and