Re: [Piglit] [PATCH 4/4] egl_khr_create_context_profile: Verify that the profile is ignored pre-3.2

2012-10-11 Thread Chad Versace
On 10/10/2012 01:31 PM, Matt Turner wrote: On Wed, Oct 10, 2012 at 11:04 AM, Chad Versace chad.vers...@linux.intel.com wrote: On 10/08/2012 04:57 PM, Matt Turner wrote: --- tests/all_egl.tests|1 + .../spec/egl_khr_create_context/CMakeLists.gl.txt |1

Re: [Piglit] [PATCH 4/4] egl_khr_create_context_profile: Verify that the profile is ignored pre-3.2

2012-10-11 Thread Matt Turner
On Thu, Oct 11, 2012 at 7:38 AM, Chad Versace chad.vers...@linux.intel.com wrote: I withdraw my comment objections to patches 2-4. That makes patch 2 reviewed-by. But there are still issues with patches 3-4. Patch 3 has the weird line break in printf. And patch 4 has the bug and misleading

Re: [Piglit] [PATCH 4/4] egl_khr_create_context_profile: Verify that the profile is ignored pre-3.2

2012-10-10 Thread Matt Turner
On Wed, Oct 10, 2012 at 11:04 AM, Chad Versace chad.vers...@linux.intel.com wrote: On 10/08/2012 04:57 PM, Matt Turner wrote: --- tests/all_egl.tests|1 + .../spec/egl_khr_create_context/CMakeLists.gl.txt |1 +