Re: [Piglit] [PATCH v2 3/3] cl: Replace handwritten vload tests with a generator

On Wed, 2017-08-23 at 14:54 -0700, Dylan Baker wrote: > Quoting Jan Vesely (2017-08-23 12:38:53) > > Hi Dylan, > > > > do you mind taking a look at the python parts? > > > > thanks, > > Jan > > Sure, I have a few comments, but mostly this looks okay, my comments are > mostly > style nits

Re: [Piglit] [PATCH v2 3/3] cl: Replace handwritten vload tests with a generator

Quoting Jan Vesely (2017-08-23 12:38:53) > Hi Dylan, > > do you mind taking a look at the python parts? > > thanks, > Jan Sure, I have a few comments, but mostly this looks okay, my comments are mostly style nits anyway. Dylan > On Wed, 2017-08-16 at 20:39 -0400, Jan Vesely wrote: > > v2:

Re: [Piglit] [PATCH v2 3/3] cl: Replace handwritten vload tests with a generator

Hi Dylan, do you mind taking a look at the python parts? thanks, Jan On Wed, 2017-08-16 at 20:39 -0400, Jan Vesely wrote: > v2: simplify > mark local storage volatile > Passes on beignet(IVB), and intel CPU > > Signed-off-by: Jan Vesely > --- > clover on carrizo

[Piglit] [PATCH v2 3/3] cl: Replace handwritten vload tests with a generator

v2: simplify mark local storage volatile Passes on beignet(IVB), and intel CPU Signed-off-by: Jan Vesely --- clover on carrizo passes as well, apart from vload_half tests, because the function is missing in libclc generated_tests/CMakeLists.txt | 4