Re: [Piglit] [PATCH] glsl: update assumption in array out of bounds test

2017-03-31 Thread Nicolai Hähnle
On 31.03.2017 01:53, Timothy Arceri wrote: Section 5.7 of the GLSL 4.5 spec says: "Behavior is undefined if a shader subscripts an array with an index less than 0 or greater than or equal to the size the array was declared with." So we cannot be sure which path the shader will take.

Re: [Piglit] [PATCH] arb_shader_clock: add basic execution tests

2017-03-31 Thread Ilia Mirkin
On Fri, Mar 31, 2017 at 2:32 AM, Nicolai Hähnle wrote: > On 30.03.2017 15:03, Ilia Mirkin wrote: >> >> On Thu, Mar 30, 2017 at 8:19 AM, Nicolai Hähnle >> wrote: >>> >>> On 30.03.2017 14:07, Ilia Mirkin wrote: Time could roll over... not sure

[Piglit] [PATCH 5/6] arb_shader_ballot: test ballotARB inside if/else control flow

2017-03-31 Thread Nicolai Hähnle
From: Nicolai Hähnle --- .../execution/fs-ballot-if-else.shader_test| 83 ++ 1 file changed, 83 insertions(+) create mode 100644 tests/spec/arb_shader_ballot/execution/fs-ballot-if-else.shader_test diff --git

[Piglit] [PATCH 6/6] arb_shader_ballot: test peeling away the first invocation

2017-03-31 Thread Nicolai Hähnle
From: Nicolai Hähnle --- .../fs-readFirstInvocation-uint-if.shader_test | 32 ++ .../fs-readFirstInvocation-uint-loop.shader_test | 49 ++ 2 files changed, 81 insertions(+) create mode 100644

[Piglit] [PATCH 0/6] ARB_shader_ballot tests

2017-03-31 Thread Nicolai Hähnle
Hi, this series adds some basic tests for the builtin functions and variables of the ARB_shader_ballot extension. I have only tested this against my own work-in-progress implementation. If somebody got to test it against the AMD or Nvidia blobs, that would be much appreciated. Please review!

[Piglit] [PATCH 3/6] arb_shader_ballot: add readFirstInvocationARB test

2017-03-31 Thread Nicolai Hähnle
From: Nicolai Hähnle --- ...fs-readFirstInvocation-uint-uniform.shader_test | 39 .../fs-readFirstInvocation-uint.shader_test| 52 ++ 2 files changed, 91 insertions(+) create mode 100644

[Piglit] [PATCH 2/6] arb_shader_ballot: add readInvocationARB tests

2017-03-31 Thread Nicolai Hähnle
From: Nicolai Hähnle --- .../fs-readInvocation-uint-uniform.shader_test | 39 ++ .../execution/fs-readInvocation-uint.shader_test | 37 2 files changed, 76 insertions(+) create mode 100644

Re: [Piglit] [PATCH 6/6] arb_shader_ballot: test peeling away the first invocation

2017-03-31 Thread Ilia Mirkin
On Fri, Mar 31, 2017 at 1:02 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > --- > .../fs-readFirstInvocation-uint-if.shader_test | 32 ++ > .../fs-readFirstInvocation-uint-loop.shader_test | 49 > ++ > 2

[Piglit] [PATCH] arb_cull_distance: Fix sometimes-uninitialized warnings.

2017-03-31 Thread Vinson Lee
exceed-limits.c:75:6: warning: variable 'clip_distances' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] if (strcmp(argv[1], "cull") == 0) { ^~~~ exceed-limits.c:90:14: note: uninitialized use occurs here

[Piglit] [PATCH] glslparsertest: Add test case for FDO bug #100438.

2017-03-31 Thread Vinson Lee
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100438 Signed-off-by: Vinson Lee --- tests/glslparsertest/glsl2/fdo100438.frag | 10 ++ 1 file changed, 10 insertions(+) create mode 100644 tests/glslparsertest/glsl2/fdo100438.frag diff --git

Re: [Piglit] [PATCH] arb_shader_clock: add basic execution tests

2017-03-31 Thread Nicolai Hähnle
On 30.03.2017 15:03, Ilia Mirkin wrote: On Thu, Mar 30, 2017 at 8:19 AM, Nicolai Hähnle wrote: On 30.03.2017 14:07, Ilia Mirkin wrote: Time could roll over... not sure what to do about that though. Maybe check if the top 2 bits are set in the old value and are unset in