Re: [Piglit] [PATCH] AMD_performance_monitor: add VC4 specific tests

2018-02-08 Thread Dylan Baker
If there's no other changes required I don't need to see a v2 just to fix all.py, I'm not really qualified to review the patch otherwise though. Dylan Quoting Boris Brezillon (2018-02-08 05:39:04) > Hi Dylan, > > On Wed, 07 Feb 2018 10:38:28 -0800 > Dylan Baker wrote: > >

Re: [Piglit] [PATCH 2/2] texunits: don't test glTexEnv with unusable texture units

2018-02-08 Thread Brian Paul
Reviewed-by: Brian Paul On Thu, Feb 8, 2018 at 5:59 PM, Marek Olšák wrote: > From: Marek Olšák > > The GL limit is MaxTextureCombinedUnits, but the real usable limit is > MaxTextureCoordUnits. This is probably a spec bug. > > Mesa

[Piglit] [PATCH 2/2] texunits: don't test glTexEnv with unusable texture units

2018-02-08 Thread Marek Olšák
From: Marek Olšák The GL limit is MaxTextureCombinedUnits, but the real usable limit is MaxTextureCoordUnits. This is probably a spec bug. Mesa will ignore glTexEnv calls where unit >= MaxTextureCoordUnits. --- tests/general/texunits.c | 4 ++-- 1 file changed, 2

[Piglit] [PATCH 1/2] arb_viewport_array/viewport_indices: allow float precision instead of double

2018-02-08 Thread Marek Olšák
From: Marek Olšák Mesa will not use doubles for this state. --- tests/spec/arb_viewport_array/viewport_indices.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/spec/arb_viewport_array/viewport_indices.c

Re: [Piglit] [PATCH] AMD_performance_monitor: add VC4 specific tests

2018-02-08 Thread Boris Brezillon
Hi Dylan, On Wed, 07 Feb 2018 10:38:28 -0800 Dylan Baker wrote: > You'll need to add this to all.py. Will fix that in the next version. Thanks, Boris -- Boris Brezillon, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering http://bootlin.com