Re: [Piglit] [PATCH] arb_gpu_shader_fp64/ssbo: fix tests to skip is no vertex ssbo available.

On 08/03/18 03:43, Dave Airlie wrote: > On 7 March 2018 at 17:52, Alejandro <apinhe...@igalia.com> wrote: >> Typo on the commit message: "skip is no" => "skip if no" >> >> Some comments below. >> >> On 07/03/18 01:54

Re: [Piglit] [PATCH] arb_gpu_shader_fp64/ssbo: fix tests to skip is no vertex ssbo available.

Typo on the commit message: "skip is no" => "skip if no" Some comments below. On 07/03/18 01:54, Dave Airlie wrote: > From: Dave Airlie > > These tests all require varying numbers of ssbos. > --- > .../shader_storage/layout-std140-fp64-mixed-shader.c | 5 >

[Piglit] [PATCH] arb_shader_atomic_counters-semantics: test different binding points

Piglit was not detecting that non-zero bindings was not properly working. --- Mesa patch and bug information here: http://lists.freedesktop.org/archives/mesa-dev/2015-April/082736.html Note that until this patch gets reviewed and committed, the subtests added on this commit would fail. On the

[Piglit] [PATCH v2] arb_shader_atomic_counters-semantics: test different binding points

Piglit was only checking the expected effects using binding point 0. With this commit, all the values between 0 and GL_MAX_ATOMIC_COUNTER_BUFFER_BINDINGS are checked. It also checks that the binding point used on the shader and the one returned by glGetActiveAtomicCounterBufferiv(..., ...,

[Piglit] [PATCH v4] arb_shader_atomic_counters-semantics: test different binding points

Piglit was only checking the expected effects using binding point 0. With this commit, all the values between 0 and GL_MAX_ATOMIC_COUNTER_BUFFER_BINDINGS are checked. It also checks that the binding point used on the shader and the one returned by glGetActiveAtomicCounterBufferiv(..., ...,

[Piglit] [PATCH v3] arb_shader_atomic_counters-semantics: test different binding points

Piglit was only checking the expected effects using binding point 0. With this commit, all the values between 0 and GL_MAX_ATOMIC_COUNTER_BUFFER_BINDINGS are checked. It also checks that the binding point used on the shader and the one returned by glGetActiveAtomicCounterBufferiv(..., ...,

Re: [Piglit] [PATCH v3] arb_shader_atomic_counters-semantics: test different binding points

On 01/08/15 15:47, Timothy Arceri wrote: On Sat, 2015-08-01 at 15:32 +0200, Alejandro Piñeiro wrote: Piglit was only checking the expected effects using binding point 0. With this commit, all the values between 0 and GL_MAX_ATOMIC_COUNTER_BUFFER_BINDINGS are checked. It also checks

[Piglit] [PATCH] arb_internalformat_query: api-errors should take into account query2 when checking invalid formats

From: Alejandro Piñeiro <apinhe...@igaila.com> That check is based on the following paragraph at internalformat_query spec (Error section): If the parameter to GetInternalformativ is not color-, depth- or stencil-renderable, then an INVALID_ENUM error is gen

Re: [Piglit] [PATCH] arb_gpu_shader5: adding an const-nonconst struct-sampler indexing

Wow, this review was quick, thank you very much. FWIW, I don't have git push access. Would you mind to push the commit? Thanks again. On 04/09/15 19:58, Ilia Mirkin wrote: > Reviewed-by: Ilia Mirkin <imir...@alum.mit.edu> > > On Fri, Sep 4, 2015 at 1:48 PM, Alejandro

[Piglit] [PATCH v2] arb_gpu_shader5: adding an const-nonconst struct-sampler indexing

Right now there are tests for the following indexing combination: a) No struct - non const sampler indexing b) Non const struct indexing - single sampler c) Non const struct indexing - const sampler indexing d) Non const struct indexing - non const sampler indexing This commit adds the

[Piglit] [PATCH] arb_gpu_shader5: adding an const-nonconst struct-sampler indexing

Right now there are tests for the following indexing combination: a) No struct - non const sampler indexing b) Non const struct indexing - single sampler c) Non const struct indexing - const sampler indexing d) Non const struct indexing - non const sampler indexing This commit adds the

Re: [Piglit] [Mesa-dev] [RFC PATCH] arb_texture_barrier: call glTextureBarrier after each glDrawRangeElements

On 24/06/16 12:17, Nicolai Hähnle wrote: > Hi Alejandro, Hi, thanks for the quick answer, more comments below. > > my understanding of the spec is that the test should be correct as > originally written, i.e. with glTextureBarrier only between full > rectangle draws. > >

[Piglit] [PATCH] arb_texture_barrier: add an arb_texture_barrier test

Allow to configure: * texture resolution * number of blend passes * number of draw passes (calls to DrawRangeElements) * granularity (triangle count) of the square being draw * number of textures This commits adds to all.py execute the test with a combination of all this parameters. ---

[Piglit] [PATCH v2] arb_texture_barrier: add an arb_texture_barrier test

Allow to configure: * texture resolution * number of blend passes * number of draw passes (calls to DrawRangeElements) * granularity (triangle count) of the square being draw * number of textures This commits adds to all.py execute the test with a combination of all this parameters.

Re: [Piglit] [Mesa-dev] [RFC PATCH] arb_texture_barrier: call glTextureBarrier after each glDrawRangeElements

On 24/06/16 17:15, Ilia Mirkin wrote: > On Fri, Jun 24, 2016 at 10:42 AM, Alejandro Piñeiro > <apinhe...@igalia.com> wrote: >> >> On 24/06/16 12:17, Nicolai Hähnle wrote: >>> Hi Alejandro, >> Hi, thanks for the quick answer, more comments below. >> >

Re: [Piglit] [PATCH] piglit-fbo: check the proper extension dependency when attaching a color texture

On 15/01/16 13:30, Alejandro Piñeiro wrote: > > On 15/01/16 13:07, Mark Janes wrote: >> This patch causes piglit.spec.ext_framebuffer_multisample.accuracy to >> fail on g33 and g965. Is that what you expected? > No, I was not expecting any regression. It seemed a tr

[Piglit] [PATCH] piglit-fbo: check the proper extension dependency when attaching a color texture

attach_color_texture uses TEXTURE_RECTANGLE, so it should check for GL_ARB_texture_rectangle. attach_multisample_color_texture uses multisample texture targets, so it should check for GL_ARB_texture_multisample. Before this patch, the dependency check was wrongly switched. ---

Re: [Piglit] [PATCH] piglit-fbo: check the proper extension dependency when attaching a color texture

On 15/01/16 21:48, Mark Janes wrote: > Alejandro Piñeiro <apinhe...@igalia.com> writes: > >> On 15/01/16 13:07, Mark Janes wrote: >>> This patch causes piglit.spec.ext_framebuffer_multisample.accuracy to >>> fail on g33 and g965. Is that what you expe

Re: [Piglit] [Mesa-dev] [RFC PATCH] arb_texture_barrier: call glTextureBarrier after each glDrawRangeElements

On 24/06/16 20:59, Ilia Mirkin wrote: > On Fri, Jun 24, 2016 at 2:56 PM, Alejandro Piñeiro <apinhe...@igalia.com> > wrote: >> On 24/06/16 17:15, Ilia Mirkin wrote: >>> On Fri, Jun 24, 2016 at 10:42 AM, Alejandro Piñeiro >>> <apinhe...@igalia.com> wro

[Piglit] [PATCH] program_interface_query: no need to check link status when using piglit_build_simple_program_multiple_shaders

From piglit_build_simple_program_multiple_shaders documentation: /** * Builds and links a program from optional sources, throwing * PIGLIT_FAIL on error. The last target must be 0. */ So internally is already calling piglit_link_check_status, deleting the program and reporting PIGLIT_FAIL if

[Piglit] [PATCH] program_interface_query: use format layout qualifiers instead of size* layout qualifiers

From ARB_shader_image_load_store spec: "(0) How does this extension differ from the similar EXT_shader_image_load_store? RESOLVED: The functionality provided by this extension is very similar to that provided by EXT_shader_image_load_stores. There are some

Re: [Piglit] [PATCH 00/21] Tests for ARB_internalformat_query2 extension

On 22/01/16 18:39, Alejandro Piñeiro wrote: > On 22/01/16 18:09, Ian Romanick wrote: >> Is this available on a branch somewhere? I'd like to look at the code >> in tree, but applying 21 patches from the mailing list... ugh. :( > Yes, sorry, I mentioned on the bugzilla, but I for

[Piglit] [PATCH v2] arb_internalformat_query2: add a generic check for TEXTURE_IMAGE_FORMAT

From spec: "Possible values include any value that is legal to pass for the parameter to the Tex*Image*D commands, or NONE if the resource is not supported for this operation." Tested on NVIDIA GeForce GTX 950 - NVIDIA 352.55: fails: In some cases is returns GL_R11F_G11F_B10F or GL_RGB9_ES5,

[Piglit] [PATCH v2] arb_internalformat_query2: Added tests for image textures

From: Antia Puentes Checks that: * TEXEL_SIZE * IMAGE_COMPATIBILITY_CLASS * IMAGE_PIXEL_FORMAT * IMAGE_PIXEL_TYPE return the values defined for them in Table 3.22 of the OpenGL 4.2 specification depending on the "Image Format" passed. For unsupported resources, this

[Piglit] [PATCH 06/21] arb_internalformat_query2: test for INTERNALFORMAT_{X}_TYPE pnames

From spec: " INTERNALFORMAT_RED_TYPE INTERNALFORMAT_GREEN_TYPE INTERNALFORMAT_BLUE_TYPE INTERNALFORMAT_ALPHA_TYPE INTERNALFORMAT_DEPTH_TYPE INTERNALFORMAT_STENCIL_TYPE For uncompressed internal formats, queries for these values return the data type used to store the component. For

[Piglit] [PATCH 09/21] arb_internalformat_query2: check returned max-dimensions values against GetInteger

In addition to the previous checks, this checks that the returned values when supported are the same that the ones you receive calling GetIntegerv with equivalent pnames like GL_MAX_TEXTURE_SIZE, GL_MAX_3D_TEXTURE_SIZE, etc. All those are internal format-independent, meanwhile GetInternalformat

[Piglit] [PATCH 08/21] arb_internalformat_query2: max dimensions related checks

Add a check for the following pnames (a subtest for each one) * MAX_WIDTH. From spec: "The maximum supported width for the resource is returned in . For resources with only one-dimension, this one dimension is considered the width. If the resource is unsupported, zero is returned."

[Piglit] [PATCH 13/21] arb_internalformat_query2: add a generic check for TEXTURE_IMAGE_TYPE

"TEXTURE_IMAGE_TYPE: Possible values include any value that is legal to pass for the parameter to the Tex*Image*D commands, or NONE if the resource is not supported for this operation." Tested on NVIDIA GeForce GTX 950 - NVIDIA 352.55: pass. --- .../generic-pname-checks.c

[Piglit] [PATCH 03/21] arb_internalformat_query2: test for the most generic pname checks

The spec includes conditions for all the pnames. On most cases, it is generic like this: "Possible values returned are . If the resource is not supported, or if the operation is not supported, NONE is returned." So this test checks that for those pnames: * If it is not supported (using

[Piglit] [PATCH 07/21] arb_internalformat_query2: IMAGE_FORMAT_COMPATIBILITY_TYPE test

From spec: "IMAGE_FORMAT_COMPATIBILITY_TYPE: The matching criteria use for the resource when used as an image textures is returned in . This is equivalent to calling GetTexParameter with set to IMAGE_FORMAT_COMPATIBILITY_TYPE. Possible values are

[Piglit] [PATCH 02/21] arb_internalformat_query2: query2 api-error check

Similar to the equivalent for arb_internalformat_query, but in addition to test when a invalid pname/target combination should return INVALID_ENUM, it also checks that a valid combination returns NO_ERROR, and testing both GetInternalformativ and GetInternalformati64v. The rationale of this is

[Piglit] [PATCH 04/21] arb_internalformat_query2: test for SAMPLES and NUM_SAMPLE_COUNTS pnames

For those pnames, it verify that the defined on the spec is fulfilled: NUM_SAMPLE_COUNTS If is not color-renderable, depth-renderable, or stencil-renderable (as defined in section 4.4.4), or if does not support multiple samples (ie other than TEXTURE_2D_MULTISAMPLE,

[Piglit] [PATCH 01/21] arb_internalformat_query: remove references to arb_internalformat_query2

arb_internalformat_query tests was taking into account query2, in order to avoid testing some pnames/internalformats valid on query2. But taking into account how deeply arb_internalformat_query2 extended and changed the behaviour of GetInternalformativ, it is really more clear to isolate both.

[Piglit] [PATCH 00/21][RFC] Tests for ARB_internalformat_query2 extension

run using NVIDIA proprietary drivers (NVIDIA GeForce GTX 950 - NVIDIA 352.55). In that case, the pass/fail ratio is 5/8. What is failing is explained on the commit message. cheers, Alejandro (on behalf of the team that worked on this) [1] http://lists.freedesktop.org/archives/mesa-dev/201

[Piglit] [PATCH 15/21] arb_internalformat_query2: add generic check for GET_TEXTURE_IMAGE_TYPE

From spec: "GET_TEXTURE_IMAGE_TYPE: Possible values include any value that is legal to pass for the parameter to GetTexImage, or NONE if the resource does not support this operation, or if GetTexImage is not supported." Tested on NVIDIA GeForce GTX 950 - NVIDIA 352.55: pass. ---

[Piglit] [PATCH 14/21] arb_internalformat_query2: add generic check for GET_TEXTURE_IMAGE_FORMAT

From query2 spec: "GET_TEXTURE_IMAGE_FORMAT: Possible values include any value that is legal to pass for the parameter to GetTexImage, or NONE if the resource does not support this operation, or if GetTexImage is not supported." The possible list of values is the same that testing

[Piglit] [PATCH 19/21] arb_internalformat_query2: Added tests for image textures

From: Antia Puentes Checks that: * TEXEL_SIZE * IMAGE_COMPATIBILITY_CLASS * IMAGE_PIXEL_FORMAT * IMAGE_PIXEL_TYPE return the values defined for them in Table 3.22 of the OpenGL 4.2 specification depending on the "Image Format" passed. This test does not check

[Piglit] [PATCH 12/21] arb_internalformat_query2: add a generic check for TEXTURE_IMAGE_FORMAT

From spec: "Possible values include any value that is legal to pass for the parameter to the Tex*Image*D commands, or NONE if the resource is not supported for this operation." Tested on NVIDIA GeForce GTX 950 - NVIDIA 352.55: fails: In some cases is returns GL_R11F_G11F_B10F or GL_RGB9_ES5,

[Piglit] [PATCH 10/21] arb_internalformat_query2: add MAX_COMBINED_DIMENSIONS subtest to max-dimensions

From spec: "MAX_COMBINED_DIMENSIONS: The maximum combined dimensions for the resource is returned in . The combined dimensions is the product of the individual dimensions of the resource. For multisampled surfaces the number of samples is considered an additional dimension. Note that the

[Piglit] [PATCH 20/21] arb_internalformat_query2: test for FILTER pname

From spec: " FILTER: The support for filter types other than NEAREST or NEAREST_MIPMAP_NEAREST for the resource is written to . This indicates if sampling from such resources supports setting the MIN/MAG filters to LINEAR values. Possible values returned are FULL_SUPPORT, CAVEAT_SUPPORT,

[Piglit] [PATCH 18/21] arb_internalformat_query2: port of query1 minmax test to query2

It is basically the same, but testing with both GetInternalformativ and GetInternalformati64v, using the test_data struct defined at common.h Tested on NVIDIA GeForce GTX 950 - NVIDIA 352.55: pass. --- tests/all.py | 1 +

[Piglit] [PATCH 21/21] arb_internalformat_query2: Added tests for {COLOR, DEPTH, STENCIL}_COMPONENTS

From: Antia Puentes Tested on NVIDIA GeForce GTX 950 - NVIDIA 352.55: pass. --- tests/all.py | 1 + .../arb_internalformat_query2/CMakeLists.gl.txt| 1 + .../arb_internalformat_query2/format-components.c | 280

[Piglit] [PATCH 05/21] arb_internalformat_query2: test for INTERNALFORMAT_{X}_SIZE pnames

From spec: " INTERNALFORMAT_RED_SIZE INTERNALFORMAT_GREEN_SIZE INTERNALFORMAT_BLUE_SIZE INTERNALFORMAT_ALPHA_SIZE INTERNALFORMAT_DEPTH_SIZE INTERNALFORMAT_STENCIL_SIZE INTERNALFORMAT_SHARED_SIZE For textures this query will return the same information as querying

[Piglit] [PATCH 17/21] arb_internalformat_query2: test for TEXTURE_COMPRESSED_BLOCK_

This test add a check for the following pnames: * TEXTURE_COMPRESSED_BLOCK_WIDTH * TEXTURE_COMPRESSED_BLOCK_HEIGHT * TEXTURE_COMPRESSED_BLOCK_SIZE On all those three, query2 spec says the following: "If the internal format is not compressed, or the resource is not supported, 0 is

[Piglit] [PATCH 16/21] arb_internalformat_query2: test for COLOR_ENCODING

From spec: "COLOR_ENCODING: Possible values for color buffers are LINEAR or SRGB, for linear or sRGB-encoded color components, respectively. For non-color formats (such as depth or stencil), or for unsupported resources, the value NONE is returned." Tested on NVIDIA GeForce GTX 950 -

[Piglit] [PATCH 06/21] arb_internalformat_query2: test for INTERNALFORMAT_{X}_TYPE pnames

From spec: " INTERNALFORMAT_RED_TYPE INTERNALFORMAT_GREEN_TYPE INTERNALFORMAT_BLUE_TYPE INTERNALFORMAT_ALPHA_TYPE INTERNALFORMAT_DEPTH_TYPE INTERNALFORMAT_STENCIL_TYPE For uncompressed internal formats, queries for these values return the data type used to store the component. For

[Piglit] [PATCH 04/21] arb_internalformat_query2: test for SAMPLES and NUM_SAMPLE_COUNTS pnames

For those pnames, it verify that the defined on the spec is fulfilled: NUM_SAMPLE_COUNTS If is not color-renderable, depth-renderable, or stencil-renderable (as defined in section 4.4.4), or if does not support multiple samples (ie other than TEXTURE_2D_MULTISAMPLE,

[Piglit] [PATCH 13/21] arb_internalformat_query2: add a generic check for TEXTURE_IMAGE_TYPE

"TEXTURE_IMAGE_TYPE: Possible values include any value that is legal to pass for the parameter to the Tex*Image*D commands, or NONE if the resource is not supported for this operation." Tested on NVIDIA GeForce GTX 950 - NVIDIA 352.55: pass. --- .../generic-pname-checks.c

[Piglit] [PATCH 07/21] arb_internalformat_query2: IMAGE_FORMAT_COMPATIBILITY_TYPE test

From spec: "IMAGE_FORMAT_COMPATIBILITY_TYPE: The matching criteria use for the resource when used as an image textures is returned in . This is equivalent to calling GetTexParameter with set to IMAGE_FORMAT_COMPATIBILITY_TYPE. Possible values are

[Piglit] [PATCH 16/21] arb_internalformat_query2: test for COLOR_ENCODING

From spec: "COLOR_ENCODING: Possible values for color buffers are LINEAR or SRGB, for linear or sRGB-encoded color components, respectively. For non-color formats (such as depth or stencil), or for unsupported resources, the value NONE is returned." Tested on NVIDIA GeForce GTX 950 -

[Piglit] [PATCH 02/21] arb_internalformat_query2: query2 api-error check

Similar to the equivalent for arb_internalformat_query, but in addition to test when a invalid pname/target combination should return INVALID_ENUM, it also checks that a valid combination returns NO_ERROR, and testing both GetInternalformativ and GetInternalformati64v. The rationale of this is

[Piglit] [PATCH 09/21] arb_internalformat_query2: check returned max-dimensions values against GetInteger

In addition to the previous checks, this checks that the returned values when supported are the same that the ones you receive calling GetIntegerv with equivalent pnames like GL_MAX_TEXTURE_SIZE, GL_MAX_3D_TEXTURE_SIZE, etc. All those are internal format-independent, meanwhile GetInternalformat

[Piglit] [PATCH 11/21] arb_internalformat_query2: Check if the resource is supported in max-dimensions

From: Antia Puentes The ARB_internalformat_query2 specification says about MAX_WIDTH, MAX_HEIGHT, MAX_DEPTH and MAX_COMBINED_DIMENSIONS : "If the resource is unsupported, zero is returned." From the same specification: "In the following descriptions, the term

[Piglit] [PATCH 19/21] arb_internalformat_query2: Added tests for image textures

From: Antia Puentes Checks that: * TEXEL_SIZE * IMAGE_COMPATIBILITY_CLASS * IMAGE_PIXEL_FORMAT * IMAGE_PIXEL_TYPE return the values defined for them in Table 3.22 of the OpenGL 4.2 specification depending on the "Image Format" passed. This test does not check

[Piglit] [PATCH 17/21] arb_internalformat_query2: test for TEXTURE_COMPRESSED_BLOCK_

This test add a check for the following pnames: * TEXTURE_COMPRESSED_BLOCK_WIDTH * TEXTURE_COMPRESSED_BLOCK_HEIGHT * TEXTURE_COMPRESSED_BLOCK_SIZE On all those three, query2 spec says the following: "If the internal format is not compressed, or the resource is not supported, 0 is

[Piglit] [PATCH 12/21] arb_internalformat_query2: add a generic check for TEXTURE_IMAGE_FORMAT

From spec: "Possible values include any value that is legal to pass for the parameter to the Tex*Image*D commands, or NONE if the resource is not supported for this operation." Tested on NVIDIA GeForce GTX 950 - NVIDIA 352.55: fails: In some cases is returns GL_R11F_G11F_B10F or GL_RGB9_ES5,

[Piglit] [PATCH 03/21] arb_internalformat_query2: test for the most generic pname checks

The spec includes conditions for all the pnames. On most cases, it is generic like this: "Possible values returned are . If the resource is not supported, or if the operation is not supported, NONE is returned." So this test checks that for those pnames: * If it is not supported (using

[Piglit] [PATCH 21/21] arb_internalformat_query2: Added tests for {COLOR, DEPTH, STENCIL}_COMPONENTS

From: Antia Puentes Tested on NVIDIA GeForce GTX 950 - NVIDIA 352.55: pass. --- tests/all.py | 1 + .../arb_internalformat_query2/CMakeLists.gl.txt| 1 + .../arb_internalformat_query2/format-components.c | 281

[Piglit] [PATCH 08/21] arb_internalformat_query2: max dimensions related checks

Add a check for the following pnames (a subtest for each one) * MAX_WIDTH. From spec: "The maximum supported width for the resource is returned in . For resources with only one-dimension, this one dimension is considered the width. If the resource is unsupported, zero is returned."

[Piglit] [PATCH 15/21] arb_internalformat_query2: add generic check for GET_TEXTURE_IMAGE_TYPE

From spec: "GET_TEXTURE_IMAGE_TYPE: Possible values include any value that is legal to pass for the parameter to GetTexImage, or NONE if the resource does not support this operation, or if GetTexImage is not supported." Tested on NVIDIA GeForce GTX 950 - NVIDIA 352.55: pass. ---

[Piglit] [PATCH 10/21] arb_internalformat_query2: add MAX_COMBINED_DIMENSIONS subtest to max-dimensions

From spec: "MAX_COMBINED_DIMENSIONS: The maximum combined dimensions for the resource is returned in . The combined dimensions is the product of the individual dimensions of the resource. For multisampled surfaces the number of samples is considered an additional dimension. Note that the

[Piglit] [PATCH 01/21] arb_internalformat_query: remove references to arb_internalformat_query2

arb_internalformat_query tests was taking into account query2, in order to avoid testing some pnames/internalformats valid on query2. But taking into account how deeply arb_internalformat_query2 extended and changed the behaviour of GetInternalformativ, it is really more clear to isolate both.

[Piglit] [PATCH 18/21] arb_internalformat_query2: port of query1 minmax test to query2

It is basically the same, but testing with both GetInternalformativ and GetInternalformati64v, using the test_data struct defined at common.h Tested on NVIDIA GeForce GTX 950 - NVIDIA 352.55: pass. --- tests/all.py | 1 +

[Piglit] [PATCH 00/21] Tests for ARB_internalformat_query2 extension

at was proposed this week for Mesa [1]. They were also run against NVIDIA proprietary drivers (NVIDIA GeForce GTX 950 - NVIDIA 352.55). In that case, the pass/fail ratio is 5/8. What is failing is explained on the commit message. cheers, Alejandro (on behalf of the team that worked on this) [

[Piglit] [PATCH 20/21] arb_internalformat_query2: test for FILTER pname

From spec: " FILTER: The support for filter types other than NEAREST or NEAREST_MIPMAP_NEAREST for the resource is written to . This indicates if sampling from such resources supports setting the MIN/MAG filters to LINEAR values. Possible values returned are FULL_SUPPORT, CAVEAT_SUPPORT,

Re: [Piglit] [PATCH 01/21] arb_internalformat_query: remove references to arb_internalformat_query2

On 22/01/16 18:08, Ian Romanick wrote: > On 01/22/2016 08:05 AM, Alejandro Piñeiro wrote: >> arb_internalformat_query tests was taking into account query2, in >> order to avoid testing some pnames/internalformats valid on query2. >> >> But taking into account how deepl

Re: [Piglit] [PATCH 00/21] Tests for ARB_internalformat_query2 extension

ub.com/Igalia/piglit/tree/internalformat-query2 > > On 01/22/2016 08:05 AM, Alejandro Piñeiro wrote: >> This series provides the tests for the ARB_internalformat_query2 >> extension: >> >> https://www.opengl.org/registry/specs/ARB/internalformat_query2.txt >>

Re: [Piglit] [PATCH 00/21] Tests for ARB_internalformat_query2 extension

Gentle ping asking for someone interested on doing the review of this series. On 22/01/16 17:05, Alejandro Piñeiro wrote: > This series provides the tests for the ARB_internalformat_query2 > extension: > > https://www.opengl.org/registry/specs/ARB/internalformat_query2.txt > >

Re: [Piglit] [PATCH] arb_internalformat_query2: Fix memory leak in test_data_clear.

st_data **data) > free(_data->params); > _data->params = NULL; > > + free(_data); > *data = NULL; > } > Reviewed-by: Alejandro Piñeiro <apinhe...@igalia.com> ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH] arb_internalformat_query2: Fix memory leaks.

Thanks Reviewed-by: Alejandro Piñeiro <apinhe...@igalia.com> On 31/03/16 02:39, Vinson Lee wrote: > Fix resource leak defects reported by Coverity. > > Signed-off-by: Vinson Lee <v...@freedesktop.org> > --- > tests/spec/arb_internalformat_query2/max-dimensions.c | 7 +

Re: [Piglit] [PATCH] arb_internalformat_query2: Remove comparison of unsigned expression < 0.

ys called with an unsigned index, so probably it is simpler this way. So either if you change the type of the parameter, or just use this patch: Reviewed-by: Alejandro Piñeiro <apinhe...@igalia.com> > Signed-off-by: Vinson Lee <v...@freedesktop.org> > --- > tests/spec/arb_i

[Piglit] RFC: confusion about vertex attrib location index=0 and CURRENT_VERTEX_ATTRIB

Hi, while checking the spec of ARB_vertex_attrib64bit [1] searching for possible piglit tests, I found the following paragraph: void GetVertexAttribLdv(uint index, enum pname, double *params); (modify the third paragraph, p. 388) The query CURRENT_VERTEX_ATTRIB returns the current

Re: [Piglit] RFC: confusion about vertex attrib location index=0 and CURRENT_VERTEX_ATTRIB

On 05/04/16 18:46, Alejandro Piñeiro wrote: > Hi, > > while checking the spec of ARB_vertex_attrib64bit [1] searching for > possible piglit tests, I found the following paragraph: > > void GetVertexAttribLdv(uint index, enum pname, double *params); > > (modify the

Re: [Piglit] [PATCH] arb_internalformat_query2: Add fall through comment.

Reviewed-by: Alejandro Piñeiro <apinhe...@igalia.com> On 07/04/16 00:59, Vinson Lee wrote: > Silence Coverity "missing break in switch" defect. > > Signed-off-by: Vinson Lee <v...@freedesktop.org> > --- > tests/spec/arb_internalformat_query2/common.c

Re: [Piglit] [PATCH v2] util: Add new headed matrix_index header to [vertex data]

Ping. Timothy could you take a look to the patch? BTW, this is basically your patch, plus the minor tweaks I asked you on my review. If you were the one doing them, I would have granted the R-b. So you just need to confirm that you agree with the changes. BR On 04/04/16 10:04, Alejandro Piñeiro

Re: [Piglit] [PATCH v2] util: Add new headed matrix_index header to [vertex data]

Thanks for confirming. I have just pushed a v3 patch adding a reference to arrays of arrays on the documentation. And thanks for the patch. BR On 09/04/16 03:14, Timothy Arceri wrote: > On Fri, 2016-04-08 at 10:10 +0200, Alejandro Piñeiro wrote: >> Ping. Timothy could you ta

Re: [Piglit] [PATCH v2] arb_internalformat_query2: Set expected_value in default case.

On 08/03/16 09:03, Alejandro Piñeiro wrote: > > On 08/03/16 07:37, Vinson Lee wrote: >> Fixes uninitialized scalar defect reported by Coverity. >> >> Also fix incorrect assertion. >> >> Suggested-by: Brian Paul <bri...@vmware.com> >>

Re: [Piglit] [PATCH v2] arb_internalformat_query2: Set expected_value in default case.

things is what it is done on image-texture test, so it is probably more consistent this way. With those small changes: Reviewed-by: Alejandro Piñeiro <apinhe...@igalia.com> Thanks. ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 00/21] Tests for ARB_internalformat_query2 extension

On 04/03/16 05:44, Dave Airlie wrote: > On 23 January 2016 at 02:05, Alejandro Piñeiro <apinhe...@igalia.com> wrote: >> This series provides the tests for the ARB_internalformat_query2 >> extension: >> >> https://www.opengl.org/registry/specs/ARB/internalformat_q

Re: [Piglit] [PATCH 00/21] Tests for ARB_internalformat_query2 extension

. Thanks in advance On 22/01/16 17:05, Alejandro Piñeiro wrote: > This series provides the tests for the ARB_internalformat_query2 > extension: > > https://www.opengl.org/registry/specs/ARB/internalformat_query2.txt > > The corresponding bug is being tracked at: > > http

Re: [Piglit] [PATCH 00/21] Tests for ARB_internalformat_query2 extension

On 03/03/16 19:44, Alejandro Piñeiro wrote: > On 02/03/16 09:49, Alejandro Piñeiro wrote: >> The series on mesa that implements the feature got a review, mostly >> accepting it, pending two small things: >> >> https://lists.freedesktop.org/archives/mesa-dev/2016-Marc

Re: [Piglit] [PATCH 00/21] Tests for ARB_internalformat_query2 extension

On 02/03/16 09:49, Alejandro Piñeiro wrote: > The series on mesa that implements the feature got a review, mostly > accepting it, pending two small things: > > https://lists.freedesktop.org/archives/mesa-dev/2016-March/108956.html > > So here another ping for the piglit series, a

Re: [Piglit] [PATCH] util: Add new headed matrix_index header to [vertex data]

On 03/04/16 03:45, Timothy Arceri wrote: > On Fri, 2016-04-01 at 13:01 +0200, Alejandro Piñeiro wrote: >> While searching how to specify matrices on shader runner I found this >> unreviewed patch. I guess that a late review is better than nothing. >> >> On 10/12/15

[Piglit] [PATCH v2] util: Add new headed matrix_index header to [vertex data]

From: Timothy Arceri <timothy.arc...@collabora.com> This allows data to be set for matrix attributes in shader runner. For example to set colunm 2 of mat2x3: attname/float/3/1 v2 (changes made by Alejandro in behalf of Timothy Arceri): * Fix matrix_index, as was wrongly being substracte

Re: [Piglit] [PATCH] util: Add new headed matrix_index header to [vertex data]

While searching how to specify matrices on shader runner I found this unreviewed patch. I guess that a late review is better than nothing. On 10/12/15 06:25, Timothy Arceri wrote: > This allows data to be set for matrix attributes in shader runner. > > For example to set colunm 2 of mat2x3: >

Re: [Piglit] [PATCH 1/4] arb_vertex_attrib_64bit: Adds double vertex input tests generator (v2)

On 20/05/16 10:25, Andres Gomez wrote: > On Fri, 2016-05-20 at 10:00 +0200, Alejandro Piñeiro wrote: >> On 20/05/16 01:25, Andres Gomez wrote: >> Really nitpicky nitpick: when v2 patches are sent to the list, "v2" >> is >> included on the prefix on bl

Re: [Piglit] [PATCH 1/4] arb_vertex_attrib_64bit: Adds double vertex input tests generator (v2)

types, including a double derived type. Note that this generator > creates a big amount of test: ~6000. > > v2: > - Include tests with interleaved u/int derived types. > - Values are never repeated in a shader variable to avoid identical > array members or columns in the same mat

[Piglit] [PATCH 06/12] arb_internalformat_query2: 0 is a valid value for NUM_SAMPLE_COUNTS

minmax is testing that the implementation fulfill the minimum values stablished by the spec. Copied from the equivalent arb_internalformat_query1 test, it was returning error if any of the tested formats returned 0 for NUM_SAMPLE_COUNTS, as the minimum value was 1. That is not a restriction for

[Piglit] [PATCH 00/12] ARB_internalformat_query2 support for OpenGL ES and other fixes

when printing some failing cases, that I implemented while working on this. [1] https://lists.freedesktop.org/archives/mesa-dev/2016-May/116673.html [2] https://www.khronos.org/bugzilla/show_bug.cgi?id=1496 Alejandro Piñeiro (12): arb_internalformat_query2: fix framebuffer object dependency

[Piglit] [PATCH 10/12] registry: arb_internalformat_query2 should be also supported on gles2

From the ARB_internalformat_query2 spec: "Dependencies OpenGL 2.0 or OpenGL ES 2.0 is required." So the extension should be also supported on gles2. Khronos public bug created: https://www.khronos.org/bugzilla/show_bug.cgi?id=1496 Acked-by: Eduardo Lima

[Piglit] [PATCH 07/12] arb_internalformat_query2: add common config macro for all query2 tests

As we are using the same source code in order to test this extension on desktop gl, gles2 or gles3, the values of supports_gl_es_version or supports_gl_compat_version can vary. Instead of using #ifdefs, one alternative would be pass this value as a command line parameter when calling the binary.

[Piglit] [PATCH 11/12] arb_internalformat_query2: print more details when filter test fails

Acked-by: Eduardo Lima Acked-by: Antia Puentes --- tests/spec/arb_internalformat_query2/common.c | 4 ++-- tests/spec/arb_internalformat_query2/common.h | 4 tests/spec/arb_internalformat_query2/filter.c | 15 +-- 3 files changed, 19

[Piglit] [PATCH 08/12] arb_internalformat_query2: add gles2 tests

Acked-by: Eduardo Lima Acked-by: Antia Puentes --- tests/all.py| 17 + .../spec/arb_internalformat_query2/CMakeLists.gles2.txt | 17 + 2 files changed, 34 insertions(+) create

[Piglit] [PATCH 12/12] arb_internalformat_query2: print properly the value of a failing case

Before this commit, it was printed the numerical value and always tried to get a GL enum from it. This commit checks if the pname returns a enum or not and decide. Additionally it also do some wrapping on the fact that GL_NONE, GL_POINTS and GL_FALSE has the same value. Acked-by: Eduardo Lima

[Piglit] [PATCH 05/12] arb_internalformat_query2: color-renderable formats are different for gles

Acked-by: Eduardo Lima Acked-by: Antia Puentes --- tests/spec/arb_internalformat_query2/minmax.c | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/tests/spec/arb_internalformat_query2/minmax.c

[Piglit] [PATCH 03/12] arb_internalformat_query2: being more strict with the format/type inferred from internalformat

For max-dimensions test we are trying to create a texture based on the target and internalformat, in order to confirm if it is supported or not. gles seems to be more strict on the type/format used, so we need to be more careful. This commit helps to get max-dimensions test passing on gles.

[Piglit] [PATCH 02/12] arb_internalformat_query2: add gles3 checks when checking for dependencies

Acked-by: Eduardo Lima Acked-by: Antia Puentes --- tests/spec/arb_internalformat_query2/common.c | 29 ++- 1 file changed, 24 insertions(+), 5 deletions(-) diff --git a/tests/spec/arb_internalformat_query2/common.c

[Piglit] [PATCH 01/12] arb_internalformat_query2: fix framebuffer object dependency check

For most tests the dependency is not needed. For the ones that need the functionality, the check is about supporting the extension or being under gles. Acked-by: Eduardo Lima Acked-by: Antia Puentes --- tests/spec/arb_internalformat_query2/api-errors.c

Re: [Piglit] [PATCH 1/2] util: Add array_index support to [vertex data] (v2)

From my side: Reviewed-by: Alejandro Piñeiro <apinhe...@igalia.com> Having said so, with this patch we are basically changing the format for vertex attribute data, used on tons of existing shader tests. And although the previous format is still supported, this patch marks it as deprecate

Re: [Piglit] [PATCH] util: Add array_index support to [vertex data]

On 25/04/16 15:56, Andres Gomez wrote: > This allows data to be set for arbitrary array sized attributes in > shader runner. > > For example to set mat2x3[2]: > attname[0]/mat2x3/3/1 attname[0]/mat2x3/3/2 attname[1]/mat2x3/3/1 > attname[1]/mat2x3/3/2 > > The syntax has been extended so the

  1   2   3   4   5   >