Re: [Piglit] [PATCH] primitive-restart: test primitive-restart with VBO

2012-05-11 Thread Brian Paul
On 05/10/2012 11:34 AM, Jordan Justen wrote: On Thu, May 10, 2012 at 9:26 AM, Jordan Justenjljus...@gmail.com wrote: On Thu, May 10, 2012 at 8:58 AM, Jordan Justenjljus...@gmail.com wrote: On Thu, May 10, 2012 at 7:10 AM, Brian Paulbri...@vmware.com wrote: I'd like to have a separate test

Re: [Piglit] [PATCH 01/29] texline: Replace glut with piglit-util and glut_wrap.h

2012-05-21 Thread Brian Paul
On 05/21/2012 12:08 PM, Pauli Nieminen wrote: Signed-off-by: Pauli Nieminenpauli.niemi...@linux.intel.com --- tests/mesa/tests/texline.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/tests/mesa/tests/texline.c b/tests/mesa/tests/texline.c index 1c99953..7e0c134

Re: [Piglit] [PATCH] colormaterial-query test

2012-05-23 Thread Brian Paul
On 05/23/2012 12:01 AM, Tapani Pälli wrote: introduce a new test which checks that GL_COLOR_MATERIAL state does not get lost with sequential queries. Signed-off-by: Tapani Pällitapani.pa...@intel.com --- tests/all.tests |1 + tests/general/CMakeLists.gl.txt |1

Re: [Piglit] [PATCH 0/3] primitive-restart updates (add probe point, cleanup, add VBO)

2012-05-24 Thread Brian Paul
On 05/23/2012 04:48 PM, Jordan Justen wrote: Brian, You had some concerns about my previous primitive-restart + VBO changes, since they caused llvmpipe to fail the primitive-restart test. You were also concerned that I was only testing the case where there was a single combined VBO for vertex

Re: [Piglit] [PATCH v4 3/4] primitive-restart: add VBO testing

2012-05-29 Thread Brian Paul
Looks OK otherwise. Reviewed-by: Brian Paul bri...@vmware.com ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH v4 0/4] add VBO testing to primitive-restart and instanced_arrays

2012-05-29 Thread Brian Paul
files changed, 305 insertions(+), 107 deletions(-) I just had the one comment on the last patch. Reviewed-by: Brian Paul bri...@vmware.com ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH] generated_tests: Add positional argument specifiers.

2012-05-31 Thread Brian Paul
) parser_test += ' * [end config]\n' parser_test += ' *\n' parser_test += ' * Check that the following test vectors are constant folded correctly:\n' I've never used the str.format() stuff but I checked the 2.6 docs and this looks right. Reviewed-by: Brian Paul bri

[Piglit] [PATCH 1/2] integer-errors: check error detection for integer-related images

2012-06-06 Thread Brian Paul
This is basically code that was in the old integer-texture test. This test just validates GL error detection for glReadPixels, glDrawPixels, glTexImage, etc. with regard to signed/unsigned integer formats. --- tests/all.tests |1 +

[Piglit] [PATCH 2/2] texture-integer: move/improve the integer texture test to spec/gl-3.0/

2012-06-06 Thread Brian Paul
The old test was a mix of rendering tests, api tests, limit checks, etc. The new test just exercises rendering with textures of all the different integer formats. --- tests/all.tests |2 +- tests/spec/gl-3.0/CMakeLists.gl.txt |1 + tests/spec/gl-3.0/texture-integer.c |

Re: [Piglit] [PATCH 1/2] integer-errors: check error detection for integer-related images

2012-06-08 Thread Brian Paul
On 06/08/2012 11:03 AM, Chad Versace wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/07/2012 03:40 PM, Brian Paul wrote: On 06/07/2012 02:32 PM, Chad Versace wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/06/2012 12:40 PM, Brian Paul wrote: This is basically code

[Piglit] [PATCH 1/2] readpix-z: test glReadPixels(GL_DEPTH_COMPONENT)

2012-06-08 Thread Brian Paul
. + */ + +/** + * Test glReadPixels(GL_DEPTH_COMPONENT) + * Brian Paul + * June 2012 + */ + +#include piglit-util.h + +int piglit_width = 200, piglit_height = 200; +int piglit_window_mode = GLUT_RGB | GLUT_DOUBLE | GLUT_DEPTH; + + + +static void +draw_z_gradient(GLfloat zLeft, GLfloat zRight) +{ + GLfloat

[Piglit] [PATCH 2/2] drawpix-z: test glDrawPixels(GL_DEPTH_COMPONENT)

2012-06-08 Thread Brian Paul
WITH THE SOFTWARE OR THE USE OR OTHER + * DEALINGS IN THE SOFTWARE. + */ + +/** + * Test glDrawPixels(GL_DEPTH_COMPONENT) + * Brian Paul + * June 2012 + * + * We don't rely on glReadPixels(GL_DEPTH_COMPONENT) in case it's not + * working. Instead we test by drawing an image into the depth buffer

[Piglit] [PATCH] drawpix-z: test glDrawPixels(GL_DEPTH_COMPONENT)

2012-06-11 Thread Brian Paul
OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER + * DEALINGS IN THE SOFTWARE. + */ + +/** + * Test glDrawPixels(GL_DEPTH_COMPONENT) + * Brian Paul + * June 2012 + * + * We don't rely on glReadPixels(GL_DEPTH_COMPONENT) in case it's

Re: [Piglit] [PATCH 00/14] Move main() from libpiglitutil into each test

2012-06-13 Thread Brian Paul
On 06/12/2012 05:02 PM, Chad Versace wrote: The goal that this series achieves is to replace the main() function in piglit-framework.c with a new function, piglit_gl_test_run(), that takes as its input a data structure describing the test initialization info. This goal is a stepping stone

[Piglit] [PATCH] util: fix broken depth/stencil FBO setup

2012-06-14 Thread Brian Paul
The call to glTexImage2D(internalFormat=GL_DEPTH_STENCIL, format=GL_RGBA, type=GL_UNSIGNED_BYTE) generated in invalid operation error since the formats disagreed. The subsquent glFramebufferTexture2D() calls failed too. And Mesa hit a failed assertion (ex: piglit drawpix-z -fbo). Fixed by

Re: [Piglit] [PATCH 1/7] GL_ARB_ubo/negative-bindbuffer-index: New test for API errors.

2012-06-19 Thread Brian Paul
mode 100644 tests/spec/arb_uniform_buffer_object/negative-bindbuffer-index.c For the series: Reviewed-by: Brian Paul bri...@vmware.com ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] NOTICE: piglit_{width, height, window_mode} are no longer used

2012-06-21 Thread Brian Paul
On 06/20/2012 05:58 PM, Chad Versace wrote: I just committed a series that changes the way test executables should be written. This only affects tests written in C. The variables piglit_width, piglit_height, and piglit_window_mode are no longer used. If you want to write this: int

Re: [Piglit] [PATCH] util: Add include guards in piglit-framework.h.

2012-06-25 Thread Brian Paul
#includestdbool.h @@ -127,3 +129,5 @@ extern bool piglit_use_fbo; extern unsigned int piglit_winsys_fbo; extern void piglit_present_results(); + +#endif /* PIGLIT_FRAMEWORK_H */ Reviewed-by: Brian Paul bri...@vmware.com ___ Piglit mailing list Piglit

[Piglit] [PATCH 1/3] security/initialized-texmemory - test contents of unitialized texture memory

2012-06-27 Thread Brian Paul
value (like all zeros). + * But since that's not spec'd by OpenGL, we only return WARN instead of + * FAIL if that's not the case. + * + * Brian Paul + * June 2012 + */ + +#include piglit-util.h + +PIGLIT_GL_TEST_MAIN( +512 /*window_width*/, +512 /*window_height*/, +GLUT_RGB | GLUT_DOUBLE

[Piglit] [PATCH 3/3] security/initialized-vbo: test contents of uninitialized VBOs

2012-06-27 Thread Brian Paul
value (like all zeros). + * But since that's not spec'd by OpenGL, we only return WARN instead of + * FAIL if that's not the case. + * + * Brian Paul + * June 2012 + */ + +#include piglit-util.h + +PIGLIT_GL_TEST_MAIN( +100 /*window_width*/, +100 /*window_height*/, +GLUT_RGB | GLUT_DOUBLE

Re: [Piglit] [PATCH] primitive-restart: test transform feedback for GL = 3.0

2012-06-28 Thread Brian Paul
On 06/27/2012 05:01 PM, Marek Olšák wrote: Hi Jordan, please could you NOT change behavior of existing tests, so that it's not seen as a regression when comparing different test results and the test starts failing? The preferred way to update a test is either by adding command-line arguments

Re: [Piglit] [PATCH] bugs: reproduce bug 50925 (Primitive Restart + Tranform Feedback)

2012-06-28 Thread Brian Paul
On 06/28/2012 11:04 AM, Jordan Justen wrote: Signed-off-by: Jordan Justenjordan.l.jus...@intel.com --- tests/all.tests |1 + tests/bugs/CMakeLists.gl.txt |1 + tests/bugs/fdo50925.c| 105 ++ 3 files changed, 107

[Piglit] [PATCH] util: check for valid file type in piglit_load_text_file()

2012-07-02 Thread Brian Paul
Piglit would segfault if piglit_load_text_file() was accidentally passed a directory name instead of a filename. Now return NULL if the file is not regular or a symlink. --- tests/util/piglit-util.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git

Re: [Piglit] [PATCH 1/2] Add tests for ARB_transform_feedback3

2012-07-05 Thread Brian Paul
This is a pretty big patch and I didn't study every line, but it looks OK overall. Just minor comments below. For both: Reviewed-by: Brian Paul bri...@vmware.com On Thu, Jul 5, 2012 at 4:40 AM, Marek Olšák mar...@gmail.com wrote: --- tests/all.tests | 11

Re: [Piglit] [PATCH] util: Warn and report SKIP when we get a window resize during an auto run.

2012-07-19 Thread Brian Paul
On 07/18/2012 06:20 PM, Eric Anholt wrote: We've got a bunch of instances of this happening intermittently during runs with gnome-shell. Because our tests are not generally able to handle resizes, they would show up as spurious failures that are hard to reproduce. Instead, provide a diagnostic

[Piglit] [PATCH] util: check for valid file type in piglit_load_text_file()

2012-07-20 Thread Brian Paul
Piglit would segfault if piglit_load_text_file() was accidentally passed a directory name instead of a filename. Now return NULL if the file is not regular or a symlink. --- tests/util/piglit-util.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git

[Piglit] [PATCH 1/4] remove glsl-fs-sqrt-zero test

2012-07-20 Thread Brian Paul
Will be replaced by new shader_runner tests. --- tests/all.tests |1 - tests/shaders/CMakeLists.gl.txt |1 - tests/shaders/glsl-fs-sqrt-zero.c| 80 -- tests/shaders/glsl-fs-sqrt-zero.frag |4 -- 4 files changed, 0

[Piglit] [PATCH 2/4] remove glsl-vs-sqrt-zero test

2012-07-20 Thread Brian Paul
Will be replaced by new shader runner tests. --- tests/all.tests |1 - tests/shaders/CMakeLists.gl.txt |1 - tests/shaders/glsl-vs-sqrt-zero.c| 80 -- tests/shaders/glsl-vs-sqrt-zero.vert |6 --- 4 files changed, 0

[Piglit] [PATCH 3/4] vs|fs-sqrt-const-zero: new sqrt(0) tests to replace tests removed previously

2012-07-20 Thread Brian Paul
Note that sqrt(0) will typically be evaluated at compile time, not at render time. New tests will be added for render-time testing. --- tests/all.tests|5 + .../execution/fs-sqrt-const-zero.shader_test | 19 +++

[Piglit] [PATCH 4/4] vs|fs-sqrt-zero: test sqrt(x) with uniform x=0

2012-07-20 Thread Brian Paul
Since sqrt(x) is typically implemented with a reciprocal square root, zero is a special case. Mesa's GLSL-TGSI translator uses a CND instruction to return 0 if x=0. --- .../glsl-1.00/execution/fs-sqrt-zero.shader_test | 26 .../glsl-1.00/execution/vs-sqrt-zero.shader_test

Re: [Piglit] [PATCH 4/4] vs|fs-sqrt-zero: test sqrt(x) with uniform x=0

2012-07-20 Thread Brian Paul
On 07/20/2012 02:40 PM, Eric Anholt wrote: Brian Paulbri...@vmware.com writes: Since sqrt(x) is typically implemented with a reciprocal square root, zero is a special case. Mesa's GLSL-TGSI translator uses a CND instruction to return 0 if x=0. Looks like these tests already the issue more

[Piglit] [PATCH] util: fix MSVC build failure in piglit_ktx.c

2012-07-31 Thread Brian Paul
Using void pointers for pointer arithmetic doesn't work. Fixes: tests\util\piglit_ktx.c(333) : error C2036: 'void *' : unknown size Fixes http://bugs.freedesktop.org/show_bug.cgi?id=53013 --- tests/util/piglit_ktx.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[Piglit] [PATCH] GL_ARB_ubo/maxblocks: fix writing to zero-length string

2012-08-02 Thread Brian Paul
When get_shader() was called with blocks=0 we were allocating string buffers of length zero. Assigning prefix[0] = 0 caused an invalid memory write (found w/ valgrind). Adding one to the calloc() length fixes this. But compiling a shader string of length=0 seems a little strange... ---

Re: [Piglit] [PATCH] Fix swapbuffers timing in arb_seamless_cubemap test.

2012-08-07 Thread Brian Paul
-by: Brian Paul bri...@vmware.com ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH] glean: Skip multisample configs

2012-08-09 Thread Brian Paul
) + continue; + Window w(ws, **p, fWidth, fHeight); RenderingContext rc(ws, **p); if (!ws.makeCurrent(rc, w)) { Reviewed-by: Brian Paul bri...@vmware.com

Re: [Piglit] [PATCH] Allow testing of generic compressed texture formats with 1D/3D textures

2012-08-21 Thread Brian Paul
On 08/21/2012 04:11 PM, Anuj Phogat wrote: On Tue, Aug 21, 2012 at 12:26 PM, Brian Paulbri...@vmware.com wrote: On 08/21/2012 01:12 PM, Anuj Phogat wrote: The generic texture formats are allowed in theinternalformat parameter of TexImage1D, TexImage2D, TexImage3D, CopyTexImage1D, and

[Piglit] [PATCH] copyteximage: refactor the code for readability and debugging

2012-08-24 Thread Brian Paul
Test a single target/format combination in test_target_and_format(). This makes it a bit easier to hack the code to debug a specific combination. It's also easier to read. (note: the patch/diff might look really ugly and complicated but the code movement is pretty simple, actually) ---

[Piglit] [PATCH] egl_khr_create_context: add extension #defines to common.h

2012-08-28 Thread Brian Paul
From: Brian Paul bri...@vmware.com To allow building when the system's eglext.h isn't new enough. --- tests/egl/spec/egl_khr_create_context/common.h | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/tests/egl/spec/egl_khr_create_context/common.h b/tests

Re: [Piglit] [PATCH] copyteximage: loosen the tolerance for compressed formats

2012-08-28 Thread Brian Paul
On 08/28/2012 03:01 PM, Marek Olšák wrote: Interesting, I have the same patch here, except that I need the tolerance to be 5,5,5,5 for r300g (COMPRESSED_RED is fetched with 4 bits of precision, but 5 is good enough for the test). Could you please change it to 5,5,5,5? Sure. And I'll assume

[Piglit] [PATCH] tex3d-depth1: test that a 3D texture w/ depth=1 works properly

2012-08-29 Thread Brian Paul
, TORT OR OTHERWISE, ARISING FROM, + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER + * DEALINGS IN THE SOFTWARE. + */ + +/** + * Tests 3D texture with depth=1 (to make sure it's not errantly treated + * as a 2D texture. + * + * Brian Paul + * 28 Aug 2012 + */ + +#include piglit-util

[Piglit] [PATCH] max-texture-size-level: test per-level max texture size error checking

2012-09-04 Thread Brian Paul
--- tests/all.tests |1 + tests/texturing/CMakeLists.gl.txt|1 + tests/texturing/max-texture-size-level.c | 87 ++ 3 files changed, 89 insertions(+), 0 deletions(-) create mode 100644 tests/texturing/max-texture-size-level.c

Re: [Piglit] [PATCH] max-texture-size-level: test per-level max texture size error checking

2012-09-06 Thread Brian Paul
On 09/05/2012 06:26 PM, Vadim Girlin wrote: On Tue, 2012-09-04 at 17:05 -0600, Brian Paul wrote: --- tests/all.tests |1 + tests/texturing/CMakeLists.gl.txt|1 + tests/texturing/max-texture-size-level.c | 87 ++ 3 files

Re: [Piglit] [PATCH 3/7] arb_texture_cube_map_array: check for teximage3d invalid values.

2012-09-06 Thread Brian Paul
). Reviewed-by: Brian Paul bri...@vmware.com ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 4/7] arb_texture_cube_map_array: test getting binding.

2012-09-06 Thread Brian Paul
); + glBindTexture(GL_TEXTURE_CUBE_MAP_ARRAY, tex); + + glGetIntegerv(GL_TEXTURE_BINDING_CUBE_MAP_ARRAY_ARB,param); + + if (param != tex) +piglit_report_result(PIGLIT_FAIL); + + piglit_report_result(PIGLIT_PASS); +} Reviewed-by: Brian Paul bri...@vmware.com

Re: [Piglit] [PATCH 6/7] arb_texture_cube_map_array: add fbo test

2012-09-06 Thread Brian Paul
On 09/05/2012 09:34 PM, Dave Airlie wrote: This tests the glFramebufferTextureLayer interface. Signed-off-by: Dave Airlieairl...@redhat.com --- .../arb_texture_cube_map_array/CMakeLists.gl.txt |1 + .../arb_texture_cube_map_array/fbo-cubemap-array.c | 297 2

Re: [Piglit] ARB_texture_cube_map_array : initial tests

2012-09-06 Thread Brian Paul
On 09/05/2012 09:34 PM, Dave Airlie wrote: This is a bunch of tests to start testing ARB_texture_cube_map_array. The first patch modifies textureSize, the rest are standalone tests, and the final patch just adds to all.tests. All tests pass on the nvidia binary 295.59. I think the one area

Re: [Piglit] [PATCH] max-texture-size-level: test per-level max texture size error checking

2012-09-06 Thread Brian Paul
On 09/06/2012 04:42 PM, Vadim Girlin wrote: On Thu, 2012-09-06 at 08:01 -0600, Brian Paul wrote: On 09/05/2012 06:26 PM, Vadim Girlin wrote: On Tue, 2012-09-04 at 17:05 -0600, Brian Paul wrote: --- tests/all.tests |1 + tests/texturing/CMakeLists.gl.txt

[Piglit] [PATCH] max-texture-size-level: don't try to create maxSize x maxSize textures

2012-09-06 Thread Brian Paul
We might not have enough memory for a texture that large. Use width or height = 1 instead. --- tests/texturing/max-texture-size-level.c | 40 +++-- 1 files changed, 31 insertions(+), 9 deletions(-) diff --git a/tests/texturing/max-texture-size-level.c

Re: [Piglit] ARB_texture_cube_map_array : initial tests

2012-09-07 Thread Brian Paul
On 09/06/2012 05:11 PM, Dave Airlie wrote: On Fri, Sep 7, 2012 at 1:08 AM, Brian Paulbri...@vmware.com wrote: On 09/05/2012 09:34 PM, Dave Airlie wrote: This is a bunch of tests to start testing ARB_texture_cube_map_array. The first patch modifies textureSize, the rest are standalone tests,

Re: [Piglit] [PATCH] max-texture-size-level: test per-level max texture size error checking

2012-09-07 Thread Brian Paul
On 09/06/2012 05:13 PM, Vadim Girlin wrote: On Thu, 2012-09-06 at 16:56 -0600, Brian Paul wrote: On 09/06/2012 04:42 PM, Vadim Girlin wrote: On Thu, 2012-09-06 at 08:01 -0600, Brian Paul wrote: On 09/05/2012 06:26 PM, Vadim Girlin wrote: On Tue, 2012-09-04 at 17:05 -0600, Brian Paul wrote

[Piglit] [PATCH 1/2] texture-storage: fix internal format mistakes in the test

2012-09-08 Thread Brian Paul
Per issue 17 of the extension spec, unsized internalFormat values are not allowed. Change GL_RGBA to GL_RGBA8 and add some extra error checks. The test passes on NVIDIA now. --- tests/spec/arb_texture_storage/texture-storage.c | 22 ++ 1 files changed, 14 insertions(+), 8

[Piglit] [PATCH 2/2] texture-storage: do more thorough testing of internal format values

2012-09-08 Thread Brian Paul
Check that all the common unsized internal formats are illegal. And check that some common sized formats are accepted. --- tests/spec/arb_texture_storage/texture-storage.c | 85 ++ 1 files changed, 85 insertions(+), 0 deletions(-) diff --git

Re: [Piglit] glean/depthStencil: Warning: depthStencil ignored; not a valid test name.

2012-09-12 Thread Brian Paul
On 09/12/2012 08:23 AM, Andreas Boll wrote: 2012/9/12 Andreas Bollandreas.boll@gmail.com: I get the following output from glean/depthStencil test: Returncode: 0 Errors: Warning: depthStencil ignored; not a valid test name. Steps to reproduce: $ ./bin/glean -r test -o -v -v -v -t

Re: [Piglit] [PATCH 2/2] fbo-blit-stretch: add ability to choose a subtest

2012-09-12 Thread Brian Paul
(GL_ARB_framebuffer_object); + + if (argc == 2) + sscanf(argv[1], %d,test_index); } Reviewed-by: Brian Paul bri...@vmware.com ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH] fbo-colormask-formats: test glColorMask with all formats

2012-09-14 Thread Brian Paul
-colormask-formats.c LTGM. Reviewed-by: Brian Paul bri...@vmware.com ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCH 1/2] fbo-blit-stretch: add cast to silence signed/unsigned comparison warning

2012-09-20 Thread Brian Paul
--- tests/fbo/fbo-blit-stretch.cpp |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tests/fbo/fbo-blit-stretch.cpp b/tests/fbo/fbo-blit-stretch.cpp index 4c4b528..b18a721 100644 --- a/tests/fbo/fbo-blit-stretch.cpp +++ b/tests/fbo/fbo-blit-stretch.cpp @@ -538,7 +538,7 @@

[Piglit] [PATCH 2/2] shader_runner: add casts to silence char** vs const GLchar** warnings

2012-09-20 Thread Brian Paul
--- tests/shaders/shader_runner.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c index 0aff387..1d6cfe0 100644 --- a/tests/shaders/shader_runner.c +++ b/tests/shaders/shader_runner.c @@ -137,12 +137,12 @@

Re: [Piglit] [PATCH] Add a test for EXT_texture_swizzle and DEPTH_TEXTURE_MODE together.

2012-09-21 Thread Brian Paul
); + piglit_require_extension(GL_ARB_texture_rg); require GLSL too? + + setup_shaders(); + setup_texture(); +} Looks good otherwise. Reviewed-by: Brian Paul bri...@vmware.com ___ Piglit mailing list Piglit@lists.freedesktop.org http

[Piglit] [PATCH] s3tc-errors: test GL error checking with s3tc textures

2012-09-22 Thread Brian Paul
From: Brian Paul bri...@vmware.com Check for expected OpenGL errors related to texture compression. For example, glCompresedTexSubImage2D() offset/size values must be multiples of four. This test could be expanded to cover other compression formats in the future. Also, this test contains some

Re: [Piglit] [PATCH 3/7] arb_texture_cube_map_array: check for teximage3d invalid values.

2012-09-22 Thread Brian Paul
On Sat, Sep 22, 2012 at 2:07 AM, Dave Airlie airl...@gmail.com wrote: On Fri, Sep 7, 2012 at 12:52 AM, Brian Paul bri...@vmware.com wrote: On 09/05/2012 09:34 PM, Dave Airlie wrote: From: Dave Airlieairl...@redhat.com This tests teximage3d returns invalid values for width != height

[Piglit] [PATCH] piglit: add piglit_rgbw_image() helper

2012-09-22 Thread Brian Paul
From: Brian Paul bri...@vmware.com Create an image buffer with red, green, blue, white quadrants. This code was extracted out of the piglit_rgbw_texture() function. The piglit_rgbw_texture() function is then rewritten to use the new piglit_rgbw_image() function. --- tests/util/piglit-util-gl

[Piglit] [PATCH] arb_texture_cube_map_array: fix assorted compiler warnings

2012-09-22 Thread Brian Paul
From: Brian Paul bri...@vmware.com Fix const correctness warnings. Remove unused label. Use program name in error messages. --- tests/spec/arb_texture_cube_map_array/cubemap.c| 14 +++--- .../arb_texture_cube_map_array/fbo-cubemap-array.c |4 +--- 2 files changed, 8

Re: [Piglit] [PATCH] Clean up depth-tex-modes-glsl a bit.

2012-09-24 Thread Brian Paul
a new one. So I started by cleaning it up a bit. In the end I decided to write a new test anyway (already reviewed on the list), but figured the cleanups are worthwhile anyway. Reviewed-by: Brian Paul bri...@vmware.com ___ Piglit mailing list Piglit

Re: [Piglit] [PATCH] glsl-fs-shadow2D-clamp-z: test clamping of Z in shadow2D

2012-09-24 Thread Brian Paul
, 1.0) Reviewed-by: Brian Paul bri...@vmware.com ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH] Test that sRGB-related blits are allowed and do not do encoding/decoding.

2012-09-25 Thread Brian Paul
On 09/24/2012 05:35 PM, Paul Berry wrote: The behaviour specified by OpenGL for blits involving sRGB is self-contradictory--it is unclear whether blits should perform sRGB encoding/decoding, and if so, whether this encoding/decoding should be dependent upon the setting of the GL_FRAMEBUFFER_SRGB

[Piglit] [PATCH 1/2] teximage-errors: use piglit_check_gl_error() helper

2012-09-27 Thread Brian Paul
From: Brian Paul bri...@vmware.com --- tests/texturing/teximage-errors.c | 60 +--- 1 files changed, 22 insertions(+), 38 deletions(-) diff --git a/tests/texturing/teximage-errors.c b/tests/texturing/teximage-errors.c index 5f0497d..a5acc56 100644 --- a/tests

[Piglit] [PATCH 2/2] teximage-errors: fix a couple mistakes, add two new test cases

2012-09-27 Thread Brian Paul
From: Brian Paul bri...@vmware.com Fix incorrect texture height (16, not 15). Fix incorrect width, height for glCopyTexSubImage2D() test. Add two new SubImage tests for non-existant mipmap levels. --- tests/texturing/teximage-errors.c | 15 +-- 1 files changed, 13 insertions(+), 2

[Piglit] to-do item: clean up GL error checks

2012-09-28 Thread Brian Paul
If someone's looking for something simple to do in piglit... There's about 150 instances of this in the tests: assert(glGetError() == 0); I think that quite a few of them should be replaced with: if (!piglit_check_gl_error(GL_NO_ERROR)) fail; Some seem to be development sanity checks but

[Piglit] [PATCH 1/3] piglit: add compressed texture helper functions

2012-09-29 Thread Brian Paul
--- tests/util/piglit-util-gl-common.c | 85 tests/util/piglit-util-gl-common.h | 13 ++ 2 files changed, 98 insertions(+), 0 deletions(-) diff --git a/tests/util/piglit-util-gl-common.c b/tests/util/piglit-util-gl-common.c index 03d7420..7a5b2c7

[Piglit] [PATCH 3/3] compressedteximage: use new piglit compressed texture helpers

2012-09-29 Thread Brian Paul
--- tests/texturing/compressedteximage.c | 52 ++--- 1 files changed, 22 insertions(+), 30 deletions(-) diff --git a/tests/texturing/compressedteximage.c b/tests/texturing/compressedteximage.c index dd83a7b..7bcac9f 100644 --- a/tests/texturing/compressedteximage.c

[Piglit] [PATCH 2/3] s3tc-errors: use new piglit compressed texture helpers

2012-09-29 Thread Brian Paul
--- tests/texturing/s3tc-errors.c | 90 +++-- 1 files changed, 15 insertions(+), 75 deletions(-) diff --git a/tests/texturing/s3tc-errors.c b/tests/texturing/s3tc-errors.c index 2f6ef89..8a6546d 100644 --- a/tests/texturing/s3tc-errors.c +++

Re: [Piglit] to-do item: clean up GL error checks

2012-10-01 Thread Brian Paul
Great! Just to be clear, I don't think that _all_ the assert(glGetError() == 0); checks need to be replaced. In some cases they seemed to be development/sanity checks (which could probably just be removed). But in other cases it seems to be used to check that new extension enum tokens are

[Piglit] [PATCH] s3tc-errors: add additional texture size checks

2012-10-02 Thread Brian Paul
Zero-sized tex images and sub images should not generate an error. Full images which are not multiples of the block size should also be legal. Verified w/ NVIDIA's driver. --- tests/texturing/s3tc-errors.c | 38 ++ 1 files changed, 38 insertions(+), 0

[Piglit] [PATCH 2/3] piglit: rename FindLine() to piglit_find_line()

2012-10-03 Thread Brian Paul
--- tests/util/piglit-util-gl.c |2 +- tests/util/piglit-util.c|2 +- tests/util/piglit-util.h|2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/util/piglit-util-gl.c b/tests/util/piglit-util-gl.c index 96f6258..cb697d8 100644 ---

Re: [Piglit] [PATCH] Replace more if(piglit_get_gl_version() N)...

2012-10-04 Thread Brian Paul
); - piglit_report_result(PIGLIT_SKIP); - } + piglit_require_gl_version(15); piglit_require_GLSL(); piglit_require_transform_feedback(); Reviewed-by: Brian Paul bri...@vmware.com ___ Piglit mailing list Piglit

Re: [Piglit] [PATCH] Use piglit_check_gl_error() instead of block with [f]printf.

2012-10-04 Thread Brian Paul
-by: Brian Paul bri...@vmware.com ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 02/23] texline: Remove test

2012-10-04 Thread Brian Paul
/writeimg.c delete mode 100644 tests/mesa/util/writeimg.h LGTM. Reviewed-by: Brian Paul bri...@vmware.com ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 1/3] depth-cube-map: remove useless glFinish and piglit_report_result

2012-10-07 Thread Brian Paul
? PIGLIT_PASS : PIGLIT_FAIL); return pass ? PIGLIT_PASS : PIGLIT_FAIL; } For the series, Reviewed-by: Brian Paul bri...@vmware.com ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH] piglit-util-gl-common: fix ES1 / ES2 build error

2012-10-08 Thread Brian Paul
On Mon, Oct 8, 2012 at 6:17 PM, Jordan Justen jordan.l.jus...@intel.com wrote: Signed-off-by: Jordan Justen jordan.l.jus...@intel.com Cc: Brian Paul bri...@vmware.com Cc: Chad Versace chad.vers...@linux.intel.com --- tests/util/piglit-util-gl-common.c |7 +++ 1 file changed, 7

Re: [Piglit] [PATCH] draw-vertices-2101010: init color in piglit_draw

2012-10-09 Thread Brian Paul
); for (i = 0; tests[i].test; i++) { glBindBuffer(GL_ARRAY_BUFFER, 0); Reviewed-by: Brian Paul bri...@vmware.com ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH] all.tests: remove glean/teapot

2012-10-10 Thread Brian Paul
measurement tests too. But that's a whole other discussion. I'm fine with this patch though. Reviewed-by: Brian Paul bri...@vmware.com ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH] piglit-util-gl-common: fix ES1 / ES2 build error

2012-10-10 Thread Brian Paul
On 10/10/2012 12:27 PM, Chad Versace wrote: On 10/08/2012 06:23 PM, Brian Paul wrote: On Mon, Oct 8, 2012 at 6:17 PM, Jordan Justenjordan.l.jus...@intel.com wrote: Signed-off-by: Jordan Justenjordan.l.jus...@intel.com Cc: Brian Paulbri...@vmware.com Cc: Chad Versacechad.vers

Re: [Piglit] [PATCH] piglit-util-gl-common: fix ES1 / ES2 build error

2012-10-10 Thread Brian Paul
On 10/10/2012 01:26 PM, Chad Versace wrote: On 10/10/2012 12:00 PM, Brian Paul wrote: On 10/10/2012 12:27 PM, Chad Versace wrote: On 10/08/2012 06:23 PM, Brian Paul wrote: On Mon, Oct 8, 2012 at 6:17 PM, Jordan Justenjordan.l.jus...@intel.com wrote: Signed-off-by: Jordan

Re: [Piglit] [PATCH] texturing: Add test unpack-teximage2d

2012-10-12 Thread Brian Paul
. Reviewed-by: Brian Paul bri...@vmware.com ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH v2] piglit-dispatch: patch glDraw{Arrays, Elements}InstancedARB dispatch to accept ARB_instanced_arrays.

2012-10-12 Thread Brian Paul
satisfied, then # the given dispatch set is not supported by the implementation, # so we want to call the unsupported() function. I'm not too familiar with this code but this looks OK to me. Reviewed-by: Brian Paul bri...@vmware.com ___ Piglit

Re: [Piglit] arb_texture_multisample V2

2012-10-15 Thread Brian Paul
On 10/13/2012 08:55 PM, Chris Forbes wrote: Updated for new test config macros; added all.tests plumbing. Just a couple style comments- Piglit generally used tab-8 indentation. Some function calls have extra spaces, ex: f( x ) instead of f(x). -Brian

Re: [Piglit] [PATCH] tests/fbo-blit-stretch: add a 1x1 - nxm stretch test case

2012-10-15 Thread Brian Paul
, DSTXMIN + 7, DSTYMIN + 7, // stretch x y + GL_NEAREST, + }, + + + /* * Clip */ Looks OK to me. Reviewed-by: Brian Paul bri...@vmware.com ___ Piglit mailing list Piglit@lists.freedesktop.org http

Re: [Piglit] [Mesa-dev] [ANNOUNCE] waffle-1.1.0

2012-10-15 Thread Brian Paul
On 10/15/2012 02:37 AM, Chad Versace wrote: Waffle 1.1.0 is now available. Downloads and documentation are available at http://people.freedesktop.org/~chadversary/waffle/releases.html#1.1.0 Waffle is a cross-platform library that allows one to defer selection of GL API and of window system

[Piglit] [PATCH] piglit: fix crashes when using original GLUT

2012-10-15 Thread Brian Paul
The glutInit() function in the original GLUT expects argv[0] to be the program name (as from main()), not a NULL pointer. A strrchr() call crashes on NULL. For now, set argv[0]=piglit. Previously, glutInit would get the program path/name and it would appear in the window title. This seems to

Re: [Piglit] [PATCH] fbo-clear-format: test stencil glClear

2012-10-15 Thread Brian Paul
On 10/15/2012 11:10 AM, Marek Olšák wrote: The test visualizes the stencil buffer (unlike some other tests), which is very useful for debugging. Unfortunately, it doesn't work with Mesa. There seems to be a bogus GL error. The problem can be reproduced by running: ./fbo-clear-formats

Re: [Piglit] [PATCH] piglit: fix crashes when using original GLUT

2012-10-15 Thread Brian Paul
On 10/15/2012 12:08 PM, Chad Versace wrote: On 10/15/2012 10:30 AM, Brian Paul wrote: The glutInit() function in the original GLUT expects argv[0] to be the program name (as from main()), not a NULL pointer. A strrchr() call crashes on NULL. For now, set argv[0]=piglit. Previously, glutInit

Re: [Piglit] [waffle] [Mesa-dev] [ANNOUNCE] waffle-1.1.0

2012-10-15 Thread Brian Paul
On 10/15/2012 12:13 PM, Chad Versace wrote: On 10/15/2012 07:57 AM, Brian Paul wrote: On 10/15/2012 02:37 AM, Chad Versace wrote: I unpacked the .xz file, then $ cd waffle-1.1.0 $ export WAFFLE_SOURCE_DIR=$PWD/src $ cmake \ -DCMAKE_LIBRARY_PATH=$(echo $LIBRARY_PATH | sed 's/:/;/g

Re: [Piglit] [waffle] [Mesa-dev] [ANNOUNCE] waffle-1.1.0

2012-10-15 Thread Brian Paul
On 10/15/2012 12:42 PM, Chad Versace wrote: On 10/15/2012 11:20 AM, Brian Paul wrote: On 10/15/2012 12:13 PM, Chad Versace wrote: On 10/15/2012 07:57 AM, Brian Paul wrote: On 10/15/2012 02:37 AM, Chad Versace wrote: I unpacked the .xz file, then $ cd waffle-1.1.0 $ export

Re: [Piglit] [ANNOUNCE] waffle-1.1.1

2012-10-17 Thread Brian Paul
On 10/16/2012 04:40 PM, Chad Versace wrote: Waffle 1.1.1 - 16 Oct 2012 == Waffle 1.1.1 is a bugfix release. It fixes bugs discovered since 1.1.0. Downloads and documentation are available at: http://people.freedesktop.org/~chadversary/waffle/releases.html#1.1.1

Re: [Piglit] [PATCH] readpix-z: asst. test improvements

2012-10-18 Thread Brian Paul
On 10/17/2012 05:43 PM, Eric Anholt wrote: Brian Paulbri...@vmware.com writes: 1. Do a simple test that glClear(GL_DEPTH_BUFFER_BIT) works as expected. 2. Display the depth buffer contents as a grayscale image when not running in automatic mode to aid debugging. Since we've got lots of

Re: [Piglit] [PATCH] readpix-z: asst. test improvements

2012-10-18 Thread Brian Paul
On 10/18/2012 08:42 AM, Brian Paul wrote: On 10/17/2012 05:43 PM, Eric Anholt wrote: Brian Paulbri...@vmware.com writes: 1. Do a simple test that glClear(GL_DEPTH_BUFFER_BIT) works as expected. 2. Display the depth buffer contents as a grayscale image when not running in automatic mode to aid

Re: [Piglit] [PATCH 2/2] GL_ARB_occlusion_query2: Add tests for the API.

2012-10-19 Thread Brian Paul
; + } + + return pass ? PIGLIT_PASS : PIGLIT_FAIL; +} + +void +piglit_init(int argc, char **argv) +{ + piglit_require_extension(GL_ARB_occlusion_query2); +} Reviewed-by: Brian Paul bri...@vmware.com ___ Piglit mailing list Piglit

Re: [Piglit] [PATCH] Comment continuation in the middle of a define.

2012-10-25 Thread Brian Paul
// in the macro effectively makes the rest of the macro's characters go away, and hence, produces a compilation error. Reviewed-by: Brian Paul bri...@vmware.com ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman

Re: [Piglit] [PATCH] Fix glu.h inclusions on Mac OS X.

2012-10-29 Thread Brian Paul
On 10/27/2012 02:55 PM, Vinson Lee wrote: This patch fixes build failures on Mac OS X since commit 68de5fb435e6e1cb0caedddff0fd0a9c221b0005. Signed-off-by: Vinson Leev...@freedesktop.org --- tests/shaders/fp-fragment-position.c | 4

[Piglit] [PATCH 2/3] clip-flag-behavior: use piglit_check_gl_error() function instead of local code

2012-10-29 Thread Brian Paul
To remove dependency on glu.h --- tests/spec/gl-2.0/api/clip-flag-behavior.c | 38 +--- 1 files changed, 12 insertions(+), 26 deletions(-) diff --git a/tests/spec/gl-2.0/api/clip-flag-behavior.c b/tests/spec/gl-2.0/api/clip-flag-behavior.c index ecc8328..8f9d8a6 100644

  1   2   3   4   5   6   7   8   9   10   >