[Piglit] [PATCH 06/14] cmake: Add option USE_WAFFLE

2012-05-22 Thread Chad Versace
If enabled, Piglit will use Waffle in place of GLUT. The option is disabled by default. As of this patch, however, enabling this option does nothing but require libwaffle. Future patches will integrate Waffl into Piglit. Signed-off-by: Chad Versace chad.vers...@linux.intel.com

[Piglit] [PATCH 11/14] glut_waffle: Add libglut_waffle

2012-05-22 Thread Chad Versace
smoothly. Once the transition is complete, piglit-framework.c will be updated to use Waffle directly, and libglut_waffle will be removed. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- src/CMakeLists.txt|4 + src/glut_waffle/CMakeLists.no_api.txt |6 + src

[Piglit] [PATCH 12/14] piglit: Include glut_waffle.h if USE_WAFFLE is enabled

2012-05-22 Thread Chad Versace
Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- src/piglit/glut_wrap.h |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/piglit/glut_wrap.h b/src/piglit/glut_wrap.h index e28bac9..4f1c2f9 100644 --- a/src/piglit/glut_wrap.h +++ b/src/piglit

Re: [Piglit] [PATCH 01/29] texline: Replace glut with piglit-util and glut_wrap.h

2012-05-22 Thread Chad Versace
- Chad Versace chad.vers...@linux.intel.com -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJPvAzVAAoJEAIvNt057x8iDdsQAIO0KB4Pzo+JtZNE66ahpbEZ NRnO8yfTu8W3P9ZuzQR3AkvW4HQ+Wg/Ji4qBX/+xA+Dv9tShof07hUZ

Re: [Piglit] [PATCH 02/29] EXT_unpack_subimage: Remove unnecessary egl.h include

2012-05-22 Thread Chad Versace
GL_EXT_unpack_subimage. */ -#include EGL/egl.h - #include piglit-util.h int piglit_width = 100, piglit_height = 100; Reviewed-by: Chad Versace chad.vers...@linux.intel.com -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

Re: [Piglit] [PATCH 08/18] util: Disable piglit_glx_window_set_no_input when using Waffle

2012-05-23 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/23/2012 01:10 PM, Pauli Nieminen wrote: On Wed, May 23, 2012 at 01:02:16PM -0700, Chad Versace wrote: On 05/23/2012 08:46 AM, Pauli Nieminen wrote: On Tue, May 22, 2012 at 06:01:48PM -0700, Chad Versace wrote: From: Chad Versace c

Re: [Piglit] [PATCH 06/29] util: Check that glx is supported in the selected platform

2012-05-23 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/23/2012 07:39 AM, Pauli Nieminen wrote: On Tue, May 22, 2012 at 03:20:51PM -0700, Chad Versace wrote: On 05/21/2012 11:08 AM, Pauli Nieminen wrote: Check in runtime if current platform is glx before trying to check glX versions or extensions

Re: [Piglit] Waffle and piglit-dispatch plans

2012-05-29 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/29/2012 06:30 AM, Pauli Nieminen wrote: On Fri, May 25, 2012 at 01:40:10PM -0700, Paul Berry wrote: In the last few months Chad Versace and I have put a lot of effort into reworking the core of Piglit with an eye towards being able

Re: [Piglit] Waffle and piglit-dispatch plans

2012-05-30 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/29/2012 01:47 PM, Pauli Nieminen wrote: On Tue, May 29, 2012 at 11:17:26AM -0700, Chad Versace wrote: On 05/29/2012 06:30 AM, Pauli Nieminen wrote: On Fri, May 25, 2012 at 01:40:10PM -0700, Paul Berry wrote: In the last few months Chad

Re: [Piglit] [PATCH 1/2] integer-errors: check error detection for integer-related images

2012-06-07 Thread Chad Versace
incorrectly passes if the first call to glTexSubImage fails. Placing `if(!piglit_check_gl_error(GL_NO_ERROR)) return false` after the call should fix it. Other than that, Reviewed-by: Chad Versace chad.vers...@linux.intel.com -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.19 (GNU/Linux

Re: [Piglit] [PATCH 1/2] integer-errors: check error detection for integer-related images

2012-06-08 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/07/2012 03:40 PM, Brian Paul wrote: On 06/07/2012 02:32 PM, Chad Versace wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/06/2012 12:40 PM, Brian Paul wrote: This is basically code that was in the old integer-texture test

[Piglit] [PATCH 00/14] Move main() from libpiglitutil into each test

2012-06-12 Thread Chad Versace
' stated goal. No regresssions found on Sandybridge. [1] See points 5 and 6 in in http://www.mail-archive.com/piglit@lists.freedesktop.org/msg00239.html. Chad Versace (14): msvc: Copy c99 headers from Mesa for MSVC cmake: For MSVC, add include/msvc/c99 to include path util: Remove

[Piglit] [PATCH 02/14] cmake: For MSVC, add include/msvc/c99 to include path

2012-06-12 Thread Chad Versace
Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- CMakeLists.txt |2 ++ 1 file changed, 2 insertions(+) diff --git a/CMakeLists.txt b/CMakeLists.txt index 7202417..0dbb14f 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -138,6 +138,8 @@ if (MINGW) endif () if (WIN32

[Piglit] [PATCH 03/14] util: Remove custom defs of C99 types for MSVC

2012-06-12 Thread Chad Versace
piglit-util.h contained an #ifdef that defined C99 types for MSVC. Remove that #ifdef block and let MSVC simply include the C99 headers located at $PIGLIT_TOP/include/msvc/c99. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/util/piglit-util.h | 22 ++ 1

[Piglit] [PATCH 04/14] util: Add missing #include

2012-06-12 Thread Chad Versace
piglit-framework-fbo.h used bool, but did not include stdbool.h. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/util/piglit-framework-fbo.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/util/piglit-framework-fbo.h b/tests/util/piglit-framework

[Piglit] [PATCH 05/14] util: Move piglit_use_fbo to piglit-framework.*

2012-06-12 Thread Chad Versace
module, piglit-framework. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/util/piglit-framework-fbo.c |2 -- tests/util/piglit-framework-fbo.h |2 -- tests/util/piglit-framework.c |1 + tests/util/piglit-framework.h |3 +++ 4 files changed, 4 insertions(+), 4

[Piglit] [PATCH 06/14] util: Remove unused piglit_present_results()

2012-06-12 Thread Chad Versace
This was declared in piglit-framework.h, but never defined. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/util/piglit-framework.h |1 - 1 file changed, 1 deletion(-) diff --git a/tests/util/piglit-framework.h b/tests/util/piglit-framework.h index a01b050..fcf38cf 100644

[Piglit] [PATCH 07/14] util: Move glut code from piglit-framework.* to piglit-framework-glut.*

2012-06-12 Thread Chad Versace
or piglit-framework-glut. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/util/CMakeLists.txt |1 + tests/util/piglit-framework-glut.c | 108 tests/util/piglit-framework-glut.h | 28 ++ tests/util/piglit-framework.c

[Piglit] [PATCH 08/14] util: Refactor argv processing out of main()

2012-06-12 Thread Chad Versace
Move argument processing out of main() into a separate function. By simplifying main(), we simplify the transition of main() from libpiglitutil to test executable. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/util/piglit-framework.c | 26 +++--- 1

[Piglit] [PATCH 09/14] util: Move more GLUT initializtion code into piglit-framework-glut.c

2012-06-12 Thread Chad Versace
Why move initialize GLUT in two different places? This patch moves the GLUT initiliazation code located in piglit-util.c into piglit_framework_glut_init(). Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/util/piglit-framework-glut.c | 14 +- tests/util/piglit

Re: [Piglit] [PATCH 03/14] util: Remove custom defs of C99 types for MSVC

2012-06-12 Thread Chad Versace
On 06/12/2012 05:21 PM, Kenneth Graunke wrote: On 06/12/2012 04:02 PM, Chad Versace wrote: piglit-util.h contained an #ifdef that defined C99 types for MSVC. Remove that #ifdef block and let MSVC simply include the C99 headers located at $PIGLIT_TOP/include/msvc/c99. Signed-off-by: Chad

[Piglit] [PATCH] util: Remove unused piglit_set_default_fbo() [v2]

2012-06-12 Thread Chad Versace
This was declared in piglit-framework.h, but never defined. CC: Kenneth Graunke kenn...@whitecape.org Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/util/piglit-framework.h |1 - 1 file changed, 1 deletion(-) diff --git a/tests/util/piglit-framework.h b/tests/util/piglit

Re: [Piglit] [PATCH 02/14] cmake: For MSVC, add include/msvc/c99 to include path

2012-06-13 Thread Chad Versace
On 06/13/2012 12:41 AM, Jose Fonseca wrote: - Original Message - Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- CMakeLists.txt |2 ++ 1 file changed, 2 insertions(+) diff --git a/CMakeLists.txt b/CMakeLists.txt index 7202417..0dbb14f 100644

Re: [Piglit] [PATCH] cmake: Give an early error message when the required make.template module is not available.

2012-06-13 Thread Chad Versace
import_mako_error_code) +if(NOT import_mako_error_code EQUAL 0) + message(FATAL_ERROR mako.template python module not found) +endif(NOT import_mako_error_code EQUAL 0) # Default to compiling with debug information (`gcc -g`): if(NOT CMAKE_BUILD_TYPE) Reviewed-by: Chad Versace chad.vers

Re: [Piglit] [PATCH 2/5] glx_arb_create_context_profile: Verify that the core profile is supported for OpenGL 3.2

2012-06-13 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/12/2012 02:30 PM, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com NVIDIA's closed-source driver passes this test. AMD's closed-source driver has not been tested. NVIDIA's closed-source driver supports both core and

Re: [Piglit] [PATCH 1/5] glx_arb_create_context_profile: Verify that invalid profiles are rejected

2012-06-13 Thread Chad Versace
Reviewed-by: Chad Versace chad.vers...@linux.intel.com -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJP2QV8AAoJEAIvNt057x8i1yQP/j6cnvXXLcd/JVIu4v/k3Ii2 v7o0C3wcTHndxW7F1vC

Re: [Piglit] [PATCH 3/5] glx_arb_create_context_profile: Verify that the profile is ignored pre-3.2

2012-06-13 Thread Chad Versace
+ .../spec/glx_arb_create_context/pre-GL3-profile.c | 67 3 files changed, 69 insertions(+), 0 deletions(-) create mode 100644 tests/spec/glx_arb_create_context/pre-GL3-profile.c Reviewed-by: Chad Versace chad.vers...@linux.intel.com -BEGIN PGP SIGNATURE- Version

Re: [Piglit] [PATCH 5/5] glx_ext_create_context_es2_profile: Verify that the invalid ES versions are rejected

2012-06-13 Thread Chad Versace
or GLXBadProfile. Whatever decision you and James arrive at, this test is Reviewed-by: Chad Versace chad.vers...@linux.intel.com -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJP2QY1AAoJEAIvNt057x8i7xEP

Re: [Piglit] [PATCH 00/14] Move main() from libpiglitutil into each test

2012-06-15 Thread Chad Versace
On 06/15/2012 10:27 AM, Brian Paul wrote: On Fri, Jun 15, 2012 at 11:18 AM, Chad Versace chad.vers...@linux.intel.com wrote: On 06/13/2012 10:25 AM, Chad Versace wrote: On 06/13/2012 09:06 AM, Brian Paul wrote: On 06/12/2012 05:02 PM, Chad Versace wrote: Could you check this into a branch

Re: [Piglit] [PATCH 11/14] util: Define PIGLIT_GL_TEST_MAIN() and friends

2012-06-20 Thread Chad Versace
On 06/20/2012 02:32 AM, Kenneth Graunke wrote: On 06/12/2012 04:02 PM, Chad Versace wrote: PIGLIT_GL_TEST_MAIN() defines a boilerplate main() that should be suitable for most OpenGL test executables. This patch redefines piglit-framework.c:main() with PIGLIT_GL_TEST_MAIN(). In an upcoming

Re: [Piglit] [PATCH] glsl-1.30: Verify proper conversion of large floats to uints.

2012-06-22 Thread Chad Versace
| 38 2 files changed, 75 insertions(+), 0 deletions(-) create mode 100644 tests/spec/glsl-1.30/execution/fs-float-uint-conversion.shader_test create mode 100644 tests/spec/glsl-1.30/execution/vs-float-uint-conversion.shader_test Looks good. Reviewed-by: Chad Versace

Re: [Piglit] [PATCH 2/2] msaa: Test that msaa blits are clipped and scissored correctly.

2012-06-22 Thread Chad Versace
that you did test that variation. Reviewed-by: Chad Versace chad.vers...@linux.intel.com ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH] Make piglitutil library API-independent

2012-06-22 Thread Chad Versace
Blaz, Thanks for splitting the earlier patch into this series of 5. As a result, the changes were much easier to review. Everything looks good to me and is Reviewed-by: Chad Versace chad.vers...@linux.intel.com When you feel that the review process is complete and are ready to commit

Re: [Piglit] [PATCH] msaa: Test that glClear() ignores multisample fragment operations.

2012-06-28 Thread Chad Versace
incidentally selects the right sample for each pixel. This test is Reviewed-by: Chad Versace chad.vers...@linux.intel.com ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCH 0/9] Test texturing from an ETC1 miptree

2012-07-09 Thread Chad Versace
This series culminates in patch 8/9, which adds a test for texturing from an ETC1 miptree of a realworld image. You find the series on my etc1-v8 branch. Tested against my etc1-v8 Mesa branch. Chad Versace (9): util: Make piglit_probe_rect_halves_equal_rgba() GLES-compatible util: Define

Re: [Piglit] [PATCH 5/9] util: Add piglit_join_paths()

2012-07-16 Thread Chad Versace
+while (true) { +const char *p = va_arg(va, const char*); + +while (*p != 0) { +if (size_written == buf_size - 1) +break; You should probably return immediately here, otherwise you might set buf[buf_size -1 ] =

[Piglit] waffle 0.3 branch created

2012-07-31 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 If you build piglit with waffle, then please begin using waffle's 0.3 branch. That branch has a stable API and receives bug fixes. The master branch currently has an unstable API and Piglit fails to build against it. - -Chad -BEGIN PGP

Re: [Piglit] [PATCH] util: fix MSVC build failure in piglit_ktx.c

2012-07-31 Thread Chad Versace
insertions(+), 1 deletions(-) Reviewed-by: Chad Versace chad.vers...@linux.intel.com ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH] Test that glBlitFramebuffer works properly with nonzero miplevels.

2012-08-15 Thread Chad Versace
+ .../framebuffer-blit-levels.c | 250 3 files changed, 254 insertions(+), 0 deletions(-) create mode 100644 tests/spec/arb_framebuffer_object/framebuffer-blit-levels.c Reviewed-by: Chad Versace chad.vers...@linux.intel.com Do you have patches

[Piglit] [PATCH] arb_fbo: Test glBlitFramebuffer on depth textures with nonzero miplevels

2012-08-15 Thread Chad Versace
Extend the framebuffer-blit-levels test to verify that glBlitFramebuffer works when blitting to and from miplevels other than zero for depth textures. CC: Paul Berry stereotype...@gmail.com --- .../framebuffer-blit-levels.c | 125 - 1 file changed, 94

Re: [Piglit] [PATCH] arb_fbo: Test glBlitFramebuffer on depth textures with nonzero miplevels

2012-08-15 Thread Chad Versace
On 08/15/2012 02:17 PM, Paul Berry wrote: On 15 August 2012 12:51, Chad Versace chad.vers...@linux.intel.com mailto:chad.vers...@linux.intel.com wrote: Extend the framebuffer-blit-levels test to verify that glBlitFramebuffer works when blitting to and from miplevels other than

Re: [Piglit] [PATCH] texturing: add full round trip test of array depth textures.

2012-08-27 Thread Chad Versace
(+), 0 deletions(-) create mode 100644 tests/texturing/array-depth-roundtrip.c Reviewed-by: Chad Versace chad.vers...@linux.intel.com ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCH 1/5] tests: Remove all uses of glutGet

2012-08-30 Thread Chad Versace
I'm trying to transition Piglit from using GLUT to using Waffle. This requires killing all uses of GLUT functions, one-by-one. glutGet was only used in one test: fp-fragment-position. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/shaders/fp-fragment-position.c | 6 -- 1

[Piglit] [PATCH 4/5] cmake: If using Waffle, require version 1.0.1

2012-08-30 Thread Chad Versace
A following patch adds support for X11 input to glut_waffle. waffle-1.0.1 contains required bugfixes for that patch to work. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b

Re: [Piglit] [PATCH 5/5] glut_waffle: Add input support for X11

2012-08-30 Thread Chad Versace
On 08/30/2012 06:57 AM, Brian Paul wrote: On 08/30/2012 12:16 AM, Chad Versace wrote: Add support for input when using glut_waffle's GLX and X11/EGL backends. Tested with fbo-clean-formats; I cycled through the tests with the keyboard and then quit with the escape key. Signed-off-by: Chad

Re: [Piglit] [PATCH 2/3] piglit gl: convert gl extension checking to use an array of strings

2012-09-04 Thread Chad Versace
On 09/01/2012 10:15 AM, Jordan Justen wrote: This better matches the interface of glGetStringi, which should be used for GL = 3.0. Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- tests/util/piglit-util-gl-common.c | 55

Re: [Piglit] [PATCH 3/3] piglit gl: use glGetStringi for GL = 3.0

2012-09-04 Thread Chad Versace
On 09/01/2012 10:15 AM, Jordan Justen wrote: Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- tests/util/piglit-util-gl-common.c | 26 -- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git a/tests/util/piglit-util-gl-common.c

[Piglit] [PATCH 00/23] Support tests for GL core contexts

2012-09-28 Thread Chad Versace
that it supports running under GL compat and GL 3.1 core. I haven't had a chance yet to test the GL 3.1 core path because my test machine with the new X server is unavailable today. Testers are welcome. Chad Versace (23): 01 tests: Remove all uses of glutBitmapCharacter 02 texline: Convert to use

[Piglit] [PATCH 02/23] texline: Convert to use piglit framework

2012-09-28 Thread Chad Versace
This test was oldschool. It rolled its own main with a handful of GLUT functions. This patch converts it to use the PIGLIT_GL_TEST_MAIN macro. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/mesa/tests/texline.c | 83 +- 1 file

[Piglit] [PATCH 03/23] tests, util: Wrap glutPostRedisplay with piglit_post_redisplay

2012-09-28 Thread Chad Versace
is windowoverlap; but that test doesn't use piglit-framework, anyway. Since piglit_escape_exit_key() calls piglit_post_redisplay() which is defined in piglitutil_gl*, we must now link piglitutil_gl into piglitglxutil to prevent link errors. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests

[Piglit] [PATCH 04/23] tests, util: Wrap glutKeyboardFunc with piglit_set_keyboard_func

2012-09-28 Thread Chad Versace
is windowoverlap; but that tests doesn't use piglit-framework, anyway. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/fbo/fbo-formats.h | 2 +- tests/fbo/fbo-generatemipmap-formats.c | 2 +- tests/general/texgen.c | 2

[Piglit] [PATCH 07/23] framework: Report 'skip' if test executable not found

2012-09-28 Thread Chad Versace
it must be converted from Python2-style (%) to Python3-style (str.format). Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- framework/exectest.py | 45 +++-- 1 file changed, 31 insertions(+), 14 deletions(-) diff --git a/framework/exectest.py b

[Piglit] [PATCH 10/23] util: Rename piglit-framework.[ch] - piglit-framework-gl.[ch]

2012-09-28 Thread Chad Versace
This imposes naming consistency with other util and framework sources: piglit-util-cl-*, piglit-util-gl-*, and piglit-framework-cl-*. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/util/CMakeLists.txt | 2 +- tests/util/piglit-framework-fbo.c | 2 +- tests/util

[Piglit] [PATCH 11/23] cmake: Prefix cmake options and feature macros with PIGLIT

2012-09-28 Thread Chad Versace
\ -e 's/\(^\|[^_]\)\(USE_\(GLX\|GLUT\|WAFFLE\|OPENGL\|OPENGL_ES1\|OPENGL_ES2\)\)\($\|[^_]\)/\1PIGLIT_\2\4/g' \ -e 's/\(^\|[^_]\)\(BUILD_\(CL\|GLX\|GLES1\|GLES2\)_TESTS\)\($\|[^_]\)/\1PIGLIT_\2\4/g' \ Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- CMakeLists.txt

[Piglit] [PATCH 12/23] util: Add wrappers for malloc and calloc that catch errors

2012-09-28 Thread Chad Versace
Memory allocation should rarely fail, but when it does the test should immediately abort and explain why. This patch defines two utility wrapper functions, piglit_malloc() and piglit_calloc(), that do exactly that when allocation fails. Signed-off-by: Chad Versace chad.vers...@linux.intel.com

[Piglit] [PATCH 13/23] util: Add Waffle utility functions

2012-09-28 Thread Chad Versace
Add utilitiy functions to log Waffle error messages. And add error-checking wrappers for some Waffle functions. The functions are not yet used. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/util/CMakeLists.txt | 6 ++ tests/util/piglit-util-waffle.c | 89

[Piglit] [PATCH 14/23] cmake: Define cmake flags and feature macros for X11, GLX, EGL

2012-09-28 Thread Chad Versace
to libpiglitutil_gl*. The flags and macros are used in a following commit. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- CMakeLists.txt | 11 +++ 1 file changed, 11 insertions(+) diff --git a/CMakeLists.txt b/CMakeLists.txt index 224aa18..bc87d4d 100644 --- a/CMakeLists.txt

[Piglit] [PATCH 15/23] util: Rename piglit_gl_test_info - piglit_gl_test_config

2012-09-28 Thread Chad Versace
to have the structure modified by PIGLIT_GL_TEST_CONFIG_BEGIN to actually be named 'config'. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/util/piglit-framework-fbo.c | 10 +- tests/util/piglit-framework-fbo.h | 6 +++--- tests/util/piglit-framework-gl.c | 20

[Piglit] [PATCH 18/23] cmake: On Linux, require Waffle by default

2012-09-28 Thread Chad Versace
The new GL test framework, piglit_wfl_framework, requires Waffle. Testers should prefer to use that over piglit_glut_framework. To quiet the angry mob, if CMake fails to find Waffle then it prints a helpful message that points to Waffle's website. Signed-off-by: Chad Versace chad.vers

[Piglit] [PATCH 19/23] cmake, util: Switch GL tests to use new framework

2012-09-28 Thread Chad Versace
- Stop building old framework sources, piglit-framework-{fbo,glut}.c. - Stop building libglut_waffle. - Wire up piglit_gl_test_run() to use the new framework. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- cmake/target_api/CMakeLists.txt | 4 +-- cmake/target_api/gl

[Piglit] [PATCH 20/23] util,glut_waffle: Remove unused sources from old GL test framework

2012-09-28 Thread Chad Versace
Remove directory src/glut_waffle. Remove piglit-framework-{fbo,glut}*. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- src/glut_waffle/CMakeLists.no_api.txt | 11 -- src/glut_waffle/CMakeLists.txt| 3 - src/glut_waffle/README.txt| 5 - src/glut_waffle

[Piglit] [PATCH 21/23] util: Remove unneeded extern

2012-09-28 Thread Chad Versace
Remove the extern qualifier on piglit_present_results(). Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/util/piglit-framework-gl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/util/piglit-framework-gl.h b/tests/util/piglit-framework-gl.h index

[Piglit] [NOTICE] Piglit's build requirements for Linux will soon change

2012-09-28 Thread Chad Versace
Just an early alert so your Piglit build doesn't break unexpectedly. Requirements for non-Linux systems will not change. On Linux, Piglit will soon require Waffle as a build requirement by default. If you wish to continue building Piglit without Waffle, then configure Piglit with `cmake

Re: [Piglit] [PATCH 00/23] Support tests for GL core contexts

2012-09-28 Thread Chad Versace
On 09/28/2012 01:16 PM, Eric Anholt wrote: Chad Versace chad.vers...@linux.intel.com writes: This series is on my framework-gl-v22 branch. It is 1.6 MB worth of patches, so I expect some patches to be dropped by the mailing list. For reference, the point where it diverges from master is my

[Piglit] [PATCH 08/23] util, tests: Replace GLUT visual enums with PIGLTI_GL_VISUAL enums

2012-09-28 Thread Chad Versace
GLUT_DEPTH - PIGLIT_GL_VISUAL_DEPTH GLUT_STENCIL- PIGLIT_GL_VISUAL_STENCIL Signed-off-by: Chad Versace chad.vers...@linux.intel.com = This is a giant sed-job patch. Here is an example diff of a test file

[Piglit] [PATCH 22/23] util: Add fields to piglit_gl_test_config for listing supported GL flavors

2012-09-28 Thread Chad Versace
`supports_gl_es2 = true`. For desktop GL tests, add `supports_gl_compat_version = 10`. For an explanation of why version 1.0 is used for desktop GL tests, see the documentation for supports_gl_compat_version. No tests yet require a GL core context. Signed-off-by: Chad Versace chad.vers...@linux.intel.com

Re: [Piglit] [PATCH 2/2] framework: Report the command string instead of traceback on OSError.

2012-09-28 Thread Chad Versace
/exectest.py | 35 +-- 1 file changed, 21 insertions(+), 14 deletions(-) Looks good to me. I'll update the related patch in my series to prevent merge conflicts. Reviewed-by: Chad Versace chad.vers...@linux.intel.com ___ Piglit

Re: [Piglit] [PATCH v2 1/2] piglit gl: convert gl extension checking to use an array of strings

2012-10-01 Thread Chad Versace
On 09/19/2012 10:12 AM, Jordan Justen wrote: This better matches the interface of glGetStringi, which should be used for GL = 3.0. Signed-off-by: Jordan Justen jordan.l.jus...@intel.com The series is Reviewed-by: Chad Versace chad.vers...@linux.intel.com

Re: [Piglit] [PATCH 08/23] util, tests: Replace GLUT visual enums with PIGLTI_GL_VISUAL enums

2012-10-03 Thread Chad Versace
On 10/03/2012 04:43 PM, Kenneth Graunke wrote: On 09/28/2012 01:48 PM, Chad Versace wrote: /** + * A bitmask of these enums specifies visual attributes for the test's window. + * + * Each enum has the same value of its corresponding GLUT enum. That is, for + * each X

Re: [Piglit] [PATCH] piglit framework: add gbm support

2012-10-04 Thread Chad Versace
to me. Singe piglit_gbm_framework doesn't use include any gbm headers or link to libgbm, then it makes sense to enable PIGLIT_HAS_GBM unconditionally on Linux for now. Reviewed-by: Chad Versace chad.vers...@linux.intel.com ___ Piglit mailing list Piglit

Re: [Piglit] [PATCH 1/3] piglit: add const qualifier for filename param for piglit_compile_shader()

2012-10-04 Thread Chad Versace
Series is Reviewed-by: Chad Versace chad.vers...@linux.intel.com ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 2/2] egl_khr_create_context: profile attributes are never invalid for Desktop GL

2012-10-04 Thread Chad Versace
Series is Reviewed-by: Chad Versace chad.vers...@linux.intel.com ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 00/23] Support tests for GL core contexts

2012-10-04 Thread Chad Versace
I plan to commit this series on Monday Oct 4 if no one objects. Several Intel guys have been using this patch series and have not encountered any problems, so I assume the piglit_wfl_framework code is solid. However, I hope to hear from some non-Intel people too before committing. Specifically,

[Piglit] RFC: Series Support tests for GL core contexts

2012-10-04 Thread Chad Versace
I plan to commit the series on Monday Oct 4 if no one objects. Several Intel guys have been using this patch series and have not encountered any problems, so I assume the piglit_wfl_framework code is solid. However, I hope to hear from some non-Intel people too before committing. Specifically,

Re: [Piglit] [PATCH 00/23] Support tests for GL core contexts

2012-10-04 Thread Chad Versace
Ignore the previous email. I resent it as a non-threaded email so it would grab more attention. Reply to that one instead. On 10/04/2012 11:37 AM, Chad Versace wrote: I plan to commit this series on Monday Oct 4 if no one objects. Several Intel guys have been using this patch series and have

[Piglit] [PATCH 02/23] texline: Remove test

2012-10-04 Thread Chad Versace
The texline test did not probe any pixels and was not listed in all.tests. It was not a test at all. This patch also removes directory tests/mesa, because the utility functions defined there were only used by texline. CC: Eric Anholt e...@anholt.net Signed-off-by: Chad Versace chad.vers

[Piglit] [PATCH] gtf: Update EGLConfig ID

2012-10-08 Thread Chad Versace
. Anyway, the two configs are close enough that the GTF results don't change. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/gtf.tests | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/gtf.tests b/tests/gtf.tests index cade81a..572c729 100644 --- a/tests

Re: [Piglit] [PATCH] gtf: Update EGLConfig ID

2012-10-09 Thread Chad Versace
On 10/08/2012 03:40 PM, Kenneth Graunke wrote: On 10/08/2012 03:21 PM, Chad Versace wrote: The mesa commit 7dc0be8 changed the EGLConfig ID's for the Intel driver, and piglit's GTF integration hardcodes the EGLConfig ID. (Apparently, this implies that piglit's GTF integration only works

Re: [Piglit] [PATCH 2/4] egl_khr_create_context_profile: Verify that invalid profiles are rejected

2012-10-10 Thread Chad Versace
On 10/08/2012 04:57 PM, Matt Turner wrote: --- tests/all_egl.tests|1 + .../spec/egl_khr_create_context/CMakeLists.gl.txt |1 + .../spec/egl_khr_create_context/invalid-profile.c | 105 3 files changed, 107 insertions(+), 0

Re: [Piglit] [PATCH] piglit-util-gl-common: fix ES1 / ES2 build error

2012-10-10 Thread Chad Versace
On 10/08/2012 06:23 PM, Brian Paul wrote: On Mon, Oct 8, 2012 at 6:17 PM, Jordan Justen jordan.l.jus...@intel.com wrote: Signed-off-by: Jordan Justen jordan.l.jus...@intel.com Cc: Brian Paul bri...@vmware.com Cc: Chad Versace chad.vers...@linux.intel.com --- tests/util/piglit-util-gl

Re: [Piglit] [PATCH 4/4] egl_khr_create_context_profile: Verify that the profile is ignored pre-3.2

2012-10-11 Thread Chad Versace
On 10/10/2012 01:31 PM, Matt Turner wrote: On Wed, Oct 10, 2012 at 11:04 AM, Chad Versace chad.vers...@linux.intel.com wrote: On 10/08/2012 04:57 PM, Matt Turner wrote: --- tests/all_egl.tests|1 + .../spec/egl_khr_create_context/CMakeLists.gl.txt |1

[Piglit] [PATCH] texturing: Add test unpack-teximage2d

2012-10-11 Thread Chad Versace
, the correctness of glTexImage2D over the combinatorial space of pixel unpacking state. On Intel gen6 with mesa-34c58ac, the RGBA tests pass and the BGRA tests fail. CC: Rob Bradford r...@linux.intel.com CC: Neil Roberts n...@linux.intel.com Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests

Re: [Piglit] [PATCH] texturing: Add test unpack-teximage2d

2012-10-12 Thread Chad Versace
On 10/12/2012 07:25 AM, Brian Paul wrote: On 10/11/2012 09:13 PM, Chad Versace wrote: Add four tests for testing the unpacking state with glTexImage2D. unpack-teximage2d pbo=0 format=GL_RGBA unpack-teximage2d pbo=1 format=GL_RGBA unpack-teximage2d pbo=0 format=GL_BGRA

Re: [Piglit] [PATCH] piglit: fix crashes when using original GLUT

2012-10-15 Thread Chad Versace
and it would appear in the window title. This seems to be a regression since the waffle changes. --- Looks good to me. Reviewed-by: Chad Versace chad.vers...@linux.intel.com Brian, I'm curious on what OS and version of GLUT you found this problem. On Fedora 17 with freeglut-2.8.0 the segfault doesn't

Re: [Piglit] [waffle] [Mesa-dev] [ANNOUNCE] waffle-1.1.0

2012-10-15 Thread Chad Versace
On 10/15/2012 11:20 AM, Brian Paul wrote: On 10/15/2012 12:13 PM, Chad Versace wrote: On 10/15/2012 07:57 AM, Brian Paul wrote: On 10/15/2012 02:37 AM, Chad Versace wrote: I unpacked the .xz file, then $ cd waffle-1.1.0 $ export WAFFLE_SOURCE_DIR=$PWD/src $ cmake

Re: [Piglit] [waffle] [Mesa-dev] [ANNOUNCE] waffle-1.1.0

2012-10-15 Thread Chad Versace
On 10/15/2012 08:59 AM, Marek Olšák wrote: Hi Chad, waffle and/or piglit create an RGBA framebuffer even in the case where only RGB is requested, which breaks these piglit tests: - clearbuffer-display-lists (not sure - fs-texelFetchOffset-2D - fdo25614-genmipmap Thanks for finding the

Re: [Piglit] [PATCH 1/2] util: Fix the variable for linking against waffle.

2012-10-15 Thread Chad Versace
100644 --- a/tests/util/CMakeLists.txt +++ b/tests/util/CMakeLists.txt @@ -47,7 +47,7 @@ endif() set(UTIL_GL_LIBS piglitutil -${WAFFLE_LIBRARIES} +${WAFFLE_LDFLAGS} ) if(${CMAKE_SYSTEM_NAME} MATCHES Linux) Reviewed-by: Chad Versace chad.vers

Re: [Piglit] [PATCH 1/4] glx_arb_create_context: Rename pre-GL3 test to pre-GL32

2012-10-15 Thread Chad Versace
For the series, Reviewed-by: Chad Versace chad.vers...@linux.intel.com ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [ANNOUNCE] waffle-1.1.1

2012-10-16 Thread Chad Versace
build instructions in README.txt. Changes --- The full set changes can be viewed with `git log waffle-1.1.0..waffle-1.1.1`. Chad Versace (4): doc/building: Remove duplicate instructions found in README readme: Clarify build instructions cmake: Bundle the GNUInstallDirs module from cmake

Re: [Piglit] [PATCH 0/8] Add GBM support

2012-10-19 Thread Chad Versace
This series looks good to me. Reviewed-by: Chad Versace chad.vers...@linux.intel.com I wanted to test the series, but the python patches wouldn't apply :( I still want to discuss with you how to get the gbm tests running under X and Wayland when we're in the office at the same time. -Chad

Re: [Piglit] [PATCH 0/8] Add GBM support

2012-10-22 Thread Chad Versace
On 10/19/2012 06:32 PM, Jordan Justen wrote: On Fri, Oct 19, 2012 at 9:54 AM, Chad Versace chad.vers...@linux.intel.com wrote: This series looks good to me. Reviewed-by: Chad Versace chad.vers...@linux.intel.com I wanted to test the series, but the python patches wouldn't apply :( I

Re: [Piglit] [PATCH] add a PIGLIT_BUILD_GL_TESTS option

2012-10-22 Thread Chad Versace
NAK. Reasons below. As an alternative to this patch's method, I would change PIGLIT_HAS_X11 to be a cmake option, enabled by default on Linux, and base decisions on the option. I generally frown on build systems that make decisions based on autodetected dependencies. On 10/18/2012 11:11 AM,

Re: [Piglit] [PATCH 1/6] cmake: Use find_package to find Waffle

2012-11-05 Thread Chad Versace
On 10/24/2012 06:11 AM, gro...@gmail.com wrote: From: Adrian Marius Negreanu adrian.m.negre...@intel.com * replace pkg_check_modules with find_package * add FindWaffle.cmake Signed-off-by: Adrian Marius Negreanu adrian.m.negre...@intel.com --- :100644 100644 2f4c213... 719cda1... M

Re: [Piglit] [PATCH 2/6] cmake,util: Add Android Waffle support

2012-11-05 Thread Chad Versace
This looks mostly correct. Two comments below. On 10/24/2012 06:11 AM, gro...@gmail.com wrote: From: Adrian Marius Negreanu adrian.m.negre...@intel.com Signed-off-by: Adrian Marius Negreanu adrian.m.negre...@intel.com +static void +enter_event_loop(struct piglit_winsys_framework

Re: [Piglit] [PATCH 3/6] cmake: Add an Android platform and toolchain

2012-11-05 Thread Chad Versace
On 10/24/2012 06:11 AM, gro...@gmail.com wrote: From: Adrian Marius Negreanu adrian.m.negre...@intel.com Signed-off-by: Adrian Marius Negreanu adrian.m.negre...@intel.com --- :00 100644 000... 9dd8b3c... A cmake/Modules/Compiler/Android.cmake :00 100644 000...

Re: [Piglit] [PATCH 5/6] cmake: Remove the REQUIRED flag for PNG

2012-11-05 Thread Chad Versace
Brian and Jose, Is libpng needed for the Windows build? It is unused on Linux. On 10/24/2012 06:11 AM, gro...@gmail.com wrote: From: Adrian Marius Negreanu adrian.m.negre...@intel.com I haven't found any references to png, except the README file, so I guess it's ok to remove the REQUIRED

Re: [Piglit] [PATCH 6/6] cmake: Request GLUT only when Waffle is not used

2012-11-05 Thread Chad Versace
file changed, 15 insertions(+), 15 deletions(-) Reviewed-by: Chad Versace chad.vers...@linux.intel.com ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH] hiz, new depth test

2012-11-05 Thread Chad Versace
On 10/31/2012 06:38 AM, Tapani Pälli wrote: Hello, Here is a new test that tries to demonstrate failure with hiz code when frambuffer depth and color do not match. This failure happens for example with MESA_FORMAT_RGB565 color buffer and MESA_FORMAT_X8_Z24 depth buffer. This test seems to

Re: [Piglit] [PATCH] hiz, new depth test

2012-11-05 Thread Chad Versace
On 11/05/2012 12:04 PM, Chad Versace wrote: On 10/31/2012 06:38 AM, Tapani Pälli wrote: Hello, Here is a new test that tries to demonstrate failure with hiz code when frambuffer depth and color do not match. This failure happens for example with MESA_FORMAT_RGB565 color buffer

[Piglit] [PATCH] egl: Test more invalid GLES2 context versions

2012-11-05 Thread Chad Versace
In test egl-create-context-invalid-gl-version, try to create OpenGL ES2 contexts with additional invalid versions: 3.2, 3.9, 4.7. Fails with mesa-84b437 on Intel Sandybridge. CC: Matt Turner matts...@gmail.com --- tests/egl/spec/egl_khr_create_context/invalid-gl-version.c | 3 +++ 1 file

  1   2   3   4   5   6   >