[Piglit] [PATCH] Test accessing program scope arrays

2013-11-27 Thread Jan Vesely
ions). regards, Jan Jan Vesely (1): cl: Add test program-scope-arrays. tests/cl/program/execute/program-scope-arrays.cl | 57 1 file changed, 57 insertions(+) create mode 100644 tests/cl/program/execute/program-scope-ar

[Piglit] [PATCH] cl: Add test program-scope-arrays.

2013-11-27 Thread Jan Vesely
Signed-off-by: Jan Vesely --- tests/cl/program/execute/program-scope-arrays.cl | 57 1 file changed, 57 insertions(+) create mode 100644 tests/cl/program/execute/program-scope-arrays.cl diff --git a/tests/cl/program/execute/program-scope-arrays.cl b/tests/cl/program

[Piglit] [RFC PATCH 1/1] cl: Add buffer-flags test

2013-11-28 Thread Jan Vesely
Signed-off-by: Jan Vesely --- tests/all_cl.tests| 1 + tests/cl/custom/CMakeLists.cl.txt | 1 + tests/cl/custom/buffer-flags.c| 219 ++ 3 files changed, 221 insertions(+) create mode 100644 tests/cl/custom/buffer-flags.c diff --git a

[Piglit] [RFC PATCH 0/1] Buffers with different CL_MEM_* flags

2013-11-28 Thread Jan Vesely
git (mesa, llvm, libclc, ...) on my AMD TURKS card. I could use some comments about how to format output to best indicate failing combination, and whether to report successful passes at all. regards, Jan Jan Vesely (1): cl: Add buffer-flags test tests/all_cl.tests| 1

[Piglit] [PATCH V2 1/1] cl: Add buffer-flags test

2013-11-29 Thread Jan Vesely
v2: Rework into subtests Signed-off-by: Jan Vesely --- tests/all_cl.tests| 1 + tests/cl/custom/CMakeLists.cl.txt | 1 + tests/cl/custom/buffer-flags.c| 224 ++ 3 files changed, 226 insertions(+) create mode 100644 tests/cl/custom

[Piglit] [PATCH 2/2] program-tester: Allow double type

2013-11-29 Thread Jan Vesely
Signed-off-by: Jan Vesely --- tests/cl/program/program-tester.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/tests/cl/program/program-tester.c b/tests/cl/program/program-tester.c index 31aeec9..d93034e 100644 --- a/tests/cl/program/program-tester.c +++ b/tests

[Piglit] [PATCH 0/2] Storing doubles

2013-11-29 Thread Jan Vesely
tests from warn to skipped on my amd turks (and to passed on intel cpu implementation). Note that the compiler only complains about missing extension for type double, vector types (doubleN) pass. regards, Jan Jan Vesely (2): cl: check for cl_khr_fp64 in generated double store tests program-t

[Piglit] [PATCH 1/2] cl: check for cl_khr_fp64 in generated double store tests

2013-11-29 Thread Jan Vesely
Signed-off-by: Jan Vesely --- generated_tests/generate-cl-store-tests.py | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/generated_tests/generate-cl-store-tests.py b/generated_tests/generate-cl-store-tests.py index 58aa3a2..5a09985 100644 --- a/generated_tests

[Piglit] [PATCH V3 1/1] cl: Add buffer-flags test

2013-12-03 Thread Jan Vesely
v2: Rework to use subtests v3: fix printf output use piglit_merge_result whitespace fixes 0 as default was added in OpenCL 1.2 Signed-off-by: Jan Vesely --- Hi, thanks for your feedback. I was wondering what to do about the overlap with cl-api-create-buffer test. cl-api-create

[Piglit] [PATCH RESEND 1/1] cl: Add test program-scope-arrays.

2014-01-07 Thread Jan Vesely
Signed-off-by: Jan Vesely --- Resending to not be forgotten. The last two tests fail on my AMD TURKS. All 4 tests pass on nVidia and Intel OCL. This functionality is used in gegl color kernels making at least 3 tests in their suite to fail. Jan tests/cl/program/execute/program-scope

Re: [Piglit] [PATCH RESEND 1/1] cl: Add test program-scope-arrays.

2014-01-15 Thread Jan Vesely
On Mon, 2014-01-13 at 08:55 -0800, Tom Stellard wrote: > On Tue, Jan 07, 2014 at 06:21:36PM -0500, Jan Vesely wrote: > > Signed-off-by: Jan Vesely > > Reviewed-by: Tom Stellard Thank you. Can you push it as well? I don't have commit access. > > These patches sh

[Piglit] [PATCH 1/1] cl: Extend float to long conversion test

2014-06-24 Thread Jan Vesely
Fill in subtest name Signed-off-by: Jan Vesely --- I kept the same values for ulong version, even if there are duplicates. .../execute/builtin/convert/float-convert_long.cl | 28 -- 1 file changed, 26 insertions(+), 2 deletions(-) diff --git a/tests/cl/program/execute

[Piglit] [PATCH v2 1/1] cl: Extend float to long conversion test

2014-06-24 Thread Jan Vesely
Fill in subtest name v2: Add 2^63 as a test value Signed-off-by: Jan Vesely --- .../execute/builtin/convert/float-convert_long.cl | 28 -- 1 file changed, 26 insertions(+), 2 deletions(-) diff --git a/tests/cl/program/execute/builtin/convert/float-convert_long.cl b/tests

[Piglit] [PATCH 1/1] cl: generated store: reduce the number of elements to 4

2014-06-24 Thread Jan Vesely
8 ulong16 crashes r600. Signed-off-by: Jan Vesely --- Crashing on lack of resources is probably not the intended behavior. generated_tests/cl/store/store-kernels-global.inc | 4 generated_tests/generate-cl-store-tests.py| 18 +- 2 files changed, 9 insertions

Re: [Piglit] [PATCH v2 1/1] cl: Extend float to long conversion test

2014-07-15 Thread Jan Vesely
a light poke Tom, Matt, sorry I forgot to CC you, this piglit tests the conversions submitted last week. thank you, Jan On Tue, 2014-06-24 at 15:15 -0400, Jan Vesely wrote: > Fill in subtest name > v2: Add 2^63 as a test value > > Signed-off-by: Jan Vesely > --- > .../execu

Re: [Piglit] [PATCH v2 1/1] cl: Extend float to long conversion test

2014-07-25 Thread Jan Vesely
On Tue, 2014-07-15 at 10:22 -0400, Tom Stellard wrote: > On Tue, Jul 15, 2014 at 09:03:18AM -0400, Jan Vesely wrote: > > a light poke > > > > Tom, Matt, > > sorry I forgot to CC you, this piglit tests the conversions submitted > > last week. > > > &g

[Piglit] [PATCH 1/1] cl: Merge tests with the same name.

2014-08-01 Thread Jan Vesely
This fixes hidden failures where summary would report the result of the last test with given name. Signed-off-by: Jan Vesely --- I saw 3 ways to deal with the problem of tests having the same name: a) Merge the tests b) Add index to every test c) add support for same named tests to summary

Re: [Piglit] [PATCH 1/1] cl: fix clGetKernelWorkGroupInfo

2014-08-12 Thread Jan Vesely
fprintf(stderr, > + "Failed (error code: %s): Trigger > CL_INVALID_DEVICE if device is NULL but there is more than one device > associated with kernel.\n", > + piglit_cl_get_error_name(errNo)); > + piglit

Re: [Piglit] [PATCH 1/1] cl: fix clGetKernelWorkGroupInfo

2014-08-21 Thread Jan Vesely
On Wed, 2014-08-13 at 15:01 +0200, EdB wrote: > On Tuesday 12 August 2014 17:25:37 Jan Vesely wrote: > > On Sun, 2014-08-10 at 16:46 +0200, EdB wrote: > > > From: EdB > > > > > > If there is only one device associed with the kernel and device arg is > &

Re: [Piglit] [PATCH 1/1] cl: Merge tests with the same name.

2014-08-30 Thread Jan Vesely
On Fri, 2014-08-01 at 16:24 -0400, Jan Vesely wrote: > This fixes hidden failures where summary would report the result > of the last test with given name. > > Signed-off-by: Jan Vesely > --- > > I saw 3 ways to deal with the problem of tests having the same name: > a)

Re: [Piglit] [PATCH] CL: Silence uninitialized use warning in switch(main_argument_type)

2014-09-01 Thread Jan Vesely
ning, but I think it'd be better to tell the compiler that exit_report_result does not return. See the attached patches, they fix the problem for me (clang svn). jan -- Jan Vesely From 91471f10049b00200e44a7bfec4676a6f5529b91 Mon Sep 17 00:00:00 2001 From: Jan Vesely Date: Mon, 1 Sep 2014

Re: [Piglit] [PATCH] cl-program-tester: Add NORETURN attribute to exit_report_result.

2014-09-02 Thread Jan Vesely
{ > free_dynamic_strs(); I think it'd be nice to add a clang ifdef to piglit-util.h instead of relying on clang defining __GNUC__. either way Reviewed-by: Jan Vesely -- Jan Vesely signature.asc Description: This is a digitally signed message part ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 1/3] cl: Add floating point rounding tests

2014-09-02 Thread Jan Vesely
On Fri, 2014-08-29 at 17:37 -0500, Aaron Watry wrote: > Adds tests for ceil, floor, round, trunc > > Signed-off-by: Aaron Watry All tests pass on intel CPU OCL, neg round tests fail on EG, but afaict the tests follow the specs. Reviewed-by: Jan Vesely > --- > generated_tests/g

Re: [Piglit] [PATCH 2/3] cl: Add sqrt tests

2014-09-02 Thread Jan Vesely
On Fri, 2014-08-29 at 17:37 -0500, Aaron Watry wrote: > Signed-off-by: Aaron Watry Reviewed-by: Jan Vesely > --- > generated_tests/generate-cl-math-builtins.py | 12 +++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/generated_tests/generate-c

Re: [Piglit] [PATCH 3/3] cl: Add acos tests

2014-09-02 Thread Jan Vesely
On Fri, 2014-08-29 at 17:37 -0500, Aaron Watry wrote: > Signed-off-by: Aaron Watry Reviewed-by: Jan Vesely > --- > generated_tests/generate-cl-math-builtins.py | 12 +++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/generated_tests/generate-c

[Piglit] [PATCH 1/1] cl: Add copysign tests

2014-09-02 Thread Jan Vesely
Signed-off-by: Jan Vesely --- This patch applies on top of Aaron's series. generated_tests/generate-cl-math-builtins.py | 10 ++ 1 file changed, 10 insertions(+) diff --git a/generated_tests/generate-cl-math-builtins.py b/generated_tests/generate-cl-math-builtins.py index a2

[Piglit] [PATCH v2 1/1] cl: Add copysign tests

2014-09-02 Thread Jan Vesely
v2: Fix -NaN test Signed-off-by: Jan Vesely --- yes, you're right, thx for noticing that. Although I was not sure whether copysign (-4.0, nan) should not return 4.0 jan generated_tests/generate-cl-math-builtins.py | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff

[Piglit] [PATCH 1/1] results.py: Print warning when overwriting subtest results

2014-09-03 Thread Jan Vesely
Signed-off-by: Jan Vesely --- There is none reported for quick.py profile, and tons for cl.py framework/results.py | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/framework/results.py b/framework/results.py index ddadcc1..7d3a375 100644 --- a/framework/results.py

[Piglit] [PATCH 1/1] cl: fix adding concurent tests

2014-09-03 Thread Jan Vesely
Signed-off-by: Jan Vesely --- seemed wrong. Wonder if we can use concurrent tests. tests/cl.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/cl.py b/tests/cl.py index fd698fc..b59368d 100644 --- a/tests/cl.py +++ b/tests/cl.py @@ -21,7 +21,7 @@ def add_plain_test

[Piglit] [PATCH 2/5] cl: Fix subtest names in scalar-comparison

2014-09-03 Thread Jan Vesely
These use lte kernels Also fixes duplicate subtest names Signed-off-by: Jan Vesely --- tests/cl/program/execute/scalar-comparison-uchar.cl | 2 +- tests/cl/program/execute/scalar-comparison-uint.cl | 2 +- tests/cl/program/execute/scalar-comparison-ulong.cl | 2 +- tests/cl/program/execute

[Piglit] [PATCH 3/5] cl: Fix name of bitwise int subtest

2014-09-03 Thread Jan Vesely
Signed-off-by: Jan Vesely --- tests/cl/program/execute/scalar-bitwise-int.cl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/cl/program/execute/scalar-bitwise-int.cl b/tests/cl/program/execute/scalar-bitwise-int.cl index 1a0668b..e5f836c 100644 --- a/tests/cl/program

[Piglit] [PATCH 4/5] cl: Run vXi32-stack subtest in parallel

2014-09-03 Thread Jan Vesely
Avoid duplicate subtest names Signed-off-by: Jan Vesely --- tests/cl/program/execute/v2i32-stack.cl | 17 ++--- tests/cl/program/execute/v3i32-stack.cl | 15 ++- tests/cl/program/execute/v4i32-stack.cl | 15 ++- 3 files changed, 18 insertions(+), 29 deletions

[Piglit] [PATCH 5/5] cl: Run stack array subtest in parallel

2014-09-03 Thread Jan Vesely
Avoid duplicate subtest names Signed-off-by: Jan Vesely --- tests/cl/program/execute/i32-stack-array.cl | 125 +++- 1 file changed, 49 insertions(+), 76 deletions(-) diff --git a/tests/cl/program/execute/i32-stack-array.cl b/tests/cl/program/execute/i32-stack-array.cl

[Piglit] [PATCH 1/5] cl: Avoid duplicate subtest names

2014-09-03 Thread Jan Vesely
Signed-off-by: Jan Vesely --- tests/cl/program/execute/builtin/atomic/atomic_add-local.cl | 4 ++-- tests/cl/program/execute/builtin/atomic/atomic_dec-local.cl | 4 ++-- tests/cl/program/execute/builtin/atomic/atomic_inc-local.cl | 4 ++-- tests/cl/program/execute/builtin/atomic/atomic_sub

Re: [Piglit] [PATCH 1/1] results.py: Print warning when overwriting subtest results

2014-09-03 Thread Jan Vesely
On Wed, 2014-09-03 at 19:33 -0400, Ilia Mirkin wrote: > On Wed, Sep 3, 2014 at 7:16 PM, Jan Vesely wrote: > > Signed-off-by: Jan Vesely > > --- > > > > There is none reported for quick.py profile, and tons for cl.py > > > > framework/results.py | 8 +++

Re: [Piglit] [PATCH 1/1] cl: fix adding concurent tests

2014-09-04 Thread Jan Vesely
ent=True) yeah, it looks nicer. > > > On Wed, Sep 3, 2014 at 4:35 PM, Ilia Mirkin wrote: > > > On Wed, Sep 3, 2014 at 7:28 PM, Tom Stellard wrote: > > > On Wed, Sep 03, 2014 at 07:20:10PM -0400, Jan Vesely wrote: > > >> Signed-off-by: Jan Vesely > &

[Piglit] [PATCH v2 1/1] cl: Merge tests with the same name.

2014-09-04 Thread Jan Vesely
This fixes hidden failures where summary would report the result of the last test with given name. v2: Tag tss variants Signed-off-by: Jan Vesely --- generated_tests/genclbuiltins.py | 65 1 file changed, 33 insertions(+), 32 deletions(-) diff --git a

Re: [Piglit] [PATCH 1/1] results.py: Print warning when overwriting subtest results

2014-09-04 Thread Jan Vesely
c test name is reported? Warning was just one way to report the problem, I'm OK with whatever approach fits the piglit best. Although seeing a list of duplicate names in the console made fixing them easier. jan > > [snip] -- Jan Vesely signature.asc Description: This is a digitally signed message part ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCH v2 1/1] results.py: Print warning when overwriting subtest results

2014-09-04 Thread Jan Vesely
v2: don't mix tabs and spaces use 'in' instead of 'has_key' Signed-off-by: Jan Vesely --- framework/results.py | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/framework/results.py b/framework/results.py index ddadcc1..820b39c 100644 -

Re: [Piglit] [PATCH v2 1/1] results.py: Print warning when overwriting subtest results

2014-09-08 Thread Jan Vesely
On Thu, 2014-09-04 at 15:39 -0700, Dylan Baker wrote: > Reviewed-by: Dylan Baker thank you. Can you push it as well? I don't have commit access. jan > > On Thursday, September 04, 2014 06:14:11 PM Jan Vesely wrote: > > v2: don't mix tabs and spaces > >

[Piglit] [PATCH v3 1/1] cl: Add copysign tests

2014-09-09 Thread Jan Vesely
v2: Fix -NaN test v3: Rebase Signed-off-by: Jan Vesely --- generated_tests/generate-cl-math-builtins.py | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/generated_tests/generate-cl-math-builtins.py b/generated_tests/generate-cl-math-builtins.py index 11105a5

Re: [Piglit] [PATCH v3 1/1] cl: Add copysign tests

2014-09-10 Thread Jan Vesely
ep 9, 2014 at 6:34 PM, Jan Vesely wrote: > > v2: Fix -NaN test > > v3: Rebase > > > > Signed-off-by: Jan Vesely > > --- > > generated_tests/generate-cl-math-builtins.py | 12 +++- > > 1 file changed, 11 insertions(+), 1 deletion(-) > > &g

Re: [Piglit] [PATCH 1/5] cl: Avoid duplicate subtest names

2014-09-16 Thread Jan Vesely
ping these fix duplicate subtest names in non-generated tests patches 2 and 3 are ordinary fixes, patch 1 is just renames. On Wed, 2014-09-03 at 20:51 -0400, Jan Vesely wrote: > Signed-off-by: Jan Vesely > --- > tests/cl/program/execute/builtin/atomic/atomic_add-local.cl | 4 ++-- &g

Re: [Piglit] [PATCH v2 1/1] cl: Merge tests with the same name.

2014-09-16 Thread Jan Vesely
ping this fixes duplicate subtest names in generated tests On Thu, 2014-09-04 at 17:16 -0400, Jan Vesely wrote: > This fixes hidden failures where summary would report the result > of the last test with given name. > > v2: Tag tss variants > > Signed-

Re: [Piglit] [PATCH 4/5] cl: Run vXi32-stack subtest in parallel

2014-09-17 Thread Jan Vesely
On Wed, 2014-09-17 at 07:47 -0700, Tom Stellard wrote: > On Wed, Sep 03, 2014 at 08:51:39PM -0400, Jan Vesely wrote: > > Avoid duplicate subtest names > > > > For patches 4 and 5, I would rather just rename the tests than merge them > together. This keeps the tests sim

Re: [Piglit] [PATCH] cl: Add tests for global atomc_add()

2014-09-19 Thread Jan Vesely
tests/cl/program/execute/builtin/atomic/atomic_add.inc > @@ -0,0 +1,23 @@ > +#define SIMPLE_TEST(TYPE) \ > +kernel void simple_##TYPE(global TYPE *out, ATOMIC_ADDRSPACE TYPE *mem, TYPE > initial, TYPE value) { \ > + *mem = initial; \ > + TYPE a =

[Piglit] [PATCH v2 4/5] cl: vXi32-stack: Rename to avoid subtest name conflicts

2014-09-19 Thread Jan Vesely
Signed-off-by: Jan Vesely --- tests/cl/program/execute/v2i32-stack.cl | 4 ++-- tests/cl/program/execute/v3i32-stack.cl | 4 ++-- tests/cl/program/execute/v4i32-stack.cl | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/cl/program/execute/v2i32-stack.cl b/tests/cl

[Piglit] [PATCH v2 5/5] cl: i32-stack-array: Rename to avoid subtest conflicts

2014-09-19 Thread Jan Vesely
Signed-off-by: Jan Vesely --- tests/cl/program/execute/i32-stack-array.cl | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/tests/cl/program/execute/i32-stack-array.cl b/tests/cl/program/execute/i32-stack-array.cl index 534ee13..1269663 100644 --- a

Re: [Piglit] [PATCH v2 5/5] cl: i32-stack-array: Rename to avoid subtest conflicts

2014-09-22 Thread Jan Vesely
On Mon, 2014-09-22 at 11:31 -0700, Tom Stellard wrote: > On Fri, Sep 19, 2014 at 07:30:41PM -0400, Jan Vesely wrote: > > Signed-off-by: Jan Vesely > > For the whole series: > > Reviewed-by: Tom Stellard > > Do you need me to commit these? yes please. my access r

Re: [Piglit] [PATCH v2 1/1] cl: Merge tests with the same name.

2014-09-25 Thread Jan Vesely
ping On Tue, 2014-09-16 at 17:49 -0400, Jan Vesely wrote: > ping > > this fixes duplicate subtest names in generated tests > > > > On Thu, 2014-09-04 at 17:16 -0400, Jan Vesely wrote: > > This fixes hidden failures where summary would report the result > >

Re: [Piglit] [PATCH 1/2] cl: Add atomic_max tests

2014-09-25 Thread Jan Vesely
> TYPE other) { \ > + *mem = initial; \ > + TYPE a = atomic_max(mem, other); \ > + out[0] = a; \ > + out[1] = *mem; \ > +} > + > +#define THREADS_TEST(TYPE) \ > +kernel void threads_##TYPE(global TYPE *out, local TYPE *mem) { \ > + *mem = 0;

Re: [Piglit] [PATCH] cl/atomic: Fix duplicate names for threaded int/uint tests

2014-09-25 Thread Jan Vesely
Reviewed-by: Jan Vesely thanks On Thu, 2014-09-25 at 15:38 -0500, Aaron Watry wrote: > Signed-off-by: Aaron Watry > CC: Jan Vesely > --- > tests/cl/program/execute/builtin/atomic/atomic_add-local.cl | 4 ++-- > tests/cl/program/execute/builtin/atomic/atomic_and-l

Re: [Piglit] [PATCH v2 5/5] cl: i32-stack-array: Rename to avoid subtest conflicts

2014-09-25 Thread Jan Vesely
On Mon, 2014-09-22 at 11:31 -0700, Tom Stellard wrote: > On Fri, Sep 19, 2014 at 07:30:41PM -0400, Jan Vesely wrote: > > Signed-off-by: Jan Vesely > > For the whole series: > > Reviewed-by: Tom Stellard > > Do you need me to commit these? these too, thanks, ja

Re: [Piglit] [PATCH 1/1] cl: fix adding concurent tests

2014-09-25 Thread Jan Vesely
Didn't notice somebody dropped Tom from the cc list. On Thu, 2014-09-04 at 10:28 -0400, Jan Vesely wrote: > On Wed, 2014-09-03 at 20:20 -0700, Dylan Baker wrote: > > I'd caught this error in a branch as well, but noticed there were no users > > of this function so it di

Re: [Piglit] [PATCH 1/1] cl: fix adding concurent tests

2014-09-26 Thread Jan Vesely
On Fri, 2014-09-26 at 07:22 -0700, Tom Stellard wrote: > On Thu, Sep 25, 2014 at 10:19:16PM -0400, Jan Vesely wrote: > > Didn't notice somebody dropped Tom from the cc list. > > > > On Thu, 2014-09-04 at 10:28 -0400, Jan Vesely wrote: > > > On Wed, 2014-09-0

[Piglit] [PATCH 1/1] cl: Run concurrent on Linux render nodes, or non-Linux

2014-09-26 Thread Jan Vesely
Signed-off-by: Jan Vesely --- Something like this? tests/cl.py | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/tests/cl.py b/tests/cl.py index f618f59..2d3c930 100644 --- a/tests/cl.py +++ b/tests/cl.py @@ -7,6 +7,9 @@ __all__ = ['profile'] import

[Piglit] [PATCH v2 1/1] cl: Run concurrent on Linux render nodes, or non-Linux

2014-09-28 Thread Jan Vesely
v2: make the flag a module parameter Signed-off-by: Jan Vesely --- This still restricts CPU implementations to run serial on linux machines without render nodes, but I guess those few cases can use -c. tests/cl.py | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git

[Piglit] [PATCH 1/1] cl: Add more sin/cos tests

2014-10-03 Thread Jan Vesely
Signed-off-by: Jan Vesely --- the newly added values fail on my TURKS gpu. All tests still pass on Intel CPU. generated_tests/generate-cl-math-builtins.py | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/generated_tests/generate-cl-math-builtins.py b/generated_tests

Re: [Piglit] [PATCH 1/1] cl: Add more sin/cos tests

2014-10-08 Thread Jan Vesely
On Wed, 2014-10-08 at 09:49 -0500, Aaron Watry wrote: > Reviewed-by: Aaron Watry thanks. btw: do these pass on your system? > > Do you need someone to push this for you? yes pls. my access request bug is stale for some reason jan > > --Aaron > > On Fri, Oct 3, 2014 a

Re: [Piglit] [PATCH 1/1] cl: Add more sin/cos tests

2014-10-09 Thread Jan Vesely
On Thu, 2014-10-09 at 06:37 -0700, Tom Stellard wrote: > On Wed, Oct 08, 2014 at 04:07:39PM -0400, Jan Vesely wrote: > > On Wed, 2014-10-08 at 09:49 -0500, Aaron Watry wrote: > > > Reviewed-by: Aaron Watry > > > > thanks. > > btw: do these pass on your s

[Piglit] [PATCH 1/1] cl: add log10 test

2014-10-21 Thread Jan Vesely
Signed-off-by: Jan Vesely --- passes on r600 (with posted libclc patch) and intel cpu ocl generated_tests/generate-cl-math-builtins.py | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/generated_tests/generate-cl-math-builtins.py b/generated_tests/generate-cl

Re: [Piglit] [PATCH 1/2] cl: Add some erf builtin tests

2014-10-24 Thread Jan Vesely
27; : 4 > }, > +'erf' : { > +'arg_types' : [F, F], > +'function_type': 'ttt', > +'values' : [ > +[0.0, 0.950004,0.990005,-0.994999475, > 0.27219439321703e-29, 1, -1], # Result

Re: [Piglit] [PATCH 1/8] cl: Add atomic_sub global tests

2014-10-24 Thread Jan Vesely
set magic. either way, for the series Reviewed-by: Jan Vesely > --- > .../builtin/atomic/atomic_sub-global-return.cl | 62 > ++ > .../execute/builtin/atomic/atomic_sub-global.cl| 59 > 2 files changed, 121 insertions(+) > cre

Re: [Piglit] [PATCH 2/2] gl-1.0-readpixsanity: Eliminate use of variable length arrays.

2014-10-29 Thread Jan Vesely
for (x = 0; x < piglit_width; ++x) { > - if (buf[y][x] != expected) { > + for (y = 0; y < h && pass; ++y) { > + for (x = 0; x < w; ++x) { > + if (buf[y*w + x] != expected) { >

Re: [Piglit] [PATCH 2/2] gl-1.0-readpixsanity: Eliminate use of variable length arrays.

2014-10-29 Thread Jan Vesely
On Wed, 2014-10-29 at 16:38 +, Jose Fonseca wrote: > On 29/10/14 16:20, Jan Vesely wrote: > > On Wed, 2014-10-29 at 11:48 +, jfons...@vmware.com wrote: > >> From: José Fonseca > >> > >> Non-standard GCC extension. > > > > just FYI, it'

Re: [Piglit] [PATCH v2] cl: fix clGetKernelWorkGroupInfo

2014-11-03 Thread Jan Vesely
On Sun, 2014-11-02 at 14:35 +0100, EdB wrote: > If there is only one device associed with the kernel and device arg is NULL typo "associated" > you don't have to trigger CL_INVALID_DEVICE Reviewed-by: Jan Vesely > > v2: > Test for CL_SUCCESS instead of disabling

[Piglit] [PATCH 2/5] Add noreturn attribute on clang

2014-12-03 Thread Jan Vesely
Signed-off-by: Jan Vesely --- Clang also defines __GNUC__, but it feels better not to rely on it tests/util/piglit-util.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/util/piglit-util.h b/tests/util/piglit-util.h index af9fb97..e869dc2 100755 --- a/tests/util

[Piglit] [PATCH 3/5] arb_timer_query: Add missing header

2014-12-03 Thread Jan Vesely
Signed-off-by: Jan Vesely --- tests/spec/arb_timer_query/timestamp-get.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/spec/arb_timer_query/timestamp-get.c b/tests/spec/arb_timer_query/timestamp-get.c index 031c7a1..98a58d2 100644 --- a/tests/spec/arb_timer_query/timestamp-get.c

[Piglit] [PATCH 1/5] cl: Fix signed/unsigned comparison warnings

2014-12-03 Thread Jan Vesely
Signed-off-by: Jan Vesely --- tests/cl/program/program-tester.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/tests/cl/program/program-tester.c b/tests/cl/program/program-tester.c index cfd81be..d6dbc55 100644 --- a/tests/cl/program/program-tester.c +++ b

[Piglit] [PATCH 5/5] cl: Fix format warning

2014-12-03 Thread Jan Vesely
Signed-off-by: Jan Vesely --- tests/util/piglit-util-cl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/util/piglit-util-cl.c b/tests/util/piglit-util-cl.c index 5ac20a8..47e0c7a 100644 --- a/tests/util/piglit-util-cl.c +++ b/tests/util/piglit-util-cl.c @@ -109,7

[Piglit] [PATCH 4/5] cl: Fix using pointer as value

2014-12-03 Thread Jan Vesely
piglit_cl_get_device_info returns pointer even for integral values. Fix mem leaks while at it. Signed-off-by: Jan Vesely --- tests/util/piglit-framework-cl.c | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/tests/util/piglit-framework-cl.c b/tests/util

Re: [Piglit] [PATCH 3/3] util: Fix `cannot convert from 'const char *' to 'char *'` MSVC error.

2014-12-03 Thread Jan Vesely
, or am I missing something? jan > +#else > char *t = strchr(s, c); > +#endif > > return (t == NULL) ? ((char *) s + strlen(s)) : t; > } -- Jan Vesely signature.asc Description: This is a digitally signed message part __

Re: [Piglit] [PATCH] cl-api-compile-program: Initialize variable.

2014-12-03 Thread Jan Vesely
nvalid; > cl_program program; > cl_program temp_program; > - cl_kernel kernel; > + cl_kernel kernel = NULL; > > /*** Normal usage ***/ > I think it might be nicer to just move the "clReleaseKernel(kernel);" line inside the else branch

Re: [Piglit] [PATCH] cl: fix clCompileProgram compil error with CL1.1

2014-12-06 Thread Jan Vesely
On Sat, 2014-12-06 at 12:17 +0100, EdB wrote: > Hello > > The bug is Verified.Fixed. > I don't have commit access. Can someone push it? you can add Reviewed-by: Jan Vesely but I can't push changes > > On Thursday 27 November 2014 12:38:52 EdB wrote: > > Thi

[Piglit] [PATCH v2 3/5] arb_timer_query: Add missing header

2014-12-12 Thread Jan Vesely
v2: protect the include with guards Signed-off-by: Jan Vesely --- tests/spec/arb_timer_query/timestamp-get.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/spec/arb_timer_query/timestamp-get.c b/tests/spec/arb_timer_query/timestamp-get.c index 031c7a1..bcfc3f9 100644 --- a/tests

[Piglit] [PATCH 2/3] Use alloca instead of variable length arrays

2014-12-12 Thread Jan Vesely
Signed-off-by: Jan Vesely --- tests/spec/ext_image_dma_buf_import/intel_external_sampler_only.c | 2 +- tests/spec/ext_image_dma_buf_import/intel_unsupported_format.c| 2 +- tests/spec/ext_image_dma_buf_import/invalid_attributes.c | 2 +- tests/spec/ext_image_dma_buf_import

[Piglit] [PATCH 3/3] cmake, gles: Remove target from the lib list

2014-12-12 Thread Jan Vesely
Fixes Target links to itself cmake warnings Signed-off-by: Jan Vesely --- compile tested. no missing symbols or libraries reported for libpiglitutils_glesX.so tests/util/CMakeLists.gles1.txt | 1 - tests/util/CMakeLists.gles2.txt | 1 - tests/util/CMakeLists.gles3.txt | 1 - 3 files changed

[Piglit] [PATCH 1/3] cl: Don't use variable length array

2014-12-12 Thread Jan Vesely
Signed-off-by: Jan Vesely --- tests/cl/program/program-tester.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tests/cl/program/program-tester.c b/tests/cl/program/program-tester.c index d6dbc55..3905679 100644 --- a/tests/cl/program/program-tester.c +++ b/tests/cl

Re: [Piglit] [PATCH 2/3] Use alloca instead of variable length arrays

2014-12-12 Thread Jan Vesely
s(declaration after statement, vla) into errors, not sure if anyone would be interested in that. jan -- Jan Vesely signature.asc Description: This is a digitally signed message part ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 2/3] Use alloca instead of variable length arrays

2014-12-12 Thread Jan Vesely
On Fri, 2014-12-12 at 13:37 -0800, Matt Turner wrote: > On Fri, Dec 12, 2014 at 1:23 PM, Jan Vesely wrote: > > On Fri, 2014-12-12 at 12:58 -0800, Matt Turner wrote: > >> I'm curious what the motivation for removing variably-sized arrays is, > >> but if I accept tha

Re: [Piglit] [PATCH 2/3] Use alloca instead of variable length arrays

2014-12-12 Thread Jan Vesely
On Fri, 2014-12-12 at 14:49 -0800, Matt Turner wrote: > On Fri, Dec 12, 2014 at 2:13 PM, Jan Vesely wrote: > > On Fri, 2014-12-12 at 13:37 -0800, Matt Turner wrote: > >> On Fri, Dec 12, 2014 at 1:23 PM, Jan Vesely wrote: > >> > On Fri, 2014-12-12 at 12:58 -0800,

Re: [Piglit] [PATCH 3/3] cmake, gles: Remove target from the lib list

2014-12-16 Thread Jan Vesely
On Sun, 2014-12-14 at 16:16 +, Emil Velikov wrote: > On 12/12/14 19:33, Jan Vesely wrote: > > Fixes Target links to itself cmake warnings > > > > Signed-off-by: Jan Vesely > > --- > > > Hmm those seems exist since day 1, yet the intent seems to be missi

Re: [Piglit] [PATCH] cl-api-create-image: Fix memory leak.

2014-12-17 Thread Jan Vesely
On Tue, 2014-12-16 at 22:20 -0800, Vinson Lee wrote: > Fix Coverity "resource leak" defect. > > Signed-off-by: Vinson Lee Reviewed-by: Jan Vesely > --- > tests/cl/api/create-image.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tests/cl/api/cr

Re: [Piglit] [PATCH] cl-api-get-platform-ids: Fix possible use after free.

2014-12-17 Thread Jan Vesely
gt; } > free(platforms); > + platforms = NULL; The next test relies on the fact that platforms is not NULL. Maybe we can use something like (void*)-1 instead of freed pointer. > } > } >

Re: [Piglit] [PATCH] util-cl: Fix non-portable sizeof.

2014-12-17 Thread Jan Vesely
On Tue, 2014-12-16 at 22:47 -0800, Vinson Lee wrote: > Fix Coverity "sizeof not portable" defect. > > Signed-off-by: Vinson Lee Reviewed-by: Jan Vesely > --- > tests/util/piglit-framework-cl-program.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > &

Re: [Piglit] [PATCH 3/3] cmake, gles: Remove target from the lib list

2014-12-22 Thread Jan Vesely
On Sun, 2014-12-21 at 18:41 +, Emil Velikov wrote: > On 16 December 2014 at 23:27, Jan Vesely wrote: > > On Sun, 2014-12-14 at 16:16 +, Emil Velikov wrote: > >> On 12/12/14 19:33, Jan Vesely wrote: > >> > Fixes Target links to itself cmake warnings > >

Re: [Piglit] [PATCH v2] cl: Add exp tests

2015-01-04 Thread Jan Vesely
On Sun, 2015-01-04 at 16:20 +0800, Meng Mengmeng wrote: > Signed-off-by: Meng Mengmeng It would be nice to have a test case that actually hits the accuracy tolerance. Either way Reviewed-by: Jan Vesely > --- > generated_tests/generate-cl-math-builtins.py | 12 +++- > 1

Re: [Piglit] [PATCH] cl: add atanpi tests

2015-01-07 Thread Jan Vesely
thing like atanpi(0.12345) would do). with that change, Reviewed-by: Jan Vesely > --- > generated_tests/generate-cl-math-builtins.py | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/generated_tests/generate-cl-math-builtins.py > b/generated_tests/generate-c

Re: [Piglit] [PATCH v2] cl: add atanpi tests

2015-01-07 Thread Jan Vesely
On Thu, 2015-01-08 at 14:06 +0800, Zhu Bingbing wrote: > This case will tests common result ande boundary result. > > Signed-off-by: Zhu Bingbing Reviewed-by: Jan Vesely > --- > generated_tests/generate-cl-math-builtins.py | 10 ++ > 1 file changed, 10 insertions(+)

Re: [Piglit] [PATCH 1/1] cl: add log10 test

2015-01-22 Thread Jan Vesely
ping On Tue, 2014-10-21 at 20:01 -0400, Jan Vesely wrote: > Signed-off-by: Jan Vesely > --- > > passes on r600 (with posted libclc patch) and intel cpu ocl > > generated_tests/generate-cl-math-builtins.py | 12 +++- > 1 file changed, 11 insertions(+), 1 deletion

[Piglit] [PATCH rebased 1/1] cl: add log10 test

2015-01-22 Thread Jan Vesely
Signed-off-by: Jan Vesely --- Rebased version. sorry for the noise generated_tests/generate-cl-math-builtins.py | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/generated_tests/generate-cl-math-builtins.py b/generated_tests/generate-cl-math-builtins.py index

[Piglit] [PATCH 1/1] cl: Fix tolerance for SP division

2015-01-23 Thread Jan Vesely
The specs say 2.5 ulp, but we only take integer values Signed-off-by: Jan Vesely --- R600: Fail -> Pass tests/cl/program/execute/vector-arithmetic-float4.program_test | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/cl/program/execute/vector-arithmetic-flo

[Piglit] [PATCH v2 1/1] cl: add log10 test

2015-01-23 Thread Jan Vesely
v2: Fix tolerance Signed-off-by: Jan Vesely --- generated_tests/generate-cl-math-builtins.py | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/generated_tests/generate-cl-math-builtins.py b/generated_tests/generate-cl-math-builtins.py index af3843f..1c96adb

[Piglit] [PATCH 1/1] cl: Fix tolerance for division in scalar arithmetic test

2015-01-26 Thread Jan Vesely
Signed-off-by: Jan Vesely --- RFC: I only tagged numerical results, it did not make sense to me to do it for NaNs and Infs R600: Fail -> Pass tests/cl/program/execute/scalar-arithmetic-float.cl | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/cl/prog

Re: [Piglit] [PATCH] cl: fix clCompileProgram compil error with CL1.1

2015-02-05 Thread Jan Vesely
On Tue, 2015-01-06 at 21:23 +0100, EdB wrote: > Ping pushed > > Le 2014-12-06 23:56, Jan Vesely a écrit : > > On Sat, 2014-12-06 at 12:17 +0100, EdB wrote: > >> Hello > >> > >> The bug is Verified.Fixed. > >> I don't have commit access. C

Re: [Piglit] [PATCH 1/1] cl: Fix tolerance for division in scalar arithmetic test

2015-02-06 Thread Jan Vesely
ping On Mon, 2015-01-26 at 15:20 -0500, Jan Vesely wrote: > Signed-off-by: Jan Vesely > --- > RFC: I only tagged numerical results, > it did not make sense to me to do it for NaNs and Infs > > R600: Fail -> Pass > > tests/cl/program/execute/scalar-arithmetic-float.

Re: [Piglit] [PATCH 2/3] Use alloca instead of variable length arrays

2015-02-06 Thread Jan Vesely
ping On Fri, 2014-12-12 at 19:13 -0500, Jan Vesely wrote: > On Fri, 2014-12-12 at 14:49 -0800, Matt Turner wrote: > > On Fri, Dec 12, 2014 at 2:13 PM, Jan Vesely wrote: > > > On Fri, 2014-12-12 at 13:37 -0800, Matt Turner wrote: > > >> On Fri, Dec 12, 2014 at 1:23

Re: [Piglit] [PATCH] cl: fix clCompileProgram compil error with CL1.1

2015-02-06 Thread Jan Vesely
On Fri, 2015-02-06 at 12:37 +0100, EdB wrote: > On Thursday 05 February 2015 13:49:37 Jan Vesely wrote: > > On Tue, 2015-01-06 at 21:23 +0100, EdB wrote: > > > Ping > > > > pushed > thanks feel free to ping patches that need review/push, I'll try to f

Re: [Piglit] [PATCH] cl-api-create-sampler: Fix memory leak.

2015-02-07 Thread Jan Vesely
On Fri, 2015-02-06 at 18:55 -0800, Vinson Lee wrote: > Fix resource leak defect reported by Coverity. > > Signed-off-by: Vinson Lee the function could be cleaned up a bit by using temp variable, but that can be done later. Reviewed-by: Jan Vesely > --- > tests/cl/api/creat

Re: [Piglit] [PATCH 2/3] Use alloca instead of variable length arrays

2015-02-09 Thread Jan Vesely
ows, so I don't think anyone will be building them with msvc anytime > > soon. > > > > Dylan > > > > On Fri, Feb 06, 2015 at 11:49:08AM -0500, Jan Vesely wrote: > >> ping > >> > >> On Fri, 2014-12-12 at 19:13 -0500, Jan Vesely wrote: >

  1   2   3   4   >