Re: [Piglit] [PATCH 3/4] GLSL 1.50 Interface blocks: Test that interface blocks cannot have initializers or sampler types within the block.

2013-09-27 Thread Jordan Justen
On Fri, 2013-09-27 at 11:28 -0700, Nicholas Mack wrote: > diff --git > a/tests/spec/glsl-1.50/compiler/interface-blocks-no-sampler-type-within-block.vert > > b/tests/spec/glsl-1.50/compiler/interface-blocks-no-sampler-type-within-block.vert > new file mode 100644 > index 000..8055c72 > --- /

Re: [Piglit] [PATCH 3/4] GLSL 1.50 Interface blocks: Test that interface blocks cannot have initializers or sampler types within the block.

2013-09-27 Thread Jordan Justen
On Fri, 2013-09-27 at 14:46 -0700, Jordan Justen wrote: > On Fri, 2013-09-27 at 11:28 -0700, Nicholas Mack wrote: > > diff --git > > a/tests/spec/glsl-1.50/compiler/interface-blocks-no-sampler-type-within-block.vert > > > > b/tests/spec/glsl-1.50/compiler/interface-bl

Re: [Piglit] [PATCH 1/3] GL 3.2: Test framebuffer with layered attachments

2013-10-03 Thread Jordan Justen
Series Reviewed-by: Jordan Justen and pushed to master. On Mon, Sep 16, 2013 at 10:31 AM, Jacob Penner wrote: > --- > tests/all.tests| 1 + > .../gl-3.2/layered-rendering/CMakeLists.gl.txt | 1 + > .../framebuffer-layered-a

Re: [Piglit] [PATCH 06/14] Test that the built-in gl_PerVertex interface block can be redeclared.

2013-10-08 Thread Jordan Justen
// will use gl_Position > +# float gl_PointSize; // will use gl_PointSize > +# vec4 t; // error, only gl_PerVertex members allowed Not a big deal, but the bad example of 't' here seems to be left over from patch 3's comment. I see it below again. So far 1-6 Reviewed-b

Re: [Piglit] [PATCH 14/14] Test that gl_in may be redeclared with an array size.

2013-10-08 Thread Jordan Justen
Series Reviewed-by: Jordan Justen I thought I might see a positive .geom with *both* per-vertex in & out. Too trivial? On Wed, Oct 2, 2013 at 4:45 PM, Paul Berry wrote: > --- > ...gs-redeclares-pervertex-in-with-array-size.geom | 45 > ++ > 1 file change

Re: [Piglit] [PATCH] gs: Test that a single shader can redeclare both gl_PerVertex input and output.

2013-10-08 Thread Jordan Justen
Reviewed-by: Jordan Justen On Tue, Oct 8, 2013 at 1:59 PM, Paul Berry wrote: > --- > ...gs-redeclares-both-pervertex-blocks.shader_test | 67 > ++ > 1 file changed, 67 insertions(+) > create mode 100644 > tests/spec/glsl-1.50/execution/gs-redecla

[Piglit] [PATCH] depthstencil-render-miplevels: use double-buffered visual

2013-10-10 Thread Jordan Justen
Signed-off-by: Jordan Justen --- tests/texturing/depthstencil-render-miplevels.cpp |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/texturing/depthstencil-render-miplevels.cpp b/tests/texturing/depthstencil-render-miplevels.cpp index 813ca6f..a6d5df0 100644 --- a

Re: [Piglit] [PATCH 1/2] GL 3.2: Test gl_Layer render to layered attachements

2013-10-11 Thread Jordan Justen
Jacob, This and your other 3 patch gl_Layer series are: Reviewed-by: Jordan Justen and applied. Let me know if I missed any of your remaining patches. (I added 8 total patches of yours to the tree.) Thanks, -Jordan On Thu, Sep 26, 2013 at 1:46 PM, Jacob Penner wrote: > --- >

[Piglit] [PATCH 1/2] shader_runner: support SIZE in requirement section of a shader_test

2013-10-11 Thread Jordan Justen
If a test requires a certain size, it adds 'SIZE Width Height' to the requirements section. Width and Height must be unsigned integers. Signed-off-by: Jordan Justen --- tests/shaders/shader_runner.c | 40 +++- 1 file changed, 27 insertions(+), 13

[Piglit] [PATCH 2/2] glsl-1.50: add size requirements to 3 shader_test tests

2013-10-11 Thread Jordan Justen
Signed-off-by: Jordan Justen --- .../spec/glsl-1.50/execution/geometry/point-size-out.shader_test |5 +++-- .../execution/redeclare-pervertex-out-subset-gs.shader_test |5 +++-- .../glsl-1.50/execution/redeclare-pervertex-subset-vs.shader_test |5 +++-- 3 files changed, 9

Re: [Piglit] [PATCH] gs: Check GL errors in primitive-id-restart test.

2013-10-11 Thread Jordan Justen
Reviewed-by: Jordan Justen On Fri, Oct 11, 2013 at 11:36 AM, Paul Berry wrote: > Previously, if drawing failed due to a GL error, no primitives would > be generated, so the test would have nothing to check, and it would > erroneously pass. Avoid that by checking for GL errors at t

Re: [Piglit] [PATCH] cmake: Detect if system has POSIX clocks

2013-10-14 Thread Jordan Justen
Chad, I wanted a similar feature, but I was also thinking of adding a piglit-util function (piglit_get_microseconds). I think it should be easy to port this function to windows. I also had the cmake parts a little different, but I don't really have a preference on that. http://cgit.freedesktop.o

[Piglit] [PATCH 01/10] shader_runner: support SIZE in requirement section of a shader_test

2013-10-15 Thread Jordan Justen
If a test requires a certain size, it adds 'SIZE Width Height' to the requirements section. Width and Height must be unsigned integers. Signed-off-by: Jordan Justen --- tests/shaders/shader_runner.c | 40 +++- 1 file changed, 27 insertions(+), 13

[Piglit] [PATCH 00/10] shader_runner support for micro benchmarks

2013-10-15 Thread Jordan Justen
st in this series), that we add any micro benchmark scripts to the tree. Rather I would just like to make it possible to write such scripts for shader_runner. The last patch in this series provides an example usage, but I don't want that patch to be added to piglit. Jordan Justen (10): sha

[Piglit] [PATCH 02/10] glsl-1.50: add size requirements to 3 shader_test tests

2013-10-15 Thread Jordan Justen
Signed-off-by: Jordan Justen --- .../spec/glsl-1.50/execution/geometry/point-size-out.shader_test |5 +++-- .../execution/redeclare-pervertex-out-subset-gs.shader_test |5 +++-- .../glsl-1.50/execution/redeclare-pervertex-subset-vs.shader_test |5 +++-- 3 files changed, 9

[Piglit] [PATCH 05/10] shader_runner: support depth visual with DEPTH keyword in requirements

2013-10-15 Thread Jordan Justen
Signed-off-by: Jordan Justen --- tests/shaders/shader_runner.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c index b833e5c..8e601aa 100644 --- a/tests/shaders/shader_runner.c +++ b/tests/shaders/shader_runner.c

[Piglit] [PATCH 04/10] shader_runner: add 'time reset' and 'time show' commands

2013-10-15 Thread Jordan Justen
convenient input for ministat. Signed-off-by: Jordan Justen --- tests/shaders/shader_runner.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c index 2667aed..b833e5c 100644 --- a/tests/shaders/shader_runner.c

[Piglit] [PATCH 03/10] piglit-util: add piglit_get_microseconds

2013-10-15 Thread Jordan Justen
Signed-off-by: Jordan Justen Cc: Chad Versace --- Chad, this conflicts with your "Detect if system has POSIX clocks" patch, but it could be tweaked to follow your version. CMakeLists.txt |6 ++ tests/util/piglit-util.c | 17 + tests/util/piglit-uti

[Piglit] [PATCH 06/10] shader_runner: enable depth clear

2013-10-15 Thread Jordan Justen
Signed-off-by: Jordan Justen --- tests/shaders/shader_runner.c |4 1 file changed, 4 insertions(+) diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c index 8e601aa..6841cd3 100644 --- a/tests/shaders/shader_runner.c +++ b/tests/shaders/shader_runner.c @@ -1692,6

[Piglit] [PATCH 08/10] shader_runner: add echo command

2013-10-15 Thread Jordan Justen
Signed-off-by: Jordan Justen --- tests/shaders/shader_runner.c |5 + 1 file changed, 5 insertions(+) diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c index b3f17e3..65b9bea 100644 --- a/tests/shaders/shader_runner.c +++ b/tests/shaders/shader_runner.c

[Piglit] [PATCH 10/10] Example shader_test scripts using new commands

2013-10-15 Thread Jordan Justen
This commit is not intended to be added to piglit master, but it shows an example of how the previous shader_runner commits can be used. Signed-off-by: Jordan Justen --- 1080p-depth-glsl-clear.shader_test | 39 1080p-depth-hiz-clear.shader_test | 39

[Piglit] [PATCH 09/10] shader_runner: add finish command

2013-10-15 Thread Jordan Justen
Signed-off-by: Jordan Justen --- tests/shaders/shader_runner.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c index 65b9bea..5409ba7 100644 --- a/tests/shaders/shader_runner.c +++ b/tests/shaders/shader_runner.c @@ -1939,6

[Piglit] [PATCH 07/10] shader_runner: enable scissor command

2013-10-15 Thread Jordan Justen
Signed-off-by: Jordan Justen --- tests/shaders/shader_runner.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c index 6841cd3..b3f17e3 100644 --- a/tests/shaders/shader_runner.c +++ b/tests/shaders/shader_runner.c

Re: [Piglit] [PATCH] Test unsized arrays in interface blocks

2013-10-16 Thread Jordan Justen
Reviewed-by: Jordan Justen On Fri, Sep 27, 2013 at 9:02 AM, Paul Berry wrote: > These tests verify that unsized arrays appearing inside interface > blocks obey the same rules as unsized arrays appearing outside > interface blocks. Namely, their size is inferred from the largest &

Re: [Piglit] [RFC PATCH] Test that in/out qualifiers are required when redeclaring gl_ClipDistance.

2013-10-16 Thread Jordan Justen
; with the VS, do you think you've tested it enough to be sure that an app also could not accidentally be relying on this behavior? If we are pretty confident that apps won't break, then Reviewed-by: Jordan Justen Also, perhaps we should log a spec bug to ask th

Re: [Piglit] [PATCH] cmake: Detect if system has POSIX clocks

2013-10-16 Thread Jordan Justen
On Wed, Oct 16, 2013 at 9:24 AM, Ian Romanick wrote: > On 10/14/2013 04:37 PM, Jordan Justen wrote: >> Chad, >> >> I wanted a similar feature, but I was also thinking of adding a >> piglit-util function (piglit_get_microseconds). I think it should be >> easy

Re: [Piglit] [PATCH 00/10] shader_runner support for micro benchmarks

2013-10-16 Thread Jordan Justen
On Wed, Oct 16, 2013 at 10:58 AM, Eric Anholt wrote: > Jordan Justen writes: > >> git://people.freedesktop.org/~jljusten/piglit shader_runner-time-v1 >> >> I think shader_runner could be an easy way to develop >> quick micro-benchmarks when working on performanc

[Piglit] [PATCH 2/2] piglit-util: add piglit_get_microseconds

2013-10-17 Thread Jordan Justen
v2: * Use Chad's cmake detection * return value is signed, and a negative indicates an error Signed-off-by: Jordan Justen Cc: Chad Versace Cc: Ian Romanick --- tests/util/piglit-util.c | 20 tests/util/piglit-util.h | 10 ++ 2 files changed, 30 inser

[Piglit] [PATCH 1/2] cmake: Detect if system has POSIX MONOTONIC clocks

2013-10-17 Thread Jordan Justen
=> PIGLIT_HAS_POSIX_CLOCK_MONOTONIC * Link with librt. On older systems, clocks_gettime may be in librt rather than glibc. CC: Nicholas Mack Signed-off-by: Chad Versace Cc: Chad Versace Cc: Ian Romanick Signed-off-by: Jordan Justen --- CMakeLists.txt | 19 +++ 1 file changed, 19 inserti

Re: [Piglit] [PATCH 2/2] piglit-util: add piglit_get_microseconds

2013-10-17 Thread Jordan Justen
On Thu, 2013-10-17 at 13:56 -0700, Chad Versace wrote: > On 10/17/2013 10:52 AM, Jordan Justen wrote: > > v2: > > * Use Chad's cmake detection > > * return value is signed, and a negative indicates an error > > > > Signed-off-by: Jordan Justen >

Re: [Piglit] [PATCH] util/x11: Propagate window resize events to piglit_width/height

2013-10-18 Thread Jordan Justen
Reviewed-by: Jordan Justen On Fri, 2013-10-18 at 11:12 -0700, Chad Versace wrote: > When I switched Piglit from GLUT to Waffle, I broke detection of X11 > window resizes. When the user resized the window, Piglit called > piglit_display() but neglected to update piglit_width/height.

Re: [Piglit] [PATCH] Fix invalid gs qualifier "layout(triangles) out" in a few tests.

2013-10-22 Thread Jordan Justen
Reviewed-by: Jordan Justen On Tue, Oct 22, 2013 at 10:37 AM, Paul Berry wrote: > "triangles" is not a valid geometry shader output primitive type. > "triangle_strip" must be used instead. > --- > .../spec/glsl-1.50/execution/invariant-qualifier-everywhere.shader

Re: [Piglit] [PATCH 5/7] ARB_texture_view: Test for rendering various targets in texture view

2013-10-29 Thread Jordan Justen
On Fri, Oct 25, 2013 at 9:41 AM, Jon Ashburn wrote: > RE your comment: > >> +config.window_width = 128; >> +config.window_height = 128; > > > "Is 128 special? Can you just go with the defaults? In the past we've had > trouble on Windows when the width is < 130 or so pixels. Long story.

[Piglit] [PATCH] gbm: add event loop and exit after 1 run

2013-11-12 Thread Jordan Justen
frameworks. Signed-off-by: Jordan Justen --- tests/util/piglit-framework-gl/piglit_gbm_framework.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/tests/util/piglit-framework-gl/piglit_gbm_framework.c b/tests/util/piglit-framework-gl/piglit_gbm_framework.c index 4df3861..859a7c9

[Piglit] Require Signed-off-by for patches?

2013-11-13 Thread Jordan Justen
On Wed, Nov 13, 2013 at 11:26 AM, Paul Berry wrote: > On 13 November 2013 11:01, Frank Henigman wrote: >> >> I'd like to see an explanation of "signed-off-by," "reviewed-by" etc. >> Maybe as simple as: >> >> "Use the tags signed-off-by, reviewed-by, tested-by, acked-by as for linux >> kernel patc

Re: [Piglit] Require Signed-off-by for patches?

2013-11-13 Thread Jordan Justen
On Wed, Nov 13, 2013 at 12:08 PM, Paul Berry wrote: > On 13 November 2013 12:06, Jordan Justen wrote: >> >> On Wed, Nov 13, 2013 at 11:26 AM, Paul Berry >> wrote: >> > On 13 November 2013 11:01, Frank Henigman wrote: >> >> >> >> I'd

Re: [Piglit] Require Signed-off-by for patches?

2013-11-13 Thread Jordan Justen
On Wed, Nov 13, 2013 at 5:12 PM, Matt Turner wrote: > On Wed, Nov 13, 2013 at 12:06 PM, Jordan Justen wrote: >> What are the arguments against just following the kernel's >> Signed-off-by practice? > > What are the arguments for it? > > The kernel's submi

Re: [Piglit] Require Signed-off-by for patches?

2013-11-14 Thread Jordan Justen
On Thu, Nov 14, 2013 at 3:09 PM, Ian Romanick wrote: > On 11/13/2013 05:12 PM, Matt Turner wrote: >> On Wed, Nov 13, 2013 at 12:06 PM, Jordan Justen wrote: >>> What are the arguments against just following the kernel's >>> Signed-off-by practice? >> >&

Re: [Piglit] Require Signed-off-by for patches?

2013-11-15 Thread Jordan Justen
On Fri, Nov 15, 2013 at 1:42 PM, Eric Anholt wrote: > Jordan Justen writes: >> Do we think Signed-off-by may cause people to have reservations about >> contributing code to piglit? > > No, but I know from other projects that I *will* forget signed-off-by > and get nagged

[Piglit] [PATCH] arb_viewport_array: Only specify 150 for shader version

2013-11-26 Thread Jordan Justen
These tests are expected to run with OpenGL 3.2, so we should only use #version 150. We also need to enable the GL_ARB_viewport_array extension in the geometry shader. Signed-off-by: Jordan Justen Cc: Jon Ashburn --- Jon, my slightly older nVidia card failed render_depthrange before and after

Re: [Piglit] [PATCH] arb_viewport_array: Only specify 150 for shader version

2013-11-26 Thread Jordan Justen
On Tue, Nov 26, 2013 at 10:49 AM, Anuj Phogat wrote: > On Tue, Nov 26, 2013 at 8:57 AM, Jordan Justen > wrote: >> These tests are expected to run with OpenGL 3.2, so >> we should only use #version 150. We also need to >> enable the GL_ARB_viewport_array extension i

Re: [Piglit] [PATCH] arb_viewport_array: Only specify 150 for shader version

2013-11-26 Thread Jordan Justen
On Tue, Nov 26, 2013 at 4:28 PM, Jon Ashburn wrote: > These changes pass on Nvidia Quadro 600 with this driver: 4.3.0 NVIDIA > 313.30 Thanks! Reviewed and/or Tested-by you? -Jordan > On 11/26/2013 09:57 AM, Jordan Justen wrote: >> >> tests/spec/arb_viewport_array/re

Re: [Piglit] [PATCH] ARB_viewport_array: Fix minmax test for piglit_require_extension

2013-11-26 Thread Jordan Justen
Reviewed-by: Jordan Justen and applied. Thanks! On Mon, Nov 25, 2013 at 12:04 PM, Jon Ashburn wrote: > Will need someone to upload this to origin/master > --- > tests/spec/arb_viewport_array/minmax.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/spec/

Re: [Piglit] [PATCH] Move multisample blit scaled tests to spec/ext_framebuffer_multisample_blit_scaled

2013-11-27 Thread Jordan Justen
Reviewed-by: Jordan Justen On Fri, Nov 8, 2013 at 4:09 PM, Anuj Phogat wrote: > We moved Fbo and TestPattern classes to a global location tests/util in > commit 9c1b2ac. Now, the functions from these classes can be utilized > from spec/ext_framebuffer_multisample_blit_scaled

[Piglit] [PATCH 1/2] shader_runner: always enable VAO for gl >= 31

2014-01-21 Thread Jordan Justen
This fixes attributeless rendering on nvidia. For example: * tests/spec/glsl-1.50/execution/geometry/point-size-out.shader_test Signed-off-by: Jordan Justen --- tests/shaders/shader_runner.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/shaders

[Piglit] [PATCH 2/2] arb_gpu_shader5: add invocation-id-basic.shader_test

2014-01-21 Thread Jordan Justen
Signed-off-by: Jordan Justen --- .../invocation-id-basic.shader_test| 53 ++ 1 file changed, 53 insertions(+) create mode 100644 tests/spec/arb_gpu_shader5/invocation-id-basic.shader_test diff --git a/tests/spec/arb_gpu_shader5/invocation-id

[Piglit] [PATCH 1/2] .gitignore: ignore 'main' results files

2014-01-23 Thread Jordan Justen
Signed-off-by: Jordan Justen --- .gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitignore b/.gitignore index 635a107..df8513f 100644 --- a/.gitignore +++ b/.gitignore @@ -24,3 +24,5 @@ tests/glslparsertest/glslcompiler generated_tests/cl .makotmp + +main \ No newline at

[Piglit] [PATCH 2/2] .gitignore: ignore piglit-summary-html.py output

2014-01-23 Thread Jordan Justen
Signed-off-by: Jordan Justen --- .gitignore | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.gitignore b/.gitignore index df8513f..72e5bd5 100644 --- a/.gitignore +++ b/.gitignore @@ -25,4 +25,7 @@ generated_tests/cl .makotmp +*.css +*.html + main \ No newline at end of file

[Piglit] [PATCH 1/7] arb_gpu_shader5/invocation-id-basic: use signed int

2014-01-23 Thread Jordan Justen
gl_InvocationID is defined as an int. Signed-off-by: Jordan Justen --- Patch series is available at: git://people.freedesktop.org/~jljusten/piglit gs-inv-id .../spec/arb_gpu_shader5/execution/invocation-id-basic.shader_test | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[Piglit] [PATCH 4/7] arb_gpu_shader5: invocations layout qualifier is not allowed on GS output

2014-01-23 Thread Jordan Justen
Signed-off-by: Jordan Justen --- .../incorrect-out-layout-qualifier-invocations.geom| 18 ++ 1 file changed, 18 insertions(+) create mode 100644 tests/spec/arb_gpu_shader5/compiler/incorrect-out-layout-qualifier-invocations.geom diff --git a/tests/spec/arb_gpu_shader5

[Piglit] [PATCH 2/7] arb_gpu_shader5/invocation-id-basic: range check gl_InvocationID

2014-01-23 Thread Jordan Justen
Make sure that gl_InvocationID is 0 .. 3. Signed-off-by: Jordan Justen --- .../execution/invocation-id-basic.shader_test| 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/tests/spec/arb_gpu_shader5/execution/invocation-id-basic.shader_test b/tests

[Piglit] [PATCH 3/7] glsl-1.50: invalid GS input layout qualifiers

2014-01-23 Thread Jordan Justen
Signed-off-by: Jordan Justen --- .../incorrect-in-layout-qualifier-column_major.geom | 20 .../incorrect-in-layout-qualifier-max_vertices.geom | 20 .../incorrect-in-layout-qualifier-packed.geom| 20 .../incorrect-in-layout

[Piglit] [PATCH 5/7] arb_gpu_shader5: gl_InvocationID should be 0 w/o invocations qualifier

2014-01-23 Thread Jordan Justen
Signed-off-by: Jordan Justen --- .../invocation-id-without-qualifier.shader_test| 55 ++ 1 file changed, 55 insertions(+) create mode 100644 tests/spec/arb_gpu_shader5/execution/invocation-id-without-qualifier.shader_test diff --git a/tests/spec/arb_gpu_shader5

[Piglit] [PATCH 7/7] arb_gpu_shader5: test reading GEOMETRY_SHADER_INVOCATIONS

2014-01-23 Thread Jordan Justen
Signed-off-by: Jordan Justen --- tests/spec/arb_gpu_shader5/CMakeLists.txt | 1 + .../arb_gpu_shader5/execution/CMakeLists.gl.txt| 12 +++ .../spec/arb_gpu_shader5/execution/CMakeLists.txt | 1 + .../spec/arb_gpu_shader5/execution/invocation-id.c | 110 + 4

[Piglit] [PATCH 6/7] arb_gpu_shader5: add minmax test

2014-01-23 Thread Jordan Justen
Signed-off-by: Jordan Justen --- tests/spec/CMakeLists.txt| 1 + tests/spec/arb_gpu_shader5/CMakeLists.gl.txt | 12 ++ tests/spec/arb_gpu_shader5/CMakeLists.txt| 1 + tests/spec/arb_gpu_shader5/minmax.c | 64 4 files changed, 78

Re: [Piglit] [PATCH 1/4] Add variable color_format to configure non-multisample fbo

2014-01-30 Thread Jordan Justen
For patch 1: * how about a subject prefix of piglit-fbo? For patch 2: * how about a subject prefix of arb_sample_shading? * bump 'compat' version to 31 Series Reviewed-by: Jordan Justen On Tue, Dec 17, 2013 at 11:30 AM, Anuj Phogat wrote: > Signed-off-by: Anuj Phogat > -

[Piglit] [PATCH] arb_gpu_shader5: test transform feedback with multiple streams

2014-01-31 Thread Jordan Justen
ARB_gpu_shader5 requires a minimum of 4 vertex streams. This allows a geometry shader to output vertices independently to up to 4 streams. Signed-off-by: Jordan Justen --- tests/all.py | 1 + .../arb_gpu_shader5/execution/CMakeLists.gl.txt| 1

[Piglit] [PATCH] arb_gpu_shader5: test setting the invocations count in a separate GS

2014-01-31 Thread Jordan Justen
Signed-off-by: Jordan Justen --- .../invocation-id-in-separate-gs.shader_test | 62 ++ 1 file changed, 62 insertions(+) create mode 100644 tests/spec/arb_gpu_shader5/execution/invocation-id-in-separate-gs.shader_test diff --git a/tests/spec/arb_gpu_shader5/execution

[Piglit] [PATCH] arb_gpu_shader5: add compiler/invocations_count_too_large test

2014-02-04 Thread Jordan Justen
This test makes sure that a compile error is generated if the invocations count is too large. Signed-off-by: Jordan Justen --- tests/all.py | 1 + tests/spec/arb_gpu_shader5/CMakeLists.txt | 1 + .../arb_gpu_shader5/compiler/CMakeLists.gl.txt

Re: [Piglit] [PATCH] log: Replace console output with a simpler output

2014-02-05 Thread Jordan Justen
\o/ Reviewed-by: Jordan Justen On Thu, Jan 9, 2014 at 12:02 PM, Dylan Baker wrote: > This replaces the console spewer with a simpler console reporting > mechanism inspired by the output of ninja. This reduces code, remove all > singleton instances and speeds up piglit runs. There is a

[Piglit] [PATCH] gbm: use libcaca to display results in non-auto mode

2014-02-07 Thread Jordan Justen
If GBM is enabled, attempt to locate libcaca too. If the test was not run with -auto, then use libcaca to draw a text version of the test's results to the console. Signed-off-by: Jordan Justen --- CMakeLists.txt | 8 ++ tests/util/CMakeList

Re: [Piglit] [PATCH] gbm: use libcaca to display results in non-auto mode

2014-02-08 Thread Jordan Justen
On Fri, Feb 7, 2014 at 10:04 PM, Kristian Høgsberg wrote: > On Fri, Feb 7, 2014 at 4:38 PM, Kenneth Graunke wrote: >> On 02/07/2014 11:04 AM, Jordan Justen wrote: >>> If GBM is enabled, attempt to locate libcaca too. >>> >>> If the test was not run with -auto,

Re: [Piglit] [PATCH] sso: Verify glActiveShaderProgram with invalid program parameter

2014-02-19 Thread Jordan Justen
amebuffer contents." > > After calling glActiveShaderProgram with an invalid parameter, verify > that the active program state has not been modified. > > Signed-off-by: Ian Romanick > Cc: Jordan Justen > --- > tests/all.py

Re: [Piglit] [PATCH] sso: Verify glActiveShaderProgram with invalid program parameter

2014-02-19 Thread Jordan Justen
On Wed, Feb 19, 2014 at 7:43 PM, Ian Romanick wrote: > On 02/19/2014 07:35 PM, Jordan Justen wrote: >> On Wed, Feb 19, 2014 at 4:55 PM, Ian Romanick wrote: >>> From: Ian Romanick >>> >>> There are several cases outlined in the GL 4.4 spec where >>> g

Re: [Piglit] libepoxy conversion v2

2014-02-26 Thread Jordan Justen
On Wed, Feb 26, 2014 at 10:30 AM, Ken Phillis Jr wrote: > > On Feb 25, 2014 3:45 PM, Brian Paul wrote: >> I haven't had time to look at these changes, nor libepoxy. But it's >> critical to us that piglit continues to work on Windows. >> > I just checked libepoxy against MSVC2010 and it is a total

Re: [Piglit] libepoxy conversion v2

2014-03-11 Thread Jordan Justen
On Fri, Mar 7, 2014 at 9:12 PM, Eric Anholt wrote: > Jose Fonseca writes: > >> - Original Message - >>> On Wed, Feb 26, 2014 at 10:30 AM, Ken Phillis Jr >>> wrote: >>> > >>> > On Feb 25, 2014 3:45 PM, Brian Paul wrote: >>> >> I haven't had time to look at these changes, nor libepoxy. Bu

Re: [Piglit] Over three thousand crashes on opengl driver of ADM&NV caused by commit b28cdc887aefb1e766719e1f74d457f77bdf9a18

2014-04-03 Thread Jordan Justen
Piglit mailing list > Piglit@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/piglit > From 96b1730a3d2c2027f9d2c0ddf9536b4ef0624fea Mon Sep 17 00:00:00 2001 From: Jordan Justen Date: Thu, 3 Apr 2014 08:29:38 -0700 Subject: [PATCH] shader_runner: use program before sett

Re: [Piglit] Over three thousand crashes on opengl driver of ADM&NV caused by commit b28cdc887aefb1e766719e1f74d457f77bdf9a18

2014-04-03 Thread Jordan Justen
On Thu, Apr 3, 2014 at 8:37 AM, Jordan Justen wrote: > On Thu, Apr 3, 2014 at 2:42 AM, Fu, Ping wrote: >> Hi Justen, >> >> I tested the latest piglit and found lots of crashes(Over three thousand) on >> both AMD and NVIDIA. This mig

Re: [Piglit] Over three thousand crashes on opengl driver of ADM&NV caused by commit b28cdc887aefb1e766719e1f74d457f77bdf9a18

2014-04-03 Thread Jordan Justen
On Thu, Apr 3, 2014 at 9:31 AM, Brian Paul wrote: > On 04/03/2014 10:25 AM, Jordan Justen wrote: >> >> On Thu, Apr 3, 2014 at 8:37 AM, Jordan Justen wrote: >>> >>> On Thu, Apr 3, 2014 at 2:42 AM, Fu, Ping wrote: >>>> >>>> Hi Justen, >&

[Piglit] [PATCH] ext_image_dma_buf_import/intel_external_sampler_only: fix link error

2014-04-11 Thread Jordan Justen
Mesa is no longer exporting the symbols of OES_framebuffer_object, which caused a link error with this test. In addition, the test needed additional extension checks. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=77295 Signed-off-by: Jordan Justen Cc: Ian Romanick Cc: Dylan Baker

Re: [Piglit] [Mesa-dev] Regressions due to commit 1afe3359258

2014-04-19 Thread Jordan Justen
On Sat, Apr 19, 2014 at 10:03 AM, Ilia Mirkin wrote: > On Fri, Apr 18, 2014 at 1:35 PM, Jordan Justen > wrote: >> On 2014-04-18 08:46:00, Kenneth Graunke wrote: >>> On 04/18/2014 12:09 AM, Ilia Mirkin wrote: >>> > Hi Ken, >>> > >>> > I j

Re: [Piglit] [PATCH] gl-3.1: Add test for attributeless rendering with gl_VertexID

2014-04-22 Thread Jordan Justen
Could this be a shader_test instead? But, shader_runner is sort of in limbo for attributeless rendering. (See also b28cdc88 and revert of that same commit in c20596b8.) On Tue, Apr 22, 2014 at 2:47 PM, Chris Forbes wrote: > This tests that rendering with no vertex attributes bound works, in the

Re: [Piglit] [Mesa-dev] Regressions due to commit 1afe3359258

2014-04-22 Thread Jordan Justen
On Tue, Apr 22, 2014 at 8:54 AM, Ian Romanick wrote: > On 04/19/2014 11:44 AM, Jordan Justen wrote: >> On Sat, Apr 19, 2014 at 10:03 AM, Ilia Mirkin wrote: >>> On Fri, Apr 18, 2014 at 1:35 PM, Jordan Justen >>> wrote: >>>> On 2014-04-18 08:46:00, Kenneth G

[Piglit] [PATCH 1/3] cmake: Install under separate piglit directory

2014-04-30 Thread Jordan Justen
Install paths updated: * $PREFIX/share/doc => $PREFIX/share/doc/piglit * $PREFIX/lib => $PREFIX/lib/piglit/lib * $PREFIX/bin => $PREFIX/lib/piglit/bin * etc... Signed-off-by: Jordan Justen --- CMakeLists.txt | 23 +-- cmake/piglit_util.cmake | 4 ++--

[Piglit] [PATCH 0/3] Update piglit install locations

2014-04-30 Thread Jordan Justen
Move piglit binaries and libraries out of the system paths Add a piglit wrapper command to easily run piglit commands in the new install location git://people.freedesktop.org/~jljusten/piglit piglit-cmd Jordan Justen (3): cmake: Install under separate piglit directory cmake: Add version

[Piglit] [PATCH 2/3] cmake: Add version suffix for install paths

2014-04-30 Thread Jordan Justen
If used, then piglit will be installed into a separate path. For example, if '-DPIGLIT_INSTALL_VERSION=20140430' was specified with cmake, then piglit would install to $PREFIX/lib/piglit-20140430. Signed-off-by: Jordan Justen --- CMakeLists.txt | 10 -- 1 file changed, 8

[Piglit] [PATCH 3/3] piglit: Add piglit command

2014-04-30 Thread Jordan Justen
. 'piglit help ' will run 'piglit-.py --help' as expected. 'piglit', 'piglit help' or 'piglit --help' will show the list of possible sub-commands. Signed-off-by: Jordan Justen --- CMakeLists.txt | 14 + piglit

Re: [Piglit] [PATCH 3/3] piglit: Add piglit command

2014-04-30 Thread Jordan Justen
On Wed, Apr 30, 2014 at 11:18 AM, Dylan Baker wrote: > On Wednesday, April 30, 2014 10:28:57 Jordan Justen wrote: >> The piglit command is a wrapper command for the >> piglit-.py scripts. >> >> For example, running 'piglit run' is equivalent to piglit-run.py.

Re: [Piglit] [PATCH 0/3] Update piglit install locations

2014-04-30 Thread Jordan Justen
binaries and libraries out of the system paths >> >> Add a piglit wrapper command to easily run piglit commands >> in the new install location >> >> git://people.freedesktop.org/~jljusten/piglit piglit-cmd >> >> Jordan Justen (3): >> cmake: Instal

Re: [Piglit] [PATCH 3/3] piglit: Add piglit command

2014-04-30 Thread Jordan Justen
On Wed, Apr 30, 2014 at 1:58 PM, Dylan Baker wrote: > On Wednesday, April 30, 2014 13:42:09 Jordan Justen wrote: >> Anyway, piglit_cmd.py is the source that controls the piglit command, >> so it can evolve to present something different. >> >> This patch seems like a

Re: [Piglit] [PATCH 0/3] Update piglit install locations

2014-05-02 Thread Jordan Justen
uilt, not installed; > built, not installed; built, installed). > > I have tested my piglit in all three applications and it works for me, > > would you have a look? It looks pretty good. Less 'git' like than my version, but it works for me. Reviewed-by: Jordan Justen for a5

Re: [Piglit] [PATCH 0/3] Update piglit install locations

2014-05-02 Thread Jordan Justen
On Fri, May 2, 2014 at 2:12 PM, Dylan Baker wrote: > On Friday, May 02, 2014 12:41:03 Jordan Justen wrote: >> Rather than '../lib/piglit', could you use path.join('..', 'lib', >> path.basename(sys.argv[0]))? > > sure. &g

Re: [Piglit] [PATCH 4/4] piglit: Add a toplevel piglit command

2014-05-03 Thread Jordan Justen
ser will > +capture -h/--help and the results will not be useful. > + > +""" > + > +import os > +import os.path as path > +import sys > +import argparse > + > +# If running in the source directory there will be a HACKING file, don't > +# muck with

Re: [Piglit] [PATCH 4/4] piglit: Add a toplevel piglit command

2014-05-05 Thread Jordan Justen
On Mon, May 5, 2014 at 1:35 AM, Dylan Baker wrote: > On Saturday, May 03, 2014 05:47:26 PM Jordan Justen wrote: >> On Fri, May 2, 2014 at 6:31 PM, Dylan Baker wrote: >> > This uses the functions created by the last commit to create a >> > all-in-one piglit command

Re: [Piglit] [PATCH 03/10] sso: Use pick_a_glsl_version utility function

2014-05-05 Thread Jordan Justen
Patches 2 & 3, sso: Add utility function to select the GLSL version sso: Use pick_a_glsl_version utility function Reviewed-by: Jordan Justen On Sun, Apr 27, 2014 at 2:12 PM, Ian Romanick wrote: > From: Ian Romanick > > Existing tests had this open-coded. > > Signed-o

Re: [Piglit] [PATCH 04/10] sso: Add tests for the preprocessor define

2014-05-05 Thread Jordan Justen
Did you get this yet for sso tests? +import_glsl_parser_tests(arb_separate_shader_objects, +testsDir + '/spec/arb_separate_shader_objects', ['']) Reviewed-by: Jordan Justen -Jordan On Sun, Apr 27, 2014 at 2:12 PM, Ian Romanick wrote: > From: I

Re: [Piglit] piglit-run.py changed?

2014-05-07 Thread Jordan Justen
On Wed, May 7, 2014 at 8:27 AM, Ilia Mirkin wrote: > On Wed, May 7, 2014 at 11:22 AM, Brian Paul wrote: >> I know there have been recent changes to the piglit python scripts but I >> haven't been following them too closely. >> >> It seems that piglit-run.py has changed in some way and I don't und

[Piglit] [PATCH] wrappers: Fix argument issue with new wrapper scripts

2014-05-08 Thread Jordan Justen
The new argument parsing wants the script name parameter sys.argv[0] stripped off. Signed-off-by: Jordan Justen Cc: Dylan Baker Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=78421 --- piglit-resume.py| 2 +- piglit-run.py | 2 +- piglit-summary-html.py | 2

[Piglit] [PATCH] shader_runner: enable VAO for gl >= 31 before glDrawArrays

2014-05-14 Thread Jordan Justen
This fixes attributeless rendering on nvidia's binary driver and Mesa (as of 1afe3359258a9e89b62c8638761f52d78f6d1cbc). For example: * tests/spec/glsl-1.50/execution/geometry/point-size-out.shader_test Signed-off-by: Jordan Justen Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=771

[Piglit] [PATCH 1/2] shader_runner: Allow tests to require an OpenGL CORE profile

2014-05-14 Thread Jordan Justen
Signed-off-by: Jordan Justen --- tests/shaders/shader_runner.c | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c index a288afa..bd7fe6f 100644 --- a/tests/shaders/shader_runner.c +++ b/tests

[Piglit] [PATCH 2/2] gl-3.1: attributeless-vertexid; C => shader_test

2014-05-14 Thread Jordan Justen
Signed-off-by: Jordan Justen Cc: Chris Forbes --- This also depends on "shader_runner: enable VAO for gl >= 31 before glDrawArrays" Also, does this actually require a core profile? tests/all.py | 1 - tests/spec/gl-3.1/CMak

Re: [Piglit] [PATCH 2/2] Add compiler tests for overlapping attribute locations

2014-05-16 Thread Jordan Justen
Reviewed-by: Jordan Justen On Mon, Mar 10, 2014 at 11:38 AM, Anuj Phogat wrote: > Signed-off-by: Anuj Phogat > --- > .../compiler/overlapping-attrib-locations-1.vert | 28 > ++ > .../compiler/overlapping-attrib-locations-2.vert | 28 > +

Re: [Piglit] [PATCH V2 2/2] glsl-1.50: Add shader tests to verify gl_FragCoord redeclarations

2014-05-16 Thread Jordan Justen
> + * gl_FragCoord in all fragment shaders in a single program must have > + * the same set of qualifiers." > + * > + * Tests the case when one fragment shader redeclares gl_FragCoord without > + * any qualifiers and other one has missing redeclaration. Spec is not very >

Re: [Piglit] [PATCH 1/2] Add test to verify overlapping locations of vertex input attributes

2014-05-16 Thread Jordan Justen
ot required to generate an error > + * in this case." > + * > + * Aliasing of vertex input variables is allowed in: OpenGL > + * 2.0 (and above) and OpenGL ES 2.0. This test varifies > + * that aliasing can be used successfully in a vertex shader > + *

[Piglit] [PATCH 04/11] shader_runner: Add image texture command for BindImageTexture

2014-06-01 Thread Jordan Justen
We only use one parameter which means the texture unit index must match the image unit index. Signed-off-by: Jordan Justen --- tests/shaders/shader_runner.c | 8 1 file changed, 8 insertions(+) diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c index 846db4c

[Piglit] [PATCH 10/11] built-in-constants: Support compute shaders

2014-06-01 Thread Jordan Justen
Compute shaders must be linked separately to process minimums and maximums. In the line following the version, we now look for a shader type string. (One of vertex, geometry, fragment or compute.) If specified, then that shader type will be tested separately. Signed-off-by: Jordan Justen

[Piglit] [PATCH 11/11] arb_compute_shader: Test remaining compute GLSL minimums & maximums

2014-06-01 Thread Jordan Justen
Also, convert two glslparsertest tests to use built-in-constants. Signed-off-by: Jordan Justen --- tests/all.py | 1 + .../compiler/gl_MaxComputeWorkGroupCount.comp| 20 .../compiler/gl_MaxComputeWorkGroupSize.comp

[Piglit] [PATCH 09/11] arb_compute_shader: Test simple usage of barrier function

2014-06-01 Thread Jordan Justen
Signed-off-by: Jordan Justen --- .../execution/simple-barrier.shader_test | 56 ++ 1 file changed, 56 insertions(+) create mode 100644 tests/spec/arb_compute_shader/execution/simple-barrier.shader_test diff --git a/tests/spec/arb_compute_shader/execution/simple

[Piglit] [PATCH 07/11] arb_compute_shader: Test reading and merging multiple source images

2014-06-01 Thread Jordan Justen
Signed-off-by: Jordan Justen --- .../execution/multiple-texture-reading.shader_test | 80 ++ 1 file changed, 80 insertions(+) create mode 100644 tests/spec/arb_compute_shader/execution/multiple-texture-reading.shader_test diff --git a/tests/spec/arb_compute_shader

[Piglit] [PATCH 03/11] shader_runner: Allow binding a texture to FB attachment0

2014-06-01 Thread Jordan Justen
This will allow probing from the texture for operations that want to target a texture rather than the draw framebuffer. (For example, imageStore) Signed-off-by: Jordan Justen --- tests/shaders/shader_runner.c | 29 + 1 file changed, 29 insertions(+) diff --git a

  1   2   3   4   >