[Piglit] [PATCH] Handle OpenGL ES-CM 1.x strings in piglit_get_gl_version

2012-07-27 Thread Matt Turner
Otherwise, piglit would fail to parse the version string and report a failure if glGetString(GL_VERSION) were called in an ES 1.x context. I'm not sure why we need this check at all and can't just eat characters while(!isdigit(*c) *c != NULL). --- The piglit_is_gles() function immediately above

[Piglit] piglit tests for EGL_KHR_create_context

2012-07-31 Thread Matt Turner
This series adds nine tests for EGL_KHR_create_context. It's based on the GLX_ARB_create_context tests but with some differences. These GLX_ARB_create_context tests aren't applicable: - Verify rejection of forward-compatible flag w/pre-3.0 - Verify that invalid render types are rejected -

[Piglit] [PATCH 01/11] Handle OpenGL ES-CM 1.x strings in piglit_get_gl_version

2012-07-31 Thread Matt Turner
Otherwise, piglit would fail to parse the version string and report a failure if glGetString(GL_VERSION) were called in an ES 1.x context. --- tests/util/piglit-util-gl-common.c | 10 -- 1 files changed, 4 insertions(+), 6 deletions(-) diff --git a/tests/util/piglit-util-gl-common.c

[Piglit] [PATCH 06/11] egl_khr_create_context: Verify that the attributes list can be empty

2012-07-31 Thread Matt Turner
--- tests/all_egl.tests|1 + .../spec/egl_khr_create_context/CMakeLists.gl.txt |1 + .../egl_khr_create_context/valid-attribute-empty.c | 81 3 files changed, 83 insertions(+), 0 deletions(-) create mode 100644

[Piglit] [PATCH 07/11] egl_khr_create_context: Verify that the attributes list pointer can be NULL

2012-07-31 Thread Matt Turner
--- tests/all_egl.tests|1 + .../spec/egl_khr_create_context/CMakeLists.gl.txt |1 + .../egl_khr_create_context/valid-attribute-null.c | 78 3 files changed, 80 insertions(+), 0 deletions(-) create mode 100644

[Piglit] [PATCH 08/11] egl_khr_create_context: Verify that the invalid GL versions are rejected

2012-07-31 Thread Matt Turner
--- tests/all_egl.tests|1 + .../spec/egl_khr_create_context/CMakeLists.gl.txt |1 + .../egl_khr_create_context/invalid-gl-version.c| 110 3 files changed, 112 insertions(+), 0 deletions(-) create mode 100644

[Piglit] [PATCH 09/11] egl_khr_create_context: Verify that the invalid attributes are rejected

2012-07-31 Thread Matt Turner
--- tests/all_egl.tests|1 + .../spec/egl_khr_create_context/CMakeLists.gl.txt |1 + .../egl_khr_create_context/invalid-attribute.c | 118 3 files changed, 120 insertions(+), 0 deletions(-) create mode 100644

[Piglit] [PATCH 10/11] egl_khr_create_context: Verify that the invalid flags are rejected

2012-07-31 Thread Matt Turner
--- tests/all_egl.tests|1 + .../spec/egl_khr_create_context/CMakeLists.gl.txt |1 + .../egl/spec/egl_khr_create_context/invalid-flag.c | 83 3 files changed, 85 insertions(+), 0 deletions(-) create mode 100644

[Piglit] [PATCH 11/11] egl_khr_create_context: Verify that the forward-compatible flag can be accepted

2012-07-31 Thread Matt Turner
--- tests/all_egl.tests|1 + .../spec/egl_khr_create_context/CMakeLists.gl.txt |1 + .../valid-flag-forward-compatible.c| 59 3 files changed, 61 insertions(+), 0 deletions(-) create mode 100644

Re: [Piglit] piglit tests for EGL_KHR_create_context

2012-07-31 Thread Matt Turner
On Tue, Jul 31, 2012 at 6:38 PM, Matt Turner matts...@gmail.com wrote: Oh, the series is also available here: http://cgit.freedesktop.org/~mattst88/piglit/log/?h=egl_khr_create_context Another thing: I've used EGL_KHR_surfaceless_* so that the tests don't have to create windows and surfaces

[Piglit] [PATCH v2 03/17] egl_khr_create_context: Add common test infrastructure

2012-08-16 Thread Matt Turner
v2: - Require EGL_KHR_surfaceless_context instead of other surfaceless extensions. - Fix for-loop typo. - Make EGL_KHR_create_context_setup take a renderable_type_mask argument. - Make EGL_KHR_create_context_setup return whether it succeeded. - PIGLIT_SKIP if eglChooseConfig

[Piglit] [PATCH v2 05/17] egl_khr_create_context: Verify default minor version is 0 for GLES

2012-08-16 Thread Matt Turner
v2: - Try for EGL_OPENGL_ES_BIT renderable type, and if it fails try EGL_OPENGL_ES2_BIT renderable type. --- tests/all_egl.tests|1 + .../spec/egl_khr_create_context/CMakeLists.gl.txt |1 + .../default-minor-version-gles.c | 92

[Piglit] [PATCH v2 06/17] egl_khr_create_context: Verify that the attributes list can be empty for GLES

2012-08-16 Thread Matt Turner
v2: - Ask for EGL_OPENGL_ES_BIT renderable type since the defaults for major/minor are 1.0, so we can't get an ES2 context with an empty attributes list. If ES 1 isn't available, skip. --- tests/all_egl.tests|1 +

[Piglit] [PATCH v2 08/17] egl_khr_create_context: Verify that the invalid GL versions are rejected

2012-08-16 Thread Matt Turner
v2: - Do pass = pass ...; instead of pass = ... pass;. - Pass EGL_OPENGL_*BIT to _setup() and check versions for the specific rendering API. --- tests/all_egl.tests|1 + .../spec/egl_khr_create_context/CMakeLists.gl.txt |1 +

[Piglit] [PATCH v2 09/17] egl_khr_create_context: Verify that the invalid attributes are rejected for Desktop GL

2012-08-16 Thread Matt Turner
v2: - Update typo'd (in the spec) EGL_CONTEXT_OPENGL_* names. - Ask for EGL_OPENGL_BIT and skip if not available. - Call eglBindAPI(EGL_OPENGL_API) after _setup. - Fix gl_version condition (from ' 32' to '= 32'). --- tests/all_egl.tests|1 +

[Piglit] [PATCH v2 10/17] egl_khr_create_context: Verify that the invalid flags are rejected for Desktop GL

2012-08-16 Thread Matt Turner
v2: - Correct value of first_valid_flag. - Ask for EGL_OPENGL_API and skip if not available. --- tests/all_egl.tests|1 + .../spec/egl_khr_create_context/CMakeLists.gl.txt |1 + .../spec/egl_khr_create_context/invalid-flag-gl.c | 93

[Piglit] [PATCH v2 11/17] egl_khr_create_context: Verify that the forward-compatible flag can be accepted for Desktop GL

2012-08-16 Thread Matt Turner
v2: - Ask for EGL_OPENGL_BIT and skip if not available. - Only check EGL_CONTEXT_OPENGL_FORWARD_COMPATIBLE_BIT_KHR if GL 3.2+ --- tests/all_egl.tests|1 + .../spec/egl_khr_create_context/CMakeLists.gl.txt |1 +

[Piglit] [PATCH 14/17] egl_khr_create_context: Verify that the invalid flags are rejected for GLES

2012-08-16 Thread Matt Turner
--- tests/all_egl.tests|1 + .../spec/egl_khr_create_context/CMakeLists.gl.txt |1 + .../egl_khr_create_context/invalid-flag-gles.c | 100 3 files changed, 102 insertions(+), 0 deletions(-) create mode 100644

[Piglit] [PATCH 17/17] egl_khr_create_context: Verify default minor version is 0 for Desktop GL

2012-08-16 Thread Matt Turner
--- tests/all_egl.tests|1 + .../spec/egl_khr_create_context/CMakeLists.gl.txt |1 + .../default-minor-version-gl.c | 95 3 files changed, 97 insertions(+), 0 deletions(-) create mode 100644

Re: [Piglit] piglit tests for EGL_KHR_create_context

2012-08-16 Thread Matt Turner
On Tue, Jul 31, 2012 at 6:38 PM, Matt Turner matts...@gmail.com wrote: This series adds nine tests for EGL_KHR_create_context. It's based on the GLX_ARB_create_context tests but with some differences. These GLX_ARB_create_context tests aren't applicable: - Verify rejection of forward

[Piglit] [PATCH v2 15/17] egl_khr_create_context: Verify that the invalid attributes are rejected for GLES

2012-08-24 Thread Matt Turner
v2: Fixed EGL_OPENGL_BIT - EGL_OPENGL_ES_BIT typo which would cause the test to pass without actually testing an ES context. --- tests/all_egl.tests|1 + .../spec/egl_khr_create_context/CMakeLists.gl.txt |1 + .../invalid-attribute-gles.c

[Piglit] [PATCH v3 11/17] egl_khr_create_context: Verify that the forward-compatible flag can be accepted for Desktop GL

2012-08-24 Thread Matt Turner
v2: - Ask for EGL_OPENGL_BIT and skip if not available. - Only check EGL_CONTEXT_OPENGL_FORWARD_COMPATIBLE_BIT_KHR if GL 3.2+ v3: - Only check EGL_CONTEXT_OPENGL_FORWARD_COMPATIBLE_BIT_KHR if GL 3.0+ - Skip if GL 3.0. --- tests/all_egl.tests|

Re: [Piglit] piglit tests for EGL_KHR_create_context

2012-08-24 Thread Matt Turner
On Thu, Aug 16, 2012 at 10:52 AM, Matt Turner matts...@gmail.com wrote: On Tue, Jul 31, 2012 at 6:38 PM, Matt Turner matts...@gmail.com wrote: This series adds nine tests for EGL_KHR_create_context. It's based on the GLX_ARB_create_context tests but with some differences

[Piglit] [PATCH] egl_khr_create_context: Allow forward-compatible contexts to be rejected

2012-08-27 Thread Matt Turner
This reworks the test to test whether 1) forward-compatible contexts can be created, or 2) the correct error is generated when they can't. Previously the test did only the first and would fail if forward-compatible contexts couldn't be created. ---

Re: [Piglit] [Mesa-dev] [PATCH] egl-util: Adds probe_front_pixel_rgb function

2012-09-27 Thread Matt Turner
On Thu, Sep 20, 2012 at 8:59 AM, Robert Bragg rob...@sixbynine.org wrote: This adds an egl_probe_front_pixel_rgb function that is analogous to piglit_probe_pixel_rgba except it probes the front buffer instead of probing the back buffer. --- tests/egl/egl-util.c | 31

Re: [Piglit] [Mesa-dev] [PATCH] egl-util: Adds probe_front_pixel_rgb function

2012-10-02 Thread Matt Turner
On Tue, Oct 2, 2012 at 7:19 AM, Robert Bragg rob...@sixbynine.org wrote: On Thu, Sep 27, 2012 at 6:48 PM, Matt Turner matts...@gmail.com wrote: On Thu, Sep 20, 2012 at 8:59 AM, Robert Bragg rob...@sixbynine.org wrote: This adds an egl_probe_front_pixel_rgb function that is analogous

[Piglit] [PATCH 1/2] egl_khr_create_context: Clarify why attributes are rejected in GLES

2012-10-04 Thread Matt Turner
--- .../invalid-attribute-gles.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/egl/spec/egl_khr_create_context/invalid-attribute-gles.c b/tests/egl/spec/egl_khr_create_context/invalid-attribute-gles.c index 8c7e919..d3e030c 100644 ---

[Piglit] [PATCH 2/2] egl_khr_create_context: profile attributes are never invalid for Desktop GL

2012-10-04 Thread Matt Turner
The EGL_KHR_create_context spec says: If the requested OpenGL version is less than 3.2, EGL_CONTEXT_OPENGL_PROFILE_MASK_KHR is ignored and the functionality of the context is determined solely by the requested version. --- .../egl_khr_create_context/invalid-attribute-gl.c

[Piglit] [PATCH 2/4] egl_khr_create_context_profile: Verify that invalid profiles are rejected

2012-10-08 Thread Matt Turner
--- tests/all_egl.tests|1 + .../spec/egl_khr_create_context/CMakeLists.gl.txt |1 + .../spec/egl_khr_create_context/invalid-profile.c | 105 3 files changed, 107 insertions(+), 0 deletions(-) create mode 100644

[Piglit] [PATCH 3/4] egl_khr_create_context: Verify that the core profile is supported for Desktop GL 3.2

2012-10-08 Thread Matt Turner
--- We fail this test for an undiagnosed reason currently. Requesting major=3 minor=4 is rejected immediately by the EGL code, but requesting 3.2 and 3.3 contexts (which the driver doesn't currently support) does not return the correct error. tests/all_egl.tests

Re: [Piglit] [PATCH 4/4] egl_khr_create_context_profile: Verify that the profile is ignored pre-3.2

2012-10-10 Thread Matt Turner
On Wed, Oct 10, 2012 at 11:04 AM, Chad Versace chad.vers...@linux.intel.com wrote: On 10/08/2012 04:57 PM, Matt Turner wrote: --- tests/all_egl.tests|1 + .../spec/egl_khr_create_context/CMakeLists.gl.txt |1 + .../spec/egl_khr_create_context/pre-GL3

Re: [Piglit] [PATCH 4/4] egl_khr_create_context_profile: Verify that the profile is ignored pre-3.2

2012-10-11 Thread Matt Turner
On Thu, Oct 11, 2012 at 7:38 AM, Chad Versace chad.vers...@linux.intel.com wrote: I withdraw my comment objections to patches 2-4. That makes patch 2 reviewed-by. But there are still issues with patches 3-4. Patch 3 has the weird line break in printf. And patch 4 has the bug and misleading

[Piglit] [PATCH] egl_khr_create_context: Run tests concurrently

2012-10-11 Thread Matt Turner
--- tests/all_egl.tests | 39 ++- 1 files changed, 22 insertions(+), 17 deletions(-) diff --git a/tests/all_egl.tests b/tests/all_egl.tests index 526687f..ab04191 100644 --- a/tests/all_egl.tests +++ b/tests/all_egl.tests @@ -6,6 +6,11 @@ from

[Piglit] [PATCH 1/4] glx_arb_create_context: Rename pre-GL3 test to pre-GL32

2012-10-12 Thread Matt Turner
Context flags are ignored by GL versions pre-3.2, not pre-3.0. --- tests/all.tests|2 +- .../spec/glx_arb_create_context/CMakeLists.gl.txt |2 +- .../spec/glx_arb_create_context/pre-GL3-profile.c | 115

[Piglit] [PATCH 2/4] glx_arb_create_context: Don't specify the profile in the without-profile case

2012-10-12 Thread Matt Turner
Reported-by: Chad Versace chad.vers...@linux.intel.com --- .../spec/glx_arb_create_context/pre-GL32-profile.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/tests/spec/glx_arb_create_context/pre-GL32-profile.c b/tests/spec/glx_arb_create_context/pre-GL32-profile.c

[Piglit] [PATCH 3/4] glx_arb_create_context/core-profile: Remove extra newline

2012-10-12 Thread Matt Turner
--- tests/spec/glx_arb_create_context/core-profile.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/tests/spec/glx_arb_create_context/core-profile.c b/tests/spec/glx_arb_create_context/core-profile.c index 833c5ee..9892a36 100644 ---

[Piglit] [PATCH 4/4] glx_*_create_context*: Run tests concurrently

2012-10-12 Thread Matt Turner
--- tests/all.tests | 36 ++-- 1 files changed, 18 insertions(+), 18 deletions(-) diff --git a/tests/all.tests b/tests/all.tests index ede3463..71fa14e 100644 --- a/tests/all.tests +++ b/tests/all.tests @@ -669,33 +669,33 @@ import_context['query context info']

[Piglit] [PATCH 1/4] glx_arb_create_context: Rename pre-GL3 test to pre-GL32

2012-10-15 Thread Matt Turner
Context flags are ignored by GL versions pre-3.2, not pre-3.0. --- tests/all.tests|2 +- .../spec/glx_arb_create_context/CMakeLists.gl.txt |2 +- .../spec/glx_arb_create_context/pre-GL3-profile.c | 115

[Piglit] [PATCH 2/4] glx_arb_create_context: Don't specify the profile in the without-profile case

2012-10-15 Thread Matt Turner
Reported-by: Chad Versace chad.vers...@linux.intel.com --- .../spec/glx_arb_create_context/pre-GL32-profile.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/tests/spec/glx_arb_create_context/pre-GL32-profile.c b/tests/spec/glx_arb_create_context/pre-GL32-profile.c

[Piglit] [PATCH 3/4] glx_arb_create_context/core-profile: Remove extra newline

2012-10-15 Thread Matt Turner
--- tests/spec/glx_arb_create_context/core-profile.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/tests/spec/glx_arb_create_context/core-profile.c b/tests/spec/glx_arb_create_context/core-profile.c index 833c5ee..9892a36 100644 ---

[Piglit] [PATCH 4/4] glx_*_create_context*: Run tests concurrently

2012-10-15 Thread Matt Turner
--- tests/all.tests | 36 ++-- 1 files changed, 18 insertions(+), 18 deletions(-) diff --git a/tests/all.tests b/tests/all.tests index a8bd4f4..37818db 100644 --- a/tests/all.tests +++ b/tests/all.tests @@ -668,33 +668,33 @@ import_context['query context info']

Re: [Piglit] [PATCH 1/4] glx_arb_create_context: Rename pre-GL3 test to pre-GL32

2012-10-15 Thread Matt Turner
On Mon, Oct 15, 2012 at 4:09 PM, Chad Versace chad.vers...@linux.intel.com wrote: For the series, Reviewed-by: Chad Versace chad.vers...@linux.intel.com Thanks. I see that I sent this twice. Sorry about that. :) ___ Piglit mailing list

Re: [Piglit] [PATCH] egl: Test more invalid GLES2 context versions

2012-11-05 Thread Matt Turner
On Mon, Nov 5, 2012 at 2:53 PM, Chad Versace chad.vers...@linux.intel.com wrote: In test egl-create-context-invalid-gl-version, try to create OpenGL ES2 contexts with additional invalid versions: 3.2, 3.9, 4.7. Fails with mesa-84b437 on Intel Sandybridge. CC: Matt Turner matts...@gmail.com

[Piglit] [PATCH 2/2] gles-2.0: Check that ES 3 queries are not allowed in ES 2

2012-12-10 Thread Matt Turner
--- tests/spec/gles-2.0/CMakeLists.gles2.txt |2 + tests/spec/gles-2.0/invalid-es3-queries.c | 103 + 2 files changed, 105 insertions(+), 0 deletions(-) create mode 100644 tests/spec/gles-2.0/invalid-es3-queries.c diff --git

[Piglit] [PATCH v2 2/2] gles-2.0: Check that ES 3 queries are not allowed in ES 2

2012-12-11 Thread Matt Turner
--- v2: - don't use GLint64/glGetInteger64v which don't exist in ES 2 - glGetIntegerv should fail with INVALID_ENUM (not INVALID_OPERATION) - prefix test name with gles2- tests/spec/gles-2.0/CMakeLists.gles2.txt |2 + tests/spec/gles-2.0/invalid-es3-queries.c | 103

[Piglit] [PATCH v3 2/2] gles-2.0: Check that ES 3 queries are not allowed in ES 2

2012-12-13 Thread Matt Turner
Reviewed-by: Eric Anholt e...@anholt.net (v2) --- tests/spec/gles-2.0/CMakeLists.gles2.txt |2 + tests/spec/gles-2.0/invalid-es3-queries.c | 138 + 2 files changed, 140 insertions(+), 0 deletions(-) create mode 100644 tests/spec/gles-2.0/invalid-es3-queries.c

Re: [Piglit] [PATCH 2/5] gles2: new glReadPixels unit test

2012-12-20 Thread Matt Turner
On Thu, Dec 20, 2012 at 10:54 AM, Tom Gall tom.g...@linaro.org wrote: A few variations are commented out due to results that are incorrect and need to be followed up with Mesa, such as modifying the buffer even tho the format is invalid. There are cases where the returned data is incorrectly

[Piglit] [PATCH 1/3] arb_transform_feedback2: Add IsTranformFeedback() test

2012-12-20 Thread Matt Turner
--- tests/all.tests|1 + .../spec/arb_transform_feedback2/CMakeLists.gl.txt |1 + .../arb_transform_feedback2/istransformfeedback.c | 91 3 files changed, 93 insertions(+), 0 deletions(-) create mode 100644

[Piglit] [PATCH 3/3] apple_vertex_array_object: Add IsVertexArray() test

2012-12-20 Thread Matt Turner
--- tests/all.tests|4 tests/spec/arb_vertex_array_object/isvertexarray.c | 18 -- 2 files changed, 20 insertions(+), 2 deletions(-) diff --git a/tests/all.tests b/tests/all.tests index 589c4cc..fd061f9 100644 --- a/tests/all.tests

Re: [Piglit] [PATCH 2/5] updated gles2: new glReadPixels unit test

2012-12-20 Thread Matt Turner
On Thu, Dec 20, 2012 at 6:23 PM, Tom Gall tom.g...@linaro.org wrote: Small update based on feedback from Ian, Matt and Eric. Format fixes and failing variations are no longer commented out. Ehh, still lots of problems from a cursory glance. Ian found problems here:

Re: [Piglit] [PATCH 2/5] gles2: new glReadPixels unit test

2012-12-20 Thread Matt Turner
On Thu, Dec 20, 2012 at 5:06 PM, Tom Gall tom.g...@linaro.org wrote: Hi Eric, On Thu, Dec 20, 2012 at 6:30 PM, Eric Anholt e...@anholt.net wrote: Matt Turner matts...@gmail.com writes: On Thu, Dec 20, 2012 at 10:54 AM, Tom Gall tom.g...@linaro.org wrote: A few variations are commented out

Re: [Piglit] [PATCH 6/7] Allow es3conform tests to run on Sandybridge

2012-12-21 Thread Matt Turner
On Fri, Dec 21, 2012 at 5:18 PM, Carl Worth cwo...@cworth.org wrote: Without this, the tests silently do nothing on my Thinkpad X220. --- With this they all fail silently on Ivy Bridge though, don't they? ___ Piglit mailing list

Re: [Piglit] [PATCH] apple_vertex_array_object: Initialize variable apple.

2012-12-31 Thread Matt Turner
. I'd give that a Reviewed-by: Matt Turner matts...@gmail.com ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 1/2] gles2: add invalid-es3-queries_gles2 to all.tests

2013-01-02 Thread Matt Turner
( piglitutil_${piglit_target_api} ) -piglit_add_executable(gles2-invalid-es3-queries invalid-es3-queries.c) +piglit_add_executable(invalid-es3-queries_gles2 invalid-es3-queries.c) # vim: ft=cmake: -- 1.7.10.4 Reviewed-by: Matt Turner matts...@gmail.com

Re: [Piglit] [PATCH] Test that loop unrolling properly infers loop bounds.

2013-01-07 Thread Matt Turner
) failed = true; + + gl_FrontColor = failed ? vec4(1.0, 0.0, 0.0, 1.0) : vec4(0.0, 1.0, 0.0, 1.0); +} + +[fragment shader] +void main() +{ + gl_FragColor = gl_Color; +} + +[test] +draw rect -1 -1 2 2 +probe all rgba 0.0 1.0 0.0 1.0 -- 1.8.1 Reviewed-by: Matt Turner matts

Re: [Piglit] [PATCH] get-renderbuffer-internalformat: Skip testing unsupported enums.

2013-01-10 Thread Matt Turner
, GL_RENDERBUFFER_INTERNAL_FORMAT, internalformat); -- 1.7.10.4 Reviewed-by: Matt Turner matts...@gmail.com ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCH] Clarify comment about glIsBuffer behavior

2013-01-24 Thread Matt Turner
The spec's not vague, it's just stupid. glIsBuffer should return false between the time a buffer name is generated and first bound. --- tests/general/isbufferobj.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/tests/general/isbufferobj.c b/tests/general/isbufferobj.c

Re: [Piglit] [PATCH] Clarify comment about glIsBuffer behavior

2013-01-25 Thread Matt Turner
On Fri, Jan 25, 2013 at 9:35 AM, Eric Anholt e...@anholt.net wrote: Matt Turner matts...@gmail.com writes: The spec's not vague, it's just stupid. glIsBuffer should return false between the time a buffer name is generated and first bound. --- tests/general/isbufferobj.c | 6 ++ 1 file

[Piglit] [PATCH] ARB_shading_language_packing: Generate tests for builtin packing functions

2013-01-25 Thread Matt Turner
This uses the existing pack/unpack testing infrasturcture for GLSL ES 3.0 and adds support for testing pack/unpack 4x8 operations. Generate the following test files: {const,vs,fs}-{pack,unpack}{Snorm,Unorm}{2x16,4x8}.shader_test {const,vs,fs}-{pack,unpack}Half2x16.shader_test ---

Re: [Piglit] [PATCH 2/2 v2] arb_uniform_buffer_object: Only use row_major or column_major on matrix types

2013-01-28 Thread Matt Turner
, deref); fs = piglit_compile_shader_text(GL_FRAGMENT_SHADER, fs_source); -- 1.7.11.7 Both are Reviewed-by: Matt Turner matts...@gmail.com ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 1/3] android: piglit-vbo.cpp compile error

2013-01-28 Thread Matt Turner
On Mon, Jan 28, 2013 at 2:09 PM, Ian Romanick i...@freedesktop.org wrote: These changes seem innocuous enough. Reviewed-by: Ian Romanick ian.d.roman...@intel.com They are... but 2/3 and 3/3 are adding unreachable return statements after switches with a default case that asserts. Kind of bogus.

Re: [Piglit] [PATCH 1/3] android: piglit-vbo.cpp compile error

2013-01-28 Thread Matt Turner
On Mon, Jan 28, 2013 at 5:11 PM, Tom Gall tom.g...@linaro.org wrote: Sure, but tell that to the compiler. It is bad form to not have a return at the end of a function which is supposed to return something. The other way perhaps is just knock out the default case and return that. Either way.

Re: [Piglit] [PATCH 1/2] egl_khr_create_context: Fix for drivers that don't support GL = 2.0

2013-01-28 Thread Matt Turner
to create a 2.x context, then the test failed. This patch changes it to skip. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=59510 Reported-by: Lu Hua huax...@intel.com CC: Matt Turner matts...@gmail.com Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/egl/spec

Re: [Piglit] [PATCH 2/2] egl_khr_create_context: Explain why context creation must succeed

2013-01-28 Thread Matt Turner
*is* required to succeed. This patch adds comments explaining why, CC: Matt Turner matts...@gmail.com Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/egl/spec/egl_khr_create_context/default-major-version-gles.c | 3 +++ tests/egl/spec/egl_khr_create_context/default-minor-version

Re: [Piglit] [PATCH] glean/tdepthstencil: Print what error was expected

2013-01-29 Thread Matt Turner
On Tue, Jan 29, 2013 at 6:41 PM, Eric Anholt e...@anholt.net wrote: Matt Turner matts...@gmail.com writes: Thy all seem to already print what error was expected, though not what was generated. glDrawPixels(1, 1, GL_DEPTH_COMPONENT, GL_UNSIGNED_INT_24_8_EXT, p); - if (glGetError

[Piglit] [PATCHv2] glean/tdepthstencil: Print what error was expected

2013-01-30 Thread Matt Turner
... by using piglit_check_gl_error. --- v2: Fix copy'n'paste error. Leave existing error messages in place. tests/glean/tdepthstencil.cpp |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/tests/glean/tdepthstencil.cpp b/tests/glean/tdepthstencil.cpp index

Re: [Piglit] [PATCHv2] glean/tdepthstencil: Print what error was expected

2013-01-30 Thread Matt Turner
On Wed, Jan 30, 2013 at 11:04 AM, Matt Turner matts...@gmail.com wrote: Subject: glean/tdepthstencil: Print what error was expected s/expected/generated/. gah. ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman

[Piglit] [PATCH 2/2] gen_builtin_packing_tests.py: Remove stray tab

2013-01-31 Thread Matt Turner
Caused the shader_runner tests generated from that template to be indented. --- generated_tests/gen_builtin_packing_tests.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/generated_tests/gen_builtin_packing_tests.py b/generated_tests/gen_builtin_packing_tests.py index

Re: [Piglit] [PATCH 3/7] Android: Add Adrian M Negreanu's initial android support

2013-02-01 Thread Matt Turner
On Fri, Feb 1, 2013 at 3:06 PM, Tom Gall tom.g...@linaro.org wrote: This are Adrian M Negreanu's changes for piglit to support Android. These are included in this patch series for the purposes of completeness. Signed-off-by: Tom Gall tom.g...@linaro.org In that case he should be set as the

[Piglit] [PATCH] invalid-es3-queries: Check that GL_MAX_VARYING_COMPONENTS is rejected

2013-02-07 Thread Matt Turner
--- See associated Mesa patch: mesa: Allow glGet* queries of MAX_VARYING_COMPONENTS in ES 3 tests/spec/gles-2.0/invalid-es3-queries.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/tests/spec/gles-2.0/invalid-es3-queries.c

Re: [Piglit] [PATCH] Add a variant of glsl-fs-pointcoord for gles2.

2013-02-08 Thread Matt Turner
On Fri, Feb 8, 2013 at 5:31 PM, Eric Anholt e...@anholt.net wrote: diff --git a/tests/spec/gles-2.0/glsl-fs-pointcoord.c b/tests/spec/gles-2.0/glsl-fs-pointcoord.c new file mode 100644 index 000..a2404bc --- /dev/null +++ b/tests/spec/gles-2.0/glsl-fs-pointcoord.c @@ -0,0 +1,141 @@

Re: [Piglit] Core context tests and ARB_compatibility

2013-02-13 Thread Matt Turner
On Mon, Feb 11, 2013 at 11:32 PM, Alexander Monakov amona...@gmail.com wrote: Hello, I think there is a problem in piglit implementation that breaks some tests on nvidia proprietary drivers, for instance textureSize 140 fs sampler2D -auto -fbo produces: piglit: info: Failed to create GL 3.1

Re: [Piglit] [PATCH] Enable etc2 tests on gl contexts that support GL_ARB_ES3_compatibility extension

2013-03-04 Thread Matt Turner
On Mon, Mar 4, 2013 at 2:43 PM, Anuj Phogat anuj.pho...@gmail.com wrote: Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- tests/spec/gles-3.0/CMakeLists.gl.txt | 5 + tests/spec/gles-3.0/oes_compressed_etc2_texture-miptree.c | 4 2 files changed, 9

[Piglit] [PATCH 1/8] glsl-4.00/ARB_texture_query_lod: Generate compiler tests for built-in functions

2013-03-19 Thread Matt Turner
For each sampler data type, generate a test for (vertex, fragment) shader; (glsl-4.00, glsl-1.30 + ARB_texture_query_lod). The vertex shader tests confirm that textureQueryLod is not available in the the vertex shader. --- generated_tests/CMakeLists.txt |4 +

[Piglit] [PATCH 3/8] arb_texture_query_lod: Test textureQueryLod with nearest filtering.

2013-03-19 Thread Matt Turner
--- .../fs-textureQueryLod-nearest.shader_test | 192 1 files changed, 192 insertions(+), 0 deletions(-) create mode 100644 tests/spec/arb_texture_query_lod/execution/fs-textureQueryLod-nearest.shader_test diff --git

[Piglit] [PATCH 4/8] arb_texture_query_lod: Test textureQueryLod with no mipmapping.

2013-03-19 Thread Matt Turner
--- .../fs-textureQueryLod-no-mipmap.shader_test | 121 1 files changed, 121 insertions(+), 0 deletions(-) create mode 100644 tests/spec/arb_texture_query_lod/execution/fs-textureQueryLod-no-mipmap.shader_test diff --git

[Piglit] [PATCH 5/8] shader_runner: Add lod_bias option to texparameter.

2013-03-19 Thread Matt Turner
--- tests/shaders/shader_runner.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c index 7f3ddbb..002cf72 100644 --- a/tests/shaders/shader_runner.c +++ b/tests/shaders/shader_runner.c @@ -1577,6 +1577,11 @@

[Piglit] [PATCH 6/8] arb_texture_query_lod: Test textureQueryLod with lod-biasing.

2013-03-19 Thread Matt Turner
--- .../fs-textureQueryLod-nearest-biased.shader_test | 182 1 files changed, 182 insertions(+), 0 deletions(-) create mode 100644 tests/spec/arb_texture_query_lod/execution/fs-textureQueryLod-nearest-biased.shader_test diff --git

[Piglit] [PATCH 7/8] arb_texture_query_lod: Test textureQueryLod with linear filtering.

2013-03-19 Thread Matt Turner
--- .../fs-textureQueryLod-linear.shader_test | 132 1 files changed, 132 insertions(+), 0 deletions(-) create mode 100644 tests/spec/arb_texture_query_lod/execution/fs-textureQueryLod-linear.shader_test diff --git

[Piglit] [PATCH 8/8] arb_texture_query_lod: Add execution shader_tests to all.tests.

2013-03-19 Thread Matt Turner
--- tests/all.tests |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/tests/all.tests b/tests/all.tests index 1dccd9a..f0cdc91 100644 --- a/tests/all.tests +++ b/tests/all.tests @@ -1162,6 +1162,12 @@ arb_texture_buffer_range['dlist'] =

Re: [Piglit] [PATCH] Fix build of shader_runner for GLES.

2013-03-30 Thread Matt Turner
); + piglit_report_result(PIGLIT_SKIP); +#endif } else { fprintf(stderr, unknown texture parameter in `%s'\n, line); piglit_report_result(PIGLIT_FAIL); -- 1.8.2 Oh, indeed. I didn't think of this. Thanks, I've learned something new. Reviewed-by: Matt Turner matts

[Piglit] [PATCH 00/19] Bit built-ins for ARB_gpu_shader5

2013-04-22 Thread Matt Turner
With the patch series on mesa-dev, these tests can run on i965 by setting MESA_GL_VERSION_OVERRIDE=3.2 MESA_GLSL_VERSION_OVERRIDE=150 MESA_EXTENSION_OVERRIDE=GL_ARB_gpu_shader5 The tests cover bitCount, findMSB, findLSB, bitfieldReverse, bitfieldExtract, and bitfieldInsert. The series is

[Piglit] [PATCH 02/19] arb_gpu_shader5: Add a fragment shader findLSB execution test.

2013-04-22 Thread Matt Turner
--- .../built-in-functions/fs-findLSB.shader_test | 71 1 files changed, 71 insertions(+), 0 deletions(-) create mode 100644 tests/spec/arb_gpu_shader5/execution/built-in-functions/fs-findLSB.shader_test diff --git

[Piglit] [PATCH 04/19] arb_gpu_shader5: Add a fragment shader bitfieldReverse execution test.

2013-04-22 Thread Matt Turner
--- .../fs-bitfieldReverse.shader_test | 69 1 files changed, 69 insertions(+), 0 deletions(-) create mode 100644 tests/spec/arb_gpu_shader5/execution/built-in-functions/fs-bitfieldReverse.shader_test diff --git

[Piglit] [PATCH 05/19] arb_gpu_shader5: Add a fragment shader bitfieldExtract execution test.

2013-04-22 Thread Matt Turner
--- .../fs-bitfieldExtract.shader_test | 109 1 files changed, 109 insertions(+), 0 deletions(-) create mode 100644 tests/spec/arb_gpu_shader5/execution/built-in-functions/fs-bitfieldExtract.shader_test diff --git

[Piglit] [PATCH 07/19] arb_gpu_shader5: Add a vertex shader bitCount execution test.

2013-04-22 Thread Matt Turner
--- .../built-in-functions/vs-bitCount.shader_test | 74 1 files changed, 74 insertions(+), 0 deletions(-) create mode 100644 tests/spec/arb_gpu_shader5/execution/built-in-functions/vs-bitCount.shader_test diff --git

[Piglit] [PATCH 08/19] arb_gpu_shader5: Add a vertex shader bitfieldReverse execution test.

2013-04-22 Thread Matt Turner
--- .../vs-bitfieldReverse.shader_test | 73 1 files changed, 73 insertions(+), 0 deletions(-) create mode 100644 tests/spec/arb_gpu_shader5/execution/built-in-functions/vs-bitfieldReverse.shader_test diff --git

[Piglit] [PATCH 09/19] arb_gpu_shader5: Add a vertex shader findMSB execution test.

2013-04-22 Thread Matt Turner
--- .../built-in-functions/vs-findMSB.shader_test | 95 1 files changed, 95 insertions(+), 0 deletions(-) create mode 100644 tests/spec/arb_gpu_shader5/execution/built-in-functions/vs-findMSB.shader_test diff --git

[Piglit] [PATCH 10/19] arb_gpu_shader5: Add a vertex shader findLSB execution test.

2013-04-22 Thread Matt Turner
--- .../built-in-functions/vs-findLSB.shader_test | 75 1 files changed, 75 insertions(+), 0 deletions(-) create mode 100644 tests/spec/arb_gpu_shader5/execution/built-in-functions/vs-findLSB.shader_test diff --git

[Piglit] [PATCH 11/19] arb_gpu_shader5: Add a vertex shader bitfieldExtract execution test.

2013-04-22 Thread Matt Turner
--- .../vs-bitfieldExtract.shader_test | 113 1 files changed, 113 insertions(+), 0 deletions(-) create mode 100644 tests/spec/arb_gpu_shader5/execution/built-in-functions/vs-bitfieldExtract.shader_test diff --git

[Piglit] [PATCH 14/19] arb_gpu_shader5: Add a constant eval findLSB execution test.

2013-04-22 Thread Matt Turner
--- .../built-in-functions/const-findLSB.shader_test | 67 1 files changed, 67 insertions(+), 0 deletions(-) create mode 100644 tests/spec/arb_gpu_shader5/execution/built-in-functions/const-findLSB.shader_test diff --git

[Piglit] [PATCH 15/19] arb_gpu_shader5: Add a constant eval findMSB execution test.

2013-04-22 Thread Matt Turner
--- .../built-in-functions/const-findMSB.shader_test | 64 1 files changed, 64 insertions(+), 0 deletions(-) create mode 100644 tests/spec/arb_gpu_shader5/execution/built-in-functions/const-findMSB.shader_test diff --git

[Piglit] [PATCH 17/19] arb_gpu_shader5: Add a constant eval bitfieldExtract execution test.

2013-04-22 Thread Matt Turner
--- .../const-bitfieldExtract.shader_test | 60 1 files changed, 60 insertions(+), 0 deletions(-) create mode 100644 tests/spec/arb_gpu_shader5/execution/built-in-functions/const-bitfieldExtract.shader_test diff --git

[Piglit] [PATCH 18/19] arb_gpu_shader5: Add a constant eval bitfieldInsert execution test.

2013-04-22 Thread Matt Turner
--- .../const-bitfieldInsert.shader_test | 56 1 files changed, 56 insertions(+), 0 deletions(-) create mode 100644 tests/spec/arb_gpu_shader5/execution/built-in-functions/const-bitfieldInsert.shader_test diff --git

[Piglit] [PATCH 19/19] arb_gpu_shader5: Add shader_tests to all.tests.

2013-04-22 Thread Matt Turner
--- tests/all.tests |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/tests/all.tests b/tests/all.tests index 8d067be..0721f0b 100644 --- a/tests/all.tests +++ b/tests/all.tests @@ -1075,6 +1075,12 @@ for backing_type in ('texture', 'renderbuffer'):

Re: [Piglit] [PATCH] Test interaction of dead code elimination with break statements.

2013-04-23 Thread Matt Turner
not be dead code eliminated + break; + f = 0.5; + } + gl_FragColor = vec4(1.0 - f, f, 0.0, 1.0); +} + +[test] +clear color 0.0 0.0 0.0 0.0 +clear + +draw rect -1 -1 2 2 +probe all rgba 0.0 1.0 0.0 1.0 -- 1.8.2.1 Reviewed-by: Matt Turner matts

[Piglit] [PATCH 03/19] arb_gpu_shader5: Add a fragment shader findMSB execution test.

2013-04-28 Thread Matt Turner
v2: Subtract return value from 31 to get the count in LSB terms. --- .../built-in-functions/fs-findMSB.shader_test | 91 ++ 1 file changed, 91 insertions(+) create mode 100644 tests/spec/arb_gpu_shader5/execution/built-in-functions/fs-findMSB.shader_test diff --git

[Piglit] [PATCH 13/19] arb_gpu_shader5: Add a constant eval bitCount execution test.

2013-04-28 Thread Matt Turner
v2: Call nonexistent bad_constant_folding() function if test fails. --- .../built-in-functions/const-bitCount.shader_test | 59 ++ 1 file changed, 59 insertions(+) create mode 100644 tests/spec/arb_gpu_shader5/execution/built-in-functions/const-bitCount.shader_test diff

[Piglit] [PATCH 14/19] arb_gpu_shader5: Add a constant eval findLSB execution test.

2013-04-28 Thread Matt Turner
v2: Call nonexistent bad_constant_folding() function if test fails. --- .../built-in-functions/const-findLSB.shader_test | 59 ++ 1 file changed, 59 insertions(+) create mode 100644 tests/spec/arb_gpu_shader5/execution/built-in-functions/const-findLSB.shader_test diff

[Piglit] [PATCH 15/19] arb_gpu_shader5: Add a constant eval findMSB execution test.

2013-04-28 Thread Matt Turner
v2: Subtract return value from 31 to get the count in LSB terms. Call nonexistent bad_constant_folding() function if test fails. --- .../built-in-functions/const-findMSB.shader_test | 58 ++ 1 file changed, 58 insertions(+) create mode 100644

  1   2   3   4   >