Re: [Piglit] [PATCH 3/7] arb_uniform_buffer_object: set KHR_no_error compatibility
As discussed offline, I missed the HAS_ERRORS bits. On 05/19/2017 11:18 AM, Samuel Pitoiset wrote: Few comments below, you missed all negative-* tests. With those fixed, patch is: Reviewed-by: Samuel Pitoiset On 05/18/2017 04:00 AM, Timothy Arceri wrote: --- .../bindbuffer-general-point.c | 1 + .../arb_uniform_buffer_object/buffer-targets.c | 1 + .../spec/arb_uniform_buffer_object/bufferstorage.c | 1 + .../spec/arb_uniform_buffer_object/deletebuffers.c | 1 + tests/spec/arb_uniform_buffer_object/dlist.c | 1 + ...tactiveuniformblockiv-uniform-block-data-size.c | 1 + .../getactiveuniformblockname.c| 37 --- .../getactiveuniformname.c | 37 --- .../getactiveuniformsiv-uniform-array-stride.c | 1 + .../getactiveuniformsiv-uniform-block-index.c | 1 + .../getactiveuniformsiv-uniform-matrix-stride.c| 1 + .../getactiveuniformsiv-uniform-type.c | 1 + .../spec/arb_uniform_buffer_object/getintegeri_v.c | 11 +++-- .../spec/arb_uniform_buffer_object/getprogramiv.c | 1 + .../getuniformblockindex.c | 17 --- .../arb_uniform_buffer_object/getuniformindices.c | 54 -- .../arb_uniform_buffer_object/getuniformlocation.c | 1 + .../layout-std140-base-size-and-alignment.c| 1 + .../link-mismatch-blocks.c | 1 + tests/spec/arb_uniform_buffer_object/maxblocks.c | 1 + .../maxuniformblocksize.c | 1 + tests/spec/arb_uniform_buffer_object/minmax.c | 1 + .../negative-bindbuffer-index.c| 1 + .../negative-bindbuffer-target.c | 1 + .../negative-bindbufferrange-range.c | 1 + .../negative-getactiveuniformblockiv.c | 1 + .../negative-getactiveuniformsiv.c | 1 + .../referenced-by-shader.c | 1 + .../arb_uniform_buffer_object/rendering-array.c| 1 + .../spec/arb_uniform_buffer_object/rendering-dsa.c | 1 + tests/spec/arb_uniform_buffer_object/rendering.c | 1 + tests/spec/arb_uniform_buffer_object/row-major.c | 1 + .../uniformblockbinding.c | 17 --- 33 files changed, 124 insertions(+), 76 deletions(-) diff --git a/tests/spec/arb_uniform_buffer_object/bindbuffer-general-point.c b/tests/spec/arb_uniform_buffer_object/bindbuffer-general-point.c index c9e81c2..5d8498b 100644 --- a/tests/spec/arb_uniform_buffer_object/bindbuffer-general-point.c +++ b/tests/spec/arb_uniform_buffer_object/bindbuffer-general-point.c @@ -26,20 +26,21 @@ * Tests that the glBindBuffer* entrypoints also bind to the general * binding point. */ #include "piglit-util-gl.h" PIGLIT_GL_TEST_CONFIG_BEGIN config.supports_gl_compat_version = 10; config.window_visual = PIGLIT_GL_VISUAL_RGBA | PIGLIT_GL_VISUAL_DOUBLE; +config.khr_no_error_support = PIGLIT_NO_ERRORS; PIGLIT_GL_TEST_CONFIG_END void piglit_init(int argc, char **argv) { bool pass = true; GLuint bo[2]; GLint binding; diff --git a/tests/spec/arb_uniform_buffer_object/buffer-targets.c b/tests/spec/arb_uniform_buffer_object/buffer-targets.c index 28924bc..beb2055 100644 --- a/tests/spec/arb_uniform_buffer_object/buffer-targets.c +++ b/tests/spec/arb_uniform_buffer_object/buffer-targets.c @@ -34,20 +34,21 @@ * * UNIFORM_BUFFER" */ #include "piglit-util-gl.h" PIGLIT_GL_TEST_CONFIG_BEGIN config.supports_gl_compat_version = 10; config.window_visual = PIGLIT_GL_VISUAL_RGBA | PIGLIT_GL_VISUAL_DOUBLE; +config.khr_no_error_support = PIGLIT_NO_ERRORS; PIGLIT_GL_TEST_CONFIG_END void piglit_init(int argc, char **argv) { bool pass = true; GLuint bo; uint8_t in_data[1] = {0xaa}; uint8_t out_data[1] = {0xd0}; diff --git a/tests/spec/arb_uniform_buffer_object/bufferstorage.c b/tests/spec/arb_uniform_buffer_object/bufferstorage.c index 52e20e0..e3e1383 100644 --- a/tests/spec/arb_uniform_buffer_object/bufferstorage.c +++ b/tests/spec/arb_uniform_buffer_object/bufferstorage.c @@ -28,20 +28,21 @@ * from UBOs. Same as rendering.c, except that the UBOs are * persistently mapped. */ #include "piglit-util-gl.h" PIGLIT_GL_TEST_CONFIG_BEGIN config.supports_gl_compat_version = 20; config.window_visual = PIGLIT_GL_VISUAL_DOUBLE | PIGLIT_GL_VISUAL_RGBA; +config.khr_no_error_support = PIGLIT_NO_ERRORS; PIGLIT_GL_TEST_CONFIG_END static const char vert_shader_text[] = "#extension GL_ARB_uniform_buffer_object : require\n" "\n" "layout(std140) uniform;\n" "uniform ub_pos_size { vec2 pos; float size; };\n" "uniform ub_rot {float rotation; };\n" "\n" diff --git a/tests/spec/arb_uniform_buffer_object/deletebuffers.c b/tests/spec/arb_uniform_buffer_object/deletebuffers.c index 8dc249a..4cb7
Re: [Piglit] [PATCH 3/7] arb_uniform_buffer_object: set KHR_no_error compatibility
Few comments below, you missed all negative-* tests. With those fixed, patch is: Reviewed-by: Samuel Pitoiset On 05/18/2017 04:00 AM, Timothy Arceri wrote: --- .../bindbuffer-general-point.c | 1 + .../arb_uniform_buffer_object/buffer-targets.c | 1 + .../spec/arb_uniform_buffer_object/bufferstorage.c | 1 + .../spec/arb_uniform_buffer_object/deletebuffers.c | 1 + tests/spec/arb_uniform_buffer_object/dlist.c | 1 + ...tactiveuniformblockiv-uniform-block-data-size.c | 1 + .../getactiveuniformblockname.c| 37 --- .../getactiveuniformname.c | 37 --- .../getactiveuniformsiv-uniform-array-stride.c | 1 + .../getactiveuniformsiv-uniform-block-index.c | 1 + .../getactiveuniformsiv-uniform-matrix-stride.c| 1 + .../getactiveuniformsiv-uniform-type.c | 1 + .../spec/arb_uniform_buffer_object/getintegeri_v.c | 11 +++-- .../spec/arb_uniform_buffer_object/getprogramiv.c | 1 + .../getuniformblockindex.c | 17 --- .../arb_uniform_buffer_object/getuniformindices.c | 54 -- .../arb_uniform_buffer_object/getuniformlocation.c | 1 + .../layout-std140-base-size-and-alignment.c| 1 + .../link-mismatch-blocks.c | 1 + tests/spec/arb_uniform_buffer_object/maxblocks.c | 1 + .../maxuniformblocksize.c | 1 + tests/spec/arb_uniform_buffer_object/minmax.c | 1 + .../negative-bindbuffer-index.c| 1 + .../negative-bindbuffer-target.c | 1 + .../negative-bindbufferrange-range.c | 1 + .../negative-getactiveuniformblockiv.c | 1 + .../negative-getactiveuniformsiv.c | 1 + .../referenced-by-shader.c | 1 + .../arb_uniform_buffer_object/rendering-array.c| 1 + .../spec/arb_uniform_buffer_object/rendering-dsa.c | 1 + tests/spec/arb_uniform_buffer_object/rendering.c | 1 + tests/spec/arb_uniform_buffer_object/row-major.c | 1 + .../uniformblockbinding.c | 17 --- 33 files changed, 124 insertions(+), 76 deletions(-) diff --git a/tests/spec/arb_uniform_buffer_object/bindbuffer-general-point.c b/tests/spec/arb_uniform_buffer_object/bindbuffer-general-point.c index c9e81c2..5d8498b 100644 --- a/tests/spec/arb_uniform_buffer_object/bindbuffer-general-point.c +++ b/tests/spec/arb_uniform_buffer_object/bindbuffer-general-point.c @@ -26,20 +26,21 @@ * Tests that the glBindBuffer* entrypoints also bind to the general * binding point. */ #include "piglit-util-gl.h" PIGLIT_GL_TEST_CONFIG_BEGIN config.supports_gl_compat_version = 10; config.window_visual = PIGLIT_GL_VISUAL_RGBA | PIGLIT_GL_VISUAL_DOUBLE; + config.khr_no_error_support = PIGLIT_NO_ERRORS; PIGLIT_GL_TEST_CONFIG_END void piglit_init(int argc, char **argv) { bool pass = true; GLuint bo[2]; GLint binding; diff --git a/tests/spec/arb_uniform_buffer_object/buffer-targets.c b/tests/spec/arb_uniform_buffer_object/buffer-targets.c index 28924bc..beb2055 100644 --- a/tests/spec/arb_uniform_buffer_object/buffer-targets.c +++ b/tests/spec/arb_uniform_buffer_object/buffer-targets.c @@ -34,20 +34,21 @@ * * UNIFORM_BUFFER" */ #include "piglit-util-gl.h" PIGLIT_GL_TEST_CONFIG_BEGIN config.supports_gl_compat_version = 10; config.window_visual = PIGLIT_GL_VISUAL_RGBA | PIGLIT_GL_VISUAL_DOUBLE; + config.khr_no_error_support = PIGLIT_NO_ERRORS; PIGLIT_GL_TEST_CONFIG_END void piglit_init(int argc, char **argv) { bool pass = true; GLuint bo; uint8_t in_data[1] = {0xaa}; uint8_t out_data[1] = {0xd0}; diff --git a/tests/spec/arb_uniform_buffer_object/bufferstorage.c b/tests/spec/arb_uniform_buffer_object/bufferstorage.c index 52e20e0..e3e1383 100644 --- a/tests/spec/arb_uniform_buffer_object/bufferstorage.c +++ b/tests/spec/arb_uniform_buffer_object/bufferstorage.c @@ -28,20 +28,21 @@ * from UBOs. Same as rendering.c, except that the UBOs are * persistently mapped. */ #include "piglit-util-gl.h" PIGLIT_GL_TEST_CONFIG_BEGIN config.supports_gl_compat_version = 20; config.window_visual = PIGLIT_GL_VISUAL_DOUBLE | PIGLIT_GL_VISUAL_RGBA; + config.khr_no_error_support = PIGLIT_NO_ERRORS; PIGLIT_GL_TEST_CONFIG_END static const char vert_shader_text[] = "#extension GL_ARB_uniform_buffer_object : require\n" "\n" "layout(std140) uniform;\n" "uniform ub_pos_size { vec2 pos; float size; };\n" "uniform ub_rot {float rotation; };\n" "\n" diff --git a/tests/spec/arb_uniform_buffer_object/deletebuffers.c b/tests/spec/arb_uniform_buffer_object/deletebuffers.c index 8dc249a..4cb7cce 100644 --- a/tests/spec/