Hello Emil,
On Sun, 24 Apr 2016 19:20:58 +0100
Emil Velikov wrote:
> The test uses pixman internal symbols, which we currently export. To
> resolve that static link the pixman library. This is an internal only
> test ran at `make check' thus we are fine with the bloated binary and
> alike.
>
>
The old code is comparing pixman_fixed_48_16_t values to
pixman_fixed_16_16_t values, thus it is checking for truncation of overflow
values.
It would probably be better to clamp these overflowed values, like
pixman_transform_point_31_16 is doing to clamp to the pixman_fixed_48_16
result. Right now
Doesn't this check for NaNs?
On Sun, Apr 24, 2016 at 8:22 PM, Emil Velikov
wrote:
> With commit ed39992564b "Use pixman_transform_point_31_16() from
> pixman_transform_point()" we added some strange hunks.
>
> Namely: we copy the data from the internal storage to the user vector
> only to compar