Re: [Pixman] [PATCH] MIPS: DSPr2: Fix for bug in in_n_8 routine.

2013-03-13 Thread Nemanja Lukic
...@gmail.com] Sent: Wednesday, March 06, 2013 10:22 PM To: Nemanja Lukic Cc: pixman@lists.freedesktop.org Subject: Re: [Pixman] [PATCH] MIPS: DSPr2: Fix for bug in in_n_8 routine. On Mon, 4 Mar 2013 15:36:42 +0100 Nemanja Lukic wrote: > Rounding logic was not implemented right. > Instead of using ro

Re: [Pixman] [PATCH] MIPS: DSPr2: Fix for bug in in_n_8 routine.

2013-03-06 Thread Siarhei Siamashka
On Mon, 4 Mar 2013 15:36:42 +0100 Nemanja Lukic wrote: > Rounding logic was not implemented right. > Instead of using rounding version of the 8-bit shift, logical shifts were > used. > Also, code used unnecessary multiplications, which could be avoided by packing > 4 destination (a8) pixel into

[Pixman] [PATCH] MIPS: DSPr2: Fix for bug in in_n_8 routine.

2013-03-04 Thread Nemanja Lukic
Rounding logic was not implemented right. Instead of using rounding version of the 8-bit shift, logical shifts were used. Also, code used unnecessary multiplications, which could be avoided by packing 4 destination (a8) pixel into one 32bit register. There were also, unnecessary spills on stack. Co