Re: [Pixman] [PATCH 05/12] vmx: implement fast path vmx_composite_copy_area

2015-07-16 Thread Siarhei Siamashka
On Wed, 15 Jul 2015 15:33:35 +0300 Oded Gabbay wrote: > On Tue, Jul 14, 2015 at 11:41 AM, Siarhei Siamashka > wrote: > > It is a good idea to have at least one benchmark result in the commit > > message. Or provide a convincing explanation why this particular code > > is beneficial. The "no chan

Re: [Pixman] [PATCH 05/12] vmx: implement fast path vmx_composite_copy_area

2015-07-15 Thread Oded Gabbay
On Tue, Jul 14, 2015 at 11:41 AM, Siarhei Siamashka wrote: > It is a good idea to have at least one benchmark result in the commit > message. Or provide a convincing explanation why this particular code > is beneficial. The "no changes were observed" commit message does not > do a good job justify

Re: [Pixman] [PATCH 05/12] vmx: implement fast path vmx_composite_copy_area

2015-07-14 Thread Siarhei Siamashka
On Thu, 2 Jul 2015 13:04:10 +0300 Oded Gabbay wrote: > No changes were observed when running cairo trimmed benchmarks. > > Signed-off-by: Oded Gabbay > --- > pixman/pixman-vmx.c | 26 ++ > 1 file changed, 26 insertions(+) > > diff --git a/pixman/pixman-vmx.c b/pixman/

[Pixman] [PATCH 05/12] vmx: implement fast path vmx_composite_copy_area

2015-07-02 Thread Oded Gabbay
No changes were observed when running cairo trimmed benchmarks. Signed-off-by: Oded Gabbay --- pixman/pixman-vmx.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/pixman/pixman-vmx.c b/pixman/pixman-vmx.c index b42288b..e69d530 100644 --- a/pixman/pixman-vmx.c +++