Re: [Pixman] [cairo] Floating point API in Pixman

2010-08-12 Thread Andrea Canciani
On Thu, Aug 12, 2010 at 10:02 AM, Mathieu Lacage mathieu.lac...@sophia.inria.fr wrote: On Thu, 2010-08-12 at 09:54 +0200, Andrea Canciani wrote: (I would *really* love if int128_t was actually available!) It's available on most 64bit systems (at least x86_64) with gcc as __int128_t

[Pixman] Valgrind-clean pixman

2010-08-26 Thread Andrea Canciani
, reviews,... are appreciated. Andrea Canciani ___ Pixman mailing list Pixman@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pixman

Re: [Pixman] Valgrind-clean pixman

2010-08-28 Thread Andrea Canciani
On Fri, Aug 27, 2010 at 3:58 PM, Siarhei Siamashka siarhei.siamas...@gmail.com wrote: On Thursday 26 August 2010 20:40:08 Andrea Canciani wrote: Currently pixman allocates dynamically its implementations, but does not free them. This is not a true memory leak, since implementations are only

Re: [Pixman] Valgrind-clean pixman

2010-08-29 Thread Andrea Canciani
On Sat, Aug 28, 2010 at 5:34 PM, Siarhei Siamashka siarhei.siamas...@gmail.com wrote: On Saturday 28 August 2010 12:21:52 Andrea Canciani wrote: On Fri, Aug 27, 2010 at 3:58 PM, Siarhei Siamashka wrote: This code which is setting a global implementation pointer is also not quite thread safe

Re: [Pixman] PDF radial gradients

2010-09-10 Thread Andrea Canciani
On Fri, Sep 10, 2010 at 8:44 AM, Soeren Sandmann sandm...@daimi.au.dk wrote: Andrea Canciani ranm...@gmail.com writes: I updated the documentation of radial gradients in my wip/radial branch (http://cgit.freedesktop.org/~ranma42/pixman/log/?h=wip/radial) to reflect my changes (which make

Re: [Pixman] [PATCH] Do CPU features detection from 'constructor' function when compiled with gcc

2010-10-04 Thread Andrea Canciani
On Sun, Oct 3, 2010 at 10:52 PM, Siarhei Siamashka siarhei.siamas...@gmail.com wrote: From: Siarhei Siamashka siarhei.siamas...@nokia.com There is attribute 'constructor' supported since gcc 2.7 which allows to have a constructor function for library initialization. This eliminates an extra

Re: [Pixman] [PATCH] Do CPU features detection from 'constructor' function when compiled with gcc

2010-10-05 Thread Andrea Canciani
On Mon, Oct 4, 2010 at 11:43 PM, Siarhei Siamashka siarhei.siamas...@gmail.com wrote: On Monday 04 October 2010 13:19:45 Andrea Canciani wrote: On Sun, Oct 3, 2010 at 10:52 PM, Siarhei Siamashka siarhei.siamas...@gmail.com wrote: From: Siarhei Siamashka siarhei.siamas...@nokia.com

[Pixman] Radial gradients (again)

2010-10-18 Thread Andrea Canciani
I don't remember the timeline for pixman 0.20, but I think that the attached patch should be reviewed and merged (if it looks good), because it is a straightforward change that extends the valid domain.

Re: [Pixman] Gradients patches

2010-10-23 Thread Andrea Canciani
the range of valid values should be pretty safe. Andrea Canciani ___ Pixman mailing list Pixman@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pixman

Re: [Pixman] How pixman_implementation_t is getting free

2010-11-02 Thread Andrea Canciani
2010/11/2 kb pachauri kb.pacha...@gmail.com: Actually what i mean for freeing memory is .. freeing the opencl context, releasing command queue, all opencl kernels etc... sorry for not too clear in my words.. I dont think this will be freed until i free the context.. Then you might look this

[Pixman] [PATCH 1/3] Remove unused stop_range field

2010-11-02 Thread Andrea Canciani
--- pixman/pixman-image.c |2 -- pixman/pixman-private.h |1 - 2 files changed, 0 insertions(+), 3 deletions(-) diff --git a/pixman/pixman-image.c b/pixman/pixman-image.c index fabcd63..fc0677d 100644 --- a/pixman/pixman-image.c +++ b/pixman/pixman-image.c @@ -47,8 +47,6 @@

[Pixman] [PATCH 2/3] Fix opacity check

2010-11-02 Thread Andrea Canciani
Radial gradients are conical, thus they can have some non-opaque parts even if all of their stops are completely opaque. To guarantee that a radial gradient is actually opaque, it needs to also have one of the two circles containing the other one. In this case when extrapolating, the whole plane

[Pixman] [PATCH 3/3] Improve conical gradients opacity check

2010-11-02 Thread Andrea Canciani
Conical gradients are completely opaque if all of their stops are opaque and the repeat mode is not 'none'. --- pixman/pixman-image.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/pixman/pixman-image.c b/pixman/pixman-image.c index ec277c6..0511f2f 100644 ---

Re: [Pixman] [PATCH 2/3] Fix opacity check

2010-11-04 Thread Andrea Canciani
On Thu, Nov 4, 2010 at 2:05 AM, Soeren Sandmann sandm...@daimi.au.dk wrote: Andrea Canciani ranm...@gmail.com writes: @@ -436,6 +436,12 @@ compute_image_info (pixman_image_t *image)       {           int i; +         if (image-common.type == RADIAL +             image-radial.a = 0

[Pixman] [PATCH] Improve handling of tangent circles

2011-01-03 Thread Andrea Canciani
When b is 0, avoid the division by zero and just return transparent black. When the solution t would have an invalid radius (negative or outside [0,1] for none-extended gradients), return transparent black. --- pixman/pixman-radial-gradient.c | 20 ++-- 1 files changed, 18

Re: [Pixman] [PATCH 3/3] Add SSSE3 fast path skeleton

2011-01-04 Thread Andrea Canciani
On Tue, Jan 4, 2011 at 10:22 AM, Siarhei Siamashka siarhei.siamas...@gmail.com wrote: On Wednesday 08 December 2010 16:13:48 Liu Xinyun wrote: There is a performance test between commits commit 56777f3f675869806cd30bcd21a5b39d788507cb Author: Dmitri Vorobiev dmitri.vorob...@movial.com Date:  

Re: [Pixman] [PATCH] Improve handling of tangent circles

2011-01-04 Thread Andrea Canciani
On Tue, Jan 4, 2011 at 10:59 AM, Siarhei Siamashka siarhei.siamas...@gmail.com wrote: On Monday 03 January 2011 10:15:09 Andrea Canciani wrote: When b is 0, avoid the division by zero and just return transparent black. When the solution t would have an invalid radius (negative or outside

Re: [Pixman] [PATCH 0/18] Add iterators to images

2011-01-07 Thread Andrea Canciani
On Thu, Jan 6, 2011 at 3:43 AM, Soeren Sandmann sandm...@cs.au.dk wrote: Søren Sandmann sandm...@cs.au.dk writes: The following patch series changes the scanline access to be based on iterators instead of direct calls to virtual functions. There are several benefits to this: It also provides

Re: [Pixman] [PATCH 14/18] Get rid of the classify methods.

2011-01-07 Thread Andrea Canciani
On Thu, Jan 6, 2011 at 3:27 AM, Søren Sandmann sandm...@cs.au.dk wrote: From: Søren Sandmann Pedersen s...@redhat.com They are not used anymore, and the linear gradient is now doing the optimization in a different way. ---  pixman/pixman-image.c           |   14 --  

Re: [Pixman] [PATCH 18/18] Fix destination fetching.

2011-01-07 Thread Andrea Canciani
On Thu, Jan 6, 2011 at 3:28 AM, Søren Sandmann sandm...@cs.au.dk wrote: From: Søren Sandmann Pedersen s...@redhat.com When fetching from destinations, we need to ignore transformations, repeat and filtering. Currently we don't ignore them, which means all kinds of bad things can happen.

Re: [Pixman] [PATCH 15/18] Add direct-write optimization back

2011-01-07 Thread Andrea Canciani
On Thu, Jan 6, 2011 at 3:27 AM, Søren Sandmann sandm...@cs.au.dk wrote: From: Søren Sandmann Pedersen s...@redhat.com Introduce a new ITER_LOCALIZED_ALPHA flag that indicates that the alpha value computed is used only for the alpha channel of the output; it doesn't affect the RGB channels.

Re: [Pixman] [PATCH 0/18] Add iterators to images

2011-01-08 Thread Andrea Canciani
On Sat, Jan 8, 2011 at 12:15 PM, Soeren Sandmann sandm...@cs.au.dk wrote: Iterators gets initialized with a buffer which can always contain at least width pixels. This is sufficient for current image types, but future image types might need additional space. Would it be possible to have the

Re: [Pixman] warnings in pixman 0.21.4

2011-01-25 Thread Andrea Canciani
On Tue, Jan 25, 2011 at 4:38 PM, Rolland Dudemaine roll...@ghs.com wrote: - *max_vx.diff corrects the initialization of max_vx. Contrary to what you mention, the variable is declared in a local block, so the scope of the variable is restricted to that block, regardless of whether it is part

Re: [Pixman] [cairo] pixman: New ARM NEON optimizations

2011-02-12 Thread Andrea Canciani
On Fri, Feb 11, 2011 at 11:30 AM, Soeren Sandmann sandm...@cs.au.dk wrote: Chris Wilson ch...@chris-wilson.co.uk writes: But at the moment, about the only thing I truly want to add to the API is a LERP operator. Cairo has a slightly different definition for [clip-] masked operators where

Re: [Pixman] [PATCH] Avoid marking images dirty when properties are reset

2011-02-15 Thread Andrea Canciani
On Tue, Feb 15, 2011 at 10:55 AM, Soeren Sandmann sandm...@cs.au.dk wrote: When an image property is set to the same value that it already is, there is no reason to mark the image dirty and incur a recomputation of the flags. ---  pixman/pixman-image.c |   20 +++-  1 files

[Pixman] [PATCH 1/3] Fix compilation on Win32

2011-02-22 Thread Andrea Canciani
Building the library from a clean git repository fails with: pixman-image.c(33) : fatal error C1083: Cannot open include file: 'pixman-combine32.h': No such file or directory pixman-combine32.h is not used by pixman-image.c, so its inclusion can simply be removed. --- pixman/pixman-image.c |

[Pixman] [PATCH 2/3] test: Fix tests for compilation on Windows

2011-02-22 Thread Andrea Canciani
The Microsoft C compiler cannot handle subobject initialization and Win32 does not provide snprintf. Work around these limitations by using normal struct initailization and directly using printf. --- test/composite.c| 48 +++--- test/fetch-test.c |

[Pixman] [PATCH 3/3] test: add Makefile for Win32

2011-02-22 Thread Andrea Canciani
--- test/Makefile.win32 | 73 +++ 1 files changed, 73 insertions(+), 0 deletions(-) create mode 100644 test/Makefile.win32 diff --git a/test/Makefile.win32 b/test/Makefile.win32 new file mode 100644 index 000..c71afe1 --- /dev/null +++

Re: [Pixman] [PATCH 2/3] test: Fix tests for compilation on Windows

2011-02-23 Thread Andrea Canciani
On Wed, Feb 23, 2011 at 6:26 PM, Brent Fulgham bfulg...@gmail.com wrote: Thanks for making these fixes -- they look great! I have one small suggestion regarding your update to composite.c; while MSVC does not provide an snprintf symbol, it does provide _snprintf. The documentation states

Re: [Pixman] Win32 fixes and improvements

2011-02-24 Thread Andrea Canciani
On Tue, Feb 22, 2011 at 11:07 PM, Andrea Canciani ranm...@gmail.com wrote: In order to make pixman more maintainable on windows, having working Makefiles for the library and the tests is probably needed. Today I took the Makefile attached to https://bugs.freedesktop.org/show_bug.cgi?id=33069

Re: [Pixman] [cairo] Planar YUV support

2011-03-02 Thread Andrea Canciani
On Wed, Mar 2, 2011 at 3:16 PM, Soeren Sandmann sandm...@cs.au.dk wrote: Siarhei Siamashka siarhei.siamas...@gmail.com writes: I'm not a big fan of let's make this totally universal and future proof approach if only a very small fraction of this functionality is going to be actually used.

Re: [Pixman] [cairo] Planar YUV support

2011-03-04 Thread Andrea Canciani
On Thu, Mar 3, 2011 at 6:58 PM, Siarhei Siamashka siarhei.siamas...@gmail.com wrote: On Wed, Mar 2, 2011 at 4:16 PM, Soeren Sandmann sandm...@cs.au.dk wrote: Siarhei Siamashka siarhei.siamas...@gmail.com writes: I'm not a big fan of let's make this totally universal and future proof approach

Re: [Pixman] Pixman on iOS

2011-03-07 Thread Andrea Canciani
On Mon, Mar 7, 2011 at 8:09 PM, cu cairou...@yahoo.com wrote: I'm actually more worried that if this build for iPhone ends up being a one shot experiment without any maintainer to keep it alive, then it is going to bitrot soon. IMHO adding support for more marginal platforms (in cairo/pixman

[Pixman] [PATCH] test: Fix compilation on win32

2011-05-05 Thread Andrea Canciani
MSVC complains about uint32_t being used as an expression: composite.c(902) : error C2275: 'uint32_t' : illegal use of this type as an expression --- test/composite.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/test/composite.c b/test/composite.c index

Re: [Pixman] [PATCH 3/3] BILINEAR-NEAREST filter optimization for simple rotation and translation

2011-05-23 Thread Andrea Canciani
On Sun, May 22, 2011 at 11:15 PM, Siarhei Siamashka siarhei.siamas...@gmail.com wrote: From: Siarhei Siamashka siarhei.siamas...@nokia.com Simple rotation and translation are the additional cases when BILINEAR filter can be safely reduced to NEAREST. I believe that this reduction is valid for

Re: [Pixman] [PATCH 3/3] BILINEAR-NEAREST filter optimization for simple rotation and translation

2011-05-23 Thread Andrea Canciani
On Mon, May 23, 2011 at 8:43 AM, Andrea Canciani ranm...@gmail.com wrote: On Sun, May 22, 2011 at 11:15 PM, Siarhei Siamashka siarhei.siamas...@gmail.com wrote: From: Siarhei Siamashka siarhei.siamas...@nokia.com Simple rotation and translation are the additional cases when BILINEAR filter

[Pixman] [PATCH] Include noop in win32 builds

2011-05-23 Thread Andrea Canciani
--- pixman/Makefile.win32 |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/pixman/Makefile.win32 b/pixman/Makefile.win32 index b5f9397..7c92722 100644 --- a/pixman/Makefile.win32 +++ b/pixman/Makefile.win32 @@ -49,6 +49,7 @@ SOURCES = \

Re: [Pixman] [PATCH 3/3] BILINEAR-NEAREST filter optimization for simple rotation and translation

2011-05-23 Thread Andrea Canciani
On Mon, May 23, 2011 at 3:16 PM, Siarhei Siamashka siarhei.siamas...@gmail.com wrote: On Mon, May 23, 2011 at 9:48 AM, Andrea Canciani ranm...@gmail.com wrote: On Mon, May 23, 2011 at 8:43 AM, Andrea Canciani ranm...@gmail.com wrote: On Sun, May 22, 2011 at 11:15 PM, Siarhei Siamashka

Re: [Pixman] [PATCH 1/4] Fix lcg_rand_u32() to return 32 random bits.

2011-08-04 Thread Andrea Canciani
On Thu, Aug 4, 2011 at 4:21 AM, Søren Sandmann sandm...@cs.au.dk wrote: From: Søren Sandmann Pedersen s...@redhat.com The lcg_rand() function only returns 15 random bits, so lcg_rand_u32() would always have 0 in bit 31 and bit 15. Fix that by calling lcg_rand() three times, to generate 15,

Re: [Pixman] [PATCH 3/4] Speed up pixman_region{, 32}_contains_rectangle()

2011-08-04 Thread Andrea Canciani
On Thu, Aug 4, 2011 at 4:21 AM, Søren Sandmann sandm...@cs.au.dk wrote: From: Søren Sandmann Pedersen s...@redhat.com When someone selects some text in Firefox under a non-composited X server and initiates a drag, a shaped window is created with a complex shape corresponding to the outline of

[Pixman] [PATCH] win32: Build benchmarks

2011-08-09 Thread Andrea Canciani
Add the makefile rules needed to compile lowlevel-blt-bench on win32 and fix the compilation errors. --- test/Makefile.win32 |5 - test/lowlevel-blt-bench.c |6 ++ 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/test/Makefile.win32 b/test/Makefile.win32 index

[Pixman] [PATCH] Workaround bug in llvm-gcc

2011-08-16 Thread Andrea Canciani
llvm-gcc (shipped in Apple XCode 4.1.1) as the default compiler performs an invalid optimization which unifies the empty_region and the bad_region structures because they have the same content. A bug has been filed against Apple Developers Tool for this issue. This commit works around this bug by

[Pixman] [PATCH] Workaround bug in llvm-gcc

2011-08-20 Thread Andrea Canciani
llvm-gcc (shipped in Apple XCode 4.1.1 as the default compiler or in the 2.9 release of LLVM) performs an invalid optimization which unifies the empty_region and the bad_region structures because they have the same content. A bug has been filed against Apple Developers Tool for this issue. This

Re: [Pixman] [PATCH] Workaround bug in llvm-gcc

2011-08-23 Thread Andrea Canciani
On Mon, Aug 22, 2011 at 3:24 PM, Soeren Sandmann sandm...@cs.au.dk wrote: Andrea Canciani ranm...@gmail.com writes: llvm-gcc (shipped in Apple XCode 4.1.1 as the default compiler or in the 2.9 release of LLVM) performs an invalid optimization which unifies the empty_region and the bad_region

[Pixman] [PATCH 1/7] test: Fix compilation on win32

2011-09-04 Thread Andrea Canciani
Adding scaling-helpers-test to the testsuite on win32 makes MSVC complain about int64_t being used as an expression: scaling-helpers-test.c(27) : error C2275: 'int64_t' : illegal use of this type as an expression --- test/scaling-helpers-test.c |2 +- 1 files changed, 1 insertions(+), 1

[Pixman] [PATCH 2/7] build: Reuse sources and pixman-combine build rules

2011-09-04 Thread Andrea Canciani
Makefile.am and Makefile.win32 should not duplicate content, as this leads to breaking the build when they are not kept in sync. This can be avoided by listing sources, headers and common build variables/rules in a Makefile.sources file. --- pixman/Makefile.am | 61

[Pixman] [PATCH 5/7] build-win32: Add root Makefile.win32

2011-09-04 Thread Andrea Canciani
Add Makefile.win32 to the pixman root. This makefile can recursively run the other ones to compile the library or the test suite. --- Makefile.win32 | 20 1 files changed, 20 insertions(+), 0 deletions(-) create mode 100644 Makefile.win32 diff --git a/Makefile.win32

[Pixman] [PATCH 6/7] test: Do not include config.h unless HAVE_CONFIG_H is defined

2011-09-04 Thread Andrea Canciani
The win32 build system does not generate config.h and correctly runs the compiler without defining HAVE_CONFIG_H. Nevertheless some files include config.h without checking for its availability, breaking the build from a clean directory: test\utils.h(2) : fatal error C1083: Cannot open include

[Pixman] [PATCH 7/7] build-win32: Add 'check' target

2011-09-04 Thread Andrea Canciani
On win32 the tests are built but they are not run automatically by the build system. A minimal 'check' target (depending on the tests being built) can simply run them and log to the console their success/failure. --- Makefile.win32 |5 + test/Makefile.win32 |3 +++ 2 files

Re: [Pixman] [PATCH] Only link with -lpng when libpng is actually available

2011-09-11 Thread Andrea Canciani
How about using pkg-config to detect the availability of libpng and the flags required to use it? Andrea On Sun, Sep 11, 2011 at 1:09 PM, Søren Sandmann sandm...@cs.au.dk wrote: From: Søren Sandmann Pedersen s...@redhat.com Fixes build on systems that don't have libpng ---  configure.ac    

Re: [Pixman] [RFC] Performance statistics analyzer

2011-09-14 Thread Andrea Canciani
On Wed, Sep 7, 2011 at 6:46 AM, Maarten Bosmans mkbosm...@gmail.com wrote: 2011/9/6 Taekyun Kim podai...@gmail.com: Hi, Currently pixman is used as a lowlevel backend for various applications. For doing analysis on performance, it might be desirable to provide some performance statistics

[Pixman] Code cleanup

2011-11-04 Thread Andrea Canciani
This patchset should simply cleanup some code, mostly in the tests. The patchset is also available in http://cgit.freedesktop.org/~ranma42/pixman/log/?h=wip/cocci As they are not fixes, it might be a good idea to wait for 0.24 to be released before merging them (as usual, if nobody raises

[Pixman] [PATCH 1/5] Remove useless checks for NULL before freeing

2011-11-04 Thread Andrea Canciani
This patch has been generated by the following Coccinelle semantic patch: // Remove useless checks for NULL before freeing // // free (NULL) is a no-op, so there is no need to avoid it @@ expression E; @@ + free (E); + E = NULL; - if (unlikely (E != NULL)) { - free(E); ( - E = NULL; | - E

[Pixman] [PATCH 2/5] test: Cleanup includes

2011-11-04 Thread Andrea Canciani
All the tests are linked to libutil, hence it makes sence to always include utils.h and reuse what it provides (config.h inclusion, access to private pixman APIs, ARRAY_LENGTH, ...). --- test/a1-trap-test.c |2 +- test/blitters-test.c |1 - test/composite-traps-test.c |

[Pixman] [PATCH 3/5] Use the ARRAY_LENGTH() macro when possible

2011-11-04 Thread Andrea Canciani
This patch has been generated by the following Coccinelle semantic patch: // Use the ARRAY_LENGTH() macro when possible // // Replace open-coded array length computations with the // ARRAY_LENGTH() macro @@ type T; T[] E; @@ - (sizeof(E)/sizeof(T)) + ARRAY_LENGTH (E) --- test/blitters-test.c

[Pixman] [PATCH 4/5] test: Reuse the ARRAY_LENGTH() macro

2011-11-04 Thread Andrea Canciani
It is provided by utils.h, there is no need to redefine it. --- test/alphamap.c |2 -- test/scaling-crash-test.c |5 ++--- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/test/alphamap.c b/test/alphamap.c index 554b309..24a350e 100644 --- a/test/alphamap.c +++

[Pixman] [PATCH 5/5] demos: Consistently use G_N_ELEMENTS()

2011-11-04 Thread Andrea Canciani
Instead of open-coding G_N_ELEMENTS(), just use it. --- demos/composite-test.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/demos/composite-test.c b/demos/composite-test.c index f5f352f..bba90c5 100644 --- a/demos/composite-test.c +++ b/demos/composite-test.c @@

[Pixman] [PATCH] test: Produce autotools-looking report in the win32 build system

2011-11-08 Thread Andrea Canciani
Tweak the commands used to run the tests on win32 to make the output look mostly like that produced by the autotools test system. In addition to this, make sure that the exit status of the test target is success (0) if and only if no failure occurred. --- test/Makefile.win32 | 21

Re: [Pixman] pixman make error

2011-11-17 Thread Andrea Canciani
On Thu, Nov 17, 2011 at 7:16 AM, lwin_...@dimension.com.tw wrote: hi Sir, Madam:         When I compiled , the system show  a error message as the attachment. Please kindly advise me how to fix the problem. Thanks Can you check if your make command is a GNU Make? $ make --version GNU Make

[Pixman] [PATCH 1/3] gradient-walker: Remove need_reset field

2012-01-05 Thread Andrea Canciani
A reset can be forced by making left_x right_x, because no pos will satisfy left = pos right. --- pixman/pixman-gradient-walker.c | 17 ++--- pixman/pixman-private.h |2 -- 2 files changed, 6 insertions(+), 13 deletions(-) diff --git a/pixman/pixman-gradient-walker.c

[Pixman] [PATCH 3/3] gradient-walker: Use appropriate size for left and right offset

2012-01-05 Thread Andrea Canciani
Otherwise if pos cannot be represented as an int32_t, the gradient is reset at every step. --- pixman/pixman-gradient-walker.c | 13 +++-- pixman/pixman-private.h |4 ++-- 2 files changed, 5 insertions(+), 12 deletions(-) diff --git a/pixman/pixman-gradient-walker.c

Re: [Pixman] [PATCH 1/1] Disable implementations mentioned in the PIXMAN_DISABLE environment variable.

2012-02-26 Thread Andrea Canciani
On Sun, Feb 26, 2012 at 4:12 PM, Matt Turner matts...@gmail.com wrote: On Sat, Feb 25, 2012 at 9:39 PM, Søren Sandmann sandm...@cs.au.dk wrote: From: Søren Sandmann Pedersen s...@redhat.com With this, it becomes possible to do     PIXMAN_DISABLE=sse2 mmx some_app which will run some_app

Re: [Pixman] [cairo] help building cairo on windows

2012-09-10 Thread Andrea Canciani
This reminds me that I have some patches to improve building pixman on win32: http://cgit.freedesktop.org/~ranma42/pixman/commit/?h=wip/simpleops-to-master Soren, is it ok if I push the attached patches? I will work a little more on simpleops before proposing it again (in particular, I'd like to

[Pixman] [PATCH 4/4] Add support for SSSE3 to the MSVC build system

2013-09-26 Thread Andrea Canciani
Handle SSSE3 just like MMX and SSE2. --- pixman/Makefile.win32 | 29 +++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git a/pixman/Makefile.win32 b/pixman/Makefile.win32 index 57ed7a5..7b64033 100644 --- a/pixman/Makefile.win32 +++ b/pixman/Makefile.win32 @@

[Pixman] [PATCH 2/4] Fix building of other programs on MSVC

2013-09-26 Thread Andrea Canciani
In d1434d112ca5cd325e4fb85fc60afd1b9e902786 the benchmarks have been extended to include other programs as well and the variable names have been updated accordingly in the autotools-based build system, but not in the MSVC one. --- test/Makefile.win32 | 6 +++--- 1 file changed, 3 insertions(+), 3

[Pixman] [PATCH 1/4] Fix build on MSVC

2013-09-26 Thread Andrea Canciani
After a4c79d695d52c94647b1aff78548e5892d616b70 the MMX and SSE2 code has some declarations after the beginning of a block, which is not allowed by MSVC. Fixes multiple errors like: pixman-mmx.c(3625) : error C2275: '__m64' : illegal use of this type as an expression pixman-sse2.c(5708) : error

Re: [Pixman] [PATCH 2/2] test: Add new thread-test program

2013-09-28 Thread Andrea Canciani
I have some work on memleak related issues: http://cgit.freedesktop.org/~ranma42/pixman/commit/?h=wip/simpleops-to-masterid=77db90242f7b7f12c5792480a10eb3a448e6c55f and http://cgit.freedesktop.org/~ranma42/pixman/commit/?h=wip/simpleops-to-masterid=ca41228a66fe9bbec354cdef034c144ce1619793 Do you

Re: [Pixman] [PATCH 2/2] test: Add new thread-test program

2013-10-09 Thread Andrea Canciani
Sorry, I didn't realize it beforehand, but I just noticed that thread-test fails on MacOS. This happens because it relies on the availability of OpenMP to have a thread-local state for the prng. Would it be ok to have each thread explicitly keep the state of its prng or is this another element

[Pixman] [PATCH] Fix thread-test on non-OpenMP systems

2013-10-09 Thread Andrea Canciani
The non-reentrant versions of prng_* functions are thread-safe only in OpenMP-enabled builds. Fixes thread-test failing when compiled with Clang (both on Linux and on MacOS). --- test/thread-test.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git

Re: [Pixman] [PATCH 2/2] test: Add new thread-test program

2013-10-09 Thread Andrea Canciani
...@cs.au.dk (Søren Sandmann) wrote: Siarhei Siamashka siarhei.siamas...@gmail.com writes: On Wed, 09 Oct 2013 17:06:06 +0200 sandm...@cs.au.dk (Søren Sandmann) wrote: Andrea Canciani ranm...@gmail.com writes: Sorry, I didn't realize it beforehand, but I just noticed that thread

[Pixman] [PATCH] test: Fix the win32 build

2013-11-11 Thread Andrea Canciani
The win32 build has no config.h, so HAVE_CONFIG_H should be checked before including it, as in utils.h. --- test/thread-test.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/test/thread-test.c b/test/thread-test.c index fa21933..0b07b26 100644 --- a/test/thread-test.c +++

Re: [Pixman] [PATCH] Allow building on Windows with cmd.exe

2015-06-04 Thread Andrea Canciani
-- 1 file changed, 12 insertions(+), 2 deletions(-) Thanks for the patch. But it is a bit difficult for non-Windows folks to see if it makes any sense or not. So it would be best if some other Windows user could review and confirm that it works. I have added Andrea Canciani (the author

[Pixman] Pixman not building on MacOS X 10.11

2015-10-10 Thread Andrea Canciani
It looks like the latest XCode cannot build pixman: $ clang --version Apple LLVM version 7.0.0 (clang-700.0.72) Target: x86_64-apple-darwin14.5.0 Thread model: posix pixman-mmx.c:100:20: error: constraint 'K' expects an integer constant expression : "y" (__A), "K" (__N)

Re: [Pixman] Pixman not building on MacOS X 10.11

2015-10-11 Thread Andrea Canciani
<jerem...@freedesktop.org> wrote: > > > > > > On Oct 10, 2015, at 13:48, Andrea Canciani <ranm...@gmail.com> > wrote: > > > > The attached hack gets the code to compile on modern clang, but I > > > > believe first of all we should improve the configure.

[Pixman] [PATCH] test: Fix fence-image-self-test on Mac

2015-10-13 Thread Andrea Canciani
On MacOS X an out-of-bounds access to an mmap-ed region typically results in a SIGBUS, but fence-image-self-test was only accepting a SIGSEGV as notification of invalid access. Fixes fence-image-self-test --- test/fence-image-self-test.c | 12 +++- test/utils.c | 6

[Pixman] [PATCH] test: Fix fence-image-self-test on Mac

2015-10-13 Thread Andrea Canciani
On MacOS X, according to the manpage of mprotect(), "When a program violates the protections of a page, it gets a SIGBUS or SIGSEGV signal.", but fence-image-self-test was only accepting a SIGSEGV as notification of invalid access. Fixes fence-image-self-test Reviewed-by: Pekka Paalanen

[Pixman] [PATCH 4/4] build: Use `del` instead of `rm` on `cmd.exe` shells

2015-12-23 Thread Andrea Canciani
s work on Win32 both using `cmd.exe` and using the MSYS environment. Signed-off-by: Simon Richter <simon.rich...@hogyros.de> Signed-off-by: Andrea Canciani <ranm...@gmail.com> --- Makefile.win32.common | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/Makef

[Pixman] [PATCH 3/4] build: Do not use `mkdir -p` on Windows

2015-12-23 Thread Andrea Canciani
` shell, except for the `clean` targets. Signed-off-by: Andrea Canciani <ranm...@gmail.com> --- Makefile.win32.common | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Makefile.win32.common b/Makefile.win32.common index b498c2f..a759ddc 100644 --- a/Makefile.win32.common

[Pixman] [PATCH 1/4] build: Remove use of BUILT_SOURCES from Makefile.win32

2015-12-23 Thread Andrea Canciani
Since 3d81d89c292058522cce91338028d9b4c4a23c24 BUILT_SOURCES is not used anymore, but it was unintentionally left in Win32 Makefiles. Signed-off-by: Andrea Canciani <ranm...@gmail.com> --- Makefile.win32.common | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile

[Pixman] [PATCH 2/4] build: Avoid phony `pixman` target in test/Makefile.win32

2015-12-23 Thread Andrea Canciani
Instead of explicitly depending on "pixman" for the "all" and "check" targets, rely on the dependency to the .lib file Signed-off-by: Andrea Canciani <ranm...@gmail.com> --- test/Makefile.win32 | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-)

[Pixman] [PATCH] build: Distinguish SKIP and FAIL on Win32

2015-12-24 Thread Andrea Canciani
-by: Andrea Canciani <ranm...@gmail.com> --- test/Makefile.win32 | 31 --- 1 file changed, 20 insertions(+), 11 deletions(-) diff --git a/test/Makefile.win32 b/test/Makefile.win32 index bdd9b7f..d38f0c0 100644 --- a/test/Makefile.win32 +++ b/test/Makefile.win32 @@ -19,26

Re: [Pixman] [PATCH] Allow building on Windows with cmd.exe

2015-12-23 Thread Andrea Canciani
On Tue, Dec 22, 2015 at 2:19 PM, Oded Gabbay <oded.gab...@gmail.com> wrote: > On Thu, Jun 4, 2015 at 12:02 PM, Andrea Canciani <ranm...@gmail.com> > wrote: > > The patch does not regress the mingw-based build (basically that used in > > http://cairographics.org/end_t