Re: [pkg-discuss] Code review: 11867 - Enable interactive search on PM tree views
WFM. Thanks. On Tue, 2009-11-17 at 09:01 +, Padraig O'Briain wrote: > This works for me. However I am unhappy with having two calls to > self.w_categories_treeview.set_search_column(). See webrev, > http://cr.opensolaris.org/~padraig/ips-11867-v5/, for my proposed > alternative, i.e. one call at line 1431. > > Padraig > > On 11/16/09 16:20, Joanmarie Diggs wrote: > > Here's take 4: http://defect.opensolaris.org/bz/attachment.cgi?id=3031 > > > > Addresses: > > > > 1. We should also be catching re.error as well as TypeError. (Thanks > > John!) > > > > 2. Switching publishers causes the feature to fail in the category > > treeview. It turns out the search column was getting reset. (Thanks > > Michal!) > > > > --joanie > > > > On Mon, 2009-11-16 at 08:52 -0500, Joanmarie Diggs wrote: > > > > > New patch: http://defect.opensolaris.org/bz/attachment.cgi?id=3025 > > > > > > Hopefully addresses: > > > > > > 1. Michal's tracebacks. (Thanks for catching that. Sorry it needed > > > catching. :-/) > > > > > > 2. John's suggestion to pull out the re.compile. > > > > > > 3. Padraig's observation from pylint that my compare "functions" could > > > be functions. > > > > > > 4. Padraig's traceback. > > > > > > 5. Wrapped the re stuff in a try/except just in case. > > > > > > Please review. Thanks! > > > --joanie > > > > > > > > > > > > ___ pkg-discuss mailing list pkg-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
Re: [pkg-discuss] Code review: 11867 - Enable interactive search on PM tree views
Padraig O'Briain wrote: This works for me. However I am unhappy with having two calls to self.w_categories_treeview.set_search_column(). See webrev, http://cr.opensolaris.org/~padraig/ips-11867-v5/, for my proposed alternative, i.e. one call at line 1431. Yep nice optimization. Ran through tests again on this variant and all works fine. +1 JR Padraig On 11/16/09 16:20, Joanmarie Diggs wrote: Here's take 4: http://defect.opensolaris.org/bz/attachment.cgi?id=3031 Addresses: 1. We should also be catching re.error as well as TypeError. (Thanks John!) 2. Switching publishers causes the feature to fail in the category treeview. It turns out the search column was getting reset. (Thanks Michal!) --joanie On Mon, 2009-11-16 at 08:52 -0500, Joanmarie Diggs wrote: New patch: http://defect.opensolaris.org/bz/attachment.cgi?id=3025 Hopefully addresses: 1. Michal's tracebacks. (Thanks for catching that. Sorry it needed catching. :-/) 2. John's suggestion to pull out the re.compile. 3. Padraig's observation from pylint that my compare "functions" could be functions. 4. Padraig's traceback. 5. Wrapped the re stuff in a try/except just in case. Please review. Thanks! --joanie ___ pkg-discuss mailing list pkg-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
Re: [pkg-discuss] Code review: 11867 - Enable interactive search on PM tree views
Tested v4 against the gate. All coding issues addressed. Putting in all the various characters that caused issues before, switching between Pubs, testing within search results list for single and all. All works fine for me. +1 JR Joanmarie Diggs wrote: Here's take 4: http://defect.opensolaris.org/bz/attachment.cgi?id=3031 Addresses: 1. We should also be catching re.error as well as TypeError. (Thanks John!) 2. Switching publishers causes the feature to fail in the category treeview. It turns out the search column was getting reset. (Thanks Michal!) --joanie On Mon, 2009-11-16 at 08:52 -0500, Joanmarie Diggs wrote: New patch: http://defect.opensolaris.org/bz/attachment.cgi?id=3025 Hopefully addresses: 1. Michal's tracebacks. (Thanks for catching that. Sorry it needed catching. :-/) 2. John's suggestion to pull out the re.compile. 3. Padraig's observation from pylint that my compare "functions" could be functions. 4. Padraig's traceback. 5. Wrapped the re stuff in a try/except just in case. Please review. Thanks! --joanie ___ pkg-discuss mailing list pkg-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
Re: [pkg-discuss] Code review: 11867 - Enable interactive search on PM tree views
This works for me. However I am unhappy with having two calls to self.w_categories_treeview.set_search_column(). See webrev, http://cr.opensolaris.org/~padraig/ips-11867-v5/, for my proposed alternative, i.e. one call at line 1431. Padraig On 11/16/09 16:20, Joanmarie Diggs wrote: Here's take 4: http://defect.opensolaris.org/bz/attachment.cgi?id=3031 Addresses: 1. We should also be catching re.error as well as TypeError. (Thanks John!) 2. Switching publishers causes the feature to fail in the category treeview. It turns out the search column was getting reset. (Thanks Michal!) --joanie On Mon, 2009-11-16 at 08:52 -0500, Joanmarie Diggs wrote: New patch: http://defect.opensolaris.org/bz/attachment.cgi?id=3025 Hopefully addresses: 1. Michal's tracebacks. (Thanks for catching that. Sorry it needed catching. :-/) 2. John's suggestion to pull out the re.compile. 3. Padraig's observation from pylint that my compare "functions" could be functions. 4. Padraig's traceback. 5. Wrapped the re stuff in a try/except just in case. Please review. Thanks! --joanie ___ pkg-discuss mailing list pkg-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
Re: [pkg-discuss] Code review: 11867 - Enable interactive search on PM tree views
Here's take 4: http://defect.opensolaris.org/bz/attachment.cgi?id=3031 Addresses: 1. We should also be catching re.error as well as TypeError. (Thanks John!) 2. Switching publishers causes the feature to fail in the category treeview. It turns out the search column was getting reset. (Thanks Michal!) --joanie On Mon, 2009-11-16 at 08:52 -0500, Joanmarie Diggs wrote: > New patch: http://defect.opensolaris.org/bz/attachment.cgi?id=3025 > > Hopefully addresses: > > 1. Michal's tracebacks. (Thanks for catching that. Sorry it needed > catching. :-/) > > 2. John's suggestion to pull out the re.compile. > > 3. Padraig's observation from pylint that my compare "functions" could > be functions. > > 4. Padraig's traceback. > > 5. Wrapped the re stuff in a try/except just in case. > > Please review. Thanks! > --joanie > ___ pkg-discuss mailing list pkg-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
Re: [pkg-discuss] Code review: 11867 - Enable interactive search on PM tree views
Michal Pryc wrote: Joanmarie Diggs wrote: New patch: http://defect.opensolaris.org/bz/attachment.cgi?id=3025 Hopefully addresses: 1. Michal's tracebacks. (Thanks for catching that. Sorry it needed catching. :-/) 2. John's suggestion to pull out the re.compile. 3. Padraig's observation from pylint that my compare "functions" could be functions. 4. Padraig's traceback. 5. Wrapped the re stuff in a try/except just in case. Joanie, I don't see the errors in the terminal anymore - well done. One thing which is not working is the interactive search on Categories. When I start typing something the category got unselected, but it's not switching to the category which is supposed to be found. It works pretty well on the packages tree view. So: Go to the opensolaris.org, where there are many categories Type: Web Ser or: Go to the opensolaris.org, where there are many categories Type: Theming Nothing happens. Ok I think I found the problem. This happens ONLY when I did switch to another publisher and switch back. Probably the you need to reconnect the event function after the switch happens. best Michal ___ pkg-discuss mailing list pkg-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
Re: [pkg-discuss] Code review: 11867 - Enable interactive search on PM tree views
Joanmarie Diggs wrote: New patch: http://defect.opensolaris.org/bz/attachment.cgi?id=3025 Hopefully addresses: 1. Michal's tracebacks. (Thanks for catching that. Sorry it needed catching. :-/) 2. John's suggestion to pull out the re.compile. 3. Padraig's observation from pylint that my compare "functions" could be functions. 4. Padraig's traceback. 5. Wrapped the re stuff in a try/except just in case. Joanie - looks good, but on the possible exception raised: http://docs.python.org/library/re.html#re.error We should be catching re.error as well as TypeError. JR Please review. Thanks! --joanie ___ pkg-discuss mailing list pkg-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
Re: [pkg-discuss] Code review: 11867 - Enable interactive search on PM tree views
Joanmarie Diggs wrote: New patch: http://defect.opensolaris.org/bz/attachment.cgi?id=3025 Hopefully addresses: 1. Michal's tracebacks. (Thanks for catching that. Sorry it needed catching. :-/) 2. John's suggestion to pull out the re.compile. 3. Padraig's observation from pylint that my compare "functions" could be functions. 4. Padraig's traceback. 5. Wrapped the re stuff in a try/except just in case. Joanie, I don't see the errors in the terminal anymore - well done. One thing which is not working is the interactive search on Categories. When I start typing something the category got unselected, but it's not switching to the category which is supposed to be found. It works pretty well on the packages tree view. So: Go to the opensolaris.org, where there are many categories Type: Web Ser or: Go to the opensolaris.org, where there are many categories Type: Theming Nothing happens. best Michal Pryc ___ pkg-discuss mailing list pkg-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
Re: [pkg-discuss] Code review: 11867 - Enable interactive search on PM tree views
New patch: http://defect.opensolaris.org/bz/attachment.cgi?id=3025 Hopefully addresses: 1. Michal's tracebacks. (Thanks for catching that. Sorry it needed catching. :-/) 2. John's suggestion to pull out the re.compile. 3. Padraig's observation from pylint that my compare "functions" could be functions. 4. Padraig's traceback. 5. Wrapped the re stuff in a try/except just in case. Please review. Thanks! --joanie ___ pkg-discuss mailing list pkg-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
Re: [pkg-discuss] Code review: 11867 - Enable interactive search on PM tree views
On Mon, 2009-11-16 at 12:24 +, Padraig O'Briain wrote: > > > On 11/16/09 12:14, Joanmarie Diggs wrote: > > On Mon, 2009-11-16 at 12:10 +, John Rice wrote: > > > > > This is working for me, I don't see the problem Padraig reported. I do > > > see the traceback when typing '?'. I did test with ',.!!' and they all > > > worked, nice catch Michal. Should be wrapping this stuff in block to > > > catch re.exception and just return True if we catch one. > > > > > > > We could. And/or I could sleep more than I do. ;-) I should've used > > re.escape. 'Twas dumb of me. > > > > But what Padraig is seeing is puzzling me. Padraig, what build of > > OpenSolaris? > > > > > > I am on 127. I will try to replicate it after lunch. Aha! Just got it. Nice catch. Enjoy your lunch. :-) --joanie ___ pkg-discuss mailing list pkg-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
Re: [pkg-discuss] Code review: 11867 - Enable interactive search on PM tree views
On 11/16/09 12:14, Joanmarie Diggs wrote:
On Mon, 2009-11-16 at 12:10 +, John Rice wrote:
This is working for me, I don't see the problem Padraig reported. I do
see the traceback when typing '?'. I did test with ',.!!' and they all
worked, nice catch Michal. Should be wrapping this stuff in block to
catch re.exception and just return True if we catch one.
We could. And/or I could sleep more than I do. ;-) I should've used
re.escape. 'Twas dumb of me.
But what Padraig is seeing is puzzling me. Padraig, what build of
OpenSolaris?
I am on 127. I will try to replicate it after lunch.
Padraig
Joanie you could optimise:
REGEX_STRIP_BOLD = re.compile("<.{0,1}\w>")
By pulling this out and have it defined out of the class scope:
def __categoriestreeview_compare_func(self, model, column, key, itr):
+value = re.sub(REGEX_STRIP_BOLD, "", model.get_value(itr,
column))
+return re.match(key, value, re.IGNORECASE) is None
Okie dokie. Thanks!
--joanie
___
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
Re: [pkg-discuss] Code review: 11867 - Enable interactive search on PM tree views
On Mon, 2009-11-16 at 12:10 +, John Rice wrote:
> This is working for me, I don't see the problem Padraig reported. I do
> see the traceback when typing '?'. I did test with ',.!!' and they all
> worked, nice catch Michal. Should be wrapping this stuff in block to
> catch re.exception and just return True if we catch one.
We could. And/or I could sleep more than I do. ;-) I should've used
re.escape. 'Twas dumb of me.
But what Padraig is seeing is puzzling me. Padraig, what build of
OpenSolaris?
> Joanie you could optimise:
>
> REGEX_STRIP_BOLD = re.compile("<.{0,1}\w>")
>
> By pulling this out and have it defined out of the class scope:
>
> def __categoriestreeview_compare_func(self, model, column, key, itr):
> +value = re.sub(REGEX_STRIP_BOLD, "", model.get_value(itr,
> column))
> +return re.match(key, value, re.IGNORECASE) is None
Okie dokie. Thanks!
--joanie
___
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
Re: [pkg-discuss] Code review: 11867 - Enable interactive search on PM tree views
Michal Pryc wrote: Joanmarie Diggs wrote: This is great, with one minor nit, when typing different characters I am getting different tracebacks in the terminal, probably we could ignore them as they do not affect PM functionality: I disagree. Tracebacks are bad. I'll fix it. What I meant is to try/except those and pass some of the errors, but fixing is the best. This function acts on name only. Because we will have descriptions with the new list api, should we also operate on descriptions IF the name was not found? I'm not sure. But lemme know what you think, and I'll see what I can do I don't have strong opinion, John what do you think? Michal For now lets stick with names, might be confusing to user to include descriptions, may also have a performance hit on larger lists. JR ___ pkg-discuss mailing list pkg-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
Re: [pkg-discuss] Code review: 11867 - Enable interactive search on PM tree views
This is working for me, I don't see the problem Padraig reported. I do
see the traceback when typing '?'. I did test with ',.!!' and they all
worked, nice catch Michal. Should be wrapping this stuff in block to
catch re.exception and just return True if we catch one.
Joanie you could optimise:
REGEX_STRIP_BOLD = re.compile("<.{0,1}\w>")
By pulling this out and have it defined out of the class scope:
def __categoriestreeview_compare_func(self, model, column, key, itr):
+value = re.sub(REGEX_STRIP_BOLD, "", model.get_value(itr,
column))
+return re.match(key, value, re.IGNORECASE) is None
Thanks.
JR
Joanmarie Diggs wrote:
Hi Michal.
Thanks for the review! It did occur to me to test accented letters and
other locales; it didn't occur to me to type punctuation. :-)
This is great, with one minor nit, when typing different characters I am
getting different tracebacks in the terminal, probably we could ignore
them as they do not affect PM functionality:
I disagree. Tracebacks are bad. I'll fix it.
This function acts on name only. Because we will have descriptions with
the new list api, should we also operate on descriptions IF the name was
not found?
I'm not sure. But lemme know what you think, and I'll see what I can do.
Take care.
--joanie
___
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
Re: [pkg-discuss] Code review: 11867 - Enable interactive search on PM tree views
On 11/16/09 11:58, Joanmarie Diggs wrote:
On Mon, 2009-11-16 at 11:46 +, Padraig O'Briain wrote:
I think it is more serious. When I type f I get
Traceback (most recent call last):
File "/export/home/padraig/11867_clone/src/packagemanager.py", line
2821, in __categoriestreeview_compare_func
value = re.sub(re.compile("<.{0,1}\w>"), "", model.get_value(itr,
column))
File "/usr/lib/python2.4/sre.py", line 142, in sub
return _compile(pattern, 0).sub(repl, string, count)
TypeError: expected string or buffer
This I'm not seeing. But I'll see what I can do and post a new patch
soon.
When I ran pylint on packagemanager.py I got
R:2820:PackageManager.__categoriestreeview_compare_func: Method could be
a function
R:2932:PackageManager.__applicationtreeview_compare_func: Method could
be a function
I've been meaning to ask, what command are you giving specifically, what
pylintrc file are you using, etc.?
pylint --rcfile=tests/gui_pylintrc packagemanager.py
Thanks!
___
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
Re: [pkg-discuss] Code review: 11867 - Enable interactive search on PM tree views
Joanmarie Diggs wrote: This is great, with one minor nit, when typing different characters I am getting different tracebacks in the terminal, probably we could ignore them as they do not affect PM functionality: I disagree. Tracebacks are bad. I'll fix it. What I meant is to try/except those and pass some of the errors, but fixing is the best. This function acts on name only. Because we will have descriptions with the new list api, should we also operate on descriptions IF the name was not found? I'm not sure. But lemme know what you think, and I'll see what I can do I don't have strong opinion, John what do you think? Michal ___ pkg-discuss mailing list pkg-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
Re: [pkg-discuss] Code review: 11867 - Enable interactive search on PM tree views
On Mon, 2009-11-16 at 11:46 +, Padraig O'Briain wrote:
> I think it is more serious. When I type f I get
>
> Traceback (most recent call last):
> File "/export/home/padraig/11867_clone/src/packagemanager.py", line
> 2821, in __categoriestreeview_compare_func
> value = re.sub(re.compile("<.{0,1}\w>"), "", model.get_value(itr,
> column))
> File "/usr/lib/python2.4/sre.py", line 142, in sub
> return _compile(pattern, 0).sub(repl, string, count)
> TypeError: expected string or buffer
This I'm not seeing. But I'll see what I can do and post a new patch
soon.
> When I ran pylint on packagemanager.py I got
>
> R:2820:PackageManager.__categoriestreeview_compare_func: Method could be
> a function
> R:2932:PackageManager.__applicationtreeview_compare_func: Method could
> be a function
I've been meaning to ask, what command are you giving specifically, what
pylintrc file are you using, etc.?
Thanks!
___
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
Re: [pkg-discuss] Code review: 11867 - Enable interactive search on PM tree views
Hi Michal. Thanks for the review! It did occur to me to test accented letters and other locales; it didn't occur to me to type punctuation. :-) > This is great, with one minor nit, when typing different characters I am > getting different tracebacks in the terminal, probably we could ignore > them as they do not affect PM functionality: I disagree. Tracebacks are bad. I'll fix it. > This function acts on name only. Because we will have descriptions with > the new list api, should we also operate on descriptions IF the name was > not found? I'm not sure. But lemme know what you think, and I'll see what I can do. Take care. --joanie ___ pkg-discuss mailing list pkg-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
Re: [pkg-discuss] Code review: 11867 - Enable interactive search on PM tree views
Michal Pryc wrote:
John Rice wrote:
I am proposing a patch from Joanie to enable built in GTK TreeView
interactive search support for the Category and List Views in PM.
When focused in the Category or List just start typing and a GTK
interactive search box pops up. Very handy on long lists in the views.
I have tested and reviewed it. Padraig can you take a quick look.
http://defect.opensolaris.org/bz/attachment.cgi?id=3021
11867 Enable interactive search on PM tree views
Thanks Joanie for the contribution.
This is great, with one minor nit, when typing different characters I
am getting different tracebacks in the terminal, probably we could
ignore them as they do not affect PM functionality:
I think it is more serious. When I type f I get
Traceback (most recent call last):
File "/export/home/padraig/11867_clone/src/packagemanager.py", line
2821, in __categoriestreeview_compare_func
value = re.sub(re.compile("<.{0,1}\w>"), "", model.get_value(itr,
column))
File "/usr/lib/python2.4/sre.py", line 142, in sub
return _compile(pattern, 0).sub(repl, string, count)
TypeError: expected string or buffer
When I ran pylint on packagemanager.py I got
R:2820:PackageManager.__categoriestreeview_compare_func: Method could be
a function
R:2932:PackageManager.__applicationtreeview_compare_func: Method could
be a function
Padraig
Typing: ))
Traceback (most recent call last):
File "/tmp/packagemanager.py", line 2782, in
__categoriestreeview_compare_func
return re.match(key, value, re.IGNORECASE) is None
File "/usr/lib/python2.4/sre.py", line 129, in match
return _compile(pattern, flags).match(string)
File "/usr/lib/python2.4/sre.py", line 227, in _compile
raise error, v # invalid expression
sre_constants.error: unbalanced parenthesis
Typing: [[
Traceback (most recent call last):
File "/tmp/packagemanager.py", line 2782, in
__categoriestreeview_compare_func
return re.match(key, value, re.IGNORECASE) is None
File "/usr/lib/python2.4/sre.py", line 129, in match
return _compile(pattern, flags).match(string)
File "/usr/lib/python2.4/sre.py", line 227, in _compile
raise error, v # invalid expression
sre_constants.error: unexpected end of regular expression
Typing: **
or Typing: ?
Traceback (most recent call last):
File "/tmp/packagemanager.py", line 2782, in
__categoriestreeview_compare_func
return re.match(key, value, re.IGNORECASE) is None
File "/usr/lib/python2.4/sre.py", line 129, in match
return _compile(pattern, flags).match(string)
File "/usr/lib/python2.4/sre.py", line 227, in _compile
raise error, v # invalid expression
sre_constants.error: nothing to repeat
This function acts on name only. Because we will have descriptions
with the new list api, should we also operate on descriptions IF the
name was not found?
best
Michal
___
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
Re: [pkg-discuss] Code review: 11867 - Enable interactive search on PM tree views
John Rice wrote: I am proposing a patch from Joanie to enable built in GTK TreeView interactive search support for the Category and List Views in PM. When focused in the Category or List just start typing and a GTK interactive search box pops up. Very handy on long lists in the views. I have tested and reviewed it. Padraig can you take a quick look. http://defect.opensolaris.org/bz/attachment.cgi?id=3021 11867 Enable interactive search on PM tree views Thanks Joanie for the contribution. This is great, with one minor nit, when typing different characters I am getting different tracebacks in the terminal, probably we could ignore them as they do not affect PM functionality: Typing: )) Traceback (most recent call last): File "/tmp/packagemanager.py", line 2782, in __categoriestreeview_compare_func return re.match(key, value, re.IGNORECASE) is None File "/usr/lib/python2.4/sre.py", line 129, in match return _compile(pattern, flags).match(string) File "/usr/lib/python2.4/sre.py", line 227, in _compile raise error, v # invalid expression sre_constants.error: unbalanced parenthesis Typing: [[ Traceback (most recent call last): File "/tmp/packagemanager.py", line 2782, in __categoriestreeview_compare_func return re.match(key, value, re.IGNORECASE) is None File "/usr/lib/python2.4/sre.py", line 129, in match return _compile(pattern, flags).match(string) File "/usr/lib/python2.4/sre.py", line 227, in _compile raise error, v # invalid expression sre_constants.error: unexpected end of regular expression Typing: ** or Typing: ? Traceback (most recent call last): File "/tmp/packagemanager.py", line 2782, in __categoriestreeview_compare_func return re.match(key, value, re.IGNORECASE) is None File "/usr/lib/python2.4/sre.py", line 129, in match return _compile(pattern, flags).match(string) File "/usr/lib/python2.4/sre.py", line 227, in _compile raise error, v # invalid expression sre_constants.error: nothing to repeat This function acts on name only. Because we will have descriptions with the new list api, should we also operate on descriptions IF the name was not found? best Michal ___ pkg-discuss mailing list pkg-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
Re: [pkg-discuss] Code review: 11867 Enable interactive search on PM tree views
How is this current webrev supposed to work? If I have selection on "Applications" and type 'd' the selection is removed and the list of packages is changed after what seems like a long time (I assume 600 milliseconds) to what would be displayed for "All Categories". Padraig On 10/13/09 03:45, Joanmarie Diggs wrote: Hey John. Sweet!! I will use this constantly. Any chance of pulling off this functionality for the list of packages as well? I would think that you could keep it simple: After all, you've only got two visible text columns and only one (Name) is really of interest for interactive search. For me personally, the new category interactive search will be what I use when I want to browse (in the generic sense of the word) or when I'm not sure what the name of a desired package is. Any time I do a fresh install, however, I want ss-dev, the SUNWxscreensaver stuff, and a bunch of packages which start with 'SUNWg'. It would be extremely cool to be able to select All Categories, move focus to the packages list, and then jump to desired items by typing. Regardless, thank you so much for this one! Take care. --joanie On Mon, 2009-10-12 at 19:30 +0100, John Rice wrote: Joanie - here's a fix to enable search in the category tree and allow faster keyboard navigation by making category selection do a lazy update. webrev: http://cr.opensolaris.org/~jmr/pm_interactive_categorytree_search_11867_12Oct_325pm/ bug: 11867 Enable interactive search on PM tree views JR ___ pkg-discuss mailing list pkg-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/pkg-discuss ___ pkg-discuss mailing list pkg-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
Re: [pkg-discuss] Code review: 11867 Enable interactive search on PM tree views
Hey John. Sweet!! I will use this constantly. Any chance of pulling off this functionality for the list of packages as well? I would think that you could keep it simple: After all, you've only got two visible text columns and only one (Name) is really of interest for interactive search. For me personally, the new category interactive search will be what I use when I want to browse (in the generic sense of the word) or when I'm not sure what the name of a desired package is. Any time I do a fresh install, however, I want ss-dev, the SUNWxscreensaver stuff, and a bunch of packages which start with 'SUNWg'. It would be extremely cool to be able to select All Categories, move focus to the packages list, and then jump to desired items by typing. Regardless, thank you so much for this one! Take care. --joanie On Mon, 2009-10-12 at 19:30 +0100, John Rice wrote: > Joanie - here's a fix to enable search in the category tree and allow > faster keyboard navigation by making category selection do a lazy update. > > webrev: > http://cr.opensolaris.org/~jmr/pm_interactive_categorytree_search_11867_12Oct_325pm/ > bug: 11867 Enable interactive search on PM tree views > > JR ___ pkg-discuss mailing list pkg-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
