Re: [pkg-discuss] Code review: bug #9002 - check_classifications.txt should be adjusted for new post 2008.11 classifications.
david.co...@sun.com wrote: 9115: GUI Package Manager should read classifications from depot .../_resources/classifications file. http://defect.opensolaris.org/bz/show_bug.cgi?id=9115 Actually, I would rather the underlying issue of leveraging a static file be fixed instead. Instead, what I'd like to see in the meantime is a single static sections files - the master copy is what can be served up by the depot and the PM file should be auto-generated from it as part of the build process. I added your comment to bug #9115. From Shawn's earlier commentary, it looks like we are heading towards a static file "located somewhere centrally (like a DTD would be) on opensolaris.org (similar to how DTDs work) or on opensolaris.com or on sun.com." When somebody tells me where/what that file is, and how I can easily edit it, then this bug can be adjusted accordingly. 9116: gen_os_files.py should no longer generate the opensolaris.org.sections file. http://defect.opensolaris.org/bz/show_bug.cgi?id=9116 I'm confused? Does gen_os_files.py generate that file or use that along with the data in the import files? It generates it. ___ pkg-discuss mailing list pkg-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
Re: [pkg-discuss] Code review: bug #9002 - check_classifications.txt should be adjusted for new post 2008.11 classifications.
9115: GUI Package Manager should read classifications from depot .../_resources/classifications file. http://defect.opensolaris.org/bz/show_bug.cgi?id=9115 Actually, I would rather the underlying issue of leveraging a static file be fixed instead. Instead, what I'd like to see in the meantime is a single static sections files - the master copy is what can be served up by the depot and the PM file should be auto-generated from it as part of the build process. 9116: gen_os_files.py should no longer generate the opensolaris.org.sections file. http://defect.opensolaris.org/bz/show_bug.cgi?id=9116 I'm confused? Does gen_os_files.py generate that file or use that along with the data in the import files? ___ pkg-discuss mailing list pkg-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
Re: [pkg-discuss] Code review: bug #9002 - check_classifications.txt should be adjusted for new post 2008.11 classifications.
Rich Burridge wrote: As far as I'm concerned, it's data that should be the same, irrespective of the repository or the publisher. It's the de-facto set of classifications for all OpenSolaris packages. Over time, it will be added to, but it's what we've got now. We need to put this in a place where package publishing software such as Source Juicer can get at it. If it's not being served up by a depot, then where should it go? Okay, I don't think that has been clear so far. If this is a reference document, it can't be served up from the web directory of a repository, as that is customisable by an administrator (via --content-root) so we can't guarantee the file will be there or contain the correct data. So, this needs to be located somewhere centrally (like a DTD would be) on opensolaris.org (similar to how DTDs work) or on opensolaris.com or on sun.com. I'm assuming that is desirable anyway, as you don't want to tie updates of the classification file to updates of the depot software? Cheers, -- Shawn Walker ___ pkg-discuss mailing list pkg-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
Re: [pkg-discuss] Code review: bug #9002 - check_classifications.txt should be adjusted for new post 2008.11 classifications.
Shawn Walker wrote: Rich Burridge wrote: Danek Duvall wrote: http://cr.opensolaris.org/~richb/pkg-9002-v1/ I share David's concerns, but want to add -- is there a reason that the file is .txt, rather than (say) extensionless? New webrev, moving "classifications.txt" to "classifications" at: http://cr.opensolaris.org/~richb/pkg-9002-v2/ Okay, I'm going to throw a monkey wrench in the works here and ask if this is data that clients expect to be able to retrieve from a standard location. If it is, is it: * data that the repository should be serving because it is specific to a repository? * data that is specific to a publisher, but not a repository? * data that all pkg clients on OpenSolaris should use, and so, is platform specific? * data that all pkg clients should use, and so should be distributed with the software and updated through software updates? As far as I'm concerned, it's data that should be the same, irrespective of the repository or the publisher. It's the de-facto set of classifications for all OpenSolaris packages. Over time, it will be added to, but it's what we've got now. We need to put this in a place where package publishing software such as Source Juicer can get at it. If it's not being served up by a depot, then where should it go? ___ pkg-discuss mailing list pkg-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
Re: [pkg-discuss] Code review: bug #9002 - check_classifications.txt should be adjusted for new post 2008.11 classifications.
Michal Pryc wrote: ... The question for you: Can the GUI Package Manager code be adjusted to read in this file instead of opensolaris.org.sections? I am pretty sure it can be, but not for 2009.06. Good. I've opened two new bugs: 9115: GUI Package Manager should read classifications from depot .../_resources/classifications file. http://defect.opensolaris.org/bz/show_bug.cgi?id=9115 9116: gen_os_files.py should no longer generate the opensolaris.org.sections file. http://defect.opensolaris.org/bz/show_bug.cgi?id=9116 Thanks. ___ pkg-discuss mailing list pkg-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
Re: [pkg-discuss] Code review: bug #9002 - check_classifications.txt should be adjusted for new post 2008.11 classifications.
Rich Burridge wrote: Danek Duvall wrote: http://cr.opensolaris.org/~richb/pkg-9002-v1/ I share David's concerns, but want to add -- is there a reason that the file is .txt, rather than (say) extensionless? New webrev, moving "classifications.txt" to "classifications" at: http://cr.opensolaris.org/~richb/pkg-9002-v2/ Okay, I'm going to throw a monkey wrench in the works here and ask if this is data that clients expect to be able to retrieve from a standard location. If it is, is it: * data that the repository should be serving because it is specific to a repository? * data that is specific to a publisher, but not a repository? * data that all pkg clients on OpenSolaris should use, and so, is platform specific? * data that all pkg clients should use, and so should be distributed with the software and updated through software updates? Cheers, -- Shawn Walker ___ pkg-discuss mailing list pkg-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
Re: [pkg-discuss] Code review: bug #9002 - check_classifications.txt should be adjusted for new post 2008.11 classifications.
Danek Duvall wrote: http://cr.opensolaris.org/~richb/pkg-9002-v1/ I share David's concerns, but want to add -- is there a reason that the file is .txt, rather than (say) extensionless? New webrev, moving "classifications.txt" to "classifications" at: http://cr.opensolaris.org/~richb/pkg-9002-v2/ Thanks. ___ pkg-discuss mailing list pkg-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
Re: [pkg-discuss] Code review: bug #9002 - check_classifications.txt should be adjusted for new post 2008.11 classifications.
Rich Burridge wrote: Michal Pryc wrote: ... Understood but I don't believe src/gui/data/opensolaris.org.sections needs to be limited at the moment to just the ones being used by the import files, right? I don't think so, but John or Michal are probably the best people to answer that. The publisher.sections file is describing relationship between categories and sections (please see attached two files to understand what I am calling section and category). So for example if the category Games is in the section Applications then in the file publisher.sections there need to be relation Games belongs to Applications. The sections are predefined and cannot be changed dynamically, but publisher owners can define to which sections their categories belongs using publisher.sections file. This file is per publisher, so that is why we do have opensolaris.org.sections, because our publisher is called opensolaris.org. Another file src/gui/data/opensolaris.org is describing relations between packages and categories. For example SUNWgnome-games belongs to the Games category. As far as I know there is script which generates opensolaris.org.sections and opensolaris.org files while those are published to the repository, but I am not 100% sure. Is that answaring your question? No. Please have a look at the webrev at: http://cr.opensolaris.org/~richb/pkg-9002-v1/ In there you will see a new file called .../src/web/_resources/classifications.txt (soon to be called .../src/web/_resources/classifications). It will be served up by IPS package depots (such as http://pkg.opensolaris.org/release/_resources/classifications). It shows the classifications (categories/subcategories) in a format that would be read with something like: import simplejson import urllib2 ... self.class_url = "http://pkg.opensolaris.org/release/_resources/classifications"; ... try: fileobj = urllib2.urlopen(self.class_url) self.categories = simplejson.load(fileobj) except (ValueError, urllib2.HTTPError), e: print >> sys.stderr, "Unable to get package classifications.", e sys.exit(3) The script .../gate/src/util/distro_import/check_classifications.py has been modified (as part of the same webrev) to use it. The Source Juicer folks would change their code to do the same. The question for you: Can the GUI Package Manager code be adjusted to read in this file instead of opensolaris.org.sections? I am pretty sure it can be, but not for 2009.06. Michal Pryc ___ pkg-discuss mailing list pkg-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
Re: [pkg-discuss] Code review: bug #9002 - check_classifications.txt should be adjusted for new post 2008.11 classifications.
Michal Pryc wrote: ... Understood but I don't believe src/gui/data/opensolaris.org.sections needs to be limited at the moment to just the ones being used by the import files, right? I don't think so, but John or Michal are probably the best people to answer that. The publisher.sections file is describing relationship between categories and sections (please see attached two files to understand what I am calling section and category). So for example if the category Games is in the section Applications then in the file publisher.sections there need to be relation Games belongs to Applications. The sections are predefined and cannot be changed dynamically, but publisher owners can define to which sections their categories belongs using publisher.sections file. This file is per publisher, so that is why we do have opensolaris.org.sections, because our publisher is called opensolaris.org. Another file src/gui/data/opensolaris.org is describing relations between packages and categories. For example SUNWgnome-games belongs to the Games category. As far as I know there is script which generates opensolaris.org.sections and opensolaris.org files while those are published to the repository, but I am not 100% sure. Is that answaring your question? No. Please have a look at the webrev at: http://cr.opensolaris.org/~richb/pkg-9002-v1/ In there you will see a new file called .../src/web/_resources/classifications.txt (soon to be called .../src/web/_resources/classifications). It will be served up by IPS package depots (such as http://pkg.opensolaris.org/release/_resources/classifications). It shows the classifications (categories/subcategories) in a format that would be read with something like: import simplejson import urllib2 ... self.class_url = "http://pkg.opensolaris.org/release/_resources/classifications"; ... try: fileobj = urllib2.urlopen(self.class_url) self.categories = simplejson.load(fileobj) except (ValueError, urllib2.HTTPError), e: print >> sys.stderr, "Unable to get package classifications.", e sys.exit(3) The script .../gate/src/util/distro_import/check_classifications.py has been modified (as part of the same webrev) to use it. The Source Juicer folks would change their code to do the same. The question for you: Can the GUI Package Manager code be adjusted to read in this file instead of opensolaris.org.sections? ___ pkg-discuss mailing list pkg-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
Re: [pkg-discuss] Code review: bug #9002 - check_classifications.txt should be adjusted for new post 2008.11 classifications.
Danek Duvall wrote: On Thu, May 21, 2009 at 07:25:36AM -0700, Rich Burridge wrote: http://cr.opensolaris.org/~richb/pkg-9002-v1/ I share David's concerns, but want to add -- is there a reason that the file is .txt, rather than (say) extensionless? No. It can be whatever you want it to be. ___ pkg-discuss mailing list pkg-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
Re: [pkg-discuss] Code review: bug #9002 - check_classifications.txt should be adjusted for new post 2008.11 classifications.
On Thu, May 21, 2009 at 07:25:36AM -0700, Rich Burridge wrote: > http://cr.opensolaris.org/~richb/pkg-9002-v1/ I share David's concerns, but want to add -- is there a reason that the file is .txt, rather than (say) extensionless? Danek ___ pkg-discuss mailing list pkg-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
Re: [pkg-discuss] Code review: bug #9002 - check_classifications.txt should be adjusted for new post 2008.11 classifications.
david.co...@sun.com wrote: Isn't there a duplication of data here in the workspace between src/web/_resources/classifications.txt and src/gui/data/opensolaris.org.sections? There is a slight difference. .../src/web/_resources/classifications.txt gives all the categories/sub-categories that Frank (and others) have specified. Understood but I don't believe src/gui/data/opensolaris.org.sections needs to be limited at the moment to just the ones being used by the import files, right? I don't think so, but John or Michal are probably the best people to answer that. ___ pkg-discuss mailing list pkg-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
Re: [pkg-discuss] Code review: bug #9002 - check_classifications.txt should be adjusted for new post 2008.11 classifications.
Isn't there a duplication of data here in the workspace between src/web/_resources/classifications.txt and src/gui/data/opensolaris.org.sections? There is a slight difference. .../src/web/_resources/classifications.txt gives all the categories/sub-categories that Frank (and others) have specified. Understood but I don't believe src/gui/data/opensolaris.org.sections needs to be limited at the moment to just the ones being used by the import files, right? ___ pkg-discuss mailing list pkg-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
Re: [pkg-discuss] Code review: bug #9002 - check_classifications.txt should be adjusted for new post 2008.11 classifications.
david.co...@sun.com wrote: http://defect.opensolaris.org/bz/show_bug.cgi?id=9002 check_classifications.txt should be adjusted for new post 2008.11 classifications. Webrev is at: http://cr.opensolaris.org/~richb/pkg-9002-v1/ Isn't there a duplication of data here in the workspace between src/web/_resources/classifications.txt and src/gui/data/opensolaris.org.sections? There is a slight difference. .../src/web/_resources/classifications.txt gives all the categories/sub-categories that Frank (and others) have specified. opensolaris.org.sections gives all the categories/sub-categories currently used by the existing IPS package definition files under .../gate/src/util/distro-import//[common,i386,sparc]/ and .../gate/src/util/distro-import/unbundleds/ in the pkg source workspace. Please let me know if you think a new bug should be filed for the GUI Package Manager code to use .../src/web/_resources/classifications.txt rather than opensolaris.org.sections ___ pkg-discuss mailing list pkg-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
Re: [pkg-discuss] Code review: bug #9002 - check_classifications.txt should be adjusted for new post 2008.11 classifications.
http://defect.opensolaris.org/bz/show_bug.cgi?id=9002 check_classifications.txt should be adjusted for new post 2008.11 classifications. Webrev is at: http://cr.opensolaris.org/~richb/pkg-9002-v1/ Isn't there a duplication of data here in the workspace between src/web/_resources/classifications.txt and src/gui/data/opensolaris.org.sections? ___ pkg-discuss mailing list pkg-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
