I got feedback from Knut:
"I also needed to install SUNWgnome-python-extras in order to get it working
(couldn't find the gtkmozembed module without it). I don't see that it was
added as a dependency in the webrev. Maybe it's implicit because of some of the
other dependencies, but I thought I'd mention it."
It wasn't implicit, so here's a modified webrev:
http://cr.opensolaris.org/~richb/pkg-6664-v2/
Thanks.
Original Message
Subject: [pkg-discuss] Code review request for opensolaris packaging
bugs #6664, #6665 and #6671
Date: Wed, 18 Feb 2009 10:07:36 -0800
From: Rich Burridge
To: pkg discuss
Hi all,
Looking for a code review of the proposed changes for
fixing bugs #6664, #6665 and #6671:
http://defect.opensolaris.org/bz/show_bug.cgi?id=6664
SUNWcodeina missing dependencies
http://defect.opensolaris.org/bz/show_bug.cgi?id=6665
SUNWpython-twisted has missing dependencies
http://defect.opensolaris.org/bz/show_bug.cgi?id=6671
rpcgen and cpp
Webrev is at:
http://cr.opensolaris.org/~richb/pkg-6664-v1/
More information:
Bug #6664
Looking at the original SVR4 package depend file for SUNWcodeina
for WOS build #108, it has the following dependency lines (not
counting the Core ones):
P SUNWgnome-python-libs Python support libraries for GNOME
P SUNWgnome-media GNOME streaming media framework
P SUNWgst-python Python bindings for the GStreamer streaming media framework
P SUNWpyyaml24 A YAML parser and emitter for the Python language
P SUNWpython-notify Python bindings for libnotify
P SUNWpython-twisted Event-based framework for internet applications
None of these are found by the dependency checking in
solaris.py, so I've added in depend lines for each of them.
I've also added in a depend line for SUNWpython-xdg.
As that latter dependency isn't mentioned in the SVR4 package
depend file, we should probably open a bug in Bugster to get
this fixed there too.
(Note the dependency on SUNWPython is now automatically picked
up by the dependency in the SUNWpython-twisted package -- see below).
--
Bug #6665
Looking at the original SVR4 package depend file for
SUNWpython-twisted for WOS build #108, it has the following
dependency lines (not counting the Core ones):
P SUNWPython The Python interpreter, libraries and utilities
This is currently not found by the dependency checking in solaris.py,
so I've added in a depend line for it. There is no mention of a
Zope dependency, but there clearly is one. I've added a depend line
for SUNWpython-zope-interface. As it isn't mentioned in the SVR4
package depend file, we should probably open a bug in Bugster to
get this fixed there too.
--
Bug #6671
Looking at the original SVR4 package depend file for SUNWbtool
for WOS build #108, it has the following dependency lines (not
counting the Core ones):
P SUNWtecla Tecla command-line editing library
P SUNWperl584core Perl 5.8.4 (core)
The SUNWtecla one is automatically found by the solaris.py
dependency checker. I've added in a depend line for SUNWperl584core
and one for SUNWcpp. As the latter isn't mentioned in the SVR4
package depend file, we should probably open a bug in Bugster to
get this fixed there too.
Thanks.
___
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
___
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
