Re: [pkg-go] Go 1.10 build/test failures

2018-02-16 Thread Michael Stapelberg
I uploaded fixes for: • golang-github-julienschmidt-httprouter • golang-gopkg-macaroon-bakery.v2 • golang-github-asaskevich-govalidator …and a new upstream version for golang-golang-x-oauth2, which fixes the test failure. …and filed upstream issues for: •

Re: [pkg-go] Go 1.10 build/test failures

2018-02-15 Thread Michael Stapelberg
Here’s one more, which my tooling couldn’t find before due to an unrelated bug: golang-github-asaskevich-govalidator --- FAIL: TestIsRequestURI (0.00s) validator_test.go:736: Expected IsRequestURI("irc://#channel@network") to be true, got false --- FAIL: TestIsRequestURL (0.00s)

[pkg-go] Go 1.10 build/test failures

2018-02-15 Thread Michael Stapelberg
Hey, I did a quick rebuild of our packages with Go 1.10 (I plan to write in more detail about the infrastructure I used in the next few days) and noticed the following new failures: no longer compiles: github.com/gopherjs/gopherjs. error exit status 2 no longer passes tests: