Re: [pkg-go] [PATCH] Compute Built-Using with go list, not Build-Depends

2016-04-14 Thread Michael Hudson-Doyle
On 15 April 2016 at 03:55, Martín Ferrari wrote: > On 14/04/16 01:43, Michael Hudson-Doyle wrote: >> Built-Using for a binary is meant to include all packages that are included >> in >> the binary itself, but using Build-Depends only pulls in the direct >> dependencies. Use go list and dpkg-query

Re: [pkg-go] [PATCH] Compute Built-Using with go list, not Build-Depends

2016-04-14 Thread Tianon Gravi
On 14 April 2016 at 15:50, Michael Hudson-Doyle wrote: > Yeah, that's the problem. I was testing with a package that set GOPATH in > rules :-( I sent the same fix to the bug, or at least tried to... Oh yep, you totally did: https://bugs.debian.org/821000#20 (which reminds me that I need to subsc

Re: [pkg-go] [PATCH] Compute Built-Using with go list, not Build-Depends

2016-04-14 Thread Michael Hudson-Doyle
On 15/04/2016 10:48 am, "Tianon Gravi" wrote: > > On 14 April 2016 at 15:46, Tianon Gravi wrote: > > I think this block is why that latest upload is causing everything to > > fail to build -- we removed GOPATH from "sub build", but didn't add > > "_set_gopath" like we did down in "sub test" to re

Re: [pkg-go] [PATCH] Compute Built-Using with go list, not Build-Depends

2016-04-14 Thread Tianon Gravi
On 14 April 2016 at 15:46, Tianon Gravi wrote: > I think this block is why that latest upload is causing everything to > fail to build -- we removed GOPATH from "sub build", but didn't add > "_set_gopath" like we did down in "sub test" to replace it, ala: (and I'm happy to actually commit and upl

Re: [pkg-go] [PATCH] Compute Built-Using with go list, not Build-Depends

2016-04-14 Thread Tianon Gravi
On 13 April 2016 at 17:43, Michael Hudson-Doyle wrote: > @@ -156,7 +161,6 @@ sub get_targets { > sub build { > my $this = shift; > > -$ENV{GOPATH} = $this->{cwd} . '/' . $this->get_builddir(); > if (exists($ENV{DH_GOLANG_GO_GENERATE}) && $ENV{DH_GOLANG_GO_GENERATE} > == 1) { >

Re: [pkg-go] [PATCH] Compute Built-Using with go list, not Build-Depends

2016-04-14 Thread Martín Ferrari
On 14/04/16 01:43, Michael Hudson-Doyle wrote: > Built-Using for a binary is meant to include all packages that are included in > the binary itself, but using Build-Depends only pulls in the direct > dependencies. Use go list and dpkg-query --search instead to find out which > (debian) packages ins

[pkg-go] [PATCH] Compute Built-Using with go list, not Build-Depends

2016-04-13 Thread Michael Hudson-Doyle
Built-Using for a binary is meant to include all packages that are included in the binary itself, but using Build-Depends only pulls in the direct dependencies. Use go list and dpkg-query --search instead to find out which (debian) packages installed the (go) packages that were actually used during