Your message dated Fri, 17 Jul 2015 21:06:50 +0000
with message-id 
<CANnVG6kZAh=jaciqt+wbgs_yznguq5ixezvevjpznttfhuh...@mail.gmail.com>
and subject line Re: [pkg-go] Bug#792704: etcd: Allow etcd configuration with 
systemd unit file
has caused the Debian Bug report #792704,
regarding etcd: Allow etcd configuration with systemd unit file
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
792704: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=792704
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: etcd
Version: 2.0.8-2
Severity: wishlist

Dear Maintainer,

The systemd unit file hard codes a working dir and name. It does not have any 
mechanism for additional configuration. Personally I like the Fedora systemd 
unit file

http://pkgs.fedoraproject.org/cgit/etcd.git/tree/etcd.service

Which uses /etc/etcd/etcd.conf as the ENV file.

The sysinit scripts use /etc/default/etcd but the ENV keys in that file are not 
the ENV keys which etcd pays attention to. But there should be some way, when 
using systemd to configure it.

I got my instalation to work by just putting the Fedora .service file into 
/etc/systemd/system, but a reasonable default in /lib seems like a good idea.

-- System Information:
Debian Release: 8.1
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 3.16.0-4-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages etcd depends on:
ii  adduser  3.113+nmu3
ii  libc6    2.19-18

etcd recommends no packages.

etcd suggests no packages.

-- Configuration Files:
/etc/default/etcd changed [not included]
/etc/init.d/etcd changed [not included]

-- no debconf information

--- End Message ---
--- Begin Message ---
Closing the bug as we’ve found a solution.

On Fri, Jul 17, 2015 at 9:01 PM, Paris, Eric <epa...@parisplace.org> wrote:

> Fair enough!
>
> On Fri, Jul 17, 2015 at 4:00 PM, Michael Stapelberg
> <stapelb...@debian.org> wrote:
> > I understand that you like environment files better, but they are not
> > systemd’s idiomatic mechanism for overwriting configuration directives.
> >
> > I feel like we should not have etcd be a special case here just to
> > accomodate personal, subjective taste. Consider that systemd’s mechanism
> > works for every single service file, whereas with your suggestion, we’d
> need
> > to _modify_ every single service file in Debian — that does not strike
> me as
> > a good approach.
> >
> > If you think Debian should generally use environment files to customize
> > systemd service files, feel free to start a discussion about that on
> > debian-devel. If it turns out that Debian as a project wants to go that
> > route, I’m happy to change the service file. Until then, I’d prefer it
> if we
> > could stick to the tools that systemd already brings to the table.
> >
> > On Fri, Jul 17, 2015 at 6:00 PM, Paris, Eric <epa...@parisplace.org>
> wrote:
> >>
> >> With sysinit I can have a config file (/etc/default/etcd). I really
> >> like normal config files, which provisioning tools like
> >> salt,puppet,ansible and sysadmins can manage. You are right, today you
> >> could create etcd.service.d/override.conf, but the language in there
> >> is terrible. Like you pointed out, this is systemd configuration not
> >> etcd configuration, you have to prepend everything with Environment=
> >>
> >> Why wouldn't I just want an EnvironmentFile= something?  (Preferably
> >> after the two Environment= hard coded into the unit file) so we can
> >> have something easily usable by both humans and provisioning tools...
> >>
> >> On Fri, Jul 17, 2015 at 12:44 PM, Michael Stapelberg
> >> <stapelb...@debian.org> wrote:
> >> > Why is not good enough to use systemd’s ways to override specific keys
> >> > of a
> >> > service file? I.e., use “systemctl edit etcd” and specify e.g.
> >> > Environment=ETCD_DATA_DIR=/my/path/to/etcd
> >> >
> >> > On Fri, Jul 17, 2015 at 4:27 PM, Eric Paris <
> debianb...@parisplace.org>
> >> > wrote:
> >> >>
> >> >> Package: etcd
> >> >> Version: 2.0.8-2
> >> >> Severity: wishlist
> >> >>
> >> >> Dear Maintainer,
> >> >>
> >> >> The systemd unit file hard codes a working dir and name. It does not
> >> >> have
> >> >> any mechanism for additional configuration. Personally I like the
> >> >> Fedora
> >> >> systemd unit file
> >> >>
> >> >> http://pkgs.fedoraproject.org/cgit/etcd.git/tree/etcd.service
> >> >>
> >> >> Which uses /etc/etcd/etcd.conf as the ENV file.
> >> >>
> >> >> The sysinit scripts use /etc/default/etcd but the ENV keys in that
> file
> >> >> are not the ENV keys which etcd pays attention to. But there should
> be
> >> >> some
> >> >> way, when using systemd to configure it.
> >> >>
> >> >> I got my instalation to work by just putting the Fedora .service file
> >> >> into
> >> >> /etc/systemd/system, but a reasonable default in /lib seems like a
> good
> >> >> idea.
> >> >>
> >> >> -- System Information:
> >> >> Debian Release: 8.1
> >> >>   APT prefers stable-updates
> >> >>   APT policy: (500, 'stable-updates'), (500, 'stable'), (1,
> >> >> 'experimental')
> >> >> Architecture: amd64 (x86_64)
> >> >>
> >> >> Kernel: Linux 3.16.0-4-amd64 (SMP w/2 CPU cores)
> >> >> Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
> >> >> Shell: /bin/sh linked to /bin/dash
> >> >> Init: systemd (via /run/systemd/system)
> >> >>
> >> >> Versions of packages etcd depends on:
> >> >> ii  adduser  3.113+nmu3
> >> >> ii  libc6    2.19-18
> >> >>
> >> >> etcd recommends no packages.
> >> >>
> >> >> etcd suggests no packages.
> >> >>
> >> >> -- Configuration Files:
> >> >> /etc/default/etcd changed [not included]
> >> >> /etc/init.d/etcd changed [not included]
> >> >>
> >> >> -- no debconf information
> >> >>
> >> >> _______________________________________________
> >> >> Pkg-go-maintainers mailing list
> >> >> Pkg-go-maintainers@lists.alioth.debian.org
> >> >>
> >> >>
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
> >> >
> >> >
> >> >
> >> >
> >> > --
> >> > Best regards,
> >> > Michael
> >
> >
> >
> >
> > --
> > Best regards,
> > Michael
>



-- 
Best regards,
Michael

--- End Message ---
_______________________________________________
Pkg-go-maintainers mailing list
Pkg-go-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers

Reply via email to