Re: [pkg-go] dh-golang : DH_GOLANG_INSTALL_EXTRA_EXTENSIONS option

2015-08-03 Thread Michael Stapelberg
Thanks for confirming. I uploaded dh-golang 1.9. On Mon, Aug 3, 2015 at 8:05 PM, Alexandre Viau wrote: > Hello Michael, > > On Mon, Aug 3, 2015 at 1:45 PM, Michael Stapelberg > wrote: >> Can you confirm that this works as expected for you? Once I hear back >> from you, I’ll prepare a new dh-gola

Re: [pkg-go] dh-golang : DH_GOLANG_INSTALL_EXTRA_EXTENSIONS option

2015-08-03 Thread Alexandre Viau
Hello Michael, On Mon, Aug 3, 2015 at 1:45 PM, Michael Stapelberg wrote: > Can you confirm that this works as expected for you? Once I hear back > from you, I’ll prepare a new dh-golang release. Works fine for me! -- Alexandre Viau alexan...@alexandreviau.net __

Re: [pkg-go] dh-golang : DH_GOLANG_INSTALL_EXTRA_EXTENSIONS option

2015-08-03 Thread Michael Stapelberg
Thanks! I’ve merged the patch and taken the liberty to make the code a bit faster by using a hash, see http://anonscm.debian.org/cgit/collab-maint/dh-golang.git/ Can you confirm that this works as expected for you? Once I hear back from you, I’ll prepare a new dh-golang release. On Fri, Jul 31, 2

Re: [pkg-go] dh-golang : DH_GOLANG_INSTALL_EXTRA_EXTENSIONS option

2015-07-31 Thread Alexandre Viau
Hi, On 31/07/15 03:59 AM, Michael Stapelberg wrote: > Your patch still adds an extra option. Can you remove that part > please? > > Also, while you’re at it, install .s files as well? :) > This one should work like you wanted! -- Alexandre Viau alexan...@alexandreviau.net From 3c38a20f08306f2ee

Re: [pkg-go] dh-golang : DH_GOLANG_INSTALL_EXTRA_EXTENSIONS option

2015-07-31 Thread Michael Stapelberg
Your patch still adds an extra option. Can you remove that part please? As I said, I’d like to keep the options to a minimum, and I think the current options are already too many (I’d like to get rid of DH_GOLANG_INSTALL_ALL). Also, while you’re at it, install .s files as well? :) On Thu, Jul 30,

Re: [pkg-go] dh-golang : DH_GOLANG_INSTALL_EXTRA_EXTENSIONS option

2015-07-30 Thread Michael Hudson-Doyle
On 30 July 2015 at 23:23, Michael Stapelberg wrote: > I think the go tools do not cover files that are referenced by test code, > e.g.: > > func TestFoo(t *testing.T) { > f, err := os.Open("my_test_resource.txt") > if err != nil { > t.Fatalf("Could not open file: %v", err) > } > // … >

Re: [pkg-go] dh-golang : DH_GOLANG_INSTALL_EXTRA_EXTENSIONS option

2015-07-30 Thread Alexandre Viau
On 30/07/15 03:26 PM, Michael Stapelberg wrote: > On Thu, Jul 30, 2015 at 3:02 PM, Alexandre Viau > wrote: >> We can extend the default list of installed extensions, but I'm not > > Can you send a patch for that please? > Here you go :)! -- Alexandre Viau alexan...@alexandreviau.net From 7d03

Re: [pkg-go] dh-golang : DH_GOLANG_INSTALL_EXTRA_EXTENSIONS option

2015-07-30 Thread Michael Stapelberg
On Thu, Jul 30, 2015 at 3:02 PM, Alexandre Viau wrote: >> I think the go tools do not cover files that are referenced by test code, >> e.g.: > > Also, this does not to include files that are used in go:generate > calls. For example, .proto files. > > Note that my proposed patch would also allow t

Re: [pkg-go] dh-golang : DH_GOLANG_INSTALL_EXTRA_EXTENSIONS option

2015-07-30 Thread Alexandre Viau
> I think the go tools do not cover files that are referenced by test code, > e.g.: Also, this does not to include files that are used in go:generate calls. For example, .proto files. Note that my proposed patch would also allow to specify a file name, for example ``test.sh`` and it would be ins

Re: [pkg-go] dh-golang : DH_GOLANG_INSTALL_EXTRA_EXTENSIONS option

2015-07-30 Thread Michael Stapelberg
I think the go tools do not cover files that are referenced by test code, e.g.: func TestFoo(t *testing.T) { f, err := os.Open("my_test_resource.txt") if err != nil { t.Fatalf("Could not open file: %v", err) } // … } Did I miss something? On Thu, Jul 30, 2015 at 2:41 AM, Michael Huds

Re: [pkg-go] dh-golang : DH_GOLANG_INSTALL_EXTRA_EXTENSIONS option

2015-07-30 Thread Michael Hudson-Doyle
I guess you could ask go by invoking 'go list -json ./...' and looking for the various *Files fields. The imports/deps calculations won't work of course because the point of the copy is to get files to where they _do_ work, but that just means that there are DepsErrors fields in the json -- the com

Re: [pkg-go] dh-golang : DH_GOLANG_INSTALL_EXTRA_EXTENSIONS option

2015-07-30 Thread Michael Stapelberg
Instead of adding this via a new setting, why not make dh-golang install these files by default? I think installing everything one can legitimately call program source code is fair game. The tricky part is identifying files which are necessary for test cases. The reason why dh-golang doesn’t just

[pkg-go] dh-golang : DH_GOLANG_INSTALL_EXTRA_EXTENSIONS option

2015-07-29 Thread Alexandre Viau
Hello, This is new dh-golang feature should allow to include more files to the install in an easier way. It should be useful, for example, with cgo projects. DH_GOLANG_INSTALL_EXTRA_EXTENSIONS := .cgo,.h,.c Will include all files with .cgo, .h and .c extensions. I have had this issue (not just