Your message dated Tue, 20 Jun 2017 09:10:42 +0200
with message-id <87bmpjm8wd.fsf@midna.localhost>
and subject line Re: Bug#780077: dh-golang doesn't say *anything* about what it 
calls, even with DH_VERBOSE set
has caused the Debian Bug report #780077,
regarding dh-golang doesn't say *anything* about what it calls, even with 
DH_VERBOSE set
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
780077: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=780077
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: dh-golang
Version: 1.6
Tags: sid stretch patch
Severity: important

dh-golang doesn't say *anything* about what it calls, even with DH_VERBOSE set.

apparently dh-golang uses doit_in_builddir, which doesn't print anything, just
uses doit, not complex_doit.  The attached patch at least prints something when
DH_VERBOSE is set.

diff -Nru dh-golang-1.6/lib/Debian/Debhelper/Buildsystem/golang.pm dh-golang-1.7/lib/Debian/Debhelper/Buildsystem/golang.pm
--- dh-golang-1.6/lib/Debian/Debhelper/Buildsystem/golang.pm	2014-07-29 07:55:33.000000000 +0000
+++ dh-golang-1.7/lib/Debian/Debhelper/Buildsystem/golang.pm	2015-03-08 17:30:07.000000000 +0000
@@ -123,18 +123,26 @@
     return @targets;
 }
 
+sub _doit_in_builddir {
+    my $this = shift;
+
+    verbose_print("GOPATH=" . $ENV{GOPATH});
+    verbose_print(join(" ",@_));
+    $this->doit_in_builddir(@_);
+}
+
 sub build {
     my $this = shift;
 
     $ENV{GOPATH} = $this->{cwd} . '/' . $this->get_builddir();
-    $this->doit_in_builddir("go", "install", "-v", @_, get_targets());
+    $this->_doit_in_builddir("go", "install", "-v", @_, get_targets());
 }
 
 sub test {
     my $this = shift;
 
     $ENV{GOPATH} = $this->{cwd} . '/' . $this->get_builddir();
-    $this->doit_in_builddir("go", "test", "-v", @_, get_targets());
+    $this->_doit_in_builddir("go", "test", "-v", @_, get_targets());
 }
 
 sub install {
@@ -144,14 +152,14 @@
 
     my @binaries = <$builddir/bin/*>;
     if (@binaries > 0) {
-        $this->doit_in_builddir('mkdir', '-p', "$destdir/usr");
-        $this->doit_in_builddir('cp', '-r', 'bin', "$destdir/usr");
+        $this->_doit_in_builddir('mkdir', '-p', "$destdir/usr");
+        $this->_doit_in_builddir('cp', '-r', 'bin', "$destdir/usr");
     }
 
     # Path to the src/ directory within $destdir
     my $dest_src = "$destdir/usr/share/gocode/src/$ENV{DH_GOPKG}";
-    $this->doit_in_builddir('mkdir', '-p', $dest_src);
-    $this->doit_in_builddir('cp', '-r', '-T', "src/$ENV{DH_GOPKG}", $dest_src);
+    $this->_doit_in_builddir('mkdir', '-p', $dest_src);
+    $this->_doit_in_builddir('cp', '-r', '-T', "src/$ENV{DH_GOPKG}", $dest_src);
 }
 
 sub clean {

--- End Message ---
--- Begin Message ---
control: tags -1 + unreproducible

Hi Matthias,

Michael Stapelberg <stapelb...@debian.org> writes:
> I can’t reproduce this. When I run gbp buildpackage --git-pbuilder
> […]

I’m closing this bug since there was no reply for 2 years. If the issue
is still present, please re-open with steps to reproduce.

-- 
Best regards,
Michael

--- End Message ---
_______________________________________________
Pkg-go-maintainers mailing list
Pkg-go-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers

Reply via email to