[pkg-go] Bug#830729: Bug#830729: golang-github-mitchellh-go-homedir: FTBFS: homedir_test.go:44: "/home/lamby" != "~"

[Chris Lamb]

> My _hunch_ is that whatever you're using to build (pbuilder perhaps?)
> is running as your user ("lamby") but not including "/etc/passwd" from
> your host

It is running as my user and /etc/passwd includes:

  lamby:x:1000:1000:,,,:/home/lamby:/bin/bash

.. so, alas, that's not the problem.

(am using Docker, not pbuilder)


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

___
Pkg-go-maintainers mailing list
Pkg-go-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers

[pkg-go] Bug#830729: Bug#830729: golang-github-mitchellh-go-homedir: FTBFS: homedir_test.go:44: "/home/lamby" != "~"

[Tianon Gravi]

On 17 July 2016 at 08:22, Chris Lamb  wrote:
> So, I can make the tests pass if I *remove* the "HOME=" bit in
> debian/rules. Sorry I can't be more help.

It looks like it passes in the reproducible builds framework, but I
think I might have a hunch for what's failing on your system.

When I build, I build via sbuild, so it builds as my user, but sets
HOME to something non-existent, hence without HOME being reset, the
tests fail in sbuild (which is what the buildds use too).

My _hunch_ is that whatever you're using to build (pbuilder perhaps?)
is running as your user ("lamby") but not including "/etc/passwd" from
your host (which "sbuild" appears to provide -- at least for the user
I currently am), so when the tests try to discover the current user's
home directory, it fails in the strange ways we're seeing.

I'm hoping we can find an easy way to verify my theory so we can
decide whether this might need to instead be an autopkgtest (which I'd
rather avoid, but if it's not reasonable to expect our current "build
user" to have a valid entry in "/etc/passwd" we don't have much
choice).


♥,
- Tianon
  4096R / B42F 6819 007F 00F8 8E36  4FD4 036A 9C25 BF35 7DD4

___
Pkg-go-maintainers mailing list
Pkg-go-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers

[pkg-go] Bug#830729: Bug#830729: golang-github-mitchellh-go-homedir: FTBFS: homedir_test.go:44: "/home/lamby" != "~"

[Chris Lamb]

> I can't seem to reproduce this failure. :(

So, I can make the tests pass if I *remove* the "HOME=" bit in
debian/rules. Sorry I can't be more help.


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

___
Pkg-go-maintainers mailing list
Pkg-go-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers

[pkg-go] Bug#830729: Bug#830729: golang-github-mitchellh-go-homedir: FTBFS: homedir_test.go:44: "/home/lamby" != "~"

[Tianon Gravi]

On 10 July 2016 at 13:30, Chris Lamb  wrote:
> go install -v github.com/mitchellh/go-homedir
>   github.com/mitchellh/go-homedir
>  debian/rules override_dh_auto_test
>   make[1]: Entering directory 
> '/home/lamby/temp/cdt.20160710222637.V3OyQr9oAG.golang-github-mitchellh-go-homedir/golang-github-mitchellh-go-homedir-0.0~git20150831.0.df55a15'
>   # explicitly unset HOME to force tests to shell out
>   HOME= dh_auto_test
> go test -v github.com/mitchellh/go-homedir
>   === RUN   TestDir
>   --- FAIL: TestDir (0.00s)
> homedir_test.go:44: "/home/lamby" != "~"
>   === RUN   TestExpand
>   --- FAIL: TestExpand (0.00s)
> homedir_test.go:97: Input: "~/foo"
>
> Output: "~/foo"
>   FAIL
>   exit status 1
>   FAIL  github.com/mitchellh/go-homedir 0.005s
>   dh_auto_test: go test -v github.com/mitchellh/go-homedir returned exit code 
> 1
>   debian/rules:4: recipe for target 'override_dh_auto_test' failed
>   make[1]: *** [override_dh_auto_test] Error 1
>   make[1]: Leaving directory 
> '/home/lamby/temp/cdt.20160710222637.V3OyQr9oAG.golang-github-mitchellh-go-homedir/golang-github-mitchellh-go-homedir-0.0~git20150831.0.df55a15'

I can't seem to reproduce this failure. :(


   debian/rules override_dh_auto_test
make[1]: Entering directory '/<>'
# explicitly unset HOME to force tests to shell out
HOME= dh_auto_test
go test -v -p 1 github.com/mitchellh/go-homedir
=== RUN   TestDir
--- PASS: TestDir (0.00s)
=== RUN   TestExpand
--- PASS: TestExpand (0.00s)
PASS
ok   github.com/mitchellh/go-homedir 0.010s
make[1]: Leaving directory '/<>'
 fakeroot debian/rules binary
dh binary --buildsystem=golang --with=golang
   dh_testroot -O--buildsystem=golang
   dh_prep -O--buildsystem=golang
   dh_auto_install -O--buildsystem=golang


♥,
- Tianon
  4096R / B42F 6819 007F 00F8 8E36  4FD4 036A 9C25 BF35 7DD4

___
Pkg-go-maintainers mailing list
Pkg-go-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers