[pkg-go] Bug#855906: golang-codegangsta-cli: FTBFS: FAIL: TestCommandYamlFileTestDefaultValueFileWins (0.00s) helpers_test.go:10: Expected 15 (type int) - Got 7 (type int)

2017-03-02 Thread Vincent Bernat
 ❦ 23 février 2017 16:57 +0800, Chris Lamb  :

>   dh_auto_test: go test -v -p 1 github.com/codegangsta/cli 
> github.com/codegangsta/cli/altsrc returned exit code 1
>   debian/rules:4: recipe for target 'build' failed
>   make: *** [build] Error 1
>   dpkg-buildpackage: error: debian/rules build gave error exit status
>   2

Bisected to
https://github.com/urfave/cli/commit/d71794de198717467a8f053036b5620ccb0d613c.

Confirmed the bug is still in 1.18.1 and gone from 1.19.0. The patch is
quite invasive and doesn't apply cleanly on top of 1.18.x because it
relies on a totally different approach (with code generation). I don't
see any "[aA]pplyWithError" function in the current code that could be
patched. I have also no clue why this problem happens now and not
before. I suppose a change in the dependencies.

I would propose to turn this package as a semi-transitional package to
golang-github-urfave-cli-dev (just a symlink). However,
golang-github-urfave-cli-dev in testing has exactly the same problem but
it doesn't happen because it is ignoring the "altsrc" directory. In
unstable, it doesn't work either if we remove the altsrc directory
(because it is missing a symlink for gopkg.in/urfave/cli.v1).

As a quick workaround, as there is absolutely no use of
github.com/codegangsta/cli/altsrc in Debian, I'll just exclude it from
the package too.
-- 
Use variable names that mean something.
- The Elements of Programming Style (Kernighan & Plauger)


signature.asc
Description: PGP signature
___
Pkg-go-maintainers mailing list
Pkg-go-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers

[pkg-go] Bug#855906: golang-codegangsta-cli: FTBFS: FAIL: TestCommandYamlFileTestDefaultValueFileWins (0.00s) helpers_test.go:10: Expected 15 (type int) - Got 7 (type int)

2017-02-23 Thread Chris Lamb
Source: golang-codegangsta-cli
Version: 1.18.0-1
Severity: serious
Justification: fails to build from source
User: reproducible-bui...@lists.alioth.debian.org
Usertags: ftbfs
X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org

Dear Maintainer,

golang-codegangsta-cli fails to build from source in unstable/amd64:

  […]

  --- PASS: TestHandleAction_WithInvalidFuncSignature (0.00s)
  === RUN   TestHandleAction_WithInvalidFuncReturnSignature
  --- PASS: TestHandleAction_WithInvalidFuncReturnSignature (0.00s)
  === RUN   TestHandleAction_WithUnknownPanic
  --- PASS: TestHandleAction_WithUnknownPanic (0.00s)
  === RUN   TestCommandFlagParsing
  --- PASS: TestCommandFlagParsing (0.00s)
  === RUN   TestCommand_Run_DoesNotOverwriteErrorFromBefore
  before error
  
  NAME:
 cli.test bar - 
  
  USAGE:
 cli.test bar [arguments...]
  --- PASS: TestCommand_Run_DoesNotOverwriteErrorFromBefore (0.00s)
  === RUN   TestCommand_OnUsageError_WithWrongFlagValue
  --- PASS: TestCommand_OnUsageError_WithWrongFlagValue (0.00s)
  === RUN   TestNewContext
  --- PASS: TestNewContext (0.00s)
  === RUN   TestContext_Int
  --- PASS: TestContext_Int (0.00s)
  === RUN   TestContext_Int64
  --- PASS: TestContext_Int64 (0.00s)
  === RUN   TestContext_Uint
  --- PASS: TestContext_Uint (0.00s)
  === RUN   TestContext_Uint64
  --- PASS: TestContext_Uint64 (0.00s)
  === RUN   TestContext_GlobalInt
  --- PASS: TestContext_GlobalInt (0.00s)
  === RUN   TestContext_GlobalInt64
  --- PASS: TestContext_GlobalInt64 (0.00s)
  === RUN   TestContext_Float64
  --- PASS: TestContext_Float64 (0.00s)
  === RUN   TestContext_GlobalFloat64
  --- PASS: TestContext_GlobalFloat64 (0.00s)
  === RUN   TestContext_Duration
  --- PASS: TestContext_Duration (0.00s)
  === RUN   TestContext_String
  --- PASS: TestContext_String (0.00s)
  === RUN   TestContext_Bool
  --- PASS: TestContext_Bool (0.00s)
  === RUN   TestContext_BoolT
  --- PASS: TestContext_BoolT (0.00s)
  === RUN   TestContext_GlobalBool
  --- PASS: TestContext_GlobalBool (0.00s)
  === RUN   TestContext_GlobalBoolT
  --- PASS: TestContext_GlobalBoolT (0.00s)
  === RUN   TestContext_Args
  --- PASS: TestContext_Args (0.00s)
  === RUN   TestContext_NArg
  --- PASS: TestContext_NArg (0.00s)
  === RUN   TestContext_IsSet
  --- PASS: TestContext_IsSet (0.00s)
  === RUN   TestContext_GlobalIsSet
  --- PASS: TestContext_GlobalIsSet (0.00s)
  === RUN   TestContext_NumFlags
  --- PASS: TestContext_NumFlags (0.00s)
  === RUN   TestContext_GlobalFlag
  --- PASS: TestContext_GlobalFlag (0.00s)
  === RUN   TestContext_GlobalFlagsInSubcommands
  --- PASS: TestContext_GlobalFlagsInSubcommands (0.00s)
  === RUN   TestContext_Set
  --- PASS: TestContext_Set (0.00s)
  === RUN   TestContext_GlobalSet
  --- PASS: TestContext_GlobalSet (0.00s)
  === RUN   TestHandleExitCoder_nil
  --- PASS: TestHandleExitCoder_nil (0.00s)
  === RUN   TestHandleExitCoder_ExitCoder
  galactic perimeter breach
  --- PASS: TestHandleExitCoder_ExitCoder (0.00s)
  === RUN   TestHandleExitCoder_MultiErrorWithExitCoder
  galactic perimeter breach
  --- PASS: TestHandleExitCoder_MultiErrorWithExitCoder (0.00s)
  === RUN   TestBoolFlagHelpOutput
  --- PASS: TestBoolFlagHelpOutput (0.00s)
  === RUN   TestStringFlagHelpOutput
  --- PASS: TestStringFlagHelpOutput (0.00s)
  === RUN   TestStringFlagWithEnvVarHelpOutput
  --- PASS: TestStringFlagWithEnvVarHelpOutput (0.00s)
  === RUN   TestStringSliceFlagHelpOutput
  --- PASS: TestStringSliceFlagHelpOutput (0.00s)
  === RUN   TestStringSliceFlagWithEnvVarHelpOutput
  --- PASS: TestStringSliceFlagWithEnvVarHelpOutput (0.00s)
  === RUN   TestIntFlagHelpOutput
  --- PASS: TestIntFlagHelpOutput (0.00s)
  === RUN   TestIntFlagWithEnvVarHelpOutput
  --- PASS: TestIntFlagWithEnvVarHelpOutput (0.00s)
  === RUN   TestInt64FlagHelpOutput
  --- PASS: TestInt64FlagHelpOutput (0.00s)
  === RUN   TestInt64FlagWithEnvVarHelpOutput
  --- PASS: TestInt64FlagWithEnvVarHelpOutput (0.00s)
  === RUN   TestUintFlagHelpOutput
  --- PASS: TestUintFlagHelpOutput (0.00s)
  === RUN   TestUintFlagWithEnvVarHelpOutput
  --- PASS: TestUintFlagWithEnvVarHelpOutput (0.00s)
  === RUN   TestUint64FlagHelpOutput
  --- PASS: TestUint64FlagHelpOutput (0.00s)
  === RUN   TestUint64FlagWithEnvVarHelpOutput
  --- PASS: TestUint64FlagWithEnvVarHelpOutput (0.00s)
  === RUN   TestDurationFlagHelpOutput
  --- PASS: TestDurationFlagHelpOutput (0.00s)
  === RUN   TestDurationFlagWithEnvVarHelpOutput
  --- PASS: TestDurationFlagWithEnvVarHelpOutput (0.00s)
  === RUN   TestIntSliceFlagHelpOutput
  --- PASS: TestIntSliceFlagHelpOutput (0.00s)
  === RUN   TestIntSliceFlagWithEnvVarHelpOutput
  --- PASS: TestIntSliceFlagWithEnvVarHelpOutput (0.00s)
  === RUN   TestInt64SliceFlagHelpOutput
  --- PASS: TestInt64SliceFlagHelpOutput (0.00s)
  === RUN   TestInt64SliceFlagWithEnvVarHelpOutput
  --- PASS: TestInt64SliceFlagWithEnvVarHelpOutput (0.00s)
  === RUN   TestFloat64FlagHelpOutput
  --- PASS: TestFloat64FlagHelpOutput (0.00s)
  === RUN