[pkg-go] Bug#857025: Bug#857025: golang-golang-x-tools FRBFS on armhf: golang.org/x/tools/refactor/satisfy [no test files]

2017-03-17 Thread Michael Stapelberg 
control: owner -1 !

Hi,

Michael Hudson-Doyle  writes:
> and the failure is this:
>
> === RUN   TestImportSymlinks
> --- FAIL: TestImportSymlinks (0.03s)
> Which, frankly, is a very bizarre test to be arch dependent.

It’s not arch-dependent, it’s “just” flaky :).

This was fixed upstream:
https://github.com/golang/tools/commit/f60b69ed8cd7a29e91f87050ae23a29581a0f367

I’ll cherry-pick this fix into a new upload after having a look at #857024.

-- 
Best regards,
Michael

___
Pkg-go-maintainers mailing list
Pkg-go-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers

[pkg-go] Bug#857025: Bug#857025: golang-golang-x-tools FRBFS on armhf: golang.org/x/tools/refactor/satisfy [no test files]

2017-03-07 Thread Michael Hudson-Doyle 
The "no test files" thing is not the cause of the failure and the log link
is a 404 for me. This link works though:


https://buildd.debian.org/status/fetch.php?pkg=golang-golang-x-tools&arch=armhf&ver=1%3A0.0~git20161028.0.b814a3b%2Bds-3%2Bb1&stamp=1488869926&raw=0

and the failure is this:

=== RUN   TestImportSymlinks
--- FAIL: TestImportSymlinks (0.03s)
fix_test.go:889: results differ
GOT:
package p

import (
"fmt"
"x/apkg/mypkg"
)

var (
_ = fmt.Print
_ = mypkg.Foo
)

WANT:
package p

import (
"fmt"
"x/mypkg"
)

var (
_ = fmt.Print
_ = mypkg.Foo
)


Which, frankly, is a very bizarre test to be arch dependent.


On 7 March 2017 at 23:26, Adrian Bunk  wrote:

> Source: golang-golang-x-tools
> Version: 1:0.0~git20161028.0.b814a3b+ds-3
> Severity: serious
>
> https://buildd.debian.org/status/fetch.php?pkg=golang-
> golang-x-tools&arch=armhf&ver=1:0.0~git20161028.0.b814a3b+
> ds-3+b1&stamp=1488869926&raw=0
>
> ...
> === RUN   TestDiff
> --- PASS: TestDiff (3.78s)
> PASS
> ok  golang.org/x/tools/refactor/rename  4.035s
> ?   golang.org/x/tools/refactor/satisfy [no test files]
> dh_auto_test: go test -v -p 1 -test.short golang.org/x/tools/benchmark/
> parse golang.org/x/tools/blog golang.org/x/tools/blog/atom
> golang.org/x/tools/cmd/benchcmp golang.org/x/tools/cmd/bundle
> golang.org/x/tools/cmd/callgraph golang.org/x/tools/cmd/digraph
> golang.org/x/tools/cmd/eg golang.org/x/tools/cmd/fiximports
> golang.org/x/tools/cmd/godex golang.org/x/tools/cmd/godoc
> golang.org/x/tools/cmd/goimports golang.org/x/tools/cmd/gomvpkg
> golang.org/x/tools/cmd/gorename golang.org/x/tools/cmd/gotype
> golang.org/x/tools/cmd/goyacc golang.org/x/tools/cmd/guru
> golang.org/x/tools/cmd/guru/serial golang.org/x/tools/cmd/html2article
> golang.org/x/tools/cmd/present golang.org/x/tools/cmd/ssadump
> golang.org/x/tools/cmd/stress golang.org/x/tools/cmd/stringer
> golang.org/x/tools/cmd/tip golang.org/x/tools/container/intsets
> golang.org/x/tools/cover golang.org/x/tools/go/ast/astutil
> golang.org/x/tools/go/buildutil golang.org/x/tools/go/callgraph
> golang.org/x/tools/go/callgraph/cha golang.org/x/tools/go/callgraph/rta
> golang.org/x/tools/go/callgraph/static golang.org/x/tools/go/
> gccgoexportdata golang.org/x/tools/go/gcexportdata golang.org/x/tools/go/
> gcimporter15 golang.org/x/tools/go/internal/gccgoimporter
> golang.org/x/tools/go/loader golang.org/x/tools/go/pointer
> golang.org/x/tools/go/ssa golang.org/x/tools/go/ssa/interp
> golang.org/x/tools/go/ssa/ssautil golang.org/x/tools/go/types/typeutil
> golang.org/x/tools/go/vcs golang.org/x/tools/godoc
> golang.org/x/tools/godoc/analysis golang.org/x/tools/godoc/redirect
> golang.org/x/tools/godoc/util golang.org/x/tools/godoc/vfs
> golang.org/x/tools/godoc/vfs/gatefs golang.org/x/tools/godoc/vfs/httpfs
> golang.org/x/tools/godoc/vfs/mapfs golang.org/x/tools/godoc/vfs/zipfs
> golang.org/x/tools/imports golang.org/x/tools/playground
> golang.org/x/tools/playground/socket golang.org/x/tools/present
> golang.org/x/tools/refactor/eg golang.org/x/tools/refactor/importgraph
> golang.org/x/tools/refactor/rename golang.org/x/tools/refactor/satisfy
> returned exit code 1
> debian/rules:50: recipe for target 'override_dh_auto_test' failed
> make[1]: *** [override_dh_auto_test] Error 1
> make[1]: Leaving directory '/«BUILDDIR»/golang-golang-x-
> tools-0.0~git20161028.0.b814a3b+ds'
> debian/rules:18: recipe for target 'build-arch' failed
> make: *** [build-arch] Error 2
> ___
> Pkg-go-maintainers mailing list
> Pkg-go-maintainers@lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
___
Pkg-go-maintainers mailing list
Pkg-go-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers

[pkg-go] Bug#857025: Bug#857025: golang-golang-x-tools FRBFS on armhf: golang.org/x/tools/refactor/satisfy [no test files]

2017-03-07 Thread Martín Ferrari 
On 07/03/17 07:26, Adrian Bunk wrote:

> https://buildd.debian.org/status/fetch.php?pkg=golang-golang-x-tools&arch=armhf&ver=1:0.0~git20161028.0.b814a3b+ds-3+b1&stamp=1488869926&raw=0

This seems to be a flaky test. I tried rebuilding on abel/armhf and I
had 3 successful runs. There is a report upstream of flakyness in this
test: https://github.com/golang/go/issues/18142

I will disable this test.

-- 
Martín Ferrari (Tincho)

___
Pkg-go-maintainers mailing list
Pkg-go-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers