Re: [pkg-go] Why we install the test files in dev pkg(was: Bug#870643: golang-github-pierrec-lz4-dev: please split off test data)

2017-08-04 Thread Martín Ferrari
On 04/08/17 08:04, Shengjing Zhu wrote: > IIRC, python doesn't. > Take python3-requests for example, > these tests https://github.com/requests/requests/tree/master/tests > are not installed in > https://packages.debian.org/sid/all/python3-requests/filelist > You are right, sorry about the confu

Re: [pkg-go] Why we install the test files in dev pkg(was: Bug#870643: golang-github-pierrec-lz4-dev: please split off test data)

2017-08-04 Thread Shengjing Zhu
On Fri, Aug 4, 2017 at 2:58 PM, Martín Ferrari wrote: > I am not sure if this was ever discussed, but I kind of like the tests > being there in case I want to run them. It is the same for scritping > languages like perl and python, tests are installed. IIRC, python doesn't. Take python3-requests

Re: [pkg-go] Why we install the test files in dev pkg(was: Bug#870643: golang-github-pierrec-lz4-dev: please split off test data)

2017-08-04 Thread Martín Ferrari
On 04/08/17 04:48, Shengjing Zhu wrote: > BTW, I always drop test dependencies for the -dev package. This is not a problem, as the tests are not needed for *using* the package. Autopkgtest uses the build-dependencies for that. -- Martín Ferrari (Tincho)

Re: [pkg-go] Why we install the test files in dev pkg(was: Bug#870643: golang-github-pierrec-lz4-dev: please split off test data)

2017-08-03 Thread Martín Ferrari
On 04/08/17 04:46, Shengjing Zhu wrote: > I'm wondering why we install the *_test.go files in the *-dev binary package. > IMHO, other package won't import the test files from *-dev package. I am not sure if this was ever discussed, but I kind of like the tests being there in case I want to run th

Re: [pkg-go] Why we install the test files in dev pkg(was: Bug#870643: golang-github-pierrec-lz4-dev: please split off test data)

2017-08-03 Thread Shengjing Zhu
BTW, I always drop test dependencies for the -dev package. On Fri, Aug 4, 2017 at 11:46 AM, Shengjing Zhu wrote: > Hi team, > > I'm wondering why we install the *_test.go files in the *-dev binary package. > IMHO, other package won't import the test files from *-dev package. > And the CI system i

[pkg-go] Why we install the test files in dev pkg(was: Bug#870643: golang-github-pierrec-lz4-dev: please split off test data)

2017-08-03 Thread Shengjing Zhu
Hi team, I'm wondering why we install the *_test.go files in the *-dev binary package. IMHO, other package won't import the test files from *-dev package. And the CI system is to test building the src package from scratch. It doesn't run `go test ./...` from the -dev package. So I think we shoul