Re: [pkg-go] "use of internal package not allowed" running dh-make-golang

2016-11-18 Thread Michael Stapelberg
Glad to hear it’s useful :).

On Fri, Nov 18, 2016 at 4:37 AM, Potter, Tim (HPE Linux Support) <
timothy.pot...@hpe.com> wrote:

> On 17 Nov 2016, at 6:20 PM, Michael Stapelberg 
> wrote
>
> > As for the issue itself, could you please file a bug at
> https://github.com/Debian/dh-make-golang/issues so that the problem is at
> least documented? Not sure when I’ll have time to look at it more closely,
> but we should definitely try to solve it.
>
> https://github.com/Debian/dh-make-golang/issues/50
>
> BTW thanks for an awesome tool.  dh-make-golang is such a great timesaver
> and works
> perfectly 99% of the time.
>
>
> Tim.
>



-- 
Best regards,
Michael
___
Pkg-go-maintainers mailing list
Pkg-go-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers

Re: [pkg-go] "use of internal package not allowed" running dh-make-golang

2016-11-17 Thread Michael Stapelberg
On Thu, Nov 17, 2016 at 7:41 AM, Martín Ferrari  wrote:

> Michael,
>
> On 17/11/16 08:20, Michael Stapelberg wrote:
> > Instead of creating additional scripts/tools, could we try to centralize
> > that functionality into either gbp import-orig itself, or dh-make-golang
> > please? https://github.com/Debian/dh-make-golang/issues/14 is related,
> > and paultag expressed some interest in this as well recently.
>
> That'd be great, but I don't really have the time now to dive into gbp
> or dh-make-golang to add this functionality.
>
> I uploaded my scripts to the shared repo because I think they might be
> useful for other people, no need to get upset about that!
>

I’m not upset :).


>
>
> > As for the issue itself, could you please file a bug
> > at https://github.com/Debian/dh-make-golang/issues so that the problem
> > is at least documented? Not sure when I’ll have time to look at it more
> > closely, but we should definitely try to solve it.
>
> I did not experience this bug, I can't file a report.
>

Sorry, should’ve been clearer: that was a question for Tim.


>
>
> --
> Martín Ferrari (Tincho)
>



-- 
Best regards,
Michael
___
Pkg-go-maintainers mailing list
Pkg-go-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers

Re: [pkg-go] "use of internal package not allowed" running dh-make-golang

2016-11-16 Thread Martín Ferrari
On 17/11/16 01:38, Potter, Tim (HPE Linux Support) wrote:

> It looks like the vendored dependencies that have internal packages, x-net 
> and golang-grpc,
> here are trying to be imported while being built using a longer package name: 
> github.com/docker/containerd/vendor/src/google.golang.org/grpc vs 
> google.golang.org/grpc
> but I don't understand why.

I have suffered this recently while working on a new version of
google-cloud. Some stupid rules that golang wants to enforce..

> My guess is that this was always happening but only now produces an error as 
> upstreams
> are only just starting to add internal packages to their code.
> 
> Any ideas on how to proceed?  I was going to do something awful and rename 
> the internal
> packages but would not be happy with that long-term.

The first thing I'd say is that you should remove the vendoring, both
libraries you mention are already packaged!

-- 
Martín Ferrari (Tincho)

___
Pkg-go-maintainers mailing list
Pkg-go-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers