Re: [pkg-go] Bug#888985: Bug#888985: RFS: irtt/0.9-1 [ITP] (#888985)

[Michael Stapelberg]

There’s nothing you need to do. I built it on amd64, as is currently still
required when uploading to the NEW queue (I would have preferred to upload
source-only). Once it’s accepted, the buildds will build it for all
architectures.

On Wed, Feb 14, 2018 at 2:53 PM, Pete Heist  wrote:

>
> On Feb 12, 2018, at 11:05 PM, Pete Heist  wrote:
>
> On Feb 12, 2018, at 10:22 PM, Michael Stapelberg 
> wrote:
>
> Would you like me to sponsor the upload of irtt now?
>
>
> Yes, if you would. Thanks!
>
>
> Glad to see it in the queue, although I noticed there is “source amd64” in
> the Arch column, whereas Go libs seem to have “source all”. I’d like to
> make sure it’s available for any architectures Go supports. I see that
> dh-make-golang adds "Architecture: any” to debian/control for programs, and
> it adds “Architecture: all” for libraries. Is there something more I need
> to do?
>
> Thanks,
> Pete
>
>


-- 
Best regards,
Michael
___
Pkg-go-maintainers mailing list
Pkg-go-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers

Re: [pkg-go] Bug#888985: Bug#888985: RFS: irtt/0.9-1 [ITP] (#888985)

[Pete Heist]

> On Feb 12, 2018, at 11:05 PM, Pete Heist  wrote:
> 
>> On Feb 12, 2018, at 10:22 PM, Michael Stapelberg > > wrote:
>> 
>> Would you like me to sponsor the upload of irtt now?
> 
> Yes, if you would. Thanks!

Glad to see it in the queue, although I noticed there is “source amd64” in the 
Arch column, whereas Go libs seem to have “source all”. I’d like to make sure 
it’s available for any architectures Go supports. I see that dh-make-golang 
adds "Architecture: any” to debian/control for programs, and it adds 
“Architecture: all” for libraries. Is there something more I need to do?

Thanks,
Pete

___
Pkg-go-maintainers mailing list
Pkg-go-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers

Re: [pkg-go] Bug#888985: Bug#888985: RFS: irtt/0.9-1 [ITP] (#888985)

[Pete Heist]

> On Feb 12, 2018, at 10:22 PM, Michael Stapelberg  
> wrote:
> 
> Would you like me to sponsor the upload of irtt now?

Yes, if you would. Thanks!

Pete

___
Pkg-go-maintainers mailing list
Pkg-go-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers

Re: [pkg-go] Bug#888985: Bug#888985: RFS: irtt/0.9-1 [ITP] (#888985)

[Michael Stapelberg]

On Sun, Feb 11, 2018 at 4:04 PM, Pete Heist  wrote:

>
> On Feb 11, 2018, at 12:37 AM, Michael Stapelberg 
> wrote:
>
> On Sat, Feb 10, 2018 at 6:08 PM, Pete Heist  wrote:
>
>>
>> - I tried getting signatures working but punted because GitHub creates a
>> .tar.gz, which I signed with a .tar.gz.asc, but the build process expects a
>> .tar.xz.asc in the upstream, so lintian then warns with
>> 'orig-tarball-missing-upstream-signature'. Is there any pkg-go example
>> of signatures working with a GitHub hosted repo? Otherwise I’ll eventually
>> figure it out.
>>
>
> The process currently is a bit clunky. dh-make-golang hardcodes using xz
> (via tar J), so either you change that in dh-make-golang’s source, or you
> manually create the packaging git repository:
>
> # save GitHub .tar.gz as irtt_0.9.0.orig.tar.gz
> % mkdir irtt
> % cd irtt
> % git init
> % gbp import-orig ../irtt_0.9.0.orig.tar.gz
> % cp -r /tmp/dh-make-golang/irtt/debian .
> % git commit -a -m "Initial packaging”
>
>
>
>>
>> Let me know if anything else. Thanks!
>>
>
> It would be good to avoid copying the systemd .service file into debian/.
> I think you can instead install it with a debian/rules override. See e.g.
> https://sources.debian.org/src/forked-daapd/25.0-2/debian/rules/?hl=22#L22
>
> Let me know how you’d like to proceed regarding the signatures. It’s not a
> requirement to sign the releases for now, but note that after the initial
> upload, we don’t have the luxury of starting with a fresh repository
> anymore.
>
>
> Ok, I took the advice for the .service file (thanks, that’s smoother), and
> re-initialized the repo for the last time. :)
>
> I passed on signing for now. I modified dh-make-golang to make a .tar.gz
> (thought I might even submit a pull request with a new command line
> option), but the .tar.gz that’s created is not the same as the one GitHub
> automatically creates (different internal directory names for starters), so
> for each build it looks like I’d have to:
>

I’d recommend to use the tar.gz from GitHub for simplicity. This would
require using the workflow I described above.


> - Run gbp once to generate the .tar.gz
> - Sign it to get the .tar.gz.asc
> - Run gbp again with the .tar.gz.asc in place to see that lintian doesn’t
> complain
> - Manually upload the .tar.gz and .tar.gz.asc to GitHub
> In the interest of keeping my release process as simple as possible, I’ll
> smooth this out later when I have more time!
>
> One more thing: I switched to semantic versioning when I started
> CHANGES.md, so on ftp.upload.debian.org what was irtt_0.9-1* before is
> now irtt_0.9.0-1*, in case there are some dangling files there that should
> be cleaned up.
>

There’s no need to clean things up, the upload directory is cleaned
automatically.

Would you like me to sponsor the upload of irtt now?


>
> Thanks again!
>
> Pete
>
>


-- 
Best regards,
Michael
___
Pkg-go-maintainers mailing list
Pkg-go-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers

Re: [pkg-go] Bug#888985: Bug#888985: RFS: irtt/0.9-1 [ITP] (#888985)

[Pete Heist]

> On Feb 11, 2018, at 12:37 AM, Michael Stapelberg  
> wrote:
> 
> On Sat, Feb 10, 2018 at 6:08 PM, Pete Heist  > wrote:
> 
> - I tried getting signatures working but punted because GitHub creates a 
> .tar.gz, which I signed with a .tar.gz.asc, but the build process expects a 
> .tar.xz.asc in the upstream, so lintian then warns with 
> 'orig-tarball-missing-upstream-signature'. Is there any pkg-go example of 
> signatures working with a GitHub hosted repo? Otherwise I’ll eventually 
> figure it out.
> 
> The process currently is a bit clunky. dh-make-golang hardcodes using xz (via 
> tar J), so either you change that in dh-make-golang’s source, or you manually 
> create the packaging git repository:
> 
> # save GitHub .tar.gz as irtt_0.9.0.orig.tar.gz
> % mkdir irtt
> % cd irtt
> % git init
> % gbp import-orig ../irtt_0.9.0.orig.tar.gz
> % cp -r /tmp/dh-make-golang/irtt/debian .
> % git commit -a -m "Initial packaging”
>  
> 
> Let me know if anything else. Thanks!
> 
> It would be good to avoid copying the systemd .service file into debian/. I 
> think you can instead install it with a debian/rules override. See e.g. 
> https://sources.debian.org/src/forked-daapd/25.0-2/debian/rules/?hl=22#L22 
> 
> 
> Let me know how you’d like to proceed regarding the signatures. It’s not a 
> requirement to sign the releases for now, but note that after the initial 
> upload, we don’t have the luxury of starting with a fresh repository anymore.

Ok, I took the advice for the .service file (thanks, that’s smoother), and 
re-initialized the repo for the last time. :)

I passed on signing for now. I modified dh-make-golang to make a .tar.gz 
(thought I might even submit a pull request with a new command line option), 
but the .tar.gz that’s created is not the same as the one GitHub automatically 
creates (different internal directory names for starters), so for each build it 
looks like I’d have to:
- Run gbp once to generate the .tar.gz
- Sign it to get the .tar.gz.asc
- Run gbp again with the .tar.gz.asc in place to see that lintian doesn’t 
complain
- Manually upload the .tar.gz and .tar.gz.asc to GitHub
In the interest of keeping my release process as simple as possible, I’ll 
smooth this out later when I have more time!

One more thing: I switched to semantic versioning when I started CHANGES.md, so 
on ftp.upload.debian.org what was irtt_0.9-1* before is now irtt_0.9.0-1*, in 
case there are some dangling files there that should be cleaned up.

Thanks again!

Pete

___
Pkg-go-maintainers mailing list
Pkg-go-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers

Re: [pkg-go] Bug#888985: Bug#888985: RFS: irtt/0.9-1 [ITP] (#888985)

[Pete Heist]

> On Feb 9, 2018, at 8:15 AM, Michael Stapelberg  wrote:
> 
> On Fri, Feb 9, 2018 at 2:09 AM, Pete Heist  > wrote:
> 
> From the original warnings you sent I know I’ve fixed all except "I: irtt 
> source: testsuite-autopkgtest-missing”, but a) I’m not seeing that warning 
> and b) I’m seeing two others. So my questions are:
> 
> 1) What are your expectations for 'testsuite-autopkgtest-missing', and why am 
> I not seeing it? There are no unit tests to run.
> 
> Did you apply the ~/.lintianrc I provided? Not doing so would explain the 
> difference. autopkgtest is helpful even if it only compiles the package in 
> question. Why are there no unit tests for your code? :)

Yes I did, I should have included that...

$ lintian --version
Lintian v2.5.74
$ ls -al ~/.lintianrc 
-rw-r--r-- 1 pete pete 94 Feb  7 10:25 /home/pete/.lintianrc
$ cat ~/.lintianrc 
display-info = yes
display-experimental = yes
pedantic = yes
show-overrides = no
color = auto
$

What probably explains your seeing testsuite-autopkgtest-missing and my not is 
that I was previously using dh-make-golang from Debian stable. The current sid 
version of dh-make-golang has added a "Testsuite: autopkgtest-pkg-go” line to 
debian/control, which likely satisfies lintian.

BTW I manually bumped compat-version from 10 to 11 and standards-version from 
4.1.1 to 4.1.3 as recent changes to dh-make-golang which do this aren’t in sid 
yet.

As for unit tests, in short, I haven’t gotten there yet, though there’s a bit 
more to it than that. If you’d like, I can add a few basic ones to satisfy, 
otherwise they’ll go in after one more design issue is sorted out… :)

> 2) Do you care about 'debian-watch-does-not-check-gpg-signature' and 
> 'no-upstream-changelog’? I do not sign the upstream, and the changes are in 
> README.md, in case those should be split out...
> 
> They’re not important for the time being. Of course, if you could start 
> signing upstream and provide a separate changelog file, that would be great.
> 
> Thanks!

Ok, I’ll take a look at these if there’s time.

Thanks, almost there… :)

___
Pkg-go-maintainers mailing list
Pkg-go-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers