Re: [pkg-go] RFS: golang-github-smartystreets-gunit

2018-04-10 Thread Michael Stapelberg
I recommend changing the copyright to “SmartyStreets, LLC”, which is clearer for the reader and consistent with what we already have in the archive. On Mon, Apr 9, 2018 at 10:01 PM, Raju Devidas wrote: > In Between. > > > On 04/09/2018 12:14 PM, Michael Stapelberg wrote: >

Re: [pkg-go] RFS: golang-github-smartystreets-gunit

2018-04-09 Thread Raju Devidas
In Between. On 04/09/2018 12:14 PM, Michael Stapelberg wrote: > The package looks good, but it might be good to remove the NOTE in the > Expat License entry in debian/copyright: Thanks a lot for taking out the time to review the packages. > >  NOTE: Various optional and subordinate components

Re: [pkg-go] RFS: golang-github-smartystreets-gunit

2018-04-09 Thread Michael Stapelberg
The package looks good, but it might be good to remove the NOTE in the Expat License entry in debian/copyright: NOTE: Various optional and subordinate components carry their own licensing requirements and restrictions. Use of those components is subject to the terms and conditions outlined