Re: [pkg-go] RFS: golang-protobuf-extensions patch to disable failing test

[Michael Hudson-Doyle]

On 5 April 2016 at 11:10, Potter, Tim (HPE Linux Support)
 wrote:
> Hi again.  I've made a small patch to golang-protobuf-extensions to allow it 
> to be built under the version of Go currently in stretch.  According to the 
> github issue tracker it's a known problem with Go 1.5 and higher, but has not 
> been fixed at this stage.  I've even added a DEP3 header recording this info.
>
> Could someone please review and upload?  Thanks again!

Did this ever happen? I'm asking because upstream has now (finally)
disabled these tests so we should probably package a new upstream
snapshot instead/as well.

Cheers,
mwh

___
Pkg-go-maintainers mailing list
Pkg-go-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers

Re: [pkg-go] RFS: golang-protobuf-extensions patch to disable failing test

[Potter, Tim (HPE Linux Support)]

On 5 Apr 2016, at 12:48 PM, Dmitry Smirnov  wrote:
> 
> On Tuesday, 5 April 2016 1:35:28 AM AEST Potter, Tim (HPE Linux Support)
> wrote:
>> Hi Dmitry.  I'm only removing one of the tests out of this file - about 40
>> lines out of 320 so a bit over 10%.  I thought that would be OK.
> 
> Of course it is OK. I didn't realise that you are removing just a fragment of
> file and not the whole file. However I've seen you dropping the entire file
> with patches more than once in other packages and I did not have a chance to
> tell you about it.

OK - will do.  Thanks for the tip!


Tim.


signature.asc
Description: Message signed with OpenPGP using GPGMail
___
Pkg-go-maintainers mailing list
Pkg-go-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers

Re: [pkg-go] RFS: golang-protobuf-extensions patch to disable failing test

[Dmitry Smirnov]

On Tuesday, 5 April 2016 1:35:28 AM AEST Potter, Tim (HPE Linux Support) 
wrote:
> Hi Dmitry.  I'm only removing one of the tests out of this file - about 40
> lines out of 320 so a bit over 10%.  I thought that would be OK.

Of course it is OK. I didn't realise that you are removing just a fragment of 
file and not the whole file. However I've seen you dropping the entire file 
with patches more than once in other packages and I did not have a chance to 
tell you about it.


> What do you mean by "debian/clien"?

"debian/clean" of course. See dh_clean(1).


> If there's a better way of removing
> entire files (because that does happen occasionally, especially with tests)
> I'm happy to do that in preference to a patch.

OK. I think the better way is to include name of the file you want removed to 
"debian/clean" and `dh_clean` will delete it for you. Alternatively you can 
pass file names of files to remove as arguments to dh_clean.

-- 
All the best,
 Dmitry Smirnov.

---

Criticism may not be agreeable, but it is necessary. It fulfils the same
function as pain in the human body. It calls attention to an unhealthy
state of things.
-- Winston Churchill


signature.asc
Description: This is a digitally signed message part.
___
Pkg-go-maintainers mailing list
Pkg-go-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers

Re: [pkg-go] RFS: golang-protobuf-extensions patch to disable failing test

[Potter, Tim (HPE Linux Support)]

On 5 Apr 2016, at 10:01 AM, Dmitry Smirnov  wrote:
> 
> On Monday, 4 April 2016 11:10:51 PM AEST Potter, Tim (HPE Linux Support)
> wrote:
>> Hi again.  I've made a small patch to golang-protobuf-extensions to allow
>> it to be built under the version of Go currently in stretch.  According to
>> the github issue tracker it's a known problem with Go 1.5 and higher, but
>> has not been fixed at this stage.  I've even added a DEP3 header recording
>> this info.
> 
> Tim, removing file(s) using patches is unmaintainable and tend to break on
> slightest changes. I recommend adding file you want to remove to "debian/
> clien" with relevant comments from patch header. I hope it make sense.

Hi Dmitry.  I'm only removing one of the tests out of this file - about 40 lines
out of 320 so a bit over 10%.  I thought that would be OK.

What do you mean by "debian/clien"?  If there's a better way of removing
entire files (because that does happen occasionally, especially with tests)
I'm happy to do that in preference to a patch.


Tim.


signature.asc
Description: Message signed with OpenPGP using GPGMail
___
Pkg-go-maintainers mailing list
Pkg-go-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers

Re: [pkg-go] RFS: golang-protobuf-extensions patch to disable failing test

[Dmitry Smirnov]

On Monday, 4 April 2016 11:10:51 PM AEST Potter, Tim (HPE Linux Support) 
wrote:
> Hi again.  I've made a small patch to golang-protobuf-extensions to allow
> it to be built under the version of Go currently in stretch.  According to
> the github issue tracker it's a known problem with Go 1.5 and higher, but
> has not been fixed at this stage.  I've even added a DEP3 header recording
> this info.

Tim, removing file(s) using patches is unmaintainable and tend to break on 
slightest changes. I recommend adding file you want to remove to "debian/
clien" with relevant comments from patch header. I hope it make sense.

-- 
Regards,
 Dmitry Smirnov.

---

And those who were seen dancing were thought to be insane by those who
could not hear the music.
-- Friedrich Nietzsche


signature.asc
Description: This is a digitally signed message part.
___
Pkg-go-maintainers mailing list
Pkg-go-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers