Bug#793938: [RFR] templates://openstreetmap-carto/{templates}

2015-08-12 Thread Justin B Rye
Christian PERRIER wrote:
> Rationale:
> --- openstreetmap-carto.old/debian/templates  2015-07-29 08:21:00.137809322 
> +0200
> +++ openstreetmap-carto/debian/templates  2015-08-08 08:26:44.035687192 
> +0200
> @@ -1,14 +1,18 @@
>  Template: openstreetmap-carto/fetch-data
>  Type: boolean
> +_Description: Download OpenStreetMap data files from the Internet?
> + The openstreetmap-carto stylesheet uses several data files that must
> + be downloaded from the Internet. 
> + .
> + If you choose not to do this now, it can be done manually later
> + by running the "get-shapefiles.sh" script in the 
> /usr/share/openstreetmap-carto
>   directory.
> 
> Split in two paragraphs for readability.
> 
> I'm not fond of "from the web" and prefer "from the Internet"

As always, the missing element in the installer package's
documentation is "why is this an installer and not just an ordinary
package?" - an especially mysterious question when it's in main.
Should we be including warning hints such as the word "multigigabyte"?
  
>  Template: openstreetmap-carto/database-name
>  Type: string
>  Default: gis
> +_Description: PostgreSQL database name:
> + The openstreetmap-carto stylesheet uses a PostgreSQL database to
> + store OpenStreetMap data.
> + .
> + Please choose the name for this database.

I hope it's not just that my brain's exhausted from the last one, but
this already looks good to me.

Even the package description:

> Package: openstreetmap-carto
[...]
> Description: standard OpenStreetMap Mapnik stylesheet
>  This package provides the standard OpenStreetMap stylesheet for Mapnik, built
>  from the CartoCSS source. It also provides the necessary icons, and the 
> script
>  to download the necessary shapefiles.
>  .
>  This package does not provide a tileserver, or perform tile rendering.

As I say, I'd be interested to know *why* the shapefiles have to be
downloaded from the Internet, but apart from that I don't actually
have any changes to suggest!
-- 
JBR with qualifications in linguistics, experience as a Debian
sysadmin, and probably no clue about this particular package

___
Pkg-grass-devel mailing list
Pkg-grass-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-grass-devel


Bug#793938: [RFR] templates://openstreetmap-carto/{templates}

2015-08-11 Thread Christian PERRIER
Please find, for review, the debconf templates and packages descriptions for 
the openstreetmap-carto source package.

This review will last from Wednesday, August 12, 2015 to Saturday, August 22, 
2015.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, a summary will be sent to the review bug report,
and a mail will be sent to this list with "[BTS]" as a subject tag.

Rationale:
--- openstreetmap-carto.old/debian/templates2015-07-29 08:21:00.137809322 
+0200
+++ openstreetmap-carto/debian/templates2015-08-08 08:26:44.035687192 
+0200
@@ -1,14 +1,18 @@
 Template: openstreetmap-carto/fetch-data
 Type: boolean
-_Description: Fetch data files from the web?
- The openstreetmap-carto stylesheet uses several datafiles, this package
- includes a script to fetch these from the web. This can be done manually later
- by running the get-shapefiles.sh script in the /usr/share/openstreetmap-carto
+_Description: Download OpenStreetMap data files from the Internet?
+ The openstreetmap-carto stylesheet uses several data files that must
+ be downloaded from the Internet. 
+ .
+ If you choose not to do this now, it can be done manually later
+ by running the "get-shapefiles.sh" script in the 
/usr/share/openstreetmap-carto
  directory.

Split in two paragraphs for readability.

I'm not fond of "from the web" and prefer "from the Internet"

 
 Template: openstreetmap-carto/database-name
 Type: string
 Default: gis
-_Description: Name of the postgresql database:
- The stylesheet describes how to render OpenStreetMap data contained within a
- postgresql database. The name of the database is by default debian-osm-carto.
+_Description: PostgreSQL database name:
+ The openstreetmap-carto stylesheet uses a PostgreSQL database to
+ store OpenStreetMap data.
+ .
+ Please choose the name for this database.

Use standard capitalization of PostgreSQL.

I simplified the sentence, but I hope that what I propose is correct.

Note that the mention about the default is dropped. I find it
confusing, particularly because the default is indeed "gis" from what
I read.

-- 


Template: openstreetmap-carto/fetch-data
Type: boolean
_Description: Download OpenStreetMap data files from the Internet?
 The openstreetmap-carto stylesheet uses several data files that must
 be downloaded from the Internet. 
 .
 If you choose not to do this now, it can be done manually later
 by running the "get-shapefiles.sh" script in the /usr/share/openstreetmap-carto
 directory.

Template: openstreetmap-carto/database-name
Type: string
Default: gis
_Description: PostgreSQL database name:
 The openstreetmap-carto stylesheet uses a PostgreSQL database to
 store OpenStreetMap data.
 .
 Please choose the name for this database.
--- openstreetmap-carto.old/debian/templates2015-07-29 08:21:00.137809322 
+0200
+++ openstreetmap-carto/debian/templates2015-08-08 08:26:44.035687192 
+0200
@@ -1,14 +1,18 @@
 Template: openstreetmap-carto/fetch-data
 Type: boolean
-_Description: Fetch data files from the web?
- The openstreetmap-carto stylesheet uses several datafiles, this package
- includes a script to fetch these from the web. This can be done manually later
- by running the get-shapefiles.sh script in the /usr/share/openstreetmap-carto
+_Description: Download OpenStreetMap data files from the Internet?
+ The openstreetmap-carto stylesheet uses several data files that must
+ be downloaded from the Internet. 
+ .
+ If you choose not to do this now, it can be done manually later
+ by running the "get-shapefiles.sh" script in the 
/usr/share/openstreetmap-carto
  directory.
 
 Template: openstreetmap-carto/database-name
 Type: string
 Default: gis
-_Description: Name of the postgresql database:
- The stylesheet describes how to render OpenStreetMap data contained within a
- postgresql database. The name of the database is by default debian-osm-carto.
+_Description: PostgreSQL database name:
+ The openstreetmap-carto stylesheet uses a PostgreSQL database to
+ store OpenStreetMap data.
+ .
+ Please choose the name for this database.
Source: openstreetmap-carto
Maintainer: Debian GIS Project 
Uploaders: Christopher Baines 
Section: graphics
Priority: optional
Build-Depends: debhelper (>= 9.0.0),
   node-carto,
   po-debconf
Standards-Version: 3.9.6
Vcs-Browser: https://anonscm.debian.org/cgit/pkg-grass/openstreetmap-carto.git
Vcs-Git: git://anonscm.debian.org/pkg-grass/openstreetmap-carto.git
Homepage: https://github.com/gravitystorm/openstreetmap-carto

Package: openstreetmap-carto
Architecture: all
Depends: ${misc:Depends},
 ttf-dejavu,
 curl,
 unzip,