Re: RFS: sosi2osm/1.0.0-1 [ITP]

2014-10-13 Thread Sebastiaan Couwenberg 
On 10/13/2014 11:19 PM, Ruben Undheim wrote:
> I've already made Andreas upload one package for me today, but I
> thought that since this package is a new one, I would spare Andreas
> from some work. But if I tell him that you've reviewed it, it will
> probably make his job a bit easier.

That's very considerate, but I don't expect any problems with small
packages like these.

> Regarding override_dh_auto_install: It is actually used. It prevents
> the broken "make install" from running and lets sosi2osm.install take
> care of which files should be installed. If I remove it, I will have
> to create a patch that fixes the make install target. I could do that,
> or I could add a comment to the rules file stating why it's there..
> Which one ?

That's a good reason to keep it, adding a comment explaining that `make
install` is explicitly skipped is a good idea.

Kind Regards,

Bas

-- 
 GPG Key ID: 4096R/E88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146  50D1 6750 F10A E88D 4AF1


___
Pkg-grass-devel mailing list
Pkg-grass-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-grass-devel

Re: RFS: sosi2osm/1.0.0-1 [ITP]

2014-10-13 Thread Sebastiaan Couwenberg 
On 10/13/2014 09:37 PM, Ruben Undheim wrote:
> Is there anyone here who would like to sponsor the package sosi2osm?

I'm pretty sure Andreas Tille will be happy to sponsor it, just add it
to the wiki:

https://wiki.debian.org/DebianPureBlends/SoB

> It is a new package but already part of the DebianGIS/osm blend and
> the git repo is found here:
>  git://anonscm.debian.org/pkg-grass/sosi2osm.git

A quick review of your package shows that you have an unused
override_dh_auto_install in debian/rules which should be removed.

Other than that it looks good. Thanks for your work!

Kind Regards,

Bas

-- 
 GPG Key ID: 4096R/E88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146  50D1 6750 F10A E88D 4AF1


___
Pkg-grass-devel mailing list
Pkg-grass-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-grass-devel