Bug#665799: maven-debian-helper: jar files installed to /usr/share/java AND /usr/share/maven-repo

2012-03-27 Thread tony mancill
Ludovic,

Is this behavior change okay with you?  If so, do you mind if I prepare
an upload of maven-debian-helper that includes James' patch?

Thank you,
tony

On 03/26/2012 02:04 AM, James Page wrote:
 Package: maven-debian-helper
 Version: 1.5
 Severity: normal
 Tags: patch
 User: ubuntu-de...@lists.ubuntu.com
 Usertags: origin-ubuntu precise ubuntu-patch
 
 Dear Maintainer,
 
 Version 1.5 of maven-debian-helper installs jar files to both /usr/share/java
 and into /usr/share/maven-repo for the original group/artifact/version path.
 
 This results in a bigger than normal .deb file as the code is installed twice.
 
 In Ubuntu, the attached patch was applied to achieve the following:
 
   * maven-debian-plugin/.../SysInstallMojo.java: Don't install jar
 file to /usr/share/maven-repo when also installing to /usr/share/java
 - just symlink it (LP: #965054).
 
 I've tested this on packages with install to /usr/share/java and those that 
 don't
 - the jars where just installed once with the correct symlinks created.
 
 Thanks for considering the patch.



signature.asc
Description: OpenPGP digital signature
__
This is the maintainer address of Debian's Java team
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-java-maintainers. 
Please use
debian-j...@lists.debian.org for discussions and questions.

Bug#665799: maven-debian-helper: jar files installed to /usr/share/java AND /usr/share/maven-repo

2012-03-26 Thread James Page
Package: maven-debian-helper
Version: 1.5
Severity: normal
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu precise ubuntu-patch

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Dear Maintainer,

Version 1.5 of maven-debian-helper installs jar files to both /usr/share/java
and into /usr/share/maven-repo for the original group/artifact/version path.

This results in a bigger than normal .deb file as the code is installed twice.

In Ubuntu, the attached patch was applied to achieve the following:

  * maven-debian-plugin/.../SysInstallMojo.java: Don't install jar
file to /usr/share/maven-repo when also installing to /usr/share/java
- just symlink it (LP: #965054).

I've tested this on packages with install to /usr/share/java and those that 
don't
- - the jars where just installed once with the correct symlinks created.

Thanks for considering the patch.


- -- System Information:
Debian Release: wheezy/sid
  APT prefers precise-updates
  APT policy: (500, 'precise-updates'), (500, 'precise-security'), (500, 
'precise')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-20-generic (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAEBCAAGBQJPcDEQAAoJEL/srsug59jD05YP/R/LV1aQhDHNqNQCYzjXXtMw
jRMvVOdK4SJmlkO20FsI37JrIw8jH9WhwnRrRoG2N+6H8eg+EutMldkeHoN1wDIj
EgB4x3NcPOnELYz3blqwp6dSisqUfPBSC7VniiSp9rrD7iGw6amYtW1bOG/ccLLb
in75elmcVjp8oP/xb2xkL5kUQ8h6VIwWwa3E4Nn4lPfP8uhKwP7TT3XI47fNiRmp
YOYGLLYAAXHu5CjuQEKICpzRK3XPgrPOBdYjczBm34uZEQBnMiSJFJ/yx9yHZvcG
po5HNd+HPIpfEtJ7gpeKHqfxCZMrxmL6FmIiCPniRdga9xF1SPhsNwAYu3BRmIxt
pE8vgBBdpn1IvrNG+CyGkXuKrAjkqb5YMbG4m2Z7LeGztmQd+EznIb99ZNcZvA4n
11CerqVKFjKx5lNRM3/sjq1jKNSnjzMUBuZiJN7WSRk/d+kobtU/G4KOke7Jq7Ly
w3ONsOkoMS2Cu6hv/SsRU0DIe5tmI9WnrK+mZR9/Q8zhX4u3yagpMepky5A4+dOs
D956t3rLEdy4pU1vAJ2PJm2b4vpoNeeat8eYFPTebhA1PJD6YzrNodqnvx6Evr34
Gv4zib6rZDU57z6Qroz/vtve/qUS6/xf92ojAxhC5W6tTdtubCGzJ8r+iGV89Gor
CgenRav0opllHQgCvroU
=mbNH
-END PGP SIGNATURE-
=== modified file 'maven-debian-plugin/src/main/java/org/debian/maven/plugin/SysInstallMojo.java'
--- maven-debian-plugin/src/main/java/org/debian/maven/plugin/SysInstallMojo.java	2012-01-24 23:55:22 +
+++ maven-debian-plugin/src/main/java/org/debian/maven/plugin/SysInstallMojo.java	2012-03-26 08:22:06 +
@@ -460,7 +460,6 @@
 if (jarFile.exists()) {
 System.out.println(Install jar for  + artifactId +  into /usr/share/java);
 mkdir(compatSharePath());
-FileUtils.copyFile(jarFile, new File(jarDestPath()));
 if (noUsjVersionless) {
 FileUtils.copyFile(jarFile, new File(versionedFullCompatPath()));
 } else {

__
This is the maintainer address of Debian's Java team
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-java-maintainers. 
Please use
debian-j...@lists.debian.org for discussions and questions.