Bug#765563: closure-compiler: does not work when there are spaces in the path/name of the JavaScript file

2014-10-19 Thread tony mancill 
On 10/17/2014 01:58 AM, Eerste Laatste wrote:
 Tony, it works for me with the double quotes added as shown below:
 --
 #!/bin/sh
 
 . /usr/lib/java-wrappers/java-wrappers.sh
 
 MAIN=com.google.javascript.jscomp.CommandLineRunner
 JARS=closure-compiler
 
 find_java_runtime
 find_jars ${JARS}
 ###ORIGINAL: run_java ${MAIN} $@
 ###CHANGED:
 run_java ${MAIN} $@
 --
 
 (maybe for future safety, ${JARS} and ${MAIN} should be quoted too)

Hi,

Thanks for testing the idea.  I have updated the wrapper script.

In this case, I think JARS and MAIN are safe, as find_jars doesn't
require quoting multiple args, and neither the jar names nor the
classname should contain spaces.

Thank you,
tony



signature.asc
Description: OpenPGP digital signature
__
This is the maintainer address of Debian's Java team
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-java-maintainers. 
Please use
debian-j...@lists.debian.org for discussions and questions.

Bug#765563: closure-compiler: does not work when there are spaces in the path/name of the JavaScript file

2014-10-17 Thread Eerste Laatste 
Thanks for your efforts Tony !
It seems to be the wrapper, i get this using upstream jar, Debian jar , Debian 
wrapper:
$ java -jar compiler.jar --warning_level VERBOSE --jscomp_warning=checkTypes 
--compilation_level SIMPLE_OPTIMIZATIONS --js=file with spaces.js 
--js_output_file=/tmp/compiled.js$ java -jar 
/usr/share/java/closure-compiler.jar --warning_level VERBOSE 
--jscomp_warning=checkTypes --compilation_level SIMPLE_OPTIMIZATIONS --js=file 
with spaces.js --js_output_file=/tmp/compiled.js$ closure-compiler 
--warning_level VERBOSE --jscomp_warning=checkTypes --compilation_level 
SIMPLE_OPTIMIZATIONS --js=file with spaces.js 
--js_output_file=/tmp/compiled.jsERROR - Cannot read: file
ERROR - Cannot read: spaces.js
ERROR - Cannot read: with
3 error(s), 0 warning(s)$


 Date: Thu, 16 Oct 2014 21:04:41 -0700
 From: tmanc...@debian.org
 To: hoekb...@hotmail.com; 765...@bugs.debian.org
 Subject: Re: Bug#765563: closure-compiler: does not work when there are 
 spaces in the path/name of the JavaScript file
 
 On 10/16/2014 02:39 AM, Eerste Laatste wrote:
  Package: closure-compiler
  Version: 20130227+dfsg1-6
  Severity: normal
  
  Dear Maintainer,
  
  Using closure-compiler fails when there are spaces in the path/name of a
  JavaScript file even when specifying them like:
  
  /path name with spaces/and or/script name with spaces.js
  or
  '/path name/with spaces/and or/script name with spaces.js'
  or
  /path\ name/with\ spaces/and\ or/script\ name\ with\ spaces.js
 
 Hi Eerste,
 
 Thank you for the bug report.  I'll have to take a look to see if might
 be an issue with the wrapper script (as opposed to an upstream issue).
 
 Cheers,
 tony
 
 
  __
This is the maintainer address of Debian's Java team
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-java-maintainers. 
Please use
debian-j...@lists.debian.org for discussions and questions.

Bug#765563: closure-compiler: does not work when there are spaces in the path/name of the JavaScript file

2014-10-17 Thread Eerste Laatste 
Tony, it works for me with the double quotes added as shown 
below:--#!/bin/sh
. /usr/lib/java-wrappers/java-wrappers.sh
MAIN=com.google.javascript.jscomp.CommandLineRunnerJARS=closure-compiler
find_java_runtimefind_jars ${JARS}###ORIGINAL: run_java ${MAIN} 
$@###CHANGED:run_java ${MAIN} 
$@--
(maybe for future safety, ${JARS} and ${MAIN} should be quoted too)
From: hoekb...@hotmail.com
To: tmanc...@debian.org; 765...@bugs.debian.org
Subject: RE: Bug#765563: closure-compiler: does not work when there are spaces 
in the path/name of the JavaScript file
Date: Fri, 17 Oct 2014 08:37:44 +




Thanks for your efforts Tony !
It seems to be the wrapper, i get this using upstream jar, Debian jar , Debian 
wrapper:
$ java -jar compiler.jar --warning_level VERBOSE --jscomp_warning=checkTypes 
--compilation_level SIMPLE_OPTIMIZATIONS --js=file with spaces.js 
--js_output_file=/tmp/compiled.js$ java -jar 
/usr/share/java/closure-compiler.jar --warning_level VERBOSE 
--jscomp_warning=checkTypes --compilation_level SIMPLE_OPTIMIZATIONS --js=file 
with spaces.js --js_output_file=/tmp/compiled.js$ closure-compiler 
--warning_level VERBOSE --jscomp_warning=checkTypes --compilation_level 
SIMPLE_OPTIMIZATIONS --js=file with spaces.js 
--js_output_file=/tmp/compiled.jsERROR - Cannot read: file
ERROR - Cannot read: spaces.js
ERROR - Cannot read: with
3 error(s), 0 warning(s)$


 Date: Thu, 16 Oct 2014 21:04:41 -0700
 From: tmanc...@debian.org
 To: hoekb...@hotmail.com; 765...@bugs.debian.org
 Subject: Re: Bug#765563: closure-compiler: does not work when there are 
 spaces in the path/name of the JavaScript file
 
 On 10/16/2014 02:39 AM, Eerste Laatste wrote:
  Package: closure-compiler
  Version: 20130227+dfsg1-6
  Severity: normal
  
  Dear Maintainer,
  
  Using closure-compiler fails when there are spaces in the path/name of a
  JavaScript file even when specifying them like:
  
  /path name with spaces/and or/script name with spaces.js
  or
  '/path name/with spaces/and or/script name with spaces.js'
  or
  /path\ name/with\ spaces/and\ or/script\ name\ with\ spaces.js
 
 Hi Eerste,
 
 Thank you for the bug report.  I'll have to take a look to see if might
 be an issue with the wrapper script (as opposed to an upstream issue).
 
 Cheers,
 tony
 
 

  __
This is the maintainer address of Debian's Java team
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-java-maintainers. 
Please use
debian-j...@lists.debian.org for discussions and questions.

Bug#765563: closure-compiler: does not work when there are spaces in the path/name of the JavaScript file

2014-10-16 Thread Eerste Laatste 
Package: closure-compiler
Version: 20130227+dfsg1-6
Severity: normal

Dear Maintainer,

Using closure-compiler fails when there are spaces in the path/name of a
JavaScript file even when specifying them like:

/path name with spaces/and or/script name with spaces.js
or
'/path name/with spaces/and or/script name with spaces.js'
or
/path\ name/with\ spaces/and\ or/script\ name\ with\ spaces.js


-- System Information:
Debian Release: jessie/sid
  APT prefers testing-updates
  APT policy: (500, 'testing-updates'), (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
armel

Kernel: Linux 3.16-2-amd64 (SMP w/16 CPU cores)
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages closure-compiler depends on:
ii  default-jre-headless  2:1.7-52
ii  java-wrappers 0.1.28
ii  libclosure-compiler-java  20130227+dfsg1-6

closure-compiler recommends no packages.

closure-compiler suggests no packages.

-- no debconf information

__
This is the maintainer address of Debian's Java team
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-java-maintainers. 
Please use
debian-j...@lists.debian.org for discussions and questions.

Bug#765563: closure-compiler: does not work when there are spaces in the path/name of the JavaScript file

2014-10-16 Thread tony mancill 
On 10/16/2014 02:39 AM, Eerste Laatste wrote:
 Package: closure-compiler
 Version: 20130227+dfsg1-6
 Severity: normal
 
 Dear Maintainer,
 
 Using closure-compiler fails when there are spaces in the path/name of a
 JavaScript file even when specifying them like:
 
 /path name with spaces/and or/script name with spaces.js
 or
 '/path name/with spaces/and or/script name with spaces.js'
 or
 /path\ name/with\ spaces/and\ or/script\ name\ with\ spaces.js

Hi Eerste,

Thank you for the bug report.  I'll have to take a look to see if might
be an issue with the wrapper script (as opposed to an upstream issue).

Cheers,
tony




signature.asc
Description: OpenPGP digital signature
__
This is the maintainer address of Debian's Java team
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-java-maintainers. 
Please use
debian-j...@lists.debian.org for discussions and questions.