Bug#800977: [activemq] 04/07: migrate from commons-httpclient -> httpclient

[Emmanuel Bourg]

Le 01/11/2015 16:45, tony mancill a écrit :

> Am I missing something?

Hi Tony,

I think you are right. ActiveMQ replaced commons-httpclient with
httpclient in the version 5.6.0 [1], so our package dependencies were
simply out of date and no code change is required.

Emmanuel Bourg

[1] https://github.com/apache/activemq/commit/082fdc56

__
This is the maintainer address of Debian's Java team
. 
Please use
debian-j...@lists.debian.org for discussions and questions.

Bug#800977: [activemq] 04/07: migrate from commons-httpclient -> httpclient

[tony mancill]

On 10/26/2015 02:47 PM, Emmanuel Bourg wrote:
> Hi Tony,
> 
> Le 26/10/2015 05:31, Tony Mancill a écrit :
> 
>> diff --git a/debian/control b/debian/control
>> index 84d6bde..f788c80 100644
>> --- a/debian/control
>> +++ b/debian/control
>> @@ -17,7 +17,7
>>   libcommons-daemon-java,
>> - libcommons-httpclient-java,
>> + libhttpclient-java,
>>   libcommons-io-java,
>> diff --git a/debian/maven.rules b/debian/maven.rules
>> index 9a398e5..4e17369 100644
>> --- a/debian/maven.rules
>> +++ b/debian/maven.rules
>> @@ -26,7 +26,7
>>  # Dependencies
>>  org.apache.activemq.protobuf activemq-protobuf * s/.*/1.1/ * *
>>  commons-collections commons-collections jar s/3\..*/3.x/ * *
>> -commons-httpclient commons-httpclient jar s/3\..*/3.x/ * *
>> +commons-httpclient httpclient jar s/3\..*/debian/ * *
> 
> 
> I haven't looked into the details but I don't think this is sufficient
> to transition to httpclient. The Java classes and package names are not
> the same, so a transition should imply code changes too. If it still
> builds it probably means commons-httpclient is still in the dependency
> graph at a deeper level, but activemq will FTBFS later when that other
> package referencing commons-httpclient will transition to httpclient.

Hi Emmanuel,

I went back to check to see if I was moving too quickly when I made this
change, but there are no references in the current sources to
org.apache.commons.http, but there are references to org.apache.http
found in:

> activemq-optional/src/main/java/org/apache/activemq/transport/http/HttpClientTransport.java
> activemq-optional/src/main/java/org/apache/activemq/transport/discovery/http/HTTPDiscoveryAgent.java

You are correct that libcommons-httpclient-java does get pulled in via
transitive dependencies - libaxis-java and libwagon-java are the
culprits here - but based on what I'm seeing, it appears that activemq
has been missing the build-dep on libhttpclient-java, not the other way
around.  Am I missing something?

Thank you,
tony



signature.asc
Description: OpenPGP digital signature
__
This is the maintainer address of Debian's Java team
. 
Please use
debian-j...@lists.debian.org for discussions and questions.