Bug#650882: zookeeper: zkServer.sh fails to start zookeeper

[James Page]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 04/12/11 09:14, Akira Kitada wrote:
> zkServer.sh does not work because, unlike upstream ZooKeeper
> release, $cygwin variable is not set by zkEnv.sh.

Confirmed; not normally how I use this package (either init or direct
use of jars) but it should work.

Thanks for the patch; I want to review the use of the alternatives
system for managing configuration as well which may change some of how
this package works ATM.

Regards

James

- -- 
James Page
Ubuntu Core Developer
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJO4+HtAAoJEL/srsug59jDNCkP/Rclu0JAboihN2WgXUB7LZPU
RKf6Pk39KAR4HRa70+t053lYf0eTW12tP7zD2ashz4TVPP8W5Qo3yi0l7lt3pkcQ
0BCnuI7GYaEa8T7oD4ix+4nQjbQzZ025QAuq/iLpKgKI29pGeOqjgs46DAwkCg0p
5xzbUyac4dJgFSdi3NQipbTQwPbBOwiBnO52pZAxsulWTfHy1ySbYBVZpIAE27Gc
O4jBfc02nMaQ4QCjVni9RhsMqZdNwIJuCBsUKuerJfhdabwco9CuAndpeXi6ySm+
fI+GLMggLxBSlXEqq4S1j1SOTnaSsKUbTasvDEYBjgWDM7WIA8SclKfcikpbWWlY
IGD5YtR/96chNxUsWP4iGBoc7zX/qzzQ+lWzQPvJ/UrVPyPTeUP0l49iDSHSZSKO
LOOZmMzF4OFXkKnIhxKLjxauwriIJj88nr1+ZGqqTqsHwfMGChGjPANoAs/QKsnf
Jh82bAlmFNOnaH3l1cNct6G6/LYuigqOsNt2XOuF35Ymf/shSAk5NJcDgAUH+mos
t6Cylr2SRRLYV3IoUKeu8cgofbglMZndcCOfFqAhOwkIsMsgUaL63ACnzSQtAQYL
9PCBYHOdc+gWv2vUav5KQxs/7KL2fCX/p+zagPPSZXopx6U+oCpMFrTsO+JfqFmj
yIWjKBY43d0Pi2HOaqsW
=S6Q5
-END PGP SIGNATURE-



__
This is the maintainer address of Debian's Java team
. 
Please use
debian-j...@lists.debian.org for discussions and questions.

Bug#650882: zookeeper: zkServer.sh fails to start zookeeper

[Akira Kitada]

Package: zookeeper
Version: 3.3.4+dfsg1-1
Severity: important

Dear Maintainer,

zkServer.sh does not work because, unlike upstream ZooKeeper release,
$cygwin variable is not set by zkEnv.sh.


$ sudo -u zookeeper /usr/share/zookeeper/bin/zkServer.sh start 
/etc/zookeeper/conf/zoo.cfg   
JMX enabled by default  
 
Using config:/etc/zookeeper/conf/zoo.cfg
 
/usr/share/zookeeper/bin/zkServer.sh: 1: /usr/share/zookeeper/bin/zkServer.sh: 
cygpath: not found
Using config:   
 
grep: : No such file or directory   
 
Starting zookeeper ... /usr/share/zookeeper/bin/zkServer.sh: 103: 
/usr/share/zookeeper/bin/zkServer.sh: cannot create /zookeeper_server.pid: 
Permission denied   
 
FAILED TO WRITE PID


The following patch fixes the issue.


--- /usr/share/zookeeper/bin/zkServer.sh.orig   2011-11-30 19:50:33.0 
+0900
+++ /usr/share/zookeeper/bin/zkServer.sh2011-12-04 18:12:56.0 
+0900
@@ -70,15 +70,6 @@
 echo "Using config:$2" >&2
 fi
 
-if $cygwin
-then
-ZOOCFG=`cygpath -wp "$ZOOCFG"`
-# cygwin has a "kill" in the shell itself, gets confused
-KILL=/bin/kill
-else
-KILL=kill
-fi
-
 echo "Using config: $ZOOCFG" >&2
 
 if [ -z $ZOOPIDFILE ]
@@ -126,7 +117,7 @@
 then
   echo "no zookeeper to stop (could not find file $ZOOPIDFILE)"
 else
-  $KILL -9 $(cat "$ZOOPIDFILE")
+  kill -9 $(cat "$ZOOPIDFILE")
   rm "$ZOOPIDFILE"
   echo STOPPED
 fi


-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 3.0.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/dash

Versions of packages zookeeper depends on:
ii  adduser  3.113
ii  default-jre-headless [java6-runtime-headless]1:1.6-44 
ii  libzookeeper-java3.3.4+dfsg1-1
ii  openjdk-6-jre-headless [java6-runtime-headless]  6b23~pre11-1 
ii  sun-java6-jre [java6-runtime-headless]   6.26-3   

zookeeper recommends no packages.

zookeeper suggests no packages.

-- no debconf information



__
This is the maintainer address of Debian's Java team
. 
Please use
debian-j...@lists.debian.org for discussions and questions.