Your message dated Thu, 18 May 2017 10:03:35 +0000
with message-id <e1dbihp-00012n...@fasolo.debian.org>
and subject line Bug#807686: fixed in maven-debian-helper 2.2~exp1
has caused the Debian Bug report #807686,
regarding Do not modify the debian control files during package build
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
807686: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=807686
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: maven-debian-helper
Version: 2.0
Severity: important
The files in the debian control directory should not be modified during
the build of a debian package, or in extreme cases when it can not be
avoided any such modifications must be reverted during debian/rules
clean, so that when the package build is run a second time it will do
the same thing as when run the first time.
Packages using debian-maven-helper currently does not follow this basic
rule because it makes a call to mh_resolve_dependencies as part of the
dh_auto_install invokation.
This call to mh_resolve_dependencies brings havoc and destruction to
several files in the debian directory. It modifies the debian/*.poms
file - which is not at all helpful. It adds rules that not make sense
to the debian/maven.rules and other debian/maven.*Rules files, and even
creates these when they were not previously present. This means that a
lot of the efforts spent on creating these files when making the
package are lost when the package is built, and you have to remember to
restore your work from the debian.tar.xz file before iterating the
build again.
In addition to this the call to mh_resolve_dependencies generates a lot
of entries on the debian/*.substvars file. Most of these make no sense
when mh_resolve_dependencies is run as part of a package build. The
author of the tool is aware of this since the first line in the
debian/*.substvars file it creates is a comment saying these lines
should be copied by hand to the debian/control file. This manual step
is not part of the package build, so the only thing these entries do is
generate warnings about unused tags in the debian/*.substvars file
during the build.
The one entry that makes a bit of sense is the ${maven:Depends} tag,
which could be used to add some dependencies to the binary packages.
However, this tag is not very well implemented since it lumps all the
dependencies of all binary packages as dependencies to the first binary
package that is built by the source package, and no dependencies to the
others. (The first package is usually the parent package that has no
runtime dependencies at all.) It also does not add internal
dependencies between the different binary packages being built by the
source package.
So the call to mh_resolve_dependencies has a huge set of bad unhealthy
side effects, and the one little thing that makes sense of all the
things it does it does rather poorly. So can the call to
mh_resolve_dependencies be dropped from the set of commands run by
dh_auto_install? Possibly it could be replaced with a call to another
tool that creates the ${maven:Depends} tags only and nothing else, and
in a better way than the broken way currently done by
mh_resolve_dependencies.
Calling mh_resolve_dependencies makes some sense from a tool that
creates a set of template files like e.g. mh_make, but once the
templates have been created it should not be called again, since this
will undo any effort by the maintainer of cleaning up the templates of
thing that are not needed or useful for this particular package.
I managed to create a hack in some packages I recently converted to use
maven-debian-helper so that the call to mh_resolve_dependencies was
replace by a no-op, but should such hacks be needed in order for the
package to work as expected?
Mattias
signature.asc
Description: This is a digitally signed message part
--- End Message ---
--- Begin Message ---
Source: maven-debian-helper
Source-Version: 2.2~exp1
We believe that the bug you reported is fixed in the latest version of
maven-debian-helper, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 807...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Emmanuel Bourg <ebo...@apache.org> (supplier of updated maven-debian-helper
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Thu, 18 May 2017 11:46:22 +0200
Source: maven-debian-helper
Binary: maven-debian-helper
Architecture: source all
Version: 2.2~exp1
Distribution: experimental
Urgency: medium
Maintainer: Debian Java Maintainers
<pkg-java-maintainers@lists.alioth.debian.org>
Changed-By: Emmanuel Bourg <ebo...@apache.org>
Description:
maven-debian-helper - Helper tools for building Debian packages with Maven
Closes: 703373 758611 807686 840787 859012 862894
Changes:
maven-debian-helper (2.2~exp1) experimental; urgency=medium
.
* Team upload.
.
[ Christopher Hoskin ]
* Fix "Do not modify the debian control files during package build"
Add a --build option to DependenciesSolver to suppress overwriting poms
and rules files (Closes: #807686)
.
[ tony mancill ]
* Update verbiage in copyright holder prompt to be gender-neutral.
Thanks to Tom Mable for the bug report. (Closes: #859012)
.
[ Emmanuel Bourg ]
* Add the debian.hasPackageVersion property in the installed poms when
the --has-package-version option is specified (Closes: #862894)
* Replaced the suggested dependency on devscripts with licensecheck
and fixed the error message in mh_make when licensecheck isn't installed
(Closes: #840787)
* Removed mvn-debian (Closes: #703373)
* Clarified the 'Include all modules?' question (Closes: #758611)
Checksums-Sha1:
4987e5d8bc9410e4fcd177c9691cc712c1c605a5 2193 maven-debian-helper_2.2~exp1.dsc
a6dddac9761108dd972f8063734bbc81b0f89003 87164
maven-debian-helper_2.2~exp1.tar.xz
3d5ce31a8c6630f3b6d5d36d8fbfc73740398a91 115050
maven-debian-helper_2.2~exp1_all.deb
f543a76f9880910fc80a8314c48a9e713d833818 13624
maven-debian-helper_2.2~exp1_amd64.buildinfo
Checksums-Sha256:
cbb8f38a59ec03223aa0b9164a3cb84c39c068a9879c65c05aa4d19d28b0d15b 2193
maven-debian-helper_2.2~exp1.dsc
3f1ea83e11e3dd0dd1e0cfb66b3dedd18e7418012445e19f7a7510884207227d 87164
maven-debian-helper_2.2~exp1.tar.xz
446173ad289140dc6e177bda1581c95ebd79a445f8419649e0350f28b3592bad 115050
maven-debian-helper_2.2~exp1_all.deb
1cbebb95228b316dd6848a8d24c91a0e25635e83741e30df11aad389309c0635 13624
maven-debian-helper_2.2~exp1_amd64.buildinfo
Files:
6e2eae8314a5c520ed17b82868294455 2193 java optional
maven-debian-helper_2.2~exp1.dsc
c298eda198aba6a43ae97dabd7fe54bf 87164 java optional
maven-debian-helper_2.2~exp1.tar.xz
2c2712b413382dfae1801ca8e2c66aec 115050 java optional
maven-debian-helper_2.2~exp1_all.deb
b56003366eaa58377bfe8fe6acd202e2 13624 java optional
maven-debian-helper_2.2~exp1_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEuM5N4hCA3PkD4WxA9RPEGeS50KwFAlkdbd8ACgkQ9RPEGeS5
0KzZlA//TBBhKhzLrTVKDFiX6tt7IL9MsrydKYN4XigzLBuH9ahX/72D0PZeBLpp
9ybeuvxk3yH95f0I3kz1Kq3ysz71jxiVU/ZVyONaU9wMaZDDdfHXMGIE+YSc8mdj
VneoQRatM1AfgZJro2MYRfT3A3SorkaUz0D73z0bnggAoQLp9iUAYrjYCvf2TgK5
SjzJQQBXGCkRVfoz3vAiTWXBoLqpVUBrO8OL2CcOuqRQJ6XsS0jHvOew5uQVIcay
kJLH3Rh6hTzAZS2fagXXSxC8UHR+YhMZfi5yl8I6dumAmp6QG5cmYYGq0eY2dy3m
DUf13rElr633DjWVM87jbJoHlRfmUvaGtN+R4D9d8cI9wutgq9WR5h8gm6MA3bpx
65r9iJ+/pQWCTFmTxmLGXKZmRTju8cyxG9YGFnNAT4AqDjcNN69JYN61mES50O79
gOdHciMwloTtGpgT5KW9MbTbr+XPM35ry7t2x088BuXIvzT+pcgXxHGUQlu/ddxD
H/RdWxLS4JfiKalLvlO43lf03IdV5KzK5RoO6247mOHul6KLsrC2FNdxgF1Rlmyw
+F3CcZ1GbGUrH5+LlTYNkQ3Ty/RdxTtizOcG9vcXv0A88+U3Xn9h0s3lpUZ9L//x
U8oi4MV5ip6mwpFjiZlW6duY7lKRoYJ/ke+7ZDSDXbAw/Vsp/HU=
=kEGA
-----END PGP SIGNATURE-----
--- End Message ---
__
This is the maintainer address of Debian's Java team
<http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-java-maintainers>.
Please use
debian-j...@lists.debian.org for discussions and questions.
