Your message dated Thu, 10 Jan 2019 21:21:11 +0000
with message-id <e1ghhlh-0009vb...@fasolo.debian.org>
and subject line Bug#895029: fixed in node-stringprep 0.8.0-4
has caused the Debian Bug report #895029,
regarding node-stringprep: FTBFS with recent GCC
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
895029: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=895029
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: node-stringprep
Version: 0.8.0-3
Tags: patch buster sid
Hi Jonas
While rebuilding node-stringprep for the nodejs-abi-57 in Ubuntu, it
FTBFS with a recent version of GCC. I found a pull request against
upstream's github which fixed the build and I have attached it here.
According to reproducible builds' logs [1], node-stringprep hasn't
failed for this reason yet, but it hasn't be tried since 2018-02-20. It
is failing in Buster for a different reason though.
Regards
Graham
[1]
https://tests.reproducible-builds.org/debian/history/amd64/node-stringprep.html
Description: Fixed compilation errors by adding casts
Forwarded: https://github.com/astro/node-stringprep/pull/96/commits/fa08ad0da41bfc11e82b703c4ba26fee9481591f
Author: James Bunton <jbun...@atlassian.com>
Last-Update: 2017-09-04
--- a/node-stringprep.cc
+++ b/node-stringprep.cc
@@ -119,7 +119,7 @@
error = U_ZERO_ERROR;
dest = new UChar[destLen];
size_t w = usprep_prepare(profile,
- *str, str.length(),
+ (const UChar*)*str, str.length(),
dest, destLen,
USPREP_DEFAULT, NULL, &error);
@@ -141,7 +141,7 @@
destLen = w;
}
- Local<Value> result = Nan::New<String>(dest, destLen).ToLocalChecked();
+ Local<Value> result = Nan::New<String>((uint16_t*)dest, destLen).ToLocalChecked();
delete[] dest;
return scope.Escape(result);
}
@@ -212,7 +212,7 @@
UIDNAInfo uinfo = UIDNA_INFO_INITIALIZER;
size_t w = uidna_nameToUnicode(
uidna,
- *str, str.length(),
+ (const UChar*)*str, str.length(),
dest, destLen,
&uinfo, &error);
@@ -235,7 +235,7 @@
destLen = w;
}
- Local<String> result = Nan::New<String>(dest, destLen).ToLocalChecked();
+ Local<String> result = Nan::New<String>((uint16_t*)dest, destLen).ToLocalChecked();
delete[] dest;
uidna_close(uidna);
info.GetReturnValue().Set(result);
@@ -266,7 +266,7 @@
UIDNAInfo uinfo1 = UIDNA_INFO_INITIALIZER;
size_t destLen = uidna_nameToASCII(
uidna,
- *str, strLen,
+ (const UChar*)*str, strLen,
NULL, 0,
&uinfo1, &error);
UChar *dest = NULL;
@@ -278,7 +278,7 @@
UIDNAInfo uinfo2 = UIDNA_INFO_INITIALIZER;
uidna_nameToASCII(
uidna,
- *str, strLen,
+ (const UChar*)*str, strLen,
dest, destLen,
&uinfo2, &error);
if (U_SUCCESS(error) && uinfo2.errors > 0)
@@ -295,7 +295,7 @@
return;
}
- Local<String> result = Nan::New<String>(dest, destLen).ToLocalChecked();
+ Local<String> result = Nan::New<String>((uint16_t*)dest, destLen).ToLocalChecked();
delete[] dest;
uidna_close(uidna);
info.GetReturnValue().Set(result);
--- End Message ---
--- Begin Message ---
Source: node-stringprep
Source-Version: 0.8.0-4
We believe that the bug you reported is fixed in the latest version of
node-stringprep, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 895...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Xavier Guimard <y...@debian.org> (supplier of updated node-stringprep package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Thu, 10 Jan 2019 21:49:17 +0100
Source: node-stringprep
Binary: node-node-stringprep
Architecture: source
Version: 0.8.0-4
Distribution: unstable
Urgency: medium
Maintainer: Debian Javascript Maintainers
<pkg-javascript-de...@lists.alioth.debian.org>
Changed-By: Xavier Guimard <y...@debian.org>
Closes: 895029
Description:
node-node-stringprep - ICU StringPrep profiles for Node
Changes:
node-stringprep (0.8.0-4) unstable; urgency=medium
.
* Team upload
.
[ Jérémy Lal ]
* Move to salsa
* Refresh control
.
[ Xavier Guimard ]
* Fix compilation errors with 2 patches (Closes: #895029)
* Add minimal autopkgtest files
* Declare compliance with policy 4.3.0
* Change section to javascript
* Bump debhelper compatibility level to 10 (due to cdbs)
* Update debian/copyright links
* Update debian/control links
* Set hardening flags
* Update build dependencies:
- libnode-dev instead of nodejs-dev
- node-gyp >= 3.8.0-2s
* Remove useless dh_nodejs
Checksums-Sha1:
cdb718f2e368460ed293ca4e56e59e1a629978f0 2120 node-stringprep_0.8.0-4.dsc
1af67318d283e8147d5cc579b122e395f74ac804 6592
node-stringprep_0.8.0-4.debian.tar.xz
Checksums-Sha256:
4cd45e4a55fb2b726a55243c967f4eb3ea52065dba8137cfa1acd215d5f8de29 2120
node-stringprep_0.8.0-4.dsc
41607bf2db2350b21efbfabb69cd637124d0ff661e619f73405dbb9deec606cf 6592
node-stringprep_0.8.0-4.debian.tar.xz
Files:
f6887036ccc5669776f72bab1504f711 2120 javascript optional
node-stringprep_0.8.0-4.dsc
e0d1ef450bbcb048743a852b1f844006 6592 javascript optional
node-stringprep_0.8.0-4.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
iQJEBAEBCgAuFiEEAN/li4tVV3nRAF7J9tdMp8mZ7ukFAlw3sLQQHHlhZGRAZGVi
aWFuLm9yZwAKCRD210ynyZnu6Z+7D/9G3e9UA9HVMYkr5YAUp/K9NUH/pouWi/BD
R+rQmAdyHru5hS6s+dOxhY4+aUUCbTbhjbH8XqKGMLs6miqp5IxLFmEhp0+4hb4u
OPvr57lrZpIsOTJ/GyQtT4UvE/vSaIT326Jh6Xqc+0igX2FjXZLNJ6TtDsXHACv/
JNmtHCiYOUo2kvCiEGxQCQb4WC8X1x1vGACEIw+F/gv24gB6jgAdSDKh+jxXcvRC
HlptXQhJLzR5e3+DDz3GMs/HoNwF/5Y0KN0sa17bluxF7BgecHQys+nCa5UhcKtH
umdHeF0k6TNf0uc2gZpS1Hrs5SYjZuRPBG05rXwmr8HAL/CYcJrff4KHDMlARFJ3
MS1/KeY7VT4kb3C2UqHZKrgGHYHHuTA/OHKpzJ/0dEz/Pg+lw6cP3fBZwuYwlIup
6WlQpwBCPFetqGXg0b9t7woulW9PYxYOHzRuO9RMWLmEmDwvQ9HWIW2ib3fv9atM
rsBGsSwLkCJz7iUpym4P0jJrf9t6l4wgxMA7J4ykH8oEkU9LaIknOulW9gdEwtyB
DgwH60pG/xGkRzIN1RCaz5JZakAp3VeccC7IY6nqq380NS/R4x1r/fZMWi6E0qXP
VDMI8yfjIhmDLCqyebYZ+zkQJWBdWnCLlyWTF7kMBXMM1VLlaipAAa+9qmWl/xei
fCGcHONOqg==
=ccfL
-----END PGP SIGNATURE-----
--- End Message ---
--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel
