ed to (e.g.) Go.
Unfortunately, all this is only for libraries; noticing that a binary
package that installs something into /usr/bin needs rebuilding is
manual. I think it could be extended, but it all depends on cdbs, so
no-one wants to touch it.
--
Sean Whitton
signature.asc
Description: PGP signa
team's preference, and I believe
they took the needs of the security team into account in coming to that
preference.
--
Sean Whitton
signature.asc
Description: PGP signature
--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel
a library package is updated, you only have to build the
> packages that install binaries that use that library package. You don't
> have this game of having to build all the rdeps recursively and in the
> right order.
Ah, interesting, different indeed.
--
Sean Whitton
signature.asc
Descrip
+--+
| REJECT reasoning |
+--+
undeclared-identifiers needs a stanza in d/copyright too.
+--+
|Other comments|
+--+
Where do you get the name James Halliday? I can't see any copyright
claim for him in
Hello,
On Sun 01 Mar 2020 at 04:06PM +01, roucaries bastien wrote:
> On Sat, Feb 29, 2020 at 9:11 PM Sean Whitton
> wrote:
>> +--+
>> |Other comments|
>> +--+
>>
>> Where do you get the name James Halliday?
Hello,
It looks like a lot of the files installed by this package are
installed by node-css; shouldn't this package depend on that one
instead of embedding them?
Thanks.
--
Sean Whitton
--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth
+--+
| REJECT reasoning |
+--+
Several of the items in debian/node_modules/ already look to be
available in their own packages in sid, so certainly don't need to be
bundled here anymore.
Presumably the other modules in there should be broken out into
Hello,
d/copyright is a bit confusing -- dist/css has been removed but "we
are installing it directly" ...?
Also, the Comment field for "Files: *" seems to be saying precisely
that the files are not in their preferred form for modification so I
think they do need to be
+--+
| REJECT reasoning |
+--+
src/scss/mixins/_gradients.scss has code from another project with
different copyright holders.
It looks like tests/unit-jq*.html depend on the file
vendor/qunit-1.23.1.css -- can the tests be run successfully without
t believe
you have answered: can the tests be run successfully without this file?
--
Sean Whitton
signature.asc
Description: PGP signature
--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel
Hello,
On Mon 13 Apr 2020 at 12:30PM +03, mer...@debian.org wrote:
> Many thanks for your comments.
Thank you for your reply!
> On 2020-04-08 17:31, Sean Whitton wrote:
>> d/copyright is a bit confusing -- dist/css has been removed but "we
>> are installing it directly
+--+
| REJECT reasoning |
+--+
Complete CDDL is required in d/copyright as the license is not in
common-licenses.
+--+
| N.B. |
+--+
This review may not be exhaustive. Please check your source
+--+
| REJECT reasoning |
+--+
Per existing e-mail discussion, tests/unit-*.html need filtering out
of the source tarball as their dependencies are not in Debian main.
+--+
| N.B. |
+--+
This
Hello,
Can you confirm we can rebuild the minified .css file using only tools
in Debian main?
(It would be better if d/rules actually rebuilt it.)
Thanks!
--
Sean Whitton
--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi
+--+
| REJECT reasoning |
+--+
khroma tarball contains package/dist/methods/mix.js which has a different
copyright holder.
+--+
| N.B. |
+--+
This review may not be exhaustive. Please check
+--+
| REJECT reasoning |
+--+
Given that the source has been repacked, you need a +dfsg or +ds version suffix.
+--+
| N.B. |
+--+
This review may not be exhaustive. Please check your source
reject old version too
===
Please feel free to respond to this email if you don't understand why
your files were rejected, or if you upload new files which address our
concerns.
--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
Hello,
On Wed 13 May 2020 at 06:29AM +03, mer...@debian.org wrote:
> OK, I think I understand the issue. Could you please reject the package
> so as I could repack and reupload it?
It seems you have already reuploaded it?
--
Sean Whitton
signature.asc
Description: PGP signature
-
(or a patch) will be added to replace path vendor/qunit-1.23.1.css with
> appropriate path in Debian, and the tests will then be run successfully.
In that case I think the files need to be filtered out, as otherwise we
would be including code in Debian main without also including all its
dependen
+--+
| REJECT reasoning |
+--+
test/fixtures/commonmark/spec.txt is under a different license.
+--+
|Other comments|
+--+
Copyright years for linkify-it and mdurl should include 2015.
ugh. They could have just asked for an explanation before rejecting.
You should ensure it's visible in the source package, in
README.{source,Debian} and/or d/changelog.
--
Sean Whitton
--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel
Hello,
On Tue 23 Jun 2020 at 01:47AM +02, Jonas Smedegaard wrote:
> Quoting Sean Whitton (2020-06-22 23:26:37)
>> Would someone want to use libjs-katex without nodejs installed?
>
> Yes: Pandoc can produce output which uses katex rendered with the
> Javascript interpret
binary package split to solve a problem and that's a
reasonable way to go about solving the problem, we'll sign off on it.
--
Sean Whitton
--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel
+--+
| REJECT reasoning |
+--+
debian/moment.js does not seem to be accounted for in d/copyright -- what is
its license and who holds copyright?
+--+
| N.B. |
+--+
This review may not be
Hello,
Can I ask why moment.js is bundled in the debian/ directory when it
seems to be available as a separate package, libjs-moment ?
Thanks.
--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
Couldn't you just upload a -2 with moment.js
removed to NEW?
--
Sean Whitton
signature.asc
Description: PGP signature
--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel
+--+
| REJECT reasoning |
+--+
chance.js contains code under a different license with different copyright
holders.
+--+
| N.B. |
+--+
This review may not be exhaustive. Please check your source
No response to prod from February.
===
Please feel free to respond to this email if you don't understand why
your files were rejected, or if you upload new files which address our
concerns.
--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
No response to prod from February.
===
Please feel free to respond to this email if you don't understand why
your files were rejected, or if you upload new files which address our
concerns.
--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
+--+
| REJECT reasoning |
+--+
LICENSE has other copyright holders not listed in d/copyright.
+--+
| N.B. |
+--+
This review may not be exhaustive. Please check your source package
against your
30 matches
Mail list logo
