[Pkg-javascript-devel] Bug#902178: node-turbolinks: Does not work as intended

2018-06-27 Thread Pirate Praveen
On Wed, 27 Jun 2018 18:10:55 +0530 Pirate Praveen 
wrote:
> I think this is the syntax used by sprokets. We may be able to patch it
> to use the regular commonjs require syntax.
> 

I have pushed a patch to salsa. Can you build and test?



signature.asc
Description: OpenPGP digital signature
-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

[Pkg-javascript-devel] Bug#902178: node-turbolinks: Does not work as intended

2018-06-27 Thread Pirate Praveen
On Wed, 27 Jun 2018 04:43:43 -0700 njos...@riseup.net wrote:
> I think the issue is with coffeescript compilation. I tried compiling it
> using the coffee command. The index.js produced has no imports at all.
> Hence, the output that is finally produced using webpack and uglifyjs is
> just the index.js file. The dist file is literally the index.js file
> with some webpack cruft added at the top.
> 
> I don't recognize the import syntax in the coffeescript files. Is this a
> new require syntax introduced in coffeescript 2.0 ? But why put them in
> comments with #= symbols? I hope it isn't a syntax that can only be
> compiled by their "blade" gem.

I think this is the syntax used by sprokets. We may be able to patch it
to use the regular commonjs require syntax.



signature.asc
Description: OpenPGP digital signature
-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

[Pkg-javascript-devel] Bug#902178: node-turbolinks: Does not work as intended

2018-06-27 Thread njoseph
I think the issue is with coffeescript compilation. I tried compiling it
using the coffee command. The index.js produced has no imports at all.
Hence, the output that is finally produced using webpack and uglifyjs is
just the index.js file. The dist file is literally the index.js file
with some webpack cruft added at the top.

I don't recognize the import syntax in the coffeescript files. Is this a
new require syntax introduced in coffeescript 2.0 ? But why put them in
comments with #= symbols? I hope it isn't a syntax that can only be
compiled by their "blade" gem.

--
Regards,
Joseph Nuthalapati

-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

[Pkg-javascript-devel] Bug#902178: node-turbolinks: Does not work as intended

2018-06-23 Thread Pirate Praveen
On Sat, 23 Jun 2018 18:44:53 +0530 Pirate Praveen 
wrote:
> Any ideas? May be we missed some options for webpack.

If we cannot emulate the build with webpack, we will have to package
blade (written in ruby).



signature.asc
Description: OpenPGP digital signature
-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

[Pkg-javascript-devel] Bug#902178: node-turbolinks: Does not work as intended

2018-06-23 Thread Pirate Praveen
On Sat, 23 Jun 2018 13:03:24 +0530 Joseph Nuthalapati
 wrote:> The turbolinks package installed through
Debian doesn't seem to have all the
> code from upstream.
> 
> The minified Javascript from the Debian package has 1448 characters while the
> dist packaged obtained from source has 36927 characters, measured using `wc`.
> This might be why the package does nothing when used in the browser.

We used webpack because the upstream build system is not packaged.

> Please fix the build mechanism of this package.

Any ideas? May be we missed some options for webpack.



signature.asc
Description: OpenPGP digital signature
-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

[Pkg-javascript-devel] Bug#902178: node-turbolinks: Does not work as intended

2018-06-23 Thread Joseph Nuthalapati
Package: node-turbolinks
Version: 5.1.1+dfsg-1
Severity: important

Dear Maintainer,

The turbolinks package installed through Debian doesn't seem to have all the
code from upstream.

The minified Javascript from the Debian package has 1448 characters while the
dist packaged obtained from source has 36927 characters, measured using `wc`.
This might be why the package does nothing when used in the browser.

Please fix the build mechanism of this package.



-- System Information:
Debian Release: buster/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.16.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_IN.utf8, LC_CTYPE=en_IN.utf8 (charmap=UTF-8), LANGUAGE=en_IN:en 
(charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

-- no debconf information

-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel