Re: [Pkg-javascript-devel] node-webfont (was: Re: Request to join the Debian JavaScript Maintainers group)

2022-12-11 Thread Yadd

On 11/12/2022 22:20, Julian Gilbey wrote:

On Sun, Dec 11, 2022 at 09:38:12PM +0100, Jonas Smedegaard wrote:

Quoting Julian Gilbey (2022-12-11 21:04:39)

Maybe create just a node-webfont package with embedded dependencies


That does seem like a sensible idea - I hadn't thought of doing that
until I read the wiki (there's a theme here!).  I doubt that most of
the packages required by webfont would be needed by other packages.


Please don't hide embedding dependencies, but install them and provide
them as virtual packages.

It is not only a matter of them being concretely needed by other
packages *now* but also being easily able to locate them if needed
*later* and for other reasons - e.g. security bugfixes.


Hi Jonas,

https://wiki.debian.org/Javascript/GroupSourcesTutorial explicitly
advises doing this.  I agree with your points, so I'm a little
confused.

I realise, though, that I don't know exactly what you mean by "install
them and provide them as virtual packages"; is it the point made in
"Step 2" on that Wiki page about adding them to d/control as Provides?
If so, then I think what is meant is: we include them all in a single
source and binary package, in this case node-webfont, but that package
should install these embedded node packages in /usr/share/nodejs/ as
normal (and not under /usr/share/nodejs/webfont) and declare Provides:
node-... for all of these dependencies.

Have I understood correctly?


If you use dh-sequence-nodejs, just add "Provides: ${nodejs:Provides}" and:

  echo '*' >debian/nodejs/root_modules

Cheers,
Yadd

--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel


Re: [Pkg-javascript-devel] node-webfont (was: Re: Request to join the Debian JavaScript Maintainers group)

2022-12-11 Thread Jonas Smedegaard
Quoting Julian Gilbey (2022-12-11 22:20:47)
> On Sun, Dec 11, 2022 at 09:38:12PM +0100, Jonas Smedegaard wrote:
> > Quoting Julian Gilbey (2022-12-11 21:04:39)
> > > > > Maybe create just a node-webfont package with embedded dependencies
> > > 
> > > That does seem like a sensible idea - I hadn't thought of doing that
> > > until I read the wiki (there's a theme here!).  I doubt that most of
> > > the packages required by webfont would be needed by other packages.
> > 
> > Please don't hide embedding dependencies, but install them and provide
> > them as virtual packages.
> > 
> > It is not only a matter of them being concretely needed by other
> > packages *now* but also being easily able to locate them if needed
> > *later* and for other reasons - e.g. security bugfixes.
> 
> Hi Jonas,
> 
> https://wiki.debian.org/Javascript/GroupSourcesTutorial explicitly
> advises doing this.  I agree with your points, so I'm a little
> confused.
> 
> I realise, though, that I don't know exactly what you mean by "install
> them and provide them as virtual packages"; is it the point made in
> "Step 2" on that Wiki page about adding them to d/control as Provides?
> If so, then I think what is meant is: we include them all in a single
> source and binary package, in this case node-webfont, but that package
> should install these embedded node packages in /usr/share/nodejs/ as
> normal (and not under /usr/share/nodejs/webfont) and declare Provides:
> node-... for all of these dependencies.
> 
> Have I understood correctly?

Yes, we agree.

 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/
 * Sponsorship: https://ko-fi.com/drjones

 [x] quote me freely  [ ] ask before reusing  [ ] keep private

signature.asc
Description: signature
-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel


Re: [Pkg-javascript-devel] node-webfont (was: Re: Request to join the Debian JavaScript Maintainers group)

2022-12-11 Thread Julian Gilbey
On Sun, Dec 11, 2022 at 09:38:12PM +0100, Jonas Smedegaard wrote:
> Quoting Julian Gilbey (2022-12-11 21:04:39)
> > > > Maybe create just a node-webfont package with embedded dependencies
> > 
> > That does seem like a sensible idea - I hadn't thought of doing that
> > until I read the wiki (there's a theme here!).  I doubt that most of
> > the packages required by webfont would be needed by other packages.
> 
> Please don't hide embedding dependencies, but install them and provide
> them as virtual packages.
> 
> It is not only a matter of them being concretely needed by other
> packages *now* but also being easily able to locate them if needed
> *later* and for other reasons - e.g. security bugfixes.

Hi Jonas,

https://wiki.debian.org/Javascript/GroupSourcesTutorial explicitly
advises doing this.  I agree with your points, so I'm a little
confused.

I realise, though, that I don't know exactly what you mean by "install
them and provide them as virtual packages"; is it the point made in
"Step 2" on that Wiki page about adding them to d/control as Provides?
If so, then I think what is meant is: we include them all in a single
source and binary package, in this case node-webfont, but that package
should install these embedded node packages in /usr/share/nodejs/ as
normal (and not under /usr/share/nodejs/webfont) and declare Provides:
node-... for all of these dependencies.

Have I understood correctly?

Best wishes,

   Julian

-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel


Re: [Pkg-javascript-devel] node-webfont (was: Re: Request to join the Debian JavaScript Maintainers group)

2022-12-11 Thread Jonas Smedegaard
Quoting Julian Gilbey (2022-12-11 21:04:39)
> > > Maybe create just a node-webfont package with embedded dependencies
> 
> That does seem like a sensible idea - I hadn't thought of doing that
> until I read the wiki (there's a theme here!).  I doubt that most of
> the packages required by webfont would be needed by other packages.

Please don't hide embedding dependencies, but install them and provide
them as virtual packages.

It is not only a matter of them being concretely needed by other
packages *now* but also being easily able to locate them if needed
*later* and for other reasons - e.g. security bugfixes.


 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/
 * Sponsorship: https://ko-fi.com/drjones

 [x] quote me freely  [ ] ask before reusing  [ ] keep private

signature.asc
Description: signature
-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel


[Pkg-javascript-devel] node-webfont (was: Re: Request to join the Debian JavaScript Maintainers group)

2022-12-11 Thread Julian Gilbey
Amazing, thanks all!

Comments and questions below

On Sun, Dec 11, 2022 at 11:39:45PM +0530, Pirate Praveen wrote:
> On Sun, Dec 11 2022 at 05:45:04 PM +01:00:00 +01:00:00, Yadd
>  wrote:
> > More simple:
> > 
> > $ pkgjs-depends @mdi/font-build

I discovered this after my initial post, reading the really helpful
wiki pages!

> > # @mdi/font-build@1.8.10
> > # 12 missing npm module(s)
> > [...]
> > 
> > MISSING:
> > @mdi/font-build@1.8.10
> >  └── webfont (9.0.0)
> >  └── svgicons2svgfont (9.2.0)
> >  └── array.prototype.flatmap (1.2.4)
> >  └── geometry-interfaces (1.1.4)
> >  └── neatequal (1.0.0)
> >  └── varstream (0.3.2)
> >  └── string.fromcodepoint (0.2.1)
> >  └── svg-pathdata (5.0.5)
> > [...]

Now what's interesting here is that this is an older version of
webfont; the newest version has fewer dependencies (hence why my list,
obtained from browsing npmjs.com, had fewer dependencies).  But I'm
not sure how strict nodejs dependencies are.  From reading the wiki,
it seems to me that the Debian JavaScript practice (policy?) is to
package the newest versions of nodejs libraries and to patch where
necessary.  Am I right about that?

> > Maybe create just a node-webfont package with embedded dependencies

That does seem like a sensible idea - I hadn't thought of doing that
until I read the wiki (there's a theme here!).  I doubt that most of
the packages required by webfont would be needed by other packages.

> I have attempted to package this earlier, you can see the existing work here
> https://salsa.debian.org/js-team/node-webfont
> 
> You can try to continue from there.

Amazing, thanks, I'll take a look!

Best wishes,

   Julian

-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel