[Pkg-javascript-devel] node-iconv-2.1.0 done
Hi team, I've packaged node-iconv usefull for iconv-lite build. Can you review it ? It packages also https://www.gnu.org/software/libiconv/ The files are on https://alioth.debian.org/anonscm/git/pkg-javascript/node-iconv.git Regards, Matthew ___ Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
Re: [Pkg-javascript-devel] node-iconv-2.1.0 done
Le lundi 05 mai 2014 à 10:52 +0200, Matthew Pideil a écrit : Hi team, I've packaged node-iconv usefull for iconv-lite build. Can you review it ? It packages also https://www.gnu.org/software/libiconv/ The files are on https://alioth.debian.org/anonscm/git/pkg-javascript/node-iconv.git You forgot to push upstream branch. This: lib/iconv.js /usr/lib/nodejs/ build/Release/iconv.node /usr/lib/nodejs/iconv should better be: lib/iconv.js /usr/lib/nodejs/iconv/ build/Release/iconv.node /usr/lib/nodejs/iconv/ Also it'd be nice to include package.json, in which case you'd need to either: * install lib directory instead of lib/iconv.js * if not, fix the main path in package.json * or add debian/links with usr/lib/nodejs/iconv/iconv.js usr/lib/nodejs/iconv/index.js I'm in favor of the first choice. Thank you. Jérémy. ___ Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
Re: [Pkg-javascript-devel] node-iconv-2.1.0 done
On 5 May 2014 12:34, Matthew Pideil matthew.pid...@teledetection.fr wrote: * install lib directory instead of lib/iconv.js * if not, fix the main path in package.json * or add debian/links with usr/lib/nodejs/iconv/iconv.js usr/lib/nodejs/iconv/index.js I don't understand what you suggest: How your first proposal will be understand without an index.js in /usr/lib/nodejs/iconv/ ? Is the package.json file interpreted and if so by 'who' ? Hi Matthew, you may want to read information reported in this wiki page: https://wiki.debian.org/Javascript/Nodejs Regards, Leo. -- Ubuntu Member - http://launchpad.net/~l3on Home Page - http://leoiannacone.com GPG Key Id - 0xD282FC25 ___ Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
Re: [Pkg-javascript-devel] node-iconv-2.1.0 done
Hi team, I've packaged node-iconv usefull for iconv-lite build. Can you review it ? It packages also https://www.gnu.org/software/libiconv/ The files are on https://alioth.debian.org/anonscm/git/pkg-javascript/node-iconv.git You forgot to push upstream branch. The pristine-tar branch isn't enough ? i believed it was required... didn't you use git-import-orig ? This: lib/iconv.js /usr/lib/nodejs/ build/Release/iconv.node /usr/lib/nodejs/iconv should better be: lib/iconv.js /usr/lib/nodejs/iconv/ build/Release/iconv.node /usr/lib/nodejs/iconv/ Also it'd be nice to include package.json, in which case you'd need to either: * install lib directory instead of lib/iconv.js * if not, fix the main path in package.json * or add debian/links with usr/lib/nodejs/iconv/iconv.js usr/lib/nodejs/iconv/index.js I don't understand what you suggest: How your first proposal will be understand without an index.js in /usr/lib/nodejs/iconv/ ? Is the package.json file interpreted and if so by 'who' ? you may want to read information reported in this wiki page: https://wiki.debian.org/Javascript/Nodejs A few more remarks: * close the node-iconv ITP bug, not the node-iconv-lite one, in which you could leave a comment about why node-iconv is favoured. (is David Prévot all right with the change of ITP owner ?) * it'd be better if you compiled and linked node-iconv against libc6 iconv, if that's possible, not against the embedded gnu libiconv copy that sits in ./deps * i had setup a collab-maint repo for node-iconv (two years ago) - am going to nuke it. Jérémy. ___ Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
