Re: [Pkg-javascript-devel] babel 7.9.6 notes

2020-05-04 Thread Xavier
Le 04/05/2020 à 10:19, Pirate Praveen a écrit :
> 
> 
> On Mon, May 4, 2020 at 9:52 am, Xavier  wrote:
>> # BUILD MODULES
>> Additional needed build modules:
>>  * @rollup/plugin-json
>>  * @rollup/
> 
> Why? Can't we use the packaged versions and adapt rollup.config.js?

Yes, probably

>>  * browserify-fs
>>  * buffer-es6
>>  * jest-worker
>>  * process-es6
>>  * rollup-plugin-node-builtins
>>  * rollup-plugin-node-globals
>>  * rollup-plugin-terser
> 
> We can skip this, patch rollup.config.js and run uglifyjs.terser in
> rules. Eventually we need to package this as we have to patch a lot of
> modules because of this. I have started work on it in salsa, but stopped
> because of issues with node-jest.

Sure

>>  * serialize-javascript
>>
>> # CHANGES
>> debian/control:
>>  * add build dependency to node-rollup-plugin-commonjs
>>  * add dependency to node-leven
>>
>> debian/rules: replace make `build-dist` by `make build build-dist`
>>
> 
> Why? build-dist depends on build.

No, not in 7.9.6

>> patches:
>>  * remove remove-trim-right.patch and remove-gulp-watch-task.diff
>>  * refresh patches
>>  * in Makefile, replace `NODE := $(YARN) node` by `NODE := node`
>>
>>
>> # REMAINING ERROR:
>> cd babel-plugin-dynamic-import-node && babeljs-7 src --out-dir lib
>> TypeError: glob pattern string required
>>     at new Minimatch (/usr/share/nodejs/minimatch/minimatch.js:116:11)
> 
> Incompatible version of minimatch? Just guessing. Verify version in
> package.json

No, problem is elsewhere (minimatch & glob version matches)

>>     at setopts (/usr/share/nodejs/glob/common.js:118:20)
>>     at new GlobSync (/usr/share/nodejs/glob/sync.js:40:3)
>>     at Function.globSync [as sync] (/usr/share/nodejs/glob/sync.js:26:10)
>>     at /usr/share/nodejs/@babel/cli/lib/babel/options.js:150:33
>>     at Array.reduce ()
>>     at parseArgv
>> (/usr/share/nodejs/@babel/cli/lib/babel/options.js:149:45)
>>     at Object.
>> (/usr/share/nodejs/@babel/cli/lib/babel/index.js:12:35)
>>     at Module._compile (internal/modules/cjs/loader.js:778:30)
>>     at Object.Module._extensions..js
>> (internal/modules/cjs/loader.js:789:10)


-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

Re: [Pkg-javascript-devel] babel 7.9.6 notes

2020-05-04 Thread Pirate Praveen



On Mon, May 4, 2020 at 9:52 am, Xavier  wrote:

# BUILD MODULES
Additional needed build modules:
 * @rollup/plugin-json
 * @rollup/


Why? Can't we use the packaged versions and adapt rollup.config.js?


 * browserify-fs
 * buffer-es6
 * jest-worker
 * process-es6
 * rollup-plugin-node-builtins
 * rollup-plugin-node-globals
 * rollup-plugin-terser


We can skip this, patch rollup.config.js and run uglifyjs.terser in 
rules. Eventually we need to package this as we have to patch a lot of 
modules because of this. I have started work on it in salsa, but 
stopped because of issues with node-jest.



 * serialize-javascript

# CHANGES
debian/control:
 * add build dependency to node-rollup-plugin-commonjs
 * add dependency to node-leven

debian/rules: replace make `build-dist` by `make build build-dist`



Why? build-dist depends on build.


patches:
 * remove remove-trim-right.patch and remove-gulp-watch-task.diff
 * refresh patches
 * in Makefile, replace `NODE := $(YARN) node` by `NODE := node`


# REMAINING ERROR:
cd babel-plugin-dynamic-import-node && babeljs-7 src --out-dir lib
TypeError: glob pattern string required
at new Minimatch (/usr/share/nodejs/minimatch/minimatch.js:116:11)


Incompatible version of minimatch? Just guessing. Verify version in 
package.json



at setopts (/usr/share/nodejs/glob/common.js:118:20)
at new GlobSync (/usr/share/nodejs/glob/sync.js:40:3)
at Function.globSync [as sync] 
(/usr/share/nodejs/glob/sync.js:26:10)

at /usr/share/nodejs/@babel/cli/lib/babel/options.js:150:33
at Array.reduce ()
at parseArgv 
(/usr/share/nodejs/@babel/cli/lib/babel/options.js:149:45)

at Object.
(/usr/share/nodejs/@babel/cli/lib/babel/index.js:12:35)
at Module._compile (internal/modules/cjs/loader.js:778:30)
at Object.Module._extensions..js 
(internal/modules/cjs/loader.js:789:10)


--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel




--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

Re: [Pkg-javascript-devel] babel 7.9.6 notes

2020-05-04 Thread Xavier
Le 04/05/2020 à 09:52, Xavier a écrit :
> # COMPONENTS
> 
> Add component: gensync
>  + authorize beta release in debian/watch ([\w\.\-]+)
>  + add it in debian/nodejs/submodules
> Add components:
>  * babel-plugin-dynamic-import-node (patch it to build with babel 7)
>  * @babel/plugin-syntax-async-generators
>  * @babel/plugin-syntax-dynamic-import
>  * @babel/plugin-syntax-export-namespace-from
>  * @babel/plugin-syntax-json-strings
>  * @babel/plugin-syntax-nullish-coalescing-operator
>  * @babel/plugin-syntax-object-rest-spread
>  * @babel/plugin-syntax-optional-catch-binding
>  * @babel/plugin-syntax-optional-chaining
>  * @babel/preset-modules
>  * levenary
> + add them in debian/nodejs/submodules (component name, not real name)
> 
> # BUILD MODULES
> Additional needed build modules:
>  * @rollup/plugin-json
>  * @rollup/
>  * browserify-fs
>  * buffer-es6
>  * jest-worker
>  * process-es6
>  * rollup-plugin-node-builtins
>  * rollup-plugin-node-globals
>  * rollup-plugin-terser
>  * serialize-javascript
> 
> # CHANGES
> debian/control:
>  * add build dependency to node-rollup-plugin-commonjs
>  * add dependency to node-leven
> 
> debian/rules: replace make `build-dist` by `make build build-dist`
> 
> patches:
>  * remove remove-trim-right.patch and remove-gulp-watch-task.diff
>  * refresh patches
>  * in Makefile, replace `NODE := $(YARN) node` by `NODE := node`
> 
> 
> # REMAINING ERROR:
> cd babel-plugin-dynamic-import-node && babeljs-7 src --out-dir lib
> TypeError: glob pattern string required
> at new Minimatch (/usr/share/nodejs/minimatch/minimatch.js:116:11)
> at setopts (/usr/share/nodejs/glob/common.js:118:20)
> at new GlobSync (/usr/share/nodejs/glob/sync.js:40:3)
> at Function.globSync [as sync] (/usr/share/nodejs/glob/sync.js:26:10)
> at /usr/share/nodejs/@babel/cli/lib/babel/options.js:150:33
> at Array.reduce ()
> at parseArgv (/usr/share/nodejs/@babel/cli/lib/babel/options.js:149:45)
> at Object.
> (/usr/share/nodejs/@babel/cli/lib/babel/index.js:12:35)
> at Module._compile (internal/modules/cjs/loader.js:778:30)
> at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)

NB: Error during rebuild with generated package


-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel