[Pkg-javascript-devel] Bug#591199: yui: does not build swf files from source
On Sat, Feb 02, 2013 at 05:15:08PM -0500, Michael Gilbert wrote: > On Sat, Feb 2, 2013 at 7:21 AM, Dominic Hargreaves wrote: > > There is no requirement that precompiled binaries must not be included > > in source packages, only that they are rebuilt. The build system for > > this package rebuilds, and overwrites > > > > examples/storage/swfstore.swf > > examples/swfstore/swfstore.swf > > examples/uploader/assets/uploader.swf > > build/connection/connection.swf > > build/swfstore/swfstore.swf > > build/uploader/assets/uploader.swf > > Correct. Those are ok as being rebuilt, but given that the files > below still need to go away, I decided to list them anyway. It would > be "cleaner" to get rid of them all, but yes that isn't necessary. > > > (leaving > > > > examples/swf/assets/SWFExampleAdvanced.swf > > examples/swf/assets/SWFExampleSimple.swf > > examples/charts/assets/expressinstall.swf > > build/charts/assets/charts.swf > > tests/swf/tests/YUIBridgeProject.swf > > > > untouched). > > The problem is that those are still sourceless, so they need to be > removed, regardless of whether they're put in the binary packages or > not. Ah, yes, you're right. I'll cancel my existing NMU and look at a repacking option instead. Cheers, Dominic. -- Dominic Hargreaves | http://www.larted.org.uk/~dom/ PGP key 5178E2A5 from the.earth.li (keyserver,web,email) ___ Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#591199: yui: does not build swf files from source
On Sat, Feb 2, 2013 at 7:21 AM, Dominic Hargreaves wrote: > There is no requirement that precompiled binaries must not be included > in source packages, only that they are rebuilt. The build system for > this package rebuilds, and overwrites > > examples/storage/swfstore.swf > examples/swfstore/swfstore.swf > examples/uploader/assets/uploader.swf > build/connection/connection.swf > build/swfstore/swfstore.swf > build/uploader/assets/uploader.swf Correct. Those are ok as being rebuilt, but given that the files below still need to go away, I decided to list them anyway. It would be "cleaner" to get rid of them all, but yes that isn't necessary. > (leaving > > examples/swf/assets/SWFExampleAdvanced.swf > examples/swf/assets/SWFExampleSimple.swf > examples/charts/assets/expressinstall.swf > build/charts/assets/charts.swf > tests/swf/tests/YUIBridgeProject.swf > > untouched). The problem is that those are still sourceless, so they need to be removed, regardless of whether they're put in the binary packages or not. Best wishes, Mike ___ Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#591199: yui: does not build swf files from source
On Sun, Nov 04, 2012 at 08:57:32PM -0500, Michael Gilbert wrote: > control: reopen -1 > > > * Several of the .swf files are now built from source and the rest have > >been removed from the package. (Closes: #591199) > > This seems to be incorrect about 2.9.0-1. The following pre-built swf > files still exist in the upstream tarball. > > ./examples/storage/swfstore.swf > ./examples/swf/assets/SWFExampleAdvanced.swf > ./examples/swf/assets/SWFExampleSimple.swf > ./examples/swfstore/swfstore.swf H > ./examples/uploader/assets/uploader.swf > ./examples/charts/assets/expressinstall.swf > ./build/connection/connection.swf > ./build/swfstore/swfstore.swf > ./build/uploader/assets/uploader.swf > ./build/charts/assets/charts.swf > ./tests/swf/tests/YUIBridgeProject.swf There is no requirement that precompiled binaries must not be included in source packages, only that they are rebuilt. The build system for this package rebuilds, and overwrites examples/storage/swfstore.swf examples/swfstore/swfstore.swf examples/uploader/assets/uploader.swf build/connection/connection.swf build/swfstore/swfstore.swf build/uploader/assets/uploader.swf (leaving examples/swf/assets/SWFExampleAdvanced.swf examples/swf/assets/SWFExampleSimple.swf examples/charts/assets/expressinstall.swf build/charts/assets/charts.swf tests/swf/tests/YUIBridgeProject.swf untouched). The only swf files installed (and only as examples in the -doc pacakge) are examples/swfstore/swfstore.swf examples/uploader/assets/uploader.swf examples/storage/swfstore.swf And these are rebuilt. I recommend that this bug severity be downgraded to important and retitled to reflect that the unrebuilt swf files present a risk if later package modifications install them by mistake. Removing them at build time is probably the safest/simplest way to do this. If there are no other comments on this bug, I will effect this change in one week. -- Dominic Hargreaves | http://www.larted.org.uk/~dom/ PGP key 5178E2A5 from the.earth.li (keyserver,web,email) ___ Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#591199: yui: does not build swf files from source
control: reopen -1 > * Several of the .swf files are now built from source and the rest have >been removed from the package. (Closes: #591199) This seems to be incorrect about 2.9.0-1. The following pre-built swf files still exist in the upstream tarball. ./examples/storage/swfstore.swf ./examples/swf/assets/SWFExampleAdvanced.swf ./examples/swf/assets/SWFExampleSimple.swf ./examples/swfstore/swfstore.swf ./examples/uploader/assets/uploader.swf ./examples/charts/assets/expressinstall.swf ./build/connection/connection.swf ./build/swfstore/swfstore.swf ./build/uploader/assets/uploader.swf ./build/charts/assets/charts.swf ./tests/swf/tests/YUIBridgeProject.swf ___ Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
