Re: [Pkg-javascript-devel] RFS: node-base64-js

2017-02-04 Thread Pirate Praveen
On ശനി 04 ഫെബ്രുവരി 2017 01:48 വൈകു, Siddhesh Rane wrote:
> Hi Praveen,
> I removed the line from changelog

Uploaded, thanks. Please import your repo to alioth. Request membership
to pkg-javascript project.

> As for pristine-tar I was confused between orig and dfsg_orig, because
> the latter is actually a modification that I made (It doesnt contain
> minified files) and hence is technically not 'pristine'. I did
> pristine-tar commit again and pushed to gitlab. The pristine-tar
> branch now contains files for both orig as well as the dfsg variant.

+dfsg is the indication that you have changed something.

pristine-tar has a different meaning, it allows anyone to recreate the
exact same orig tarball (pristine) from upstream branch. If you don't
use pristine-tar branch someone else generating the orig tarball may get
a different tar file (checksums don't match, I think its caused by
difference in newlines or something). See
https://sources.debian.net/src/pristine-tar/1.38/README/

> Should I keep both or remove the orig?

You can keep them.

> Regards
> Siddhesh Rane

PS: Its better to avoid top posting in mailing lists. See
https://en.wikipedia.org/wiki/Posting_style




signature.asc
Description: OpenPGP digital signature
-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel

Re: [Pkg-javascript-devel] RFS: node-base64-js

2017-02-04 Thread Siddhesh Rane
Hi Praveen,
I removed the line from changelog
As for pristine-tar I was confused between orig and dfsg_orig, because
the latter is actually a modification that I made (It doesnt contain
minified files) and hence is technically not 'pristine'. I did
pristine-tar commit again and pushed to gitlab. The pristine-tar
branch now contains files for both orig as well as the dfsg variant.
Should I keep both or remove the orig?
Regards
Siddhesh Rane

On Fri, Feb 3, 2017 at 3:10 PM, Pirate Praveen  wrote:
> On വെള്ളി 03 ഫെബ്രുവരി 2017 01:14 വൈകു, Siddhesh Rane wrote:
>> Hi Praveen,
>> I have uploaded the pristine-tar branch
>
> Filename is also important, you should commit
> node-base64-js_1.2.0+dfsg.orig.tar.gz instead of node-base64-js-1.2.0.tar.gz
>
> Also please remove "New Upstream release" line from changelog.
>
>
>
> --
> Pkg-javascript-devel mailing list
> Pkg-javascript-devel@lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel

-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel

Re: [Pkg-javascript-devel] RFS: node-base64-js

2017-02-03 Thread Pirate Praveen
On വെള്ളി 03 ഫെബ്രുവരി 2017 01:14 വൈകു, Siddhesh Rane wrote:
> Hi Praveen,
> I have uploaded the pristine-tar branch

Filename is also important, you should commit
node-base64-js_1.2.0+dfsg.orig.tar.gz instead of node-base64-js-1.2.0.tar.gz

Also please remove "New Upstream release" line from changelog.




signature.asc
Description: OpenPGP digital signature
-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel

Re: [Pkg-javascript-devel] RFS: node-base64-js

2017-02-02 Thread Siddhesh Rane
Hi Praveen,
I have uploaded the pristine-tar branch



On Fri, Feb 3, 2017 at 12:02 PM, Pirate Praveen
 wrote:
> On ബുധന്‍ 01 ഫെബ്രുവരി 2017 09:10 വൈകു, Siddhesh Rane wrote:
>> Hello,
>> I have packaged node module base64-js
>> (https://git.fosscommunity.in/SiddheshRane/node-base64-js) for ITP bug
>> #853853 (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=853853)
>>
>> It is lintian clean and verified with pbuilder.
>>
>> I request sponsorship for this package
>>
>> Regards
>> Siddhesh Rane
>>
> Please commit the orig tar ball in pristine-tar branch (may be you
> forgot to add --pristine-tar to gbp import-dsc option). You can use
> pristine-tar commit to add the orig tarball.
>
> Remove the following line from changelog next time.
>
> * New upstream release
>
>
> --
> Pkg-javascript-devel mailing list
> Pkg-javascript-devel@lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel

-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel

Re: [Pkg-javascript-devel] RFS: node-base64-js

2017-02-02 Thread Pirate Praveen
On ബുധന്‍ 01 ഫെബ്രുവരി 2017 09:10 വൈകു, Siddhesh Rane wrote:
> Hello,
> I have packaged node module base64-js
> (https://git.fosscommunity.in/SiddheshRane/node-base64-js) for ITP bug
> #853853 (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=853853)
> 
> It is lintian clean and verified with pbuilder.
> 
> I request sponsorship for this package
> 
> Regards
> Siddhesh Rane
>
Please commit the orig tar ball in pristine-tar branch (may be you
forgot to add --pristine-tar to gbp import-dsc option). You can use
pristine-tar commit to add the orig tarball.

Remove the following line from changelog next time.

* New upstream release



signature.asc
Description: OpenPGP digital signature
-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel

[Pkg-javascript-devel] RFS: node-base64-js

2017-02-01 Thread Siddhesh Rane
Hello,
I have packaged node module base64-js
(https://git.fosscommunity.in/SiddheshRane/node-base64-js) for ITP bug
#853853 (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=853853)

It is lintian clean and verified with pbuilder.

I request sponsorship for this package

Regards
Siddhesh Rane

-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel