Re: [Pkg-javascript-devel] Debian node-express

2014-04-30 Thread Jonas Smedegaard
Quoting Jérémy Lal (2014-04-30 11:59:08)
> Le mercredi 30 avril 2014 à 11:45 +0200, Jonas Smedegaard a écrit :
>> Quoting Leo Iannacone (2014-04-30 10:20:28)
>>> On 30 April 2014 02:39, Jérémy Lal  wrote:
 If /usr/lib/nodejs/express/package.json exists, nodejs uses it to 
 find the entry point of the module.
>>>
>>> Here more info about: 
>>> http://nodejs.org/api/modules.html#modules_folders_as_modules
>>
>> Thanks for that!  Really cool!
>>
>> I am still puzzled, however, on the concrete need for node-express to 
>> preserve its source structure to avoid patching package.json, as I 
>> see no name/main declarations in that specific package.json file.
>
> In that specific case, it is indeed unneeded.
> My personal preference is to not change it, and apparently yours is to 
> change it - no problem with that, isn't it ?

We can agree to disagree, yes, if that's what you mean.

I just wanted to make sure I wasn't missing some valuable point that 
afected also this specific case.  Seems that's not the case :-)

Thanks to both of you for educating me about the general case!  Having 
insight on that is obviously more important when being more "aggressive" 
in tidying while packaging, as I tend to do.


 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private


signature.asc
Description: signature
___
Pkg-javascript-devel mailing list
Pkg-javascript-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel

Re: [Pkg-javascript-devel] Debian node-express

2014-04-30 Thread Jérémy Lal
Le mercredi 30 avril 2014 à 11:45 +0200, Jonas Smedegaard a écrit :
> Quoting Leo Iannacone (2014-04-30 10:20:28)
> > On 30 April 2014 02:39, Jérémy Lal  wrote:
> >> If /usr/lib/nodejs/express/package.json exists, nodejs uses it to 
> >> find the entry point of the module.
> >
> > Here more info about:
> > http://nodejs.org/api/modules.html#modules_folders_as_modules
> 
> Thanks for that!  Really cool!
> 
> I am still puzzled, however, on the concrete need for node-express to 
> preserve its source structure to avoid patching package.json, as I see 
> no name/main declarations in that specific package.json file.

In that specific case, it is indeed unneeded.
My personal preference is to not change it, and apparently yours is to
change it - no problem with that, isn't it ?

Jérémy.





___
Pkg-javascript-devel mailing list
Pkg-javascript-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel

Re: [Pkg-javascript-devel] Debian node-express

2014-04-30 Thread Jonas Smedegaard
Quoting Leo Iannacone (2014-04-30 10:20:28)
> On 30 April 2014 02:39, Jérémy Lal  wrote:
>> Interesting.
>
> Really, which tools do you use to inspect files covered by some
> copyright in a software?

Depends on the needs - concretely I currently use exiftool and otfinfo.  
For more details please debcheckout ruby-compass (as I suggested), and 
let me guide you as needed in inspecting.  Package is not big.


>> If /usr/lib/nodejs/express/package.json exists, nodejs uses it to 
>> find the entry point of the module.
>
> Here more info about:
> http://nodejs.org/api/modules.html#modules_folders_as_modules

Thanks for that!  Really cool!

I am still puzzled, however, on the concrete need for node-express to 
preserve its source structure to avoid patching package.json, as I see 
no name/main declarations in that specific package.json file.


Regards,

 - Jonas


P.S.  I highly appreciate your practice of stripping irrelevant parts 
from your response, but suggest to consider including slightly more 
context than you did above - I find that my response is somewhat 
non-sensical due to the underlying parts missing.

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private


signature.asc
Description: signature
___
Pkg-javascript-devel mailing list
Pkg-javascript-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel

Re: [Pkg-javascript-devel] Debian node-express

2014-04-30 Thread Leo Iannacone
On 30 April 2014 02:39, Jérémy Lal  wrote:
> Interesting.

Really, which tools do you use to inspect files covered by some
copyright in a software?


> It's now accessible (thank you Leo) from the Nodejs page, as "best
> practice" manual:
> https://wiki.debian.org/Javascript/Nodejs/Manual
>
> it is far from perfect, though.

I know MoinMoin, you know Policy, so... If you write me something in
any language (text formatting syntax) I will more then happy to
translate it in MoinMoin :)


> If /usr/lib/nodejs/express/package.json exists, nodejs uses it to find
> the entry point of the module.

Here more info about:
http://nodejs.org/api/modules.html#modules_folders_as_modules

Leo.

-- 
Ubuntu Member - http://launchpad.net/~l3on
Home Page - http://leoiannacone.com
GPG Key Id - 0xD282FC25

___
Pkg-javascript-devel mailing list
Pkg-javascript-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel


Re: [Pkg-javascript-devel] Debian node-express

2014-04-29 Thread Jérémy Lal
Le mercredi 30 avril 2014 à 02:30 +0200, Jonas Smedegaard a écrit :
> Quoting Jérémy Lal (2014-04-30 01:43:03)
> > Le mercredi 30 avril 2014 à 00:46 +0200, Jonas Smedegaard a écrit :
> >> Hope you agree with the changes I made.  Don't hesitate to ask if in 
> >> doubt about any of it.
> >
> > Damn copyrighted ICC profile in the png file !
> > I didn't build the package before, is this something caught by 
> > copyright-check ? lintian ?
> 
> copyright-check wasn't enabled until now.  It didn't reveal the actual 
> problem, only hinted about binary data needing further investigation.
> 
> Related to this: DPKG does not like binary data in debian dir, so to 
> avoid binary noise ending in the copyright_hints file, those files need 
> to be excluded from copyright-check.  Previously I did just that - 
> relying on then checking manually those exluded files at each source 
> change.  Recently I have begun to instead extending copyright check: See 
> the packages ruby-compass and ghostscript for the details.

Interesting.

> The routine is dead slow currently.  Suggestions for optimizations is 
> appreciated.  When polished a bit I may include it in CDBS.
> 
> 
> > About package.json:
> > 
> > My idea was to include package.json as part of the module, because
> > 
> > * it is common practice to `require('./package.json').version` inside a
> > module, among other things
> > 
> > * eventually, being able to propose a "npm-integration" debian 
> > package, much like "rubygems-integration", would require access to 
> > package.json files.
> > 
> > * looking for package.json is hard-wired into nodejs, it's really not 
> > only about npm.
> > 
> > Granted, if you disagree that won't prevent node-express from running.
> > 
> > If you agree then it's only natural to keep the same relative tree as 
> > the one expected by package.json
> 
> Ok - sounds reasonable that we consistently include package.json, then.
> 
> Will you update our wiki page about that?

It's now accessible (thank you Leo) from the Nodejs page, as "best
practice" manual:
https://wiki.debian.org/Javascript/Nodejs/Manual

it is far from perfect, though.

> (...unless anyone else objects, of course)
> 
> 
> > (that's why the "lib/" dir was installed in the particular case of 
> > express, instead of the files within). It saves a patch...
> 
> I don't follow: How is install paths related to package.json inclusion?

If /usr/lib/nodejs/express/package.json exists, nodejs uses it to find
the entry point of the module.

Jérémy.



___
Pkg-javascript-devel mailing list
Pkg-javascript-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel

Re: [Pkg-javascript-devel] Debian node-express

2014-04-29 Thread Jonas Smedegaard
Quoting Jérémy Lal (2014-04-30 01:43:03)
> Le mercredi 30 avril 2014 à 00:46 +0200, Jonas Smedegaard a écrit :
>> Hope you agree with the changes I made.  Don't hesitate to ask if in 
>> doubt about any of it.
>
> Damn copyrighted ICC profile in the png file !
> I didn't build the package before, is this something caught by 
> copyright-check ? lintian ?

copyright-check wasn't enabled until now.  It didn't reveal the actual 
problem, only hinted about binary data needing further investigation.

Related to this: DPKG does not like binary data in debian dir, so to 
avoid binary noise ending in the copyright_hints file, those files need 
to be excluded from copyright-check.  Previously I did just that - 
relying on then checking manually those exluded files at each source 
change.  Recently I have begun to instead extending copyright check: See 
the packages ruby-compass and ghostscript for the details.

The routine is dead slow currently.  Suggestions for optimizations is 
appreciated.  When polished a bit I may include it in CDBS.


> About package.json:
> 
> My idea was to include package.json as part of the module, because
> 
> * it is common practice to `require('./package.json').version` inside a
> module, among other things
> 
> * eventually, being able to propose a "npm-integration" debian 
> package, much like "rubygems-integration", would require access to 
> package.json files.
> 
> * looking for package.json is hard-wired into nodejs, it's really not 
> only about npm.
> 
> Granted, if you disagree that won't prevent node-express from running.
> 
> If you agree then it's only natural to keep the same relative tree as 
> the one expected by package.json

Ok - sounds reasonable that we consistently include package.json, then.

Will you update our wiki page about that?

(...unless anyone else objects, of course)


> (that's why the "lib/" dir was installed in the particular case of 
> express, instead of the files within). It saves a patch...

I don't follow: How is install paths related to package.json inclusion?


>>> In case you're missing the time, i can review and upload later today.
>>
>> I suspect you couldn't (or shouldn't) upload yet: At least node-parseurl 
>> is missing (I haven't checked further).
>
> Yes, it's waiting in NEW.

Great.


 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private


signature.asc
Description: signature
___
Pkg-javascript-devel mailing list
Pkg-javascript-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel

Re: [Pkg-javascript-devel] Debian node-express

2014-04-29 Thread Jérémy Lal
Le mercredi 30 avril 2014 à 00:46 +0200, Jonas Smedegaard a écrit :
> Quoting Jérémy Lal (2014-04-29 16:03:04)
> > Le mardi 29 avril 2014 à 15:31 +0200, Jonas Smedegaard a écrit :
> >>> I reverted package to cdbs. Since I do not really know it, can you 
> >>> please take a look at debian/rules ensuring everything is correct?
> >>
> >> Certainly!
> 
> I have taken a look now - a thorough one.

Thank you for that.

> Hope you agree with the changes I made.  Don't hesitate to ask if in 
> doubt about any of it.

Damn copyrighted ICC profile in the png file !
I didn't build the package before, is this something caught by
copyright-check ? lintian ?

About package.json:

My idea was to include package.json as part of the module, because

* it is common practice to `require('./package.json').version` inside a
module, among other things

* eventually, being able to propose a "npm-integration" debian package,
much like "rubygems-integration", would require access to package.json
files.

* looking for package.json is hard-wired into nodejs, it's really not
only about npm.

Granted, if you disagree that won't prevent node-express from running.

If you agree then it's only natural to keep the same relative tree as
the one expected by package.json (that's why the "lib/" dir was
installed in the particular case of express, instead of the files
within). It saves a patch...


> > In case you're missing the time, i can review and upload later today.
> 
> I suspect you couldn't (or shouldn't) upload yet: At least node-parseurl 
> is missing (I haven't checked further).

Yes, it's waiting in NEW.

Jérémy.



___
Pkg-javascript-devel mailing list
Pkg-javascript-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel

Re: [Pkg-javascript-devel] Debian node-express

2014-04-29 Thread Jonas Smedegaard
Quoting Jérémy Lal (2014-04-29 16:03:04)
> Le mardi 29 avril 2014 à 15:31 +0200, Jonas Smedegaard a écrit :
>>> I reverted package to cdbs. Since I do not really know it, can you 
>>> please take a look at debian/rules ensuring everything is correct?
>>
>> Certainly!

I have taken a look now - a thorough one.

Hope you agree with the changes I made.  Don't hesitate to ask if in 
doubt about any of it.


> In case you're missing the time, i can review and upload later today.

I suspect you couldn't (or shouldn't) upload yet: At least node-parseurl 
is missing (I haven't checked further).


 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private


signature.asc
Description: signature
___
Pkg-javascript-devel mailing list
Pkg-javascript-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel

Re: [Pkg-javascript-devel] Debian node-express

2014-04-29 Thread Jérémy Lal
Le mardi 29 avril 2014 à 15:31 +0200, Jonas Smedegaard a écrit :
> Quoting Leo Iannacone (2014-04-29 14:58:03)
> > On 29 April 2014 12:20, Jonas Smedegaard  wrote:
> >> Sorry if that was not obvious: The reason I prefer that you revert is 
> >> indeed because I am still interested in helping maintain that 
> >> package.
> >
> > Great!.
> >
> > I reverted package to cdbs. Since I do not really know it, can you 
> > please take a look at debian/rules ensuring everything is correct?
> 
> Certainly!

Jonas, i am helping Leo for his packaging work these days.
He's greatly helping. Also his npm2deb tool looks promising [0].

(The dh-make switch in node-express happened before i had a chance to
tell him to pay more attention to previous work on the repository)

In case you're missing the time, i can review and upload later today.

Regards,
Jérémy.

[0]
https://github.com/LeoIannacone/npm2deb



___
Pkg-javascript-devel mailing list
Pkg-javascript-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel

Re: [Pkg-javascript-devel] Debian node-express

2014-04-29 Thread Jonas Smedegaard
Quoting Leo Iannacone (2014-04-29 14:58:03)
> On 29 April 2014 12:20, Jonas Smedegaard  wrote:
>> Sorry if that was not obvious: The reason I prefer that you revert is 
>> indeed because I am still interested in helping maintain that 
>> package.
>
> Great!.
>
> I reverted package to cdbs. Since I do not really know it, can you 
> please take a look at debian/rules ensuring everything is correct?

Certainly!


 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private


signature.asc
Description: signature
___
Pkg-javascript-devel mailing list
Pkg-javascript-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel

Re: [Pkg-javascript-devel] Debian node-express

2014-04-29 Thread Leo Iannacone
On 29 April 2014 12:20, Jonas Smedegaard  wrote:
> Sorry if that was not obvious: The reason I prefer that you revert is
> indeed because I am still interested in helping maintain that package.

Great!.

I reverted package to cdbs. Since I do not really know it, can you
please take a look at debian/rules ensuring everything is correct?

Best,

Leo.

-- 
Ubuntu Member - http://launchpad.net/~l3on
Home Page - http://leoiannacone.com
GPG Key Id - 0xD282FC25

___
Pkg-javascript-devel mailing list
Pkg-javascript-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel


Re: [Pkg-javascript-devel] Debian node-express

2014-04-29 Thread Jonas Smedegaard
Quoting Leo Iannacone (2014-04-29 11:56:46)
> On 29 April 2014 11:40, Jonas Smedegaard  wrote:
>> I would prefer that you revert that.  If you insist on keeping that 
>> change, then please do remove me as uploader for that package.
>
> It depends. If you're still interest in this package then I will 
> revert it.

Sorry if that was not obvious: The reason I prefer that you revert is 
indeed because I am still interested in helping maintain that package.

What other reason could it be?


 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private


signature.asc
Description: signature
___
Pkg-javascript-devel mailing list
Pkg-javascript-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel

Re: [Pkg-javascript-devel] Debian node-express

2014-04-29 Thread Leo Iannacone
On 29 April 2014 11:40, Jonas Smedegaard  wrote:
> I see that you have not only updated, but virtually rewritten the
> packaging from CDBS to short-form dh sequencer.
>
> It is not polite to do such massive restructuring without prior
> coordination with those already directly involved in a package.

Sorry about that.

> I would prefer that you revert that.  If you insist on keeping that
> change, then please do remove me as uploader for that package.

It depends. If you're still interest in this package then I will revert it.

Otherwise, I do not use CDBS, so I will keep this change.


Let me know.

All the best,

Leo.

-- 
Ubuntu Member - http://launchpad.net/~l3on
Home Page - http://leoiannacone.com
GPG Key Id - 0xD282FC25

___
Pkg-javascript-devel mailing list
Pkg-javascript-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel


Re: [Pkg-javascript-devel] Debian node-express

2014-04-29 Thread Jonas Smedegaard
[replying via list - I see no need for discretion here]

Hi Leo,

Quoting Leo Iannacone (2014-04-29 10:31:35)
> I have seen you worked on node-express debian package last year.
> 
> I'm going to update it to 4.1, are you still interested in maintain 
> that package or I can pop your contact from Uploaders ?

I see that you have not only updated, but virtually rewritten the 
packaging from CDBS to short-form dh sequencer.

It is not polite to do such massive restructuring without prior 
coordination with those already directly involved in a package.

I would prefer that you revert that.  If you insist on keeping that 
change, then please do remove me as uploader for that package.


Regards,

 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private


signature.asc
Description: signature
___
Pkg-javascript-devel mailing list
Pkg-javascript-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel