Re: [Pkg-javascript-devel] node-crc32_0.2.2-1_amd64.changes ACCEPTED into unstable, unstable

2017-12-31 Thread Pirate Praveen
On 12/31/2017 02:54 PM, Jérémy Lal wrote:
> Ha, node-gzip-js is also outdated - it has a similar better alternative
> https://github.com/nodeca/pako
> 
> I see that node-jquery uses gzip-js only to compress dist files, no ?
> It's easy to get rid of that dependency since nodejs has the zlib module
> that can compress to gzip.
> 
> Jérémy
> 
> 

Can you check if this is correct?

https://anonscm.debian.org/cgit/collab-maint/node-jquery.git/tree/debian/patches/skip-gzip-js.patch



signature.asc
Description: OpenPGP digital signature
-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel

Re: [Pkg-javascript-devel] node-crc32_0.2.2-1_amd64.changes ACCEPTED into unstable, unstable

2017-12-31 Thread Jérémy Lal
2017-12-31 7:04 GMT+01:00 Pirate Praveen :

> On 12/31/2017 04:51 AM, Jérémy Lal wrote:
>
> Sorry if i did not catch this ITP first hand but may i point out that
> there are some
> much more popular (by several orders of magnitude), and better maintained
> (crc32 is six years old) alternatives out there:
> https://github.com/SheetJS/js-crc32
> https://github.com/alexgorbatchev/node-crc
>
> This would probably means patches for the dependent module using crc32,
> yes,
> but 1. upstream of that dependent module should consider switching
> and 2. the six years old module will probably require patches as well.
>
> This is a dependency of node-gzip-js (dependency of node-jquery 2). We can
> try and convince upstream to update dependency.
>

Ha, node-gzip-js is also outdated - it has a similar better alternative
https://github.com/nodeca/pako

I see that node-jquery uses gzip-js only to compress dist files, no ?
It's easy to get rid of that dependency since nodejs has the zlib module
that can compress to gzip.

Jérémy
-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel

Re: [Pkg-javascript-devel] node-crc32_0.2.2-1_amd64.changes ACCEPTED into unstable, unstable

2017-12-30 Thread Pirate Praveen
On 12/31/2017 04:51 AM, Jérémy Lal wrote:
> Sorry if i did not catch this ITP first hand but may i point out that
> there are some
> much more popular (by several orders of magnitude), and better maintained
> (crc32 is six years old) alternatives out there:
> https://github.com/SheetJS/js-crc32
> https://github.com/alexgorbatchev/node-crc
>
> This would probably means patches for the dependent module using
> crc32, yes,
> but 1. upstream of that dependent module should consider switching
> and 2. the six years old module will probably require patches as well.
>
This is a dependency of node-gzip-js (dependency of node-jquery 2). We
can try and convince upstream to update dependency.
> Jérémy




signature.asc
Description: OpenPGP digital signature
-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel

Re: [Pkg-javascript-devel] node-crc32_0.2.2-1_amd64.changes ACCEPTED into unstable, unstable

2017-12-30 Thread Jérémy Lal
2017-12-30 20:00 GMT+01:00 Debian FTP Masters <
ftpmas...@ftp-master.debian.org>:

>
>
> Accepted:
>
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA256
>
> Format: 1.8
> Date: Thu, 30 Nov 2017 18:29:28 +0530
> Source: node-crc32
> Binary: node-crc32
> Architecture: source all
> Version: 0.2.2-1
> Distribution: unstable
> Urgency: low
> Maintainer: Debian Javascript Maintainers  alioth.debian.org>
> Changed-By: Pirate Praveen 
> Description:
>  node-crc32 - CRC-32 implemented in JavaScript
> Closes: 883188
> Changes:
>  node-crc32 (0.2.2-1) unstable; urgency=low
>  .
>* Initial release (Closes: #883188)
>

Sorry if i did not catch this ITP first hand but may i point out that there
are some
much more popular (by several orders of magnitude), and better maintained
(crc32 is six years old) alternatives out there:
https://github.com/SheetJS/js-crc32
https://github.com/alexgorbatchev/node-crc

This would probably means patches for the dependent module using crc32, yes,
but 1. upstream of that dependent module should consider switching
and 2. the six years old module will probably require patches as well.

Jérémy
-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel