Your message dated Sun, 27 Oct 2013 06:03:17 +0000
with message-id <e1vajrv-0002zv...@franck.debian.org>
and subject line Bug#675892: fixed in smb4k 1.0.8-1
has caused the Debian Bug report #675892,
regarding smb4k FTBFS on armel and armhf qreal VS double issues
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
675892: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=675892
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: smb4k
Severity: important
Tags: patch
Smb4k failed to build on the armel and armhf autobuilders with the following
error.
cd /build/buildd-smb4k_1.0.1-1-armel-kH7YB_/smb4k-1.0.1/obj-arm-linux-gnueabi/core
&& /usr/bin/c++ -DMAKE_SMB4KCORE_LIB -D_BSD_SOURCE -D_XOPEN_SOURCE=500
-D_BSD_SOURCE -DQT_NO_STL -DQT_NO_CAST_TO_ASCII -D_REENTRANT -DKDE_DEPRECATED_WARNINGS
-DKDE4_CMAKE_TOPLEVEL_DIR_LENGTH=40 -g -O2 -fstack-protector --param=ssp-buffer-size=4
-Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 -Wnon-virtual-dtor -Wno-long-long
-ansi -Wundef -Wcast-align -Wchar-subscripts -Wall -W -Wpointer-arith -Wformat-security
-fno-exceptions -DQT_NO_EXCEPTIONS -fno-check-new -fno-common -Woverloaded-virtual
-fno-threadsafe-statics -fvisibility=hidden -Werror=return-type
-fvisibility-inlines-hidden -DNDEBUG -DQT_NO_DEBUG -fPIC
-I/build/buildd-smb4k_1.0.1-1-armel-kH7YB_/smb4k-1.0.1/obj-arm-linux-gnueabi/core
-I/build/buildd-smb4k_1.0.1-1-armel-kH7YB_/smb4k-1.0.1/core
-I/build/buildd-smb4k_1.0.1-1-armel-kH7YB_/smb4k-1.0.1
-I/build/buildd-smb4k_1.0.1-1-armel-kH7YB_/smb4k-1.0.1/obj-arm-linux-gnueabi
-I/usr/include/KDE -I/usr/include/qt4/phonon -I/usr/include/qt4/QtXmlPatterns
-I/usr/include/qt4/QtXml -I/usr/include/qt4/QtUiTools -I/usr/include/qt4/QtTest
-I/usr/include/qt4/QtSvg -I/usr/include/qt4/QtSql -I/usr/include/qt4/QtScriptTools
-I/usr/include/qt4/QtScript -I/usr/include/qt4/QtNetwork -I/usr/include/qt4/QtHelp
-I/usr/include/qt4/QtDesigner -I/usr/include/qt4/QtDeclarative
-I/usr/include/qt4/QtDBus -I/usr/include/qt4/Qt3Support -I/usr/include/qt4/QtGui
-I/usr/include/qt4/QtCore -I/usr/include/qt4/Qt -I/usr/share/qt4/mkspecs/default
-I/usr/include/qt4 -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -o
CMakeFiles/smb4kcore.dir/smb4kshare.o -c
/build/buildd-smb4k_1.0.1-1-armel-kH7YB_/smb4k-1.0.1/core/smb4kshare.cpp
/build/buildd-smb4k_1.0.1-1-armel-kH7YB_/smb4k-1.0.1/core/smb4kshare.cpp: In
member function 'QString Smb4KShare::totalDiskSpaceString() const':
/build/buildd-smb4k_1.0.1-1-armel-kH7YB_/smb4k-1.0.1/core/smb4kshare.cpp:482:50:
error: cannot convert 'qreal* {aka float*}' to 'double*' for argument '2' to
'double modf(double, double*)'
/build/buildd-smb4k_1.0.1-1-armel-kH7YB_/smb4k-1.0.1/core/smb4kshare.cpp: In
member function 'QString Smb4KShare::freeDiskSpaceString() const':
/build/buildd-smb4k_1.0.1-1-armel-kH7YB_/smb4k-1.0.1/core/smb4kshare.cpp:539:50:
error: cannot convert 'qreal* {aka float*}' to 'double*' for argument '2' to
'double modf(double, double*)'
/build/buildd-smb4k_1.0.1-1-armel-kH7YB_/smb4k-1.0.1/core/smb4kshare.cpp: In
member function 'QString Smb4KShare::usedDiskSpaceString() const':
/build/buildd-smb4k_1.0.1-1-armel-kH7YB_/smb4k-1.0.1/core/smb4kshare.cpp:596:50:
error: cannot convert 'qreal* {aka float*}' to 'double*' for argument '2' to
'double modf(double, double*)'
make[3]: *** [core/CMakeFiles/smb4kcore.dir/smb4kshare.o] Error 1
On most architectures qreal is defined as double but on arm architectures it is
defined as float. Assignments between qreal and double are ok because
assignments
between float and double are ok. But assignments between pointers to qreal and
pointers to double are not ok. There can also be issues with templates and
overloaded functions.
The fix is pretty trivial, just a matter of tweaking some variable definitions.
Patch is attatched.
Description: Fix qreal vs double issues.
The code in smb4kshare.cpp tries to pass pointers to qreal to functions
expecting pointers to double. This breaks on arm architectures where
qreal is defined as float.
The patch fixes the issue by changing variable declarations.
Author: Fathi Boudra <f...@debian.org>
Bug-Debian: http://bugs.debian.org/638162
---
The information above should follow the Patch Tagging Guidelines, please
checkout http://dep.debian.net/deps/dep3/ to learn about the format. Here
are templates for supplementary fields that you might want to add:
Origin: <vendor|upstream|other>, <url of original patch>
Bug: <url in upstream bugtracker>
Bug-Debian: http://bugs.debian.org/<bugnumber>
Bug-Ubuntu: https://launchpad.net/bugs/<bugnumber>
Forwarded: <no|not-needed|url proving that it has been forwarded>
Reviewed-By: <name and email of someone who approved the patch>
Last-Update: <YYYY-MM-DD>
--- smb4k-1.0.1.orig/core/smb4kshare.cpp
+++ smb4k-1.0.1/core/smb4kshare.cpp
@@ -475,7 +475,7 @@ QString Smb4KShare::totalDiskSpaceString
QString total, total_dim = QString();
int exponent = 0;
- qreal tmp_factor = 0;
+ double tmp_factor = 0;
qulonglong factor = 0;
(void) frexp( m_total * 1024, &exponent );
@@ -532,7 +532,7 @@ QString Smb4KShare::freeDiskSpaceString(
QString free, free_dim = QString();
int exponent = 0;
- qreal tmp_factor = 0;
+ double tmp_factor = 0;
qulonglong factor = 0;
(void) frexp( m_free * 1024, &exponent );
@@ -589,7 +589,7 @@ QString Smb4KShare::usedDiskSpaceString(
QString used, used_dim = QString();
int exponent = 0;
- qreal tmp_factor = 0;
+ double tmp_factor = 0;
qulonglong factor = 0;
(void) frexp( m_used * 1024, &exponent );
--- End Message ---
--- Begin Message ---
Source: smb4k
Source-Version: 1.0.8-1
We believe that the bug you reported is fixed in the latest version of
smb4k, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 675...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Mark Purcell <m...@debian.org> (supplier of updated smb4k package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Sun, 27 Oct 2013 16:33:05 +1100
Source: smb4k
Binary: smb4k
Architecture: source i386
Version: 1.0.8-1
Distribution: unstable
Urgency: low
Maintainer: Debian KDE Extras Team <pkg-kde-extras@lists.alioth.debian.org>
Changed-By: Mark Purcell <m...@debian.org>
Description:
smb4k - Samba (SMB) share advanced browser for KDE
Closes: 675892
Changes:
smb4k (1.0.8-1) unstable; urgency=low
.
* New upstream release
- Fixes "qreal VS double issues" (Closes: #675892)
* Update +Section: kde - fixes override disparities
* Update Standards Version 3.9.4
Checksums-Sha1:
a72b0688e35e2beb3f839f6649bd13a0a4085518 1374 smb4k_1.0.8-1.dsc
9b5a745b10c7e08780de92157d7dd6f5781d09f5 2636905 smb4k_1.0.8.orig.tar.bz2
c16329aea194c0fc16d79afed7274ee2eedb93ce 4532 smb4k_1.0.8-1.debian.tar.gz
30d6e5a8d517bade54760a6b8fa5702a7fc4de67 2647474 smb4k_1.0.8-1_i386.deb
Checksums-Sha256:
0699fd524677ee46bb7b454c3835997798de1363104651270810ee77cd265e2a 1374
smb4k_1.0.8-1.dsc
cbfc7553844432e787483793ba0e07c9c9f3ce3e5ed3183812be1c50862f87c2 2636905
smb4k_1.0.8.orig.tar.bz2
d052fd2c4cd4f03fb994e5cdbdd69d636099a51fd5c665473a8d14c20195fdcf 4532
smb4k_1.0.8-1.debian.tar.gz
f443a0f93e7ce8d823a6de597921900675aeb5719cca7b4c8458be13d77da9a5 2647474
smb4k_1.0.8-1_i386.deb
Files:
728c19ff2a8add14e6c4889948d2c100 1374 kde optional smb4k_1.0.8-1.dsc
8dac25845830cee18b72776d0f90d62c 2636905 kde optional smb4k_1.0.8.orig.tar.bz2
ad77f5e86bb3240411d0e80382b52e4c 4532 kde optional smb4k_1.0.8-1.debian.tar.gz
c782f6ca75c8205ac4def2ffc9c3fb95 2647474 kde optional smb4k_1.0.8-1_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
iEYEARECAAYFAlJsqewACgkQoCzanz0IthJQiQCeIFIRSQdsrqAh/i0Gqj3j29cr
JJUAnAphRcihz3oStB574u06+c1aoHV3
=E9cL
-----END PGP SIGNATURE-----
--- End Message ---
_______________________________________________
pkg-kde-extras mailing list
pkg-kde-extras@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-kde-extras
